[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #14 from Russ Dill  2011-01-26 22:36:44 PST 
---
Created an attachment (id=42573)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42573)
 avivotool regmatch <0x7880..0x791c> (after resume)

Both files are identical

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #13 from Russ Dill  2011-01-26 22:36:03 PST 
---
Created an attachment (id=42572)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42572)
 avivotool regmatch <0x7880..0x791c> (before suspend)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[PATCH] drm: Remove unused members from struct drm_open_hash

2011-01-26 Thread Chris Wilson
Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/drm_hashtab.c |   27 ---
 include/drm/drm_hashtab.h |6 +-
 2 files changed, 9 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/drm_hashtab.c b/drivers/gpu/drm/drm_hashtab.c
index a93d7b4..e3a7568 100644
--- a/drivers/gpu/drm/drm_hashtab.c
+++ b/drivers/gpu/drm/drm_hashtab.c
@@ -39,27 +39,18 @@

 int drm_ht_create(struct drm_open_hash *ht, unsigned int order)
 {
-   unsigned int i;
+   unsigned int size = 1 << order;

-   ht->size = 1 << order;
ht->order = order;
-   ht->fill = 0;
ht->table = NULL;
-   ht->use_vmalloc = ((ht->size * sizeof(*ht->table)) > PAGE_SIZE);
-   if (!ht->use_vmalloc) {
-   ht->table = kcalloc(ht->size, sizeof(*ht->table), GFP_KERNEL);
-   }
-   if (!ht->table) {
-   ht->use_vmalloc = 1;
-   ht->table = vmalloc(ht->size*sizeof(*ht->table));
-   }
+   if (size <= PAGE_SIZE / sizeof(*ht->table))
+   ht->table = kcalloc(size, sizeof(*ht->table), GFP_KERNEL);
+   else
+   ht->table = vzalloc(size*sizeof(*ht->table));
if (!ht->table) {
DRM_ERROR("Out of memory for hash table\n");
return -ENOMEM;
}
-   for (i=0; i< ht->size; ++i) {
-   INIT_HLIST_HEAD(>table[i]);
-   }
return 0;
 }
 EXPORT_SYMBOL(drm_ht_create);
@@ -180,7 +171,6 @@ int drm_ht_remove_key(struct drm_open_hash *ht, unsigned 
long key)
list = drm_ht_find_key(ht, key);
if (list) {
hlist_del_init(list);
-   ht->fill--;
return 0;
}
return -EINVAL;
@@ -189,7 +179,6 @@ int drm_ht_remove_key(struct drm_open_hash *ht, unsigned 
long key)
 int drm_ht_remove_item(struct drm_open_hash *ht, struct drm_hash_item *item)
 {
hlist_del_init(>head);
-   ht->fill--;
return 0;
 }
 EXPORT_SYMBOL(drm_ht_remove_item);
@@ -197,10 +186,10 @@ EXPORT_SYMBOL(drm_ht_remove_item);
 void drm_ht_remove(struct drm_open_hash *ht)
 {
if (ht->table) {
-   if (ht->use_vmalloc)
-   vfree(ht->table);
-   else
+   if ((PAGE_SIZE / sizeof(*ht->table)) >> ht->order)
kfree(ht->table);
+   else
+   vfree(ht->table);
ht->table = NULL;
}
 }
diff --git a/include/drm/drm_hashtab.h b/include/drm/drm_hashtab.h
index 0af087a..3650d5d 100644
--- a/include/drm/drm_hashtab.h
+++ b/include/drm/drm_hashtab.h
@@ -45,14 +45,10 @@ struct drm_hash_item {
 };

 struct drm_open_hash {
-   unsigned int size;
-   unsigned int order;
-   unsigned int fill;
struct hlist_head *table;
-   int use_vmalloc;
+   u8 order;
 };

-
 extern int drm_ht_create(struct drm_open_hash *ht, unsigned int order);
 extern int drm_ht_insert_item(struct drm_open_hash *ht, struct drm_hash_item 
*item);
 extern int drm_ht_just_insert_please(struct drm_open_hash *ht, struct 
drm_hash_item *item,
-- 
1.7.2.3



[PATCH] radeon/kms: fix dp displayport mode validation

2011-01-26 Thread Alex Deucher
On Wed, Jan 26, 2011 at 5:51 PM,   wrote:
> From: Jerome Glisse 
>
> Check if there is a big enough dp clock & enough dp lane to
> drive the video mode provided.
>
> Signed-off-by: Jerome Glisse 
> Cc: 

Looks like a copy paste error, probably from me :)

Reviewed-By: Alex Deucher 

> ---
> ?drivers/gpu/drm/radeon/atombios_dp.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
> b/drivers/gpu/drm/radeon/atombios_dp.c
> index 4e7778d..695de9a 100644
> --- a/drivers/gpu/drm/radeon/atombios_dp.c
> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> @@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
> dpcd[DP_DPCD_SIZE], int mode_clock)
> ?int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
> ?{
> ? ? ? ?int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
> - ? ? ? int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
> + ? ? ? int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);
>
> - ? ? ? if ((lanes == 0) || (bw == 0))
> + ? ? ? if ((lanes == 0) || (dp_clock == 0))
> ? ? ? ? ? ? ? ?return MODE_CLOCK_HIGH;
>
> ? ? ? ?return MODE_OK;
> --
> 1.7.3.2
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>


[PATCH] radeon/kms: fix dp displayport mode validation

2011-01-26 Thread jgli...@redhat.com
From: Jerome Glisse 

Check if there is a big enough dp clock & enough dp lane to
drive the video mode provided.

Signed-off-by: Jerome Glisse 
Cc: 
---
 drivers/gpu/drm/radeon/atombios_dp.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
b/drivers/gpu/drm/radeon/atombios_dp.c
index 4e7778d..695de9a 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
dpcd[DP_DPCD_SIZE], int mode_clock)
 int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
 {
int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
-   int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
+   int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);

-   if ((lanes == 0) || (bw == 0))
+   if ((lanes == 0) || (dp_clock == 0))
return MODE_CLOCK_HIGH;

return MODE_OK;
-- 
1.7.3.2



[PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv->wq

2011-01-26 Thread Tejun Heo
With cmwq, there's no reason for nouveau to use a dedicated workqueue.
Drop dev_priv->wq and use system_wq instead.  Each work item is sync
flushed when the containing structure is unregistered/destroyed.

Note that this change also makes sure that nv50_gpio_handler is not
freed while the contained work item is still running.

Signed-off-by: Tejun Heo 
Cc: David Airlie 
Cc: dri-devel at lists.freedesktop.org
---
Here's a patch on top of the current linus#master.  It's much simpler
than before.  The only concern is that it adds flush_work_sync() call
which might sleep to unregistration paths.  AFAICS, this seems safe,
right?  If this looks okay to you, please feel free to route it
through the drm tree.

Thank you.

 drivers/gpu/drm/nouveau/nouveau_drv.h   |1 -
 drivers/gpu/drm/nouveau/nouveau_state.c |   10 +-
 drivers/gpu/drm/nouveau/nv50_display.c  |5 -
 drivers/gpu/drm/nouveau/nv50_gpio.c |   11 ---
 4 files changed, 13 insertions(+), 14 deletions(-)

Index: work/drivers/gpu/drm/nouveau/nouveau_drv.h
===
--- work.orig/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ work/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -652,7 +652,6 @@ struct drm_nouveau_private {
/* interrupt handling */
void (*irq_handler[32])(struct drm_device *);
bool msi_enabled;
-   struct workqueue_struct *wq;
struct work_struct irq_work;

struct list_head vbl_waiting;
Index: work/drivers/gpu/drm/nouveau/nouveau_state.c
===
--- work.orig/drivers/gpu/drm/nouveau/nouveau_state.c
+++ work/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -929,12 +929,6 @@ int nouveau_load(struct drm_device *dev,
NV_DEBUG(dev, "vendor: 0x%X device: 0x%X class: 0x%X\n",
 dev->pci_vendor, dev->pci_device, dev->pdev->class);

-   dev_priv->wq = create_workqueue("nouveau");
-   if (!dev_priv->wq) {
-   ret = -EINVAL;
-   goto err_priv;
-   }
-
/* resource 0 is mmio regs */
/* resource 1 is linear FB */
/* resource 2 is RAMIN (mmio regs + 0x100) */
@@ -947,7 +941,7 @@ int nouveau_load(struct drm_device *dev,
NV_ERROR(dev, "Unable to initialize the mmio mapping. "
 "Please report your setup to " DRIVER_EMAIL "\n");
ret = -EINVAL;
-   goto err_wq;
+   goto err_priv;
}
NV_DEBUG(dev, "regs mapped ok at 0x%llx\n",
(unsigned long long)mmio_start_offs);
@@ -1054,8 +1048,6 @@ err_ramin:
iounmap(dev_priv->ramin);
 err_mmio:
iounmap(dev_priv->mmio);
-err_wq:
-   destroy_workqueue(dev_priv->wq);
 err_priv:
kfree(dev_priv);
dev->dev_private = NULL;
Index: work/drivers/gpu/drm/nouveau/nv50_display.c
===
--- work.orig/drivers/gpu/drm/nouveau/nv50_display.c
+++ work/drivers/gpu/drm/nouveau/nv50_display.c
@@ -345,12 +345,15 @@ int nv50_display_create(struct drm_devic
 void
 nv50_display_destroy(struct drm_device *dev)
 {
+   struct drm_nouveau_private *dev_priv = dev->dev_private;
+
NV_DEBUG_KMS(dev, "\n");

drm_mode_config_cleanup(dev);

nv50_display_disable(dev);
nouveau_irq_unregister(dev, 26);
+   flush_work_sync(_priv->irq_work);
 }

 static u16
@@ -836,7 +839,7 @@ nv50_display_isr(struct drm_device *dev)
if (clock) {
nv_wr32(dev, NV03_PMC_INTR_EN_0, 0);
if (!work_pending(_priv->irq_work))
-   queue_work(dev_priv->wq, _priv->irq_work);
+   schedule_work(_priv->irq_work);
delayed |= clock;
intr1 &= ~clock;
}
Index: work/drivers/gpu/drm/nouveau/nv50_gpio.c
===
--- work.orig/drivers/gpu/drm/nouveau/nv50_gpio.c
+++ work/drivers/gpu/drm/nouveau/nv50_gpio.c
@@ -137,6 +137,7 @@ nv50_gpio_irq_unregister(struct drm_devi
struct nv50_gpio_priv *priv = pgpio->priv;
struct nv50_gpio_handler *gpioh, *tmp;
struct dcb_gpio_entry *gpio;
+   LIST_HEAD(tofree);
unsigned long flags;

gpio = nouveau_bios_gpio_entry(dev, tag);
@@ -149,10 +150,14 @@ nv50_gpio_irq_unregister(struct drm_devi
gpioh->handler != handler ||
gpioh->data != data)
continue;
-   list_del(>head);
-   kfree(gpioh);
+   list_move(>head, );
}
spin_unlock_irqrestore(>lock, flags);
+
+   list_for_each_entry_safe(gpioh, tmp, , head) {
+   flush_work_sync(>work);
+   kfree(gpioh);
+   }
 }

 bool
@@ -293,7 +298,7 @@ nv50_gpio_isr(struct drm_device *dev)
   

[Bug 32296] [r300g] Screen corruption with WoW when HyperZ enabled.

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=32296

--- Comment #15 from Chris Rankin  2011-01-26 
15:04:37 PST ---
(In reply to comment #13)
> If you compile with --enable-debug, it should print the hyperz status to
> stderr.

RADEON_HYPERZ=1
RADEON_DEBUG=hyperz

and then I get lots of lines like:

hyper-z features: hiz: 0 @ deadbeef

RV350 has no HiZ, so that's not unexpected. The can_hyperz flag does appear to
be being set as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #8 from Andy Furniss  2011-01-26 
15:02:16 PST ---
(In reply to comment #5)
> Since I also have rendering errors in doom3, which are probably related to
> shadows, I'm attaching some screenshots which show them.
> 
> Using r600g on a RV740. libdrm, mesa and xf86-video-ati all git master. kernel
> is fresh d-r-t.

I am also seeing this with 600g on a rv790.

With a debug build of mesa, stderr is flooded with -

Mesa: User error: GL_INVALID_VALUE in glScissor

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Arnd Bergmann
On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote:
> I guess you're meaning cx25821, right? 

Right, sorry for the typo.

> Palash should take a look on it and review. This is a device that allows
> 12 simultaneous streams, so, I suspect that he'll need to do some
> changes at the locking schema, to avoid performance bottlenecks.

I would be surprised if there was any measurable performance change.
The BKL was used only in the open() function to iterate the device
list, and that code is nowhere on a critical path, as far as I can tell.

Arnd


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #7 from Tobias Jakobi  2011-01-26 13:05:15 
PST ---
Created an attachment (id=42557)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42557)
broken shadows on r600g 2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #6 from Tobias Jakobi  2011-01-26 13:04:54 
PST ---
Created an attachment (id=42556)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42556)
broken shadows on r600g 1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #5 from Tobias Jakobi  2011-01-26 13:04:27 
PST ---
Since I also have rendering errors in doom3, which are probably related to
shadows, I'm attaching some screenshots which show them.

Using r600g on a RV740. libdrm, mesa and xf86-video-ati all git master. kernel
is fresh d-r-t.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #13 from Tobias Jakobi  2011-01-26 13:02:10 
PST ---
Created an attachment (id=42555)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42555)
ut2004 mipmap errors 4

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #12 from Tobias Jakobi  2011-01-26 13:01:56 
PST ---
Created an attachment (id=42554)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42554)
ut2004 mipmap errors 3

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #11 from Tobias Jakobi  2011-01-26 13:01:41 
PST ---
Created an attachment (id=42553)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42553)
ut2004 mipmap errors 2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #10 from Tobias Jakobi  2011-01-26 13:01:26 
PST ---
Created an attachment (id=42552)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42552)
ut2004 mipmap errors 1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Arnd Bergmann
On Wednesday 26 January 2011, Greg KH wrote:
> On Tue, Jan 25, 2011 at 11:17:14PM +0100, Arnd Bergmann wrote:
> > I've gone through all the code in the kernel that
> > uses the big kernel lock and come up with a solution
> > that seems at least half-reasonable for each of them.
> > 
> > The decisions are somewhat arbitrary, but here is
> > what I'd suggest we do:
> > 
> > * Remove in 2.6.39:
> >i830, autofs3, smbfs
> 
> I thought some people really wanted to keep i830.  Or was that i810?
>  I'll drop autofs3 and smbfs, thanks.

i810 needs to be kept, i830 is obsolete, see the patch changelogs
there. I assume that Dave Airlie will take both patches (i810 BKL
removal and i830 removal) into his 2.6.39 queue.

> > * Work around in an ugly way, but keep alive:
> >* ufs, ipx, i810, cx25721
> > 
> > * Fix properly:
> >* usbip, go7007, adfs, x25
> 
> Thanks for the usbip and go7007 patches, I'll queue them up.

It would be good if you could also take the cx25721 patch. It's
not the nicest one I've done, but it's a bug fix nonetheless.

Thanks,

Arnd


[Bug 33172] [r600g] ingame rendering broken (black screen) in ut2003

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33172

--- Comment #3 from Tobias Jakobi  2011-01-26 11:46:00 
PST ---
New tests on my system with ut2004. UseVBO is disabled, so I only get a black
screen ingame.

I can still play though (by ear so to speak) and while doing this I watched
memory consumption of the process:
Monitoring ut2004-bin with htop showed that during peak times the process has
more than 50GiB virtual mem (VIRT) allocated. So there's clearly a mem leak
here.

Could valgrind help to detect such a leak?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[PATCH] drm: Never change the connector status to unknown whilst polling

2011-01-26 Thread Chris Wilson
When polling for a hotplug event, if the connector detect probe returns
unknown, reuse the current status and do not trigger a hotplug event.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/drm_crtc.c|1 +
 drivers/gpu/drm/drm_crtc_helper.c |   11 +++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 2baa670..f6678f6 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -459,6 +459,7 @@ void drm_connector_init(struct drm_device *dev,
INIT_LIST_HEAD(>probed_modes);
INIT_LIST_HEAD(>modes);
connector->edid_blob_ptr = NULL;
+   connector->status = connector_status_unknown;

list_add_tail(>head, >mode_config.connector_list);
dev->mode_config.num_connector++;
diff --git a/drivers/gpu/drm/drm_crtc_helper.c 
b/drivers/gpu/drm/drm_crtc_helper.c
index 952b3d4..b3afb38 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -862,7 +862,6 @@ static void output_poll_execute(struct work_struct *work)
struct delayed_work *delayed_work = to_delayed_work(work);
struct drm_device *dev = container_of(delayed_work, struct drm_device, 
mode_config.output_poll_work);
struct drm_connector *connector;
-   enum drm_connector_status old_status;
bool repoll = false, changed = false;

if (!drm_kms_helper_poll)
@@ -870,6 +869,7 @@ static void output_poll_execute(struct work_struct *work)

mutex_lock(>mode_config.mutex);
list_for_each_entry(connector, >mode_config.connector_list, head) {
+   enum drm_connector_status old_status, new_status;

/* if this is HPD or polled don't check it -
   TV out for instance */
@@ -883,15 +883,18 @@ static void output_poll_execute(struct work_struct *work)
/* if we are connected and don't want to poll for disconnect
   skip it */
if (old_status == connector_status_connected &&
-   !(connector->polled & DRM_CONNECTOR_POLL_DISCONNECT) &&
-   !(connector->polled & DRM_CONNECTOR_POLL_HPD))
+   (connector->polled & (DRM_CONNECTOR_POLL_DISCONNECT | 
DRM_CONNECTOR_POLL_HPD)) == 0)
continue;

-   connector->status = connector->funcs->detect(connector, false);
+   new_status = connector->funcs->detect(connector, false);
+   if (new_status != connector_status_unknown)
+   connector->status = new_status;
+
DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %d to 
%d\n",
  connector->base.id,
  drm_get_connector_name(connector),
  old_status, connector->status);
+
if (old_status != connector->status)
changed = true;
}
-- 
1.7.2.3



[Bug 33542] game "nexuiz" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 49

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33542

Alex Deucher  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Alex Deucher  2011-01-26 10:49:29 PST 
---


*** This bug has been marked as a duplicate of bug 33541 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33541] game "Braid" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #4 from Alex Deucher  2011-01-26 10:49:29 PST 
---
*** Bug 33542 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33541] game "Braid" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #3 from Alexandre Derumier  2011-01-26 
10:46:11 PST ---
(In reply to comment #2)
> Can you bisect mesa?

i'll try, but i don't have much time with my work for the moment ;)

i'll keep you in touch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33541] game "Braid" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #2 from Alex Deucher  2011-01-26 10:43:53 PST 
---
Can you bisect mesa?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33542] New: game "nexuiz" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 49

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33542

   Summary: game "nexuiz" : radeon :01:00.0:
r600_check_texture_resource:1208 texture invalid
format 49
   Product: Mesa
   Version: git
  Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Gallium/r600
AssignedTo: dri-devel at lists.freedesktop.org
ReportedBy: aderumier at odiso.com


Nexuiz is launching, but after level loading, screen become black.
/var/log/messages:


radeon :01:00.0: r600_check_texture_resource:1208 texture invalid format 49



i'm using mesa-git , drm-radeon-testing-git kernel,libdrm-git and
xf86-video-ati-git from 17/01/01.

i'm using a RV620 chipset


this is a regression,It was working perfectly +-1 week before.


i've send an another bug report for game "braid", i think it's related.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33541] game "Braid" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #1 from Alexandre Derumier  2011-01-26 
10:38:42 PST ---
forget to say:

i'm using a RV620 chipset

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33541] New: game "Braid" : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33541

   Summary: game "Braid" :  radeon :01:00.0:
r600_check_texture_resource:1208 texture invalid
format 51
   Product: Mesa
   Version: git
  Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Gallium/r600
AssignedTo: dri-devel at lists.freedesktop.org
ReportedBy: aderumier at odiso.com


Braid game is launching but black screen at start.
/var/log/messages:

radeon :01:00.0: r600_check_texture_resource:1208 texture invalid format 51


i'm using mesa-git , drm-radeon-testing-git kernel,libdrm-git and
xf86-video-ati-git from 17/01/01.



this is a regression,It was working perfectly +-1 week before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #12 from Alex Deucher  2011-01-26 10:36:22 PST 
---
Can you dump the following regs with avivotool (available here:
http://cgit.freedesktop.org/~airlied/radeontool/) as root before and after
suspend?

avivotool regmatch 

Where  =
0x7880
0x7884
0x7888
0x788c
0x7890
0x7894
0x7898
0x789c
0x78a0
0x78a4
0x78a8
0x78ac
0x78b0
0x78b4
0x78b8
0x78bc
0x78c0
0x78c4
0x78c8
0x78cc
0x78d0
0x78d4
0x78d8
0x78dc
0x78e0
0x7904
0x7908
0x790c
0x7910
0x7914
0x7918
0x791c

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Greg KH
On Tue, Jan 25, 2011 at 11:17:14PM +0100, Arnd Bergmann wrote:
> I've gone through all the code in the kernel that
> uses the big kernel lock and come up with a solution
> that seems at least half-reasonable for each of them.
> 
> The decisions are somewhat arbitrary, but here is
> what I'd suggest we do:
> 
> * Remove in 2.6.39:
>i830, autofs3, smbfs

I thought some people really wanted to keep i830.  Or was that i810?

 I'll drop autofs3 and smbfs, thanks.

> * Move to staging now, kill in 2.6.41 (or later):
>appletalk, hpfs

Sounds good to me.

> * Work around in an ugly way, but keep alive:
>* ufs, ipx, i810, cx25721
> 
> * Fix properly:
>* usbip, go7007, adfs, x25

Thanks for the usbip and go7007 patches, I'll queue them up.

greg k-h


[RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Mauro Carvalho Chehab
Em 26-01-2011 09:31, Arnd Bergmann escreveu:
> On Wednesday 26 January 2011, Greg KH wrote:
>> On Tue, Jan 25, 2011 at 11:17:14PM +0100, Arnd Bergmann wrote:
>>> I've gone through all the code in the kernel that
>>> uses the big kernel lock and come up with a solution
>>> that seems at least half-reasonable for each of them.
>>>
>>> The decisions are somewhat arbitrary, but here is
>>> what I'd suggest we do:
>>>
>>> * Remove in 2.6.39:
>>>i830, autofs3, smbfs
>>
>> I thought some people really wanted to keep i830.  Or was that i810?
>>  I'll drop autofs3 and smbfs, thanks.
> 
> i810 needs to be kept, i830 is obsolete, see the patch changelogs
> there. I assume that Dave Airlie will take both patches (i810 BKL
> removal and i830 removal) into his 2.6.39 queue.
> 
>>> * Work around in an ugly way, but keep alive:
>>>* ufs, ipx, i810, cx25721
>>>
>>> * Fix properly:
>>>* usbip, go7007, adfs, x25
>>
>> Thanks for the usbip and go7007 patches, I'll queue them up.
> 
> It would be good if you could also take the cx25721 patch. It's
> not the nicest one I've done, but it's a bug fix nonetheless.

I guess you're meaning cx25821, right? 

Palash should take a look on it and review. This is a device that allows
12 simultaneous streams, so, I suspect that he'll need to do some
changes at the locking schema, to avoid performance bottlenecks.

Cheers,
Mauro


[PATCH] drm: Mark constant arrays of drm_display_mode const

2011-01-26 Thread Chris Wilson
... and fixup some methods to accept the constant argument.

Now that constant module arrays are loaded into read-only memory, using
const appropriately has some benefits beyond warning the programmer
about likely mistakes.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/drm_edid.c  |   19 ++-
 drivers/gpu/drm/drm_edid_modes.h|4 ++--
 drivers/gpu/drm/drm_modes.c |6 +++---
 drivers/gpu/drm/i915/intel_sdvo.c   |2 +-
 drivers/gpu/drm/nouveau/nv17_tv.c   |4 +++-
 drivers/gpu/drm/nouveau/nv17_tv.h   |2 +-
 drivers/gpu/drm/nouveau/nv17_tv_modes.c |2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |5 +++--
 include/drm/drm_crtc.h  |6 +++---
 9 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a245d17..af60d9b 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -449,12 +449,11 @@ static void edid_fixup_preferred(struct drm_connector 
*connector,
 struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
   int hsize, int vsize, int fresh)
 {
+   struct drm_display_mode *mode = NULL;
int i;
-   struct drm_display_mode *ptr, *mode;

-   mode = NULL;
for (i = 0; i < drm_num_dmt_modes; i++) {
-   ptr = _dmt_modes[i];
+   const struct drm_display_mode *ptr = _dmt_modes[i];
if (hsize == ptr->hdisplay &&
vsize == ptr->vdisplay &&
fresh == drm_mode_vrefresh(ptr)) {
@@ -885,7 +884,7 @@ static struct drm_display_mode *drm_mode_detailed(struct 
drm_device *dev,
 }

 static bool
-mode_is_rb(struct drm_display_mode *mode)
+mode_is_rb(const struct drm_display_mode *mode)
 {
return (mode->htotal - mode->hdisplay == 160) &&
   (mode->hsync_end - mode->hdisplay == 80) &&
@@ -894,7 +893,8 @@ mode_is_rb(struct drm_display_mode *mode)
 }

 static bool
-mode_in_hsync_range(struct drm_display_mode *mode, struct edid *edid, u8 *t)
+mode_in_hsync_range(const struct drm_display_mode *mode,
+   struct edid *edid, u8 *t)
 {
int hsync, hmin, hmax;

@@ -910,7 +910,8 @@ mode_in_hsync_range(struct drm_display_mode *mode, struct 
edid *edid, u8 *t)
 }

 static bool
-mode_in_vsync_range(struct drm_display_mode *mode, struct edid *edid, u8 *t)
+mode_in_vsync_range(const struct drm_display_mode *mode,
+   struct edid *edid, u8 *t)
 {
int vsync, vmin, vmax;

@@ -941,7 +942,7 @@ range_pixel_clock(struct edid *edid, u8 *t)
 }

 static bool
-mode_in_range(struct drm_display_mode *mode, struct edid *edid,
+mode_in_range(const struct drm_display_mode *mode, struct edid *edid,
  struct detailed_timing *timing)
 {
u32 max_clock;
@@ -1472,7 +1473,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
int hdisplay, int vdisplay)
 {
int i, count, num_modes = 0;
-   struct drm_display_mode *mode, *ptr;
+   struct drm_display_mode *mode;
struct drm_device *dev = connector->dev;

count = sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);
@@ -1482,7 +1483,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
vdisplay = 0;

for (i = 0; i < count; i++) {
-   ptr = _dmt_modes[i];
+   const struct drm_display_mode *ptr = _dmt_modes[i];
if (hdisplay && vdisplay) {
/*
 * Only when two are valid, they will be used to check
diff --git a/drivers/gpu/drm/drm_edid_modes.h b/drivers/gpu/drm/drm_edid_modes.h
index 6eb7592..5f20644 100644
--- a/drivers/gpu/drm/drm_edid_modes.h
+++ b/drivers/gpu/drm/drm_edid_modes.h
@@ -32,7 +32,7 @@
  * This table is copied from xfree86/modes/xf86EdidModes.c.
  * But the mode with Reduced blank feature is deleted.
  */
-static struct drm_display_mode drm_dmt_modes[] = {
+static const struct drm_display_mode drm_dmt_modes[] = {
/* 640x350 at 85Hz */
{ DRM_MODE("640x350", DRM_MODE_TYPE_DRIVER, 31500, 640, 672,
   736, 832, 0, 350, 382, 385, 445, 0,
@@ -266,7 +266,7 @@ static struct drm_display_mode drm_dmt_modes[] = {
 static const int drm_num_dmt_modes =
sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);

-static struct drm_display_mode edid_est_modes[] = {
+static const struct drm_display_mode edid_est_modes[] = {
{ DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 4, 800, 840,
   968, 1056, 0, 600, 601, 605, 628, 0,
   DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 800x600 
at 60Hz */
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 58e65f9..25bf873 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -593,7 +593,7 @@ EXPORT_SYMBOL(drm_mode_height);
  *
  * Return 

[Bug 33185] X crashes when kWin effects are turned on

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33185

Michel D?nzer  changed:

   What|Removed |Added

  Component|Drivers/DRI/r300|Drivers/Gallium/r300

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #11 from Russ Dill  2011-01-26 09:40:00 PST 
---
> Does a dpms cycle help?
> xset dpms force off

Nope (but causes the VGA-0 monitor to flash off and on)

> Does restarting X help?

Nope

> How about forcing a mode change? e.g.,
> xrandr --output HDMI-0 --mode 1680x1050

Nope

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33185] X crashes when kWin effects are turned on

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33185

Wojciech Ryrych  changed:

   What|Removed |Added

  Attachment #42100|0   |1
is obsolete||

--- Comment #6 from Wojciech Ryrych  2011-01-26 09:39:53 
PST ---
Created an attachment (id=42538)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42538)
kWin backtrace

OK, I've installed debugging symbols so hope this backtrace is more helpful. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33139] Radeon HD 5750 locks up when using 3D apps with r600g

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33139

--- Comment #4 from Siganderson  2011-01-26 09:26:13 PST 
---
It could be the same as https://bugs.freedesktop.org/show_bug.cgi?id=33381
I add that with the 2.6.35 kernel all games seem to work without this problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31830] [bisected] broken shadows in Unigine Sanctuary and Lightsmark

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31830

--- Comment #9 from Tom Stellard  2011-01-26 09:05:17 
PST ---
(In reply to comment #8)
> Created an attachment (id=42516)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42516)
> screenshot of the problem
> 
> Hi, this patch doesn't help neither. I tested it alone and also with the first
> patch. Concerning how the penumbra shadows should look, you don't get the 
> right
> behavior with RADEON_DEBUG=noopt? I've attached screenshot comparing bad and
> good shadows. Don't know how to help you more, I still have the debug patches
> you've sent me when we were debugging sanctuary before the "enable rename_reg"
> patch was committed, maybe I could use them again to identify the failing
> shader?

That's OK, I already know which shader is failing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 27314] DP link training fails on 2560x1440 panels

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27314

--- Comment #31 from Travis Glenn Hansen  
2011-01-26 08:35:56 PST ---
Created an attachment (id=42529)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42529)
dmesg output with 2011-01-25 patches

Thanks for continuing to look at this!  Still no go with those patches for me. 
See attached dmesg.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Palash Bandyopadhyay
I think it should be ok. If we do hit any performance issue, we'll revisit this.

Thanks,
Palash

-Original Message-
From: Arnd Bergmann [mailto:a...@arndb.de] 
Sent: Wednesday, January 26, 2011 5:45 AM
To: Mauro Carvalho Chehab
Cc: Greg KH; linux-kernel at vger.kernel.org; Andrew Hendry; Andrew Morton; 
Arjan van de Ven; Arnaldo Carvalho de Melo; autofs at linux.kernel.org; Chris 
Wilson; Dave Airlie; dri-devel at lists.freedesktop.org; Evgeniy Dushistov; 
Frederic Weisbecker; H. Peter Anvin; Ian Kent; Ingo Molnar; Jeff Layton; 
linux-cifs at vger.kernel.org; linux-fsdevel at vger.kernel.org; linux-x25 at 
vger.kernel.org; Mikulas Patocka; netdev at vger.kernel.org; Nick Bowler; 
Palash Bandyopadhyay; Ross Cohen; Russell King; Stuart Swales; Takahiro 
Hirofuchi; Thomas Gleixner
Subject: Re: [RFC 00/20] Proposal for remaining BKL users

On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote:
> I guess you're meaning cx25821, right? 

Right, sorry for the typo.

> Palash should take a look on it and review. This is a device that allows
> 12 simultaneous streams, so, I suspect that he'll need to do some
> changes at the locking schema, to avoid performance bottlenecks.

I would be surprised if there was any measurable performance change.
The BKL was used only in the open() function to iterate the device
list, and that code is nowhere on a critical path, as far as I can tell.

Arnd

Conexant E-mail Firewall (Conexant.Com) made the following annotations
-
** Legal Disclaimer  

"This email may contain confidential and privileged material for the sole use 
of the intended recipient. Any unauthorized review, use or distribution by 
others is strictly prohibited. If you have received the message in error, 
please advise the sender by reply email and delete the message. Thank you." 

** 

-



[Bug 32945] Lower part of the screen corrupt with HyperZ enabled

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #13 from Sven Arvidsson  2011-01-26 07:59:30 PST ---
Created an attachment (id=42527)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42527)
shadowtex screenshot

Okay, so if I have done this correctly, the small white area in the left corner
is 48x16, if you mean the larger black and white rendering it seems to be
256x257.

I'm attaching a screenshot of shadowtex.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


has the i915 "black screen" boot issue returned?

2011-01-26 Thread Robert P. J. Day

  after suffering through the i915 "black screen" issue for a while,
it was a relief that it finally seemed to be resolved with 2.6.37 or
something in tha vicinity.  but i just built and booted a 2.6.38-rc2+
kernel on my ubuntu 10.10 system and it once again boots to a black
screen.

  is this a new known issue?  has anyone else seen this?

rday

-- 


Robert P. J. Day   Waterloo, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday



[Bug 31830] [bisected] broken shadows in Unigine Sanctuary and Lightsmark

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31830

--- Comment #8 from Pavel Ondra?ka  2011-01-26 02:17:15 
PST ---
Created an attachment (id=42516)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42516)
screenshot of the problem

(In reply to comment #7)
> Created an attachment (id=42514)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42514
 Review: https://bugs.freedesktop.org/review?bug=31830=42514

> Disable instruction rewriting in the scheduler
> 
> I think this bug is actually in the scheduler, and it is just being exposed by
> the reg rename pass.  I have been able to track down a few instructions that
> the scheduler is converting from vector to scalar that change how the shadows
> are rendered.  However, these conversions look valid too me, so I'm really not
> sure what the problem is.  I think this patch fixes Lightsmark, but I'm not
> sure what the shadows are supposed to look like.  Can you try this patch on
> Lightsmark and Sanctuary.  Thanks.

Hi, this patch doesn't help neither. I tested it alone and also with the first
patch. Concerning how the penumbra shadows should look, you don't get the right
behavior with RADEON_DEBUG=noopt? I've attached screenshot comparing bad and
good shadows. Don't know how to help you more, I still have the debug patches
you've sent me when we were debugging sanctuary before the "enable rename_reg"
patch was committed, maybe I could use them again to identify the failing
shader?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 33515] System lockup with Page-flipping

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33515

--- Comment #1 from Michel D?nzer  2011-01-26 01:27:48 
PST ---
(In reply to comment #1)
> MESA: 7.10 with gallium and llvm enabled.

Does it also happen with the classic driver?

What card is it? (Maybe attach Xorg.0.log and dmesg)


> Drm debug log only collected a bunch of garbage characters at the time when
> system locked up.

Maybe you can get more information with netconsole.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 31830] [bisected] broken shadows in Unigine Sanctuary and Lightsmark

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31830

Tom Stellard  changed:

   What|Removed |Added

  Attachment #42355|0   |1
is obsolete||

--- Comment #7 from Tom Stellard  2011-01-26 01:11:35 
PST ---
Created an attachment (id=42514)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42514
 Review: https://bugs.freedesktop.org/review?bug=31830=42514

Disable instruction rewriting in the scheduler

I think this bug is actually in the scheduler, and it is just being exposed by
the reg rename pass.  I have been able to track down a few instructions that
the scheduler is converting from vector to scalar that change how the shadows
are rendered.  However, these conversions look valid too me, so I'm really not
sure what the problem is.  I think this patch fixes Lightsmark, but I'm not
sure what the shadows are supposed to look like.  Can you try this patch on
Lightsmark and Sanctuary.  Thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 32296] [r300g] Screen corruption with WoW when HyperZ enabled.

2011-01-26 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=32296

--- Comment #14 from Fabio Pedretti  2011-01-26 
00:35:27 PST ---
On testing the v3 patch at:
https://bugs.freedesktop.org/show_bug.cgi?id=32945#c12
with sauerbraten I got a lockup (mouse cursor still moving but I had to
reboot).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


[Bug 32296] [r300g] Screen corruption with WoW when HyperZ enabled.

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32296

--- Comment #14 from Fabio Pedretti fabio@libero.it 2011-01-26 00:35:27 
PST ---
On testing the v3 patch at:
https://bugs.freedesktop.org/show_bug.cgi?id=32945#c12
with sauerbraten I got a lockup (mouse cursor still moving but I had to
reboot).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 31830] [bisected] broken shadows in Unigine Sanctuary and Lightsmark

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31830

Tom Stellard tstel...@gmail.com changed:

   What|Removed |Added

  Attachment #42355|0   |1
is obsolete||

--- Comment #7 from Tom Stellard tstel...@gmail.com 2011-01-26 01:11:35 PST 
---
Created an attachment (id=42514)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42514
 Review: https://bugs.freedesktop.org/review?bug=31830attachment=42514

Disable instruction rewriting in the scheduler

I think this bug is actually in the scheduler, and it is just being exposed by
the reg rename pass.  I have been able to track down a few instructions that
the scheduler is converting from vector to scalar that change how the shadows
are rendered.  However, these conversions look valid too me, so I'm really not
sure what the problem is.  I think this patch fixes Lightsmark, but I'm not
sure what the shadows are supposed to look like.  Can you try this patch on
Lightsmark and Sanctuary.  Thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33515] System lockup with Page-flipping

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33515

--- Comment #1 from Michel Dänzer mic...@daenzer.net 2011-01-26 01:27:48 PST 
---
(In reply to comment #1)
 MESA: 7.10 with gallium and llvm enabled.

Does it also happen with the classic driver?

What card is it? (Maybe attach Xorg.0.log and dmesg)


 Drm debug log only collected a bunch of garbage characters at the time when
 system locked up.

Maybe you can get more information with netconsole.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] drm: Mark constant arrays of drm_display_mode const

2011-01-26 Thread Chris Wilson
... and fixup some methods to accept the constant argument.

Now that constant module arrays are loaded into read-only memory, using
const appropriately has some benefits beyond warning the programmer
about likely mistakes.

Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 drivers/gpu/drm/drm_edid.c  |   19 ++-
 drivers/gpu/drm/drm_edid_modes.h|4 ++--
 drivers/gpu/drm/drm_modes.c |6 +++---
 drivers/gpu/drm/i915/intel_sdvo.c   |2 +-
 drivers/gpu/drm/nouveau/nv17_tv.c   |4 +++-
 drivers/gpu/drm/nouveau/nv17_tv.h   |2 +-
 drivers/gpu/drm/nouveau/nv17_tv_modes.c |2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |5 +++--
 include/drm/drm_crtc.h  |6 +++---
 9 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a245d17..af60d9b 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -449,12 +449,11 @@ static void edid_fixup_preferred(struct drm_connector 
*connector,
 struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
   int hsize, int vsize, int fresh)
 {
+   struct drm_display_mode *mode = NULL;
int i;
-   struct drm_display_mode *ptr, *mode;
 
-   mode = NULL;
for (i = 0; i  drm_num_dmt_modes; i++) {
-   ptr = drm_dmt_modes[i];
+   const struct drm_display_mode *ptr = drm_dmt_modes[i];
if (hsize == ptr-hdisplay 
vsize == ptr-vdisplay 
fresh == drm_mode_vrefresh(ptr)) {
@@ -885,7 +884,7 @@ static struct drm_display_mode *drm_mode_detailed(struct 
drm_device *dev,
 }
 
 static bool
-mode_is_rb(struct drm_display_mode *mode)
+mode_is_rb(const struct drm_display_mode *mode)
 {
return (mode-htotal - mode-hdisplay == 160) 
   (mode-hsync_end - mode-hdisplay == 80) 
@@ -894,7 +893,8 @@ mode_is_rb(struct drm_display_mode *mode)
 }
 
 static bool
-mode_in_hsync_range(struct drm_display_mode *mode, struct edid *edid, u8 *t)
+mode_in_hsync_range(const struct drm_display_mode *mode,
+   struct edid *edid, u8 *t)
 {
int hsync, hmin, hmax;
 
@@ -910,7 +910,8 @@ mode_in_hsync_range(struct drm_display_mode *mode, struct 
edid *edid, u8 *t)
 }
 
 static bool
-mode_in_vsync_range(struct drm_display_mode *mode, struct edid *edid, u8 *t)
+mode_in_vsync_range(const struct drm_display_mode *mode,
+   struct edid *edid, u8 *t)
 {
int vsync, vmin, vmax;
 
@@ -941,7 +942,7 @@ range_pixel_clock(struct edid *edid, u8 *t)
 }
 
 static bool
-mode_in_range(struct drm_display_mode *mode, struct edid *edid,
+mode_in_range(const struct drm_display_mode *mode, struct edid *edid,
  struct detailed_timing *timing)
 {
u32 max_clock;
@@ -1472,7 +1473,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
int hdisplay, int vdisplay)
 {
int i, count, num_modes = 0;
-   struct drm_display_mode *mode, *ptr;
+   struct drm_display_mode *mode;
struct drm_device *dev = connector-dev;
 
count = sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);
@@ -1482,7 +1483,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
vdisplay = 0;
 
for (i = 0; i  count; i++) {
-   ptr = drm_dmt_modes[i];
+   const struct drm_display_mode *ptr = drm_dmt_modes[i];
if (hdisplay  vdisplay) {
/*
 * Only when two are valid, they will be used to check
diff --git a/drivers/gpu/drm/drm_edid_modes.h b/drivers/gpu/drm/drm_edid_modes.h
index 6eb7592..5f20644 100644
--- a/drivers/gpu/drm/drm_edid_modes.h
+++ b/drivers/gpu/drm/drm_edid_modes.h
@@ -32,7 +32,7 @@
  * This table is copied from xfree86/modes/xf86EdidModes.c.
  * But the mode with Reduced blank feature is deleted.
  */
-static struct drm_display_mode drm_dmt_modes[] = {
+static const struct drm_display_mode drm_dmt_modes[] = {
/* 640x350@85Hz */
{ DRM_MODE(640x350, DRM_MODE_TYPE_DRIVER, 31500, 640, 672,
   736, 832, 0, 350, 382, 385, 445, 0,
@@ -266,7 +266,7 @@ static struct drm_display_mode drm_dmt_modes[] = {
 static const int drm_num_dmt_modes =
sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);
 
-static struct drm_display_mode edid_est_modes[] = {
+static const struct drm_display_mode edid_est_modes[] = {
{ DRM_MODE(800x600, DRM_MODE_TYPE_DRIVER, 4, 800, 840,
   968, 1056, 0, 600, 601, 605, 628, 0,
   DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 
800x600@60Hz */
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 58e65f9..25bf873 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -593,7 +593,7 @@ EXPORT_SYMBOL(drm_mode_height);
  

[Bug 31830] [bisected] broken shadows in Unigine Sanctuary and Lightsmark

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31830

--- Comment #8 from Pavel Ondračka dra...@centrum.cz 2011-01-26 02:17:15 PST 
---
Created an attachment (id=42516)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42516)
screenshot of the problem

(In reply to comment #7)
 Created an attachment (id=42514)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42514
 Review: https://bugs.freedesktop.org/review?bug=31830attachment=42514

 Disable instruction rewriting in the scheduler
 
 I think this bug is actually in the scheduler, and it is just being exposed by
 the reg rename pass.  I have been able to track down a few instructions that
 the scheduler is converting from vector to scalar that change how the shadows
 are rendered.  However, these conversions look valid too me, so I'm really not
 sure what the problem is.  I think this patch fixes Lightsmark, but I'm not
 sure what the shadows are supposed to look like.  Can you try this patch on
 Lightsmark and Sanctuary.  Thanks.

Hi, this patch doesn't help neither. I tested it alone and also with the first
patch. Concerning how the penumbra shadows should look, you don't get the right
behavior with RADEON_DEBUG=noopt? I've attached screenshot comparing bad and
good shadows. Don't know how to help you more, I still have the debug patches
you've sent me when we were debugging sanctuary before the enable rename_reg
patch was committed, maybe I could use them again to identify the failing
shader?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] drm: Never change the connector status to unknown whilst polling

2011-01-26 Thread Chris Wilson
When polling for a hotplug event, if the connector detect probe returns
unknown, reuse the current status and do not trigger a hotplug event.

Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 drivers/gpu/drm/drm_crtc.c|1 +
 drivers/gpu/drm/drm_crtc_helper.c |   11 +++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 2baa670..f6678f6 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -459,6 +459,7 @@ void drm_connector_init(struct drm_device *dev,
INIT_LIST_HEAD(connector-probed_modes);
INIT_LIST_HEAD(connector-modes);
connector-edid_blob_ptr = NULL;
+   connector-status = connector_status_unknown;
 
list_add_tail(connector-head, dev-mode_config.connector_list);
dev-mode_config.num_connector++;
diff --git a/drivers/gpu/drm/drm_crtc_helper.c 
b/drivers/gpu/drm/drm_crtc_helper.c
index 952b3d4..b3afb38 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -862,7 +862,6 @@ static void output_poll_execute(struct work_struct *work)
struct delayed_work *delayed_work = to_delayed_work(work);
struct drm_device *dev = container_of(delayed_work, struct drm_device, 
mode_config.output_poll_work);
struct drm_connector *connector;
-   enum drm_connector_status old_status;
bool repoll = false, changed = false;
 
if (!drm_kms_helper_poll)
@@ -870,6 +869,7 @@ static void output_poll_execute(struct work_struct *work)
 
mutex_lock(dev-mode_config.mutex);
list_for_each_entry(connector, dev-mode_config.connector_list, head) {
+   enum drm_connector_status old_status, new_status;
 
/* if this is HPD or polled don't check it -
   TV out for instance */
@@ -883,15 +883,18 @@ static void output_poll_execute(struct work_struct *work)
/* if we are connected and don't want to poll for disconnect
   skip it */
if (old_status == connector_status_connected 
-   !(connector-polled  DRM_CONNECTOR_POLL_DISCONNECT) 
-   !(connector-polled  DRM_CONNECTOR_POLL_HPD))
+   (connector-polled  (DRM_CONNECTOR_POLL_DISCONNECT | 
DRM_CONNECTOR_POLL_HPD)) == 0)
continue;
 
-   connector-status = connector-funcs-detect(connector, false);
+   new_status = connector-funcs-detect(connector, false);
+   if (new_status != connector_status_unknown)
+   connector-status = new_status;
+
DRM_DEBUG_KMS([CONNECTOR:%d:%s] status updated from %d to 
%d\n,
  connector-base.id,
  drm_get_connector_name(connector),
  old_status, connector-status);
+
if (old_status != connector-status)
changed = true;
}
-- 
1.7.2.3

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Arnd Bergmann
On Wednesday 26 January 2011, Greg KH wrote:
 On Tue, Jan 25, 2011 at 11:17:14PM +0100, Arnd Bergmann wrote:
  I've gone through all the code in the kernel that
  uses the big kernel lock and come up with a solution
  that seems at least half-reasonable for each of them.
  
  The decisions are somewhat arbitrary, but here is
  what I'd suggest we do:
  
  * Remove in 2.6.39:
 i830, autofs3, smbfs
 
 I thought some people really wanted to keep i830.  Or was that i810?
  I'll drop autofs3 and smbfs, thanks.

i810 needs to be kept, i830 is obsolete, see the patch changelogs
there. I assume that Dave Airlie will take both patches (i810 BKL
removal and i830 removal) into his 2.6.39 queue.

  * Work around in an ugly way, but keep alive:
 * ufs, ipx, i810, cx25721
  
  * Fix properly:
 * usbip, go7007, adfs, x25
 
 Thanks for the usbip and go7007 patches, I'll queue them up.

It would be good if you could also take the cx25721 patch. It's
not the nicest one I've done, but it's a bug fix nonetheless.

Thanks,

Arnd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Mauro Carvalho Chehab
Em 26-01-2011 09:31, Arnd Bergmann escreveu:
 On Wednesday 26 January 2011, Greg KH wrote:
 On Tue, Jan 25, 2011 at 11:17:14PM +0100, Arnd Bergmann wrote:
 I've gone through all the code in the kernel that
 uses the big kernel lock and come up with a solution
 that seems at least half-reasonable for each of them.

 The decisions are somewhat arbitrary, but here is
 what I'd suggest we do:

 * Remove in 2.6.39:
i830, autofs3, smbfs

 I thought some people really wanted to keep i830.  Or was that i810?
  I'll drop autofs3 and smbfs, thanks.
 
 i810 needs to be kept, i830 is obsolete, see the patch changelogs
 there. I assume that Dave Airlie will take both patches (i810 BKL
 removal and i830 removal) into his 2.6.39 queue.
 
 * Work around in an ugly way, but keep alive:
* ufs, ipx, i810, cx25721

 * Fix properly:
* usbip, go7007, adfs, x25

 Thanks for the usbip and go7007 patches, I'll queue them up.
 
 It would be good if you could also take the cx25721 patch. It's
 not the nicest one I've done, but it's a bug fix nonetheless.

I guess you're meaning cx25821, right? 

Palash should take a look on it and review. This is a device that allows
12 simultaneous streams, so, I suspect that he'll need to do some
changes at the locking schema, to avoid performance bottlenecks.

Cheers,
Mauro
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Arnd Bergmann
On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote:
 I guess you're meaning cx25821, right? 

Right, sorry for the typo.
 
 Palash should take a look on it and review. This is a device that allows
 12 simultaneous streams, so, I suspect that he'll need to do some
 changes at the locking schema, to avoid performance bottlenecks.

I would be surprised if there was any measurable performance change.
The BKL was used only in the open() function to iterate the device
list, and that code is nowhere on a critical path, as far as I can tell.

Arnd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 32945] Lower part of the screen corrupt with HyperZ enabled

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32945

--- Comment #13 from Sven Arvidsson s...@whiz.se 2011-01-26 07:59:30 PST ---
Created an attachment (id=42527)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42527)
shadowtex screenshot

Okay, so if I have done this correctly, the small white area in the left corner
is 48x16, if you mean the larger black and white rendering it seems to be
256x257.

I'm attaching a screenshot of shadowtex.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 27314] DP link training fails on 2560x1440 panels

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27314

--- Comment #31 from Travis Glenn Hansen travisghan...@yahoo.com 2011-01-26 
08:35:56 PST ---
Created an attachment (id=42529)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42529)
dmesg output with 2011-01-25 patches

Thanks for continuing to look at this!  Still no go with those patches for me. 
See attached dmesg.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv-wq

2011-01-26 Thread Tejun Heo
With cmwq, there's no reason for nouveau to use a dedicated workqueue.
Drop dev_priv-wq and use system_wq instead.  Each work item is sync
flushed when the containing structure is unregistered/destroyed.

Note that this change also makes sure that nv50_gpio_handler is not
freed while the contained work item is still running.

Signed-off-by: Tejun Heo t...@kernel.org
Cc: David Airlie airl...@linux.ie
Cc: dri-devel@lists.freedesktop.org
---
Here's a patch on top of the current linus#master.  It's much simpler
than before.  The only concern is that it adds flush_work_sync() call
which might sleep to unregistration paths.  AFAICS, this seems safe,
right?  If this looks okay to you, please feel free to route it
through the drm tree.

Thank you.

 drivers/gpu/drm/nouveau/nouveau_drv.h   |1 -
 drivers/gpu/drm/nouveau/nouveau_state.c |   10 +-
 drivers/gpu/drm/nouveau/nv50_display.c  |5 -
 drivers/gpu/drm/nouveau/nv50_gpio.c |   11 ---
 4 files changed, 13 insertions(+), 14 deletions(-)

Index: work/drivers/gpu/drm/nouveau/nouveau_drv.h
===
--- work.orig/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ work/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -652,7 +652,6 @@ struct drm_nouveau_private {
/* interrupt handling */
void (*irq_handler[32])(struct drm_device *);
bool msi_enabled;
-   struct workqueue_struct *wq;
struct work_struct irq_work;
 
struct list_head vbl_waiting;
Index: work/drivers/gpu/drm/nouveau/nouveau_state.c
===
--- work.orig/drivers/gpu/drm/nouveau/nouveau_state.c
+++ work/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -929,12 +929,6 @@ int nouveau_load(struct drm_device *dev,
NV_DEBUG(dev, vendor: 0x%X device: 0x%X class: 0x%X\n,
 dev-pci_vendor, dev-pci_device, dev-pdev-class);
 
-   dev_priv-wq = create_workqueue(nouveau);
-   if (!dev_priv-wq) {
-   ret = -EINVAL;
-   goto err_priv;
-   }
-
/* resource 0 is mmio regs */
/* resource 1 is linear FB */
/* resource 2 is RAMIN (mmio regs + 0x100) */
@@ -947,7 +941,7 @@ int nouveau_load(struct drm_device *dev,
NV_ERROR(dev, Unable to initialize the mmio mapping. 
 Please report your setup to  DRIVER_EMAIL \n);
ret = -EINVAL;
-   goto err_wq;
+   goto err_priv;
}
NV_DEBUG(dev, regs mapped ok at 0x%llx\n,
(unsigned long long)mmio_start_offs);
@@ -1054,8 +1048,6 @@ err_ramin:
iounmap(dev_priv-ramin);
 err_mmio:
iounmap(dev_priv-mmio);
-err_wq:
-   destroy_workqueue(dev_priv-wq);
 err_priv:
kfree(dev_priv);
dev-dev_private = NULL;
Index: work/drivers/gpu/drm/nouveau/nv50_display.c
===
--- work.orig/drivers/gpu/drm/nouveau/nv50_display.c
+++ work/drivers/gpu/drm/nouveau/nv50_display.c
@@ -345,12 +345,15 @@ int nv50_display_create(struct drm_devic
 void
 nv50_display_destroy(struct drm_device *dev)
 {
+   struct drm_nouveau_private *dev_priv = dev-dev_private;
+
NV_DEBUG_KMS(dev, \n);
 
drm_mode_config_cleanup(dev);
 
nv50_display_disable(dev);
nouveau_irq_unregister(dev, 26);
+   flush_work_sync(dev_priv-irq_work);
 }
 
 static u16
@@ -836,7 +839,7 @@ nv50_display_isr(struct drm_device *dev)
if (clock) {
nv_wr32(dev, NV03_PMC_INTR_EN_0, 0);
if (!work_pending(dev_priv-irq_work))
-   queue_work(dev_priv-wq, dev_priv-irq_work);
+   schedule_work(dev_priv-irq_work);
delayed |= clock;
intr1 = ~clock;
}
Index: work/drivers/gpu/drm/nouveau/nv50_gpio.c
===
--- work.orig/drivers/gpu/drm/nouveau/nv50_gpio.c
+++ work/drivers/gpu/drm/nouveau/nv50_gpio.c
@@ -137,6 +137,7 @@ nv50_gpio_irq_unregister(struct drm_devi
struct nv50_gpio_priv *priv = pgpio-priv;
struct nv50_gpio_handler *gpioh, *tmp;
struct dcb_gpio_entry *gpio;
+   LIST_HEAD(tofree);
unsigned long flags;
 
gpio = nouveau_bios_gpio_entry(dev, tag);
@@ -149,10 +150,14 @@ nv50_gpio_irq_unregister(struct drm_devi
gpioh-handler != handler ||
gpioh-data != data)
continue;
-   list_del(gpioh-head);
-   kfree(gpioh);
+   list_move(gpioh-head, tofree);
}
spin_unlock_irqrestore(priv-lock, flags);
+
+   list_for_each_entry_safe(gpioh, tmp, tofree, head) {
+   flush_work_sync(gpioh-work);
+   kfree(gpioh);
+   }
 }
 
 bool
@@ -293,7 +298,7 

[Bug 33139] Radeon HD 5750 locks up when using 3D apps with r600g

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33139

--- Comment #4 from Siganderson dj_...@webmail.it 2011-01-26 09:26:13 PST ---
It could be the same as https://bugs.freedesktop.org/show_bug.cgi?id=33381
I add that with the 2.6.35 kernel all games seem to work without this problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33185] X crashes when kWin effects are turned on

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33185

Wojciech Ryrych woj...@ryrych.pl changed:

   What|Removed |Added

  Attachment #42100|0   |1
is obsolete||

--- Comment #6 from Wojciech Ryrych woj...@ryrych.pl 2011-01-26 09:39:53 PST 
---
Created an attachment (id=42538)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42538)
kWin backtrace

OK, I've installed debugging symbols so hope this backtrace is more helpful. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #11 from Russ Dill russ.d...@gmail.com 2011-01-26 09:40:00 PST ---
 Does a dpms cycle help?
 xset dpms force off

Nope (but causes the VGA-0 monitor to flash off and on)

 Does restarting X help?

Nope

 How about forcing a mode change? e.g.,
 xrandr --output HDMI-0 --mode 1680x1050

Nope

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33185] X crashes when kWin effects are turned on

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33185

Michel Dänzer mic...@daenzer.net changed:

   What|Removed |Added

  Component|Drivers/DRI/r300|Drivers/Gallium/r300

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


RE: [RFC 00/20] Proposal for remaining BKL users

2011-01-26 Thread Palash Bandyopadhyay
I think it should be ok. If we do hit any performance issue, we'll revisit this.

Thanks,
Palash

-Original Message-
From: Arnd Bergmann [mailto:a...@arndb.de] 
Sent: Wednesday, January 26, 2011 5:45 AM
To: Mauro Carvalho Chehab
Cc: Greg KH; linux-ker...@vger.kernel.org; Andrew Hendry; Andrew Morton; Arjan 
van de Ven; Arnaldo Carvalho de Melo; aut...@linux.kernel.org; Chris Wilson; 
Dave Airlie; dri-devel@lists.freedesktop.org; Evgeniy Dushistov; Frederic 
Weisbecker; H. Peter Anvin; Ian Kent; Ingo Molnar; Jeff Layton; 
linux-c...@vger.kernel.org; linux-fsde...@vger.kernel.org; 
linux-...@vger.kernel.org; Mikulas Patocka; net...@vger.kernel.org; Nick 
Bowler; Palash Bandyopadhyay; Ross Cohen; Russell King; Stuart Swales; Takahiro 
Hirofuchi; Thomas Gleixner
Subject: Re: [RFC 00/20] Proposal for remaining BKL users

On Wednesday 26 January 2011, Mauro Carvalho Chehab wrote:
 I guess you're meaning cx25821, right? 

Right, sorry for the typo.
 
 Palash should take a look on it and review. This is a device that allows
 12 simultaneous streams, so, I suspect that he'll need to do some
 changes at the locking schema, to avoid performance bottlenecks.

I would be surprised if there was any measurable performance change.
The BKL was used only in the open() function to iterate the device
list, and that code is nowhere on a critical path, as far as I can tell.

Arnd

Conexant E-mail Firewall (Conexant.Com) made the following annotations
-
** Legal Disclaimer  

This email may contain confidential and privileged material for the sole use 
of the intended recipient. Any unauthorized review, use or distribution by 
others is strictly prohibited. If you have received the message in error, 
please advise the sender by reply email and delete the message. Thank you. 

** 

-

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] drm: Remove unused members from struct drm_open_hash

2011-01-26 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 drivers/gpu/drm/drm_hashtab.c |   27 ---
 include/drm/drm_hashtab.h |6 +-
 2 files changed, 9 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/drm_hashtab.c b/drivers/gpu/drm/drm_hashtab.c
index a93d7b4..e3a7568 100644
--- a/drivers/gpu/drm/drm_hashtab.c
+++ b/drivers/gpu/drm/drm_hashtab.c
@@ -39,27 +39,18 @@
 
 int drm_ht_create(struct drm_open_hash *ht, unsigned int order)
 {
-   unsigned int i;
+   unsigned int size = 1  order;
 
-   ht-size = 1  order;
ht-order = order;
-   ht-fill = 0;
ht-table = NULL;
-   ht-use_vmalloc = ((ht-size * sizeof(*ht-table))  PAGE_SIZE);
-   if (!ht-use_vmalloc) {
-   ht-table = kcalloc(ht-size, sizeof(*ht-table), GFP_KERNEL);
-   }
-   if (!ht-table) {
-   ht-use_vmalloc = 1;
-   ht-table = vmalloc(ht-size*sizeof(*ht-table));
-   }
+   if (size = PAGE_SIZE / sizeof(*ht-table))
+   ht-table = kcalloc(size, sizeof(*ht-table), GFP_KERNEL);
+   else
+   ht-table = vzalloc(size*sizeof(*ht-table));
if (!ht-table) {
DRM_ERROR(Out of memory for hash table\n);
return -ENOMEM;
}
-   for (i=0; i ht-size; ++i) {
-   INIT_HLIST_HEAD(ht-table[i]);
-   }
return 0;
 }
 EXPORT_SYMBOL(drm_ht_create);
@@ -180,7 +171,6 @@ int drm_ht_remove_key(struct drm_open_hash *ht, unsigned 
long key)
list = drm_ht_find_key(ht, key);
if (list) {
hlist_del_init(list);
-   ht-fill--;
return 0;
}
return -EINVAL;
@@ -189,7 +179,6 @@ int drm_ht_remove_key(struct drm_open_hash *ht, unsigned 
long key)
 int drm_ht_remove_item(struct drm_open_hash *ht, struct drm_hash_item *item)
 {
hlist_del_init(item-head);
-   ht-fill--;
return 0;
 }
 EXPORT_SYMBOL(drm_ht_remove_item);
@@ -197,10 +186,10 @@ EXPORT_SYMBOL(drm_ht_remove_item);
 void drm_ht_remove(struct drm_open_hash *ht)
 {
if (ht-table) {
-   if (ht-use_vmalloc)
-   vfree(ht-table);
-   else
+   if ((PAGE_SIZE / sizeof(*ht-table))  ht-order)
kfree(ht-table);
+   else
+   vfree(ht-table);
ht-table = NULL;
}
 }
diff --git a/include/drm/drm_hashtab.h b/include/drm/drm_hashtab.h
index 0af087a..3650d5d 100644
--- a/include/drm/drm_hashtab.h
+++ b/include/drm/drm_hashtab.h
@@ -45,14 +45,10 @@ struct drm_hash_item {
 };
 
 struct drm_open_hash {
-   unsigned int size;
-   unsigned int order;
-   unsigned int fill;
struct hlist_head *table;
-   int use_vmalloc;
+   u8 order;
 };
 
-
 extern int drm_ht_create(struct drm_open_hash *ht, unsigned int order);
 extern int drm_ht_insert_item(struct drm_open_hash *ht, struct drm_hash_item 
*item);
 extern int drm_ht_just_insert_please(struct drm_open_hash *ht, struct 
drm_hash_item *item,
-- 
1.7.2.3

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #12 from Alex Deucher ag...@yahoo.com 2011-01-26 10:36:22 PST ---
Can you dump the following regs with avivotool (available here:
http://cgit.freedesktop.org/~airlied/radeontool/) as root before and after
suspend?

avivotool regmatch reg

Where reg =
0x7880
0x7884
0x7888
0x788c
0x7890
0x7894
0x7898
0x789c
0x78a0
0x78a4
0x78a8
0x78ac
0x78b0
0x78b4
0x78b8
0x78bc
0x78c0
0x78c4
0x78c8
0x78cc
0x78d0
0x78d4
0x78d8
0x78dc
0x78e0
0x7904
0x7908
0x790c
0x7910
0x7914
0x7918
0x791c

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33541] New: game Braid : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33541

   Summary: game Braid :  radeon :01:00.0:
r600_check_texture_resource:1208 texture invalid
format 51
   Product: Mesa
   Version: git
  Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Gallium/r600
AssignedTo: dri-devel@lists.freedesktop.org
ReportedBy: aderum...@odiso.com


Braid game is launching but black screen at start.
/var/log/messages:

radeon :01:00.0: r600_check_texture_resource:1208 texture invalid format 51


i'm using mesa-git , drm-radeon-testing-git kernel,libdrm-git and
xf86-video-ati-git from 17/01/01.



this is a regression,It was working perfectly +-1 week before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33541] game Braid : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #1 from Alexandre Derumier aderum...@odiso.com 2011-01-26 
10:38:42 PST ---
forget to say:

i'm using a RV620 chipset

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33541] game Braid : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #2 from Alex Deucher ag...@yahoo.com 2011-01-26 10:43:53 PST ---
Can you bisect mesa?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33541] game Braid : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #3 from Alexandre Derumier aderum...@odiso.com 2011-01-26 
10:46:11 PST ---
(In reply to comment #2)
 Can you bisect mesa?

i'll try, but i don't have much time with my work for the moment ;)

i'll keep you in touch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33542] game nexuiz : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 49

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33542

Alex Deucher ag...@yahoo.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Alex Deucher ag...@yahoo.com 2011-01-26 10:49:29 PST ---


*** This bug has been marked as a duplicate of bug 33541 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33541] game Braid : radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33541

--- Comment #4 from Alex Deucher ag...@yahoo.com 2011-01-26 10:49:29 PST ---
*** Bug 33542 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33172] [r600g] ingame rendering broken (black screen) in ut2003

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33172

--- Comment #3 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 11:46:00 PST 
---
New tests on my system with ut2004. UseVBO is disabled, so I only get a black
screen ingame.

I can still play though (by ear so to speak) and while doing this I watched
memory consumption of the process:
Monitoring ut2004-bin with htop showed that during peak times the process has
more than 50GiB virtual mem (VIRT) allocated. So there's clearly a mem leak
here.

Could valgrind help to detect such a leak?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #10 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:01:26 
PST ---
Created an attachment (id=42552)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42552)
ut2004 mipmap errors 1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #11 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:01:41 
PST ---
Created an attachment (id=42553)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42553)
ut2004 mipmap errors 2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #12 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:01:56 
PST ---
Created an attachment (id=42554)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42554)
ut2004 mipmap errors 3

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 31046] [r600g, tiling] visual errors and GPU resets

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #13 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:02:10 
PST ---
Created an attachment (id=42555)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42555)
ut2004 mipmap errors 4

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #5 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:04:27 PST 
---
Since I also have rendering errors in doom3, which are probably related to
shadows, I'm attaching some screenshots which show them.

Using r600g on a RV740. libdrm, mesa and xf86-video-ati all git master. kernel
is fresh d-r-t.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #6 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:04:54 PST 
---
Created an attachment (id=42556)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42556)
broken shadows on r600g 1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #7 from Tobias Jakobi liquid.a...@gmx.net 2011-01-26 13:05:15 PST 
---
Created an attachment (id=42557)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42557)
broken shadows on r600g 2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] radeon/kms: fix dp displayport mode validation

2011-01-26 Thread jglisse
From: Jerome Glisse jgli...@redhat.com

Check if there is a big enough dp clock  enough dp lane to
drive the video mode provided.

Signed-off-by: Jerome Glisse jgli...@redhat.com
Cc: sta...@kernel.org
---
 drivers/gpu/drm/radeon/atombios_dp.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
b/drivers/gpu/drm/radeon/atombios_dp.c
index 4e7778d..695de9a 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
dpcd[DP_DPCD_SIZE], int mode_clock)
 int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
 {
int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
-   int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
+   int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);
 
-   if ((lanes == 0) || (bw == 0))
+   if ((lanes == 0) || (dp_clock == 0))
return MODE_CLOCK_HIGH;
 
return MODE_OK;
-- 
1.7.3.2

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] radeon/kms: fix dp displayport mode validation

2011-01-26 Thread Alex Deucher
On Wed, Jan 26, 2011 at 5:51 PM,  jgli...@redhat.com wrote:
 From: Jerome Glisse jgli...@redhat.com

 Check if there is a big enough dp clock  enough dp lane to
 drive the video mode provided.

 Signed-off-by: Jerome Glisse jgli...@redhat.com
 Cc: sta...@kernel.org

Looks like a copy paste error, probably from me :)

Reviewed-By: Alex Deucher alexdeuc...@gmail.com

 ---
  drivers/gpu/drm/radeon/atombios_dp.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
 b/drivers/gpu/drm/radeon/atombios_dp.c
 index 4e7778d..695de9a 100644
 --- a/drivers/gpu/drm/radeon/atombios_dp.c
 +++ b/drivers/gpu/drm/radeon/atombios_dp.c
 @@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
 dpcd[DP_DPCD_SIZE], int mode_clock)
  int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
  {
        int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
 -       int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
 +       int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);

 -       if ((lanes == 0) || (bw == 0))
 +       if ((lanes == 0) || (dp_clock == 0))
                return MODE_CLOCK_HIGH;

        return MODE_OK;
 --
 1.7.3.2

 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33077] Broken rendering with black areas in Doom3-demo also falls to 3-4 fps time to time

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33077

--- Comment #8 from Andy Furniss li...@andyfurniss.entadsl.com 2011-01-26 
15:02:16 PST ---
(In reply to comment #5)
 Since I also have rendering errors in doom3, which are probably related to
 shadows, I'm attaching some screenshots which show them.
 
 Using r600g on a RV740. libdrm, mesa and xf86-video-ati all git master. kernel
 is fresh d-r-t.

I am also seeing this with 600g on a rv790.

With a debug build of mesa, stderr is flooded with -

Mesa: User error: GL_INVALID_VALUE in glScissor

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 32296] [r300g] Screen corruption with WoW when HyperZ enabled.

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32296

--- Comment #15 from Chris Rankin ranki...@googlemail.com 2011-01-26 15:04:37 
PST ---
(In reply to comment #13)
 If you compile with --enable-debug, it should print the hyperz status to
 stderr.

RADEON_HYPERZ=1
RADEON_DEBUG=hyperz

and then I get lots of lines like:

hyper-z features: hiz: 0 @ deadbeef

RV350 has no HiZ, so that's not unexpected. The can_hyperz flag does appear to
be being set as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


has the i915 black screen boot issue returned?

2011-01-26 Thread Robert P. J. Day

  after suffering through the i915 black screen issue for a while,
it was a relief that it finally seemed to be resolved with 2.6.37 or
something in tha vicinity.  but i just built and booted a 2.6.38-rc2+
kernel on my ubuntu 10.10 system and it once again boots to a black
screen.

  is this a new known issue?  has anyone else seen this?

rday

-- 


Robert P. J. Day   Waterloo, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 26942] radeon: screen distortion on resume

2011-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=26942





--- Comment #11 from Brett Witherspoon spo...@exherbo.org  2011-01-27 
03:26:19 ---
Created an attachment (id=45232)
 -- (https://bugzilla.kernel.org/attachment.cgi?id=45232)
regs before resume

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.

--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
--
___
Dri-devel mailing list
dri-de...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 26942] radeon: screen distortion on resume

2011-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=26942





--- Comment #12 from Brett Witherspoon spo...@exherbo.org  2011-01-27 
03:26:45 ---
Created an attachment (id=45242)
 -- (https://bugzilla.kernel.org/attachment.cgi?id=45242)
regs after resume

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.

--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
--
___
Dri-devel mailing list
dri-de...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #13 from Russ Dill russ.d...@gmail.com 2011-01-26 22:36:03 PST ---
Created an attachment (id=42572)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42572)
 avivotool regmatch 0x7880..0x791c (before suspend)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Bug 33011] HDMI-A-1 Does not work after resume (But claims it does)

2011-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33011

--- Comment #14 from Russ Dill russ.d...@gmail.com 2011-01-26 22:36:44 PST ---
Created an attachment (id=42573)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=42573)
 avivotool regmatch 0x7880..0x791c (after resume)

Both files are identical

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel