[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 --- Comment #5 from Jason Hicks (jasz...@gmail.com) --- Created attachment 275717 --> https://bugzilla.kernel.org/attachment.cgi?id=275717=edit Xorg.0.log -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 --- Comment #4 from Jason Hicks (jasz...@gmail.com) --- Created attachment 275715 --> https://bugzilla.kernel.org/attachment.cgi?id=275715=edit xrandr -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 Jason Hicks (jasz...@gmail.com) changed: What|Removed |Added Hardware|All |x86-64 -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 --- Comment #3 from Jason Hicks (jasz...@gmail.com) --- Created attachment 275713 --> https://bugzilla.kernel.org/attachment.cgi?id=275713=edit inxi -F -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 --- Comment #2 from Jason Hicks (jasz...@gmail.com) --- Created attachment 275711 --> https://bugzilla.kernel.org/attachment.cgi?id=275711=edit lspci -vk -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 --- Comment #1 from Jason Hicks (jasz...@gmail.com) --- Created attachment 275709 --> https://bugzilla.kernel.org/attachment.cgi?id=275709=edit kernel bug -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 199585] New: AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off
https://bugzilla.kernel.org/show_bug.cgi?id=199585 Bug ID: 199585 Summary: AMDGPU related kernel dump in /home/kernel/COD/linux/mm/slub.c:296 after monitors power off Product: Drivers Version: 2.5 Kernel Version: 4.16.6 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-...@kernel-bugs.osdl.org Reporter: jasz...@gmail.com Regression: No Created attachment 275707 --> https://bugzilla.kernel.org/attachment.cgi?id=275707=edit dmesg Using three monitors, one connected via display port, one DVI, and one HDMI. After they reach the display timeout and power off, the machine hard locks leaving a kernel bug stacktrace. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #66 from H4nN1baL--- Okay, thanks for your reply. Then our problems are unrelated. Even so let me share you some intel. Disable any BIOS configuration related to "GART" and "PCIE Spread Spectrum"(PCIe overclock). And keep in mind that GPUs also come with a BIOS, in some cases, they really need to be updated. Good luck. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
答复: Tracking: radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
Hi , If you are sure that the HW worked fine before. I think you should: 1. Be sure that HW works fine now. 2. recall the driver to the point at where it works well, and then replace them one by one to confirm component which causes the issue. 3. try to update the last VBIOS to adapt new driver. Thanks JimQu 发件人: amd-gfx代表 Christian König 发送时间: 2018年4月30日 1:16:14 收件人: Mathieu Malaterre; Deucher, Alexander 抄送: David Airlie; Zhou, David(ChunMing); dri-devel; amd-...@lists.freedesktop.org; LKML 主题: Re: Tracking: radeon :00:10.0: ring 0 stalled for more than 10240msec Am 23.04.2018 um 20:50 schrieb Mathieu Malaterre: > Hi there, > > I am pretty sure I was able to run kodi on an old Mac Mini G4 (big > endian) with AMD RV280. Today it is failing to start with: Well, that is rather old hardware. I suggest to make sure first that the hw isn't broken in some way. > How should I go and debug this (other than plain git-bisect) ? You first need to figure out what's the failing component. Either Mesa, DDX or the Kernel are possible candidates. Another possibility is that you updated kodi and kodi is now doing something the hw doesn't like. Regards, Christian. ___ amd-gfx mailing list amd-...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #65 from MirceaKitsune--- (In reply to H4nN1baL from comment #64) Just tested with "export MESA_EXTENSION_OVERRIDE=-GL_ARB_buffer_storage". It did not affect the freeze triggered by playing back the Blender trace. Also, to answer iive's last point which I forgot in the previous response: I have temperature monitors on my desktop, and one of the Xonotic freezes happened just a second after I alt-tab switched back from checking it. All fans and temperatures were perfectly fine during that test: The CPU was around the typical 48°C, whereas the GPU never exceeded 68°C itself. Temperatures are most surely not an issue. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v7 2/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings
This add a dt binding for ZynqMP DP subsystem. Signed-off-by: Hyun KwonReviewed-by: Rob Herring --- v6 - Add more descriptions and references - Remove the description for child node v4 - Specify phy related descriptions - Specify dma related descriptions - Remove ports - Remove child nodes for layers - Update the example accordingly v2 - Group multiple ports under 'ports' - Replace linux specific terms with generic hardware descriptions --- --- .../bindings/display/xlnx/xlnx,zynqmp-dpsub.txt| 77 ++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.txt diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.txt b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.txt new file mode 100644 index 000..ec8a58a --- /dev/null +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.txt @@ -0,0 +1,77 @@ +Xilinx ZynqMP DisplayPort subsystem +--- + +The DisplayPort subsystem of Xilinx ZynqMP (Zynq UltraScale+ MPSoC) implements +the display and audio pipelines based on the DisplayPort v1.2 standard. +The subsystem includes multiple functional blocks as below: + + buffer manager <-> blender & mixer <-> DP Tx + +The buffer manager interacts with external interface such as DMA engines or +live streams. The blender and mixer blends the incoming video / audio streams +into single stream. The DP Tx converts and transmits the stream into DisplayPort +protocol through external phy. The subsystem supports 2 video and 2 audio +streams, and various pixel formats / depths up to 4K@30 resolution. + +Please refer to "Zynq UltraScale+ Device Technical Reference Manual" [UG1085] +for more details. + +Required properties: + +- compatible: Must be "xlnx,zynqmp-dpsub-1.7". + +- reg: Physical base address and length of the registers set for the device. +- reg-names: Must be "dp", "blend", "av_buf", and "aud" to map logical register + partitions. + +- interrupts: Interrupt number. +- interrupts-parent: phandle for interrupt controller. + +- clocks: phandles for axi, audio, non-live video, and live video clocks. + axi clock is required. Audio clock is optional. If not present, audio will + be disabled. One of non-live or live video clock should be present. +- clock-names: The identification strings are required. "aclk" for axi clock. + "dp_aud_clk" for audio clock. "dp_vtc_pixel_clk_in" for non-live video clock. + "dp_live_video_in_clk" for live video clock (clock from programmable logic). + +- phys: phandles for phy specifier. The number of lanes is configurable + between 1 and 2. The number of phandles should be 1 or 2. +- phy-names: The identifier strings. "dp-phy" followed by index, 0 or 1. + For single lane, only "dp-phy0" is required. For dual lane, both "dp-phy0" + and "dp-phy1" are required where "dp-phy0" is the primary lane. + +- power-domains: phandle for the corresponding power domain + +- dmas: phandles for DMA channels as defined in + Documentation/devicetree/bindings/dma/dma.txt. +- dma-names: The identifier strings are required. "gfx0" for graphics layer + dma channel. "vid" followed by index (0 - 2) for video layer dma channels. + +Example: + zynqmp-display-subsystem@fd4a { + compatible = "xlnx,zynqmp-dpsub-1.7"; + reg = <0x0 0xfd4a 0x0 0x1000>, + <0x0 0xfd4aa000 0x0 0x1000>, + <0x0 0xfd4ab000 0x0 0x1000>, + <0x0 0xfd4ac000 0x0 0x1000>; + reg-names = "dp", "blend", "av_buf", "aud"; + interrupts = <0 119 4>; + interrupt-parent = <>; + + clock-names = "dp_apb_clk", "dp_aud_clk", "dp_live_video_in_clk"; + clocks = <_aclk>, < 17>, <_1>; + + phys = <>, <>; + phy-names = "dp-phy0", "dp-phy1"; + + power-domains = <_dp>; + + dma-names = "vid0", "vid1", "vid2", "gfx0"; + dmas = <_dpdma 0>, + <_dpdma 1>, + <_dpdma 2>, + <_dpdma 3>; + }; +}; + +[UG1085] https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v7 0/5] Xilinx ZynqMP DisplayPort KMS driver
Hi Laurent, On top of addressing your comments in v6, I've incorporated some relatively small fixes in v7. I'm mainly waiting for your feedback before committing this series, unless there's any additional review comments. Please take a look. Thanks, -hyun Hyun Kwon (5): drm: xlnx: Xilinx DRM KMS module dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings drm: xlnx: DRM KMS driver for Xilinx ZynqMP DP subsystem display drm: xlnx: DRM KMS driver for Xilinx ZynqMP DisplayPort drm: xlnx: ZynqMP DP subsystem DRM KMS driver .../bindings/display/xlnx/xlnx,zynqmp-dpsub.txt| 77 + MAINTAINERS|9 + drivers/gpu/drm/Kconfig|2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/xlnx/Kconfig | 23 + drivers/gpu/drm/xlnx/Makefile |5 + drivers/gpu/drm/xlnx/xlnx_crtc.c | 142 + drivers/gpu/drm/xlnx/xlnx_crtc.h | 83 + drivers/gpu/drm/xlnx/xlnx_drv.c| 433 +++ drivers/gpu/drm/xlnx/xlnx_drv.h| 23 + drivers/gpu/drm/xlnx/xlnx_fb.c | 249 ++ drivers/gpu/drm/xlnx/xlnx_fb.h | 27 + drivers/gpu/drm/xlnx/xlnx_gem.c| 36 + drivers/gpu/drm/xlnx/xlnx_gem.h| 21 + drivers/gpu/drm/xlnx/zynqmp_disp.c | 2755 drivers/gpu/drm/xlnx/zynqmp_disp.h | 29 + drivers/gpu/drm/xlnx/zynqmp_dp.c | 1733 drivers/gpu/drm/xlnx/zynqmp_dp.h | 30 + drivers/gpu/drm/xlnx/zynqmp_dpsub.c| 152 ++ drivers/gpu/drm/xlnx/zynqmp_dpsub.h| 23 + 20 files changed, 5853 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.txt create mode 100644 drivers/gpu/drm/xlnx/Kconfig create mode 100644 drivers/gpu/drm/xlnx/Makefile create mode 100644 drivers/gpu/drm/xlnx/xlnx_crtc.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_crtc.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_drv.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_drv.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_fb.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_fb.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_gem.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_gem.h create mode 100644 drivers/gpu/drm/xlnx/zynqmp_disp.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_disp.h create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.h create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dpsub.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dpsub.h -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v7 4/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DisplayPort
This driver creates DRM encoder and connector for ZynqMP DisplayPort. Signed-off-by: Hyun KwonAcked-by: Daniel Vetter --- v7 - Use correct number of lanes v6 - Constify all function pointers - Clean up the duplicated license paragraphs - Do complete forward declaration in the header v2 - Change the SPDX identifier format - Split drm properties into a separate patch --- --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 1733 ++ drivers/gpu/drm/xlnx/zynqmp_dp.h | 30 + 2 files changed, 1763 insertions(+) create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dp.h diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c new file mode 100644 index 000..8378fe2 --- /dev/null +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -0,0 +1,1733 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * ZynqMP DisplayPort Driver + * + * Copyright (C) 2017 - 2018 Xilinx, Inc. + * + * Author: Hyun Woo Kwon + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "zynqmp_disp.h" +#include "zynqmp_dpsub.h" + +static uint zynqmp_dp_aux_timeout_ms = 50; +module_param_named(aux_timeout_ms, zynqmp_dp_aux_timeout_ms, uint, 0444); +MODULE_PARM_DESC(aux_timeout_ms, "DP aux timeout value in msec (default: 50)"); + +/* + * Some sink requires a delay after power on request + */ +static uint zynqmp_dp_power_on_delay_ms = 4; +module_param_named(power_on_delay_ms, zynqmp_dp_power_on_delay_ms, uint, 0444); +MODULE_PARM_DESC(aux_timeout_ms, "DP power on delay in msec (default: 4)"); + +/* Link configuration registers */ +#define ZYNQMP_DP_TX_LINK_BW_SET 0x0 +#define ZYNQMP_DP_TX_LANE_CNT_SET 0x4 +#define ZYNQMP_DP_TX_ENHANCED_FRAME_EN 0x8 +#define ZYNQMP_DP_TX_TRAINING_PATTERN_SET 0xc +#define ZYNQMP_DP_TX_SCRAMBLING_DISABLE0x14 +#define ZYNQMP_DP_TX_DOWNSPREAD_CTL0x18 +#define ZYNQMP_DP_TX_SW_RESET 0x1c +#define ZYNQMP_DP_TX_SW_RESET_STREAM1 BIT(0) +#define ZYNQMP_DP_TX_SW_RESET_STREAM2 BIT(1) +#define ZYNQMP_DP_TX_SW_RESET_STREAM3 BIT(2) +#define ZYNQMP_DP_TX_SW_RESET_STREAM4 BIT(3) +#define ZYNQMP_DP_TX_SW_RESET_AUX BIT(7) +#define ZYNQMP_DP_TX_SW_RESET_ALL (ZYNQMP_DP_TX_SW_RESET_STREAM1 | \ + ZYNQMP_DP_TX_SW_RESET_STREAM2 | \ + ZYNQMP_DP_TX_SW_RESET_STREAM3 | \ + ZYNQMP_DP_TX_SW_RESET_STREAM4 | \ + ZYNQMP_DP_TX_SW_RESET_AUX) + +/* Core enable registers */ +#define ZYNQMP_DP_TX_ENABLE0x80 +#define ZYNQMP_DP_TX_ENABLE_MAIN_STREAM0x84 +#define ZYNQMP_DP_TX_FORCE_SCRAMBLER_RESET 0xc0 +#define ZYNQMP_DP_TX_VERSION 0xf8 +#define ZYNQMP_DP_TX_VERSION_MAJOR_MASKGENMASK(31, 24) +#define ZYNQMP_DP_TX_VERSION_MAJOR_SHIFT 24 +#define ZYNQMP_DP_TX_VERSION_MINOR_MASKGENMASK(23, 16) +#define ZYNQMP_DP_TX_VERSION_MINOR_SHIFT 16 +#define ZYNQMP_DP_TX_VERSION_REVISION_MASK GENMASK(15, 12) +#define ZYNQMP_DP_TX_VERSION_REVISION_SHIFT12 +#define ZYNQMP_DP_TX_VERSION_PATCH_MASKGENMASK(11, 8) +#define ZYNQMP_DP_TX_VERSION_PATCH_SHIFT 8 +#define ZYNQMP_DP_TX_VERSION_INTERNAL_MASK GENMASK(7, 0) +#define ZYNQMP_DP_TX_VERSION_INTERNAL_SHIFT0 + +/* Core ID registers */ +#define ZYNQMP_DP_TX_CORE_ID 0xfc +#define ZYNQMP_DP_TX_CORE_ID_MAJOR_MASKGENMASK(31, 24) +#define ZYNQMP_DP_TX_CORE_ID_MAJOR_SHIFT 24 +#define ZYNQMP_DP_TX_CORE_ID_MINOR_MASKGENMASK(23, 16) +#define ZYNQMP_DP_TX_CORE_ID_MINOR_SHIFT 16 +#define ZYNQMP_DP_TX_CORE_ID_REVISION_MASK GENMASK(15, 8) +#define ZYNQMP_DP_TX_CORE_ID_REVISION_SHIFT8 +#define ZYNQMP_DP_TX_CORE_ID_DIRECTION GENMASK(1) + +/* AUX channel interface registers */ +#define ZYNQMP_DP_TX_AUX_COMMAND 0x100 +#define ZYNQMP_DP_TX_AUX_COMMAND_CMD_SHIFT 8 +#define ZYNQMP_DP_TX_AUX_COMMAND_ADDRESS_ONLY BIT(12) +#define ZYNQMP_DP_TX_AUX_COMMAND_BYTES_SHIFT 0 +#define ZYNQMP_DP_TX_AUX_WRITE_FIFO0x104 +#define ZYNQMP_DP_TX_AUX_ADDRESS 0x108 +#define ZYNQMP_DP_TX_CLK_DIVIDER 0x10c +#define
[PATCH v7 1/5] drm: xlnx: Xilinx DRM KMS module
Xilinx has various platforms for display, where users can create using multiple IPs in the programmable FPGA fabric, or where some hardened pipeline is available on the chip. Furthermore, hardened pipeline can also interact with soft logics in FPGA. The Xilinx DRM KMS module is to integrate multiple subdevices and to represent the entire pipeline as a single DRM device. The module includes helper (ex, framebuffer and gem helpers) and glue logic (ex, crtc interface) functions. Signed-off-by: Hyun KwonAcked-by: Daniel Vetter --- v7 - Unbind as component in shutdown - Register release callback for master device v6 - Fix the function desc for pipeline calls - Rebase on drm-misc-next - Fix typos in documentation - Match types for return and internal variables - Remove use of 'tmp' variables - Protect any crtc list iteration with mutex - Remove a check for drm device in crtc unregistration - Split the crtc ops as a separate struct to constify - Embed xlnx_crtc_helper into xlnx_drm - Move to_xlnx_crtc macro close to xlnx_crtc - Remove unneeded include - Replace custom vres module param with CONFIG_DRM_FBDEV_OVERALLOC - Rename crtc to crtc_helper to make it clearer - Use 'DRM device' instead of 'DRM core' - Remove unused function, xlnx_get_format() - Use device instead of platform device for the logical master - Inline xlnx_of_component_probe() - Use of_get_parent() - Remove the port binding handling in the driver - Do complete forward-declarations in headers - Constify all function pointers - Use the default ioctl from fb helper - Return the minimum pitch always - Clean up the duplicate license paragraphs - Get common bits for dma mask instead of minimum value - Remove dummy function declaration from header - Fix a typo in the commit message with some re-organization v5 - Redefine xlnx_pipeline_init() v4 - Fix a bug in of graph binding handling - Remove vblank callbacks from xlnx_crtc - Remove the dt binding. This module becomes more like a library. - Rephrase the commit message v3 - Add Laurent as a maintainer - Fix multiple-reference on gem objects v2 - Change the SPDX identifier format - Merge patches(crtc, gem, fb) into single one v2 of xlnx_drv - Rename kms to display in xlnx_drv - Replace some xlnx specific fb helper with common helpers in xlnx_drv - Don't set the commit tail callback in xlnx_drv - Support 'ports' graph binding in xlnx_drv v2 of xlnx_fb - Remove wrappers in xlnx_fb - Replace some functions with drm core helpers in xlnx_fb --- --- MAINTAINERS | 9 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/xlnx/Kconfig | 12 ++ drivers/gpu/drm/xlnx/Makefile| 2 + drivers/gpu/drm/xlnx/xlnx_crtc.c | 142 + drivers/gpu/drm/xlnx/xlnx_crtc.h | 83 drivers/gpu/drm/xlnx/xlnx_drv.c | 433 +++ drivers/gpu/drm/xlnx/xlnx_drv.h | 23 +++ drivers/gpu/drm/xlnx/xlnx_fb.c | 249 ++ drivers/gpu/drm/xlnx/xlnx_fb.h | 27 +++ drivers/gpu/drm/xlnx/xlnx_gem.c | 36 drivers/gpu/drm/xlnx/xlnx_gem.h | 21 ++ 13 files changed, 1040 insertions(+) create mode 100644 drivers/gpu/drm/xlnx/Kconfig create mode 100644 drivers/gpu/drm/xlnx/Makefile create mode 100644 drivers/gpu/drm/xlnx/xlnx_crtc.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_crtc.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_drv.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_drv.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_fb.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_fb.h create mode 100644 drivers/gpu/drm/xlnx/xlnx_gem.c create mode 100644 drivers/gpu/drm/xlnx/xlnx_gem.h diff --git a/MAINTAINERS b/MAINTAINERS index 4af7f61..3bd61bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4815,6 +4815,15 @@ F: drivers/gpu/drm/etnaviv/ F: include/uapi/drm/etnaviv_drm.h F: Documentation/devicetree/bindings/display/etnaviv/ +DRM DRIVERS FOR XILINX +M: Hyun Kwon +M: Laurent Pinchart +L: dri-devel@lists.freedesktop.org +S: Maintained +F: drivers/gpu/drm/xlnx/ +F: Documentation/devicetree/bindings/display/xlnx/ +T: git git://anongit.freedesktop.org/drm/drm-misc + DRM DRIVERS FOR ZTE ZX M: Shawn Guo L: dri-devel@lists.freedesktop.org diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 757825a..badd34c 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -291,6 +291,8 @@ source "drivers/gpu/drm/tve200/Kconfig" source "drivers/gpu/drm/xen/Kconfig" +source "drivers/gpu/drm/xlnx/Kconfig" + # Keep legacy drivers last menuconfig DRM_LEGACY diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 9d66657..c05922f 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -104,3 +104,4 @@ obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
[PATCH v7 3/5] drm: xlnx: DRM KMS driver for Xilinx ZynqMP DP subsystem display
Xilinx ZynqMP has a hardened display pipeline. The pipeline can be logically partitioned into 2 parts: display controller and DisplayPort encoder / transmitter. This driver handles the display controller part of the pipeline that handles buffer management and blending. Signed-off-by: Hyun KwonAcked-by: Daniel Vetter --- v7 - Disable a plane when the fb format changes - Update planes asynchronously in the legacy set plane entry v6 - Use the new crtc op struct - Clean up the duplicated license paragraphs - Declare function pointer structures as static const - Do complete forward declaration in headers v4 - Use drm_crtc_funcs for vblank - Remove child nodes for layer v3 - Fix a small typo v2 - Use drm_fb_cma_get_gem_addr() - Use drm_crtc_arm_vblank_event() - Split drm properties into a separate patch - Remove dummy funcs - Don't add offset as it's already done by a new helper - Change the SPDX identifier format - Minor change of a commit message --- --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 2755 drivers/gpu/drm/xlnx/zynqmp_disp.h | 29 + 2 files changed, 2784 insertions(+) create mode 100644 drivers/gpu/drm/xlnx/zynqmp_disp.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_disp.h diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c new file mode 100644 index 000..9592df1 --- /dev/null +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -0,0 +1,2755 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * ZynqMP Display Controller Driver + * + * Copyright (C) 2017 - 2018 Xilinx, Inc. + * + * Author: Hyun Woo Kwon + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "xlnx_crtc.h" +#include "xlnx_fb.h" +#include "zynqmp_disp.h" +#include "zynqmp_dp.h" +#include "zynqmp_dpsub.h" + +/* + * Overview + * + * + * The display part of ZynqMP DP subsystem. Internally, the device + * is partitioned into 3 blocks: AV buffer manager, Blender, Audio. + * The driver creates the DRM crtc and plane objectes and maps the DRM + * interface into those 3 blocks. In high level, the driver is layered + * in the following way: + * + * zynqmp_disp_crtc & zynqmp_disp_plane + * |->zynqmp_disp + * |->zynqmp_disp_aud + * |->zynqmp_disp_blend + * |->zynqmp_disp_av_buf + * + * The driver APIs are used externally by + * - zynqmp_dpsub: Top level ZynqMP DP subsystem driver + * - zynqmp_dp: ZynqMP DP driver + * - xlnx_crtc: Xilinx DRM specific crtc functions + */ + +/* Blender registers */ +#define ZYNQMP_DISP_V_BLEND_BG_CLR_0 0x0 +#define ZYNQMP_DISP_V_BLEND_BG_CLR_1 0x4 +#define ZYNQMP_DISP_V_BLEND_BG_CLR_2 0x8 +#define ZYNQMP_DISP_V_BLEND_BG_MAX 0xfff +#define ZYNQMP_DISP_V_BLEND_SET_GLOBAL_ALPHA 0xc +#define ZYNQMP_DISP_V_BLEND_SET_GLOBAL_ALPHA_MASK 0x1fe +#define ZYNQMP_DISP_V_BLEND_SET_GLOBAL_ALPHA_MAX 0xff +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT 0x14 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT_RGB 0x0 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT_YCBCR4440x1 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT_YCBCR4220x2 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT_YONLY 0x3 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_VID_FMT_XVYCC 0x4 +#define ZYNQMP_DISP_V_BLEND_OUTPUT_EN_DOWNSAMPLE BIT(4) +#define ZYNQMP_DISP_V_BLEND_LAYER_CONTROL 0x18 +#define ZYNQMP_DISP_V_BLEND_LAYER_CONTROL_EN_USBIT(0) +#define ZYNQMP_DISP_V_BLEND_LAYER_CONTROL_RGB BIT(1) +#define ZYNQMP_DISP_V_BLEND_LAYER_CONTROL_BYPASS BIT(8) +#define ZYNQMP_DISP_V_BLEND_NUM_COEFF 9 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF0 0x20 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF1 0x24 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF2 0x28 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF3 0x2c +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF4 0x30 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF5 0x34 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF6 0x38 +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF7 0x3c +#define ZYNQMP_DISP_V_BLEND_RGB2YCBCR_COEFF8 0x40 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF0 0x44 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF1 0x48 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF2 0x4c +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF3 0x50 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF4 0x54 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF5 0x58 +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF6 0x5c +#define ZYNQMP_DISP_V_BLEND_IN1CSC_COEFF7 0x60 +#define
[PATCH v7 5/5] drm: xlnx: ZynqMP DP subsystem DRM KMS driver
This is a wrapper around the ZynqMP Display and DisplayPort drivers. Signed-off-by: Hyun KwonAcked-by: Daniel Vetter --- v6 - Accomodate the migration of logical master from platform device to device - Remove the duplicate license paragraphs - Do complete forward declaration in the header v5 - Add an error handling of pipeline initialization v4 - Use the newly added xlnx pipeline calls to initialize drm device v2 - Change the SPDX identifier format --- --- drivers/gpu/drm/xlnx/Kconfig| 11 +++ drivers/gpu/drm/xlnx/Makefile | 3 + drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 152 drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 23 ++ 4 files changed, 189 insertions(+) create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dpsub.c create mode 100644 drivers/gpu/drm/xlnx/zynqmp_dpsub.h diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig index 19fd7cd..7c5529c 100644 --- a/drivers/gpu/drm/xlnx/Kconfig +++ b/drivers/gpu/drm/xlnx/Kconfig @@ -10,3 +10,14 @@ config DRM_XLNX display pipeline using Xilinx IPs in FPGA. This module provides the kernel mode setting functionalities for Xilinx display drivers. + +config DRM_ZYNQMP_DPSUB + tristate "ZynqMP DP Subsystem Driver" + depends on ARCH_ZYNQMP && OF && DRM_XLNX && COMMON_CLK + select DMA_ENGINE + select GENERIC_PHY + help + DRM KMS driver for ZynqMP DP Subsystem controller. Choose + this option if you have a Xilinx ZynqMP SoC with DisplayPort + subsystem. The driver provides the kernel mode setting + functionlaities for ZynqMP DP subsystem. diff --git a/drivers/gpu/drm/xlnx/Makefile b/drivers/gpu/drm/xlnx/Makefile index c60a281..064a05a 100644 --- a/drivers/gpu/drm/xlnx/Makefile +++ b/drivers/gpu/drm/xlnx/Makefile @@ -1,2 +1,5 @@ xlnx_drm-objs += xlnx_crtc.o xlnx_drv.o xlnx_fb.o xlnx_gem.o obj-$(CONFIG_DRM_XLNX) += xlnx_drm.o + +zynqmp-dpsub-objs += zynqmp_disp.o zynqmp_dpsub.o zynqmp_dp.o +obj-$(CONFIG_DRM_ZYNQMP_DPSUB) += zynqmp-dpsub.o diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c new file mode 100644 index 000..7c6981b --- /dev/null +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c @@ -0,0 +1,152 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * ZynqMP DP Subsystem Driver + * + * Copyright (C) 2017 - 2018 Xilinx, Inc. + * + * Author: Hyun Woo Kwon + */ + +#include +#include +#include +#include +#include + +#include "xlnx_drv.h" + +#include "zynqmp_disp.h" +#include "zynqmp_dp.h" +#include "zynqmp_dpsub.h" + +static int +zynqmp_dpsub_bind(struct device *dev, struct device *master, void *data) +{ + int ret; + + ret = zynqmp_disp_bind(dev, master, data); + if (ret) + return ret; + + /* zynqmp_disp should bind first, so zynqmp_dp encoder can find crtc */ + ret = zynqmp_dp_bind(dev, master, data); + if (ret) + return ret; + + return 0; +} + +static void +zynqmp_dpsub_unbind(struct device *dev, struct device *master, void *data) +{ + zynqmp_dp_unbind(dev, master, data); + zynqmp_disp_unbind(dev, master, data); +} + +static const struct component_ops zynqmp_dpsub_component_ops = { + .bind = zynqmp_dpsub_bind, + .unbind = zynqmp_dpsub_unbind, +}; + +static int zynqmp_dpsub_probe(struct platform_device *pdev) +{ + struct zynqmp_dpsub *dpsub; + int ret; + + dpsub = devm_kzalloc(>dev, sizeof(*dpsub), GFP_KERNEL); + if (!dpsub) + return -ENOMEM; + + /* Sub-driver will access dpsub from drvdata */ + platform_set_drvdata(pdev, dpsub); + pm_runtime_enable(>dev); + + /* +* DP should be probed first so that the zynqmp_disp can set the output +* format accordingly. +*/ + ret = zynqmp_dp_probe(pdev); + if (ret) + goto err_pm; + + ret = zynqmp_disp_probe(pdev); + if (ret) + goto err_dp; + + ret = component_add(>dev, _dpsub_component_ops); + if (ret) + goto err_disp; + + /* Populate the sound child nodes */ + ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, >dev); + if (ret) { + dev_err(>dev, "failed to populate child nodes\n"); + goto err_component; + } + + dpsub->master = xlnx_drm_pipeline_init(>dev); + if (IS_ERR(dpsub->master)) { + dev_err(>dev, "failed to initialize the drm pipeline\n"); + goto err_populate; + } + + dev_info(>dev, "ZynqMP DisplayPort Subsystem driver probed"); + + return 0; + +err_populate: + of_platform_depopulate(>dev); +err_component: + component_del(>dev, _dpsub_component_ops); +err_disp: + zynqmp_disp_remove(pdev); +err_dp: + zynqmp_dp_remove(pdev); +err_pm: + pm_runtime_disable(>dev); +
[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #64 from H4nN1baL--- I've been having a very different problem with AMD cards. But I have reason to think that the problem could vary from one processor/chipset to another. My problems disappear using 'MESA_EXTENSION_OVERRIDE=-GL_ARB_buffer_storage', can you try that? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH libdrm] intel: add support for ICL 11
Em Qua, 2018-04-25 às 17:29 -0700, Michel Thierry escreveu: > On 04/25/2018 05:09 PM, Paulo Zanoni wrote: > > Add the PCI IDs and the basic code to enable ICL. This is the > > current > > PCI ID list in our documentation. > > > > Kernel commit: d55cb4fa2cf0 ("drm/i915/icl: Add the ICL PCI IDs") > > > > v2: Michel provided a fix to IS_9XX that was broken by rebase bot. > > v3: Fix double definition of PCI IDs, update IDs according to bspec > > and keep them in the same order and rebase (Lucas) > > > > Cc: Michel Thierry> > Signed-off-by: Paulo Zanoni > > Signed-off-by: Rodrigo Vivi > > Signed-off-by: Lucas De Marchi > > --- > > intel/intel_bufmgr_gem.c | 2 ++ > > intel/intel_chipset.h| 27 ++- > > intel/intel_decode.c | 4 +++- > > 3 files changed, 31 insertions(+), 2 deletions(-) > > > > diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > > index 5c47a46f..8c3a4b20 100644 > > --- a/intel/intel_bufmgr_gem.c > > +++ b/intel/intel_bufmgr_gem.c > > @@ -3660,6 +3660,8 @@ drm_intel_bufmgr_gem_init(int fd, int > > batch_size) > > bufmgr_gem->gen = 9; > > else if (IS_GEN10(bufmgr_gem->pci_device)) > > bufmgr_gem->gen = 10; > > + else if (IS_GEN11(bufmgr_gem->pci_device)) > > + bufmgr_gem->gen = 11; > > else { > > free(bufmgr_gem); > > bufmgr_gem = NULL; > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > > index ba2e3ac1..32b2c48f 100644 > > --- a/intel/intel_chipset.h > > +++ b/intel/intel_chipset.h > > @@ -257,6 +257,16 @@ > > #define PCI_CHIP_CANNONLAKE_120x5A44 > > #define PCI_CHIP_CANNONLAKE_130x5A4C > > > > +#define PCI_CHIP_ICELAKE_11_0 0x8A50 > > +#define PCI_CHIP_ICELAKE_11_1 0x8A51 > > +#define PCI_CHIP_ICELAKE_11_2 0x8A5C > > +#define PCI_CHIP_ICELAKE_11_3 0x8A5D > > +#define PCI_CHIP_ICELAKE_11_4 0x8A52 > > +#define PCI_CHIP_ICELAKE_11_5 0x8A5A > > +#define PCI_CHIP_ICELAKE_11_6 0x8A5B > > +#define PCI_CHIP_ICELAKE_11_7 0x8A71 > > +#define PCI_CHIP_ICELAKE_11_8 0x8A70 > > + > > matches what we have in the kernel's i915_pciids.h > > > #define IS_MOBILE(devid) ((devid) == PCI_CHIP_I855_GM || \ > > (devid) == PCI_CHIP_I915_GM || \ > > (devid) == PCI_CHIP_I945_GM || \ > > @@ -538,6 +548,20 @@ > > > > #define IS_GEN10(devid) (IS_CANNONLAKE(devid)) > > > > +#define IS_ICELAKE_11(devid) ((devid) == > > PCI_CHIP_ICELAKE_11_0 || \ > > +(devid) == PCI_CHIP_ICELAKE_11_1 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_2 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_3 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_4 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_5 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_6 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_7 > > || \ > > +(devid) == PCI_CHIP_ICELAKE_11_8) > > + > > +#define IS_ICELAKE(devid) (IS_ICELAKE_11(devid)) > > + > > +#define IS_GEN11(devid)(IS_ICELAKE_11(devid)) > > + > > #define IS_9XX(dev) (IS_GEN3(dev) || \ > > IS_GEN4(dev) || \ > > IS_GEN5(dev) || \ > > @@ -545,6 +569,7 @@ > > IS_GEN7(dev) || \ > > IS_GEN8(dev) || \ > > IS_GEN9(dev) || \ > > -IS_GEN10(dev)) > > +IS_GEN10(dev) || \ > > +IS_GEN11(dev)) > > > > #endif /* _INTEL_CHIPSET_H */ > > diff --git a/intel/intel_decode.c b/intel/intel_decode.c > > index bc7b04b8..b24861b1 100644 > > --- a/intel/intel_decode.c > > +++ b/intel/intel_decode.c > > @@ -3823,7 +3823,9 @@ drm_intel_decode_context_alloc(uint32_t > > devid) > > ctx->devid = devid; > > ctx->out = stdout; > > > > - if (IS_GEN10(devid)) > > + if (IS_GEN11(devid)) > > + ctx->gen = 11; > > + else if (IS_GEN10(devid)) > > ctx->gen = 10; > > else if (IS_GEN9(devid)) > > ctx->gen = 9; > > > > Reviewed-by: Michel Thierry Patch merged. Thanks everybody involved. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #63 from MirceaKitsune--- (In reply to iive from comment #62) I booted my machine with the kernel parameter panic=30 as instructed. I then waited for over two minutes to see if there's any sign of movement. Nothing happened: The machine never reboots on its own after the freeze, I still need to press the reset button on the computer case to restart it. I also noticed another detail worth noting: The keyboard NumLock led only seems to turn off after I press a key on the keyboard post freeze. So let's say the machine just crashed: I can wait a whole minute and the led is still on... then I press Control or Shift or any other key, and after roughly 3 seconds, the led then turns off. This is always the last noticeable response from the PC. Lastly I have something important to mention: Someone just replied to my thread about this crash on the openSUSE forum, and confirmed they're getting the same issue! They even posted a screenshot showing the exact same graphical garbage I'm noticing in various applications (colorful little squares littering the screen). This might be the first time someone else can confirm the problem, which is very exciting news if the person will provide us with more info. https://forums.opensuse.org/showthread.php/525727-3D-engines-causing-frequent-GPU-lockups?p=2864284#post2864284 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 85791] nouveau: errors on boot, can't use discrete gpu
https://bugzilla.kernel.org/show_bug.cgi?id=85791 --- Comment #6 from Bruno Pagani (bruno.n.pag...@gmail.com) --- I don’t know who can change status here but this should be closed. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2] drm/rockchip: Disable blending for win0
On Wed, Apr 18, 2018 at 10:31:52AM -0700, Kristian H. Kristensen wrote: > Blending win0 with the background color doesn't seem to work > correctly. We only get the background color, no matter the contents of > the win0 framebuffer. However, blending pre-multiplied color with the > default opaque black default background color is a no-op, so we can > just disable blending to get the correct result. > > Signed-off-by: Kristian H. KristensenPushed to -misc-next Thank you for your patch! Sean > Cc: Sandy Huang > Cc: Sean Paul > --- > > v2: Drop CHROMIUM: prefix, rebase on Linus' master > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 53d4afe15278..753a7548da84 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -76,6 +76,9 @@ > #define VOP_WIN_GET_YRGBADDR(vop, win) \ > vop_readl(vop, win->base + win->phy->yrgb_mst.offset) > > +#define VOP_WIN_TO_INDEX(vop_win) \ > + ((vop_win) - (vop_win)->vop->win) > + > #define to_vop(x) container_of(x, struct vop, crtc) > #define to_vop_win(x) container_of(x, struct vop_win, base) > > @@ -708,6 +711,7 @@ static void vop_plane_atomic_update(struct drm_plane > *plane, > dma_addr_t dma_addr; > uint32_t val; > bool rb_swap; > + int win_index = VOP_WIN_TO_INDEX(vop_win); > int format; > > /* > @@ -777,7 +781,14 @@ static void vop_plane_atomic_update(struct drm_plane > *plane, > rb_swap = has_rb_swapped(fb->format->format); > VOP_WIN_SET(vop, win, rb_swap, rb_swap); > > - if (fb->format->has_alpha) { > + /* > + * Blending win0 with the background color doesn't seem to work > + * correctly. We only get the background color, no matter the contents > + * of the win0 framebuffer. However, blending pre-multiplied color > + * with the default opaque black default background color is a no-op, > + * so we can just disable blending to get the correct result. > + */ > + if (fb->format->has_alpha && win_index > 0) { > VOP_WIN_SET(vop, win, dst_alpha_ctl, > DST_FACTOR_M0(ALPHA_SRC_INVERSE)); > val = SRC_ALPHA_EN(1) | SRC_COLOR_M0(ALPHA_SRC_PRE_MUL) | > -- > 2.17.0.484.g0c8726318c-goog > -- Sean Paul, Software Engineer, Google / Chromium OS ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]
https://bugs.freedesktop.org/show_bug.cgi?id=102646 Justin Mitzelchanged: What|Removed |Added Summary|[dc] Screen flickering |Screen flickering under |under amdgpu-experimental |amdgpu-experimental [buggy |[buggy auto power profile] |auto power profile] -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v3] drm/i915: Disable some extra clang warnings
Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full") enabled extra warnings for i915 to spot possible bugs in new code, and then disabled a subset of these warnings to keep the current code building without warnings (with gcc). Enabling the extra warnings also enabled some additional clang-only warnings, as a result building i915 with clang currently is extremely noisy. For now also disable the clang warnings sign-compare, sometimes-uninitialized, unneeded-internal-declaration and initializer-overrides. If desired they can be re-enabled after the code has been fixed. Signed-off-by: Matthias Kaehlcke--- Changes in v3: - don't disable -Wunneeded-internal-declaration , the only occurrence can be fixed in the code - removed 'Fixes' tag, since backporting is not necessary drivers/gpu/drm/i915/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 9bee52a949a9..dfe01452c8d1 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -18,6 +18,10 @@ subdir-ccflags-y += $(call cc-disable-warning, type-limits) subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable) +# clang warnings +subdir-ccflags-y += $(call cc-disable-warning, sign-compare) +subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized) +subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides) subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror # Fine grained warnings disable -- 2.17.0.441.gb46fe60e1d-goog ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] v3d: fixup for submit alignment and check for zero flags in other ioctls.
Signed-off-by: Eric Anholt--- airlied + danvet: this is the last change I think we need before I can merge v3d with your acks. Sending as a diff so you don't have to look at the whole thing again. Look good? drivers/gpu/drm/v3d/v3d_bo.c | 10 ++ drivers/gpu/drm/v3d/v3d_gem.c | 5 + include/uapi/drm/v3d_drm.h| 3 +++ 3 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c index 2be4e8b71604..7b1e2a549a71 100644 --- a/drivers/gpu/drm/v3d/v3d_bo.c +++ b/drivers/gpu/drm/v3d/v3d_bo.c @@ -325,6 +325,11 @@ int v3d_create_bo_ioctl(struct drm_device *dev, void *data, struct v3d_bo *bo = NULL; int ret; + if (args->flags != 0) { + DRM_INFO("unknown create_bo flags: %d\n", args->flags); + return -EINVAL; + } + bo = v3d_bo_create(dev, file_priv, PAGE_ALIGN(args->size)); if (IS_ERR(bo)) return PTR_ERR(bo); @@ -344,6 +349,11 @@ int v3d_mmap_bo_ioctl(struct drm_device *dev, void *data, struct drm_gem_object *gem_obj; int ret; + if (args->flags != 0) { + DRM_INFO("unknown mmap_bo flags: %d\n", args->flags); + return -EINVAL; + } + gem_obj = drm_gem_object_lookup(file_priv, args->handle); if (!gem_obj) { DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle); diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index fa39a1e35263..b513f9189caf 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -503,6 +503,11 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data, struct drm_syncobj *sync_out; int ret = 0; + if (args->pad != 0) { + DRM_INFO("pad must be zero: %d\n", args->pad); + return -EINVAL; + } + exec = kcalloc(1, sizeof(*exec), GFP_KERNEL); if (!exec) return -ENOMEM; diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h index 201a07645bdd..7b6627783608 100644 --- a/include/uapi/drm/v3d_drm.h +++ b/include/uapi/drm/v3d_drm.h @@ -101,6 +101,9 @@ struct drm_v3d_submit_cl { /* Number of BO handles passed in (size is that times 4). */ __u32 bo_handle_count; + + /* Pad, must be zero-filled. */ + __u32 pad; }; /** -- 2.17.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106245] Raven ridge (2400g) fails to start (swiotlb buffer is full) with IOMMU disabled
https://bugs.freedesktop.org/show_bug.cgi?id=106245 --- Comment #1 from Michel Dänzer--- Does it work if you disable SME? amdgpu doesn't actually work yet with SME enabled anyway. It's odd that SWIOTLB fails allocating 256KB this early, but it might be due to SME creating pressure on SWIOTLB. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/21] bindings: display: Add compatible for A64 DE2 pipeline
On Tue, May 1, 2018 at 11:31 AM, Chen-Yu Tsaiwrote: > On Wed, May 2, 2018 at 12:17 AM, Rob Herring wrote: >> On Mon, Apr 30, 2018 at 05:10:41PM +0530, Jagan Teki wrote: >>> Allwinner A64 has DE2 pipeline similar to other Allwinner >>> SOC's like A83T, H3/H5. >> >> 'dt-bindings: ' for the subject prefix. >> >>> >>> Signed-off-by: Jagan Teki >>> --- >>> Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + >>> 1 file changed, 1 insertion(+) >> >> Otherwise, >> >> Reviewed-by: Rob Herring > > Would it make sense to put all the display component related compatible > string additions in the same patch? i.e. "Add compatible strings for all > documented display component blocks". MIPI-DSI is missing, but it's not > documented. That's fine by me. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU
On Tue, May 1, 2018 at 11:19 AM, Chen-Yu Tsaiwrote: > On Wed, May 2, 2018 at 12:16 AM, Rob Herring wrote: >> On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: >>> Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. >>> >>> Signed-off-by: Jagan Teki >>> --- >>> Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + >>> 1 file changed, 1 insertion(+) >> >> Reviewed-by: Rob Herring > > Hi Rob, > > Do we need to add this if it's just a soc-specific compatible > we add in the device tree to future proof things in case we > discover quirks later on? Yes, but the fallbacks should be documented too as I found in the rest of the series. > AFAIK we haven't been doing this, and this is likely to create > some confusion, because they aren't actually mentioned anywhere > in the driver. The binding doc needs to written such that compatible can be validated to contain the correct set of strings. We can't do that now with free form text, but when we move to a schema we will. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/21] bindings: display: Add compatible for A64 DE2 pipeline
On Wed, May 2, 2018 at 12:17 AM, Rob Herringwrote: > On Mon, Apr 30, 2018 at 05:10:41PM +0530, Jagan Teki wrote: >> Allwinner A64 has DE2 pipeline similar to other Allwinner >> SOC's like A83T, H3/H5. > > 'dt-bindings: ' for the subject prefix. > >> >> Signed-off-by: Jagan Teki >> --- >> Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + >> 1 file changed, 1 insertion(+) > > Otherwise, > > Reviewed-by: Rob Herring Would it make sense to put all the display component related compatible string additions in the same patch? i.e. "Add compatible strings for all documented display component blocks". MIPI-DSI is missing, but it's not documented. ChenYu ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105339] Deadlock inside glClientWaitSync [Regresion bc65dcab3bc48673ff6180afb036561a4b8b1119]
https://bugs.freedesktop.org/show_bug.cgi?id=105339 Gregor Münchchanged: What|Removed |Added CC||nhaeh...@gmail.com --- Comment #7 from Gregor Münch --- added author of regression -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs
On Mon, Apr 30, 2018 at 7:40 PM, Jagan Tekiwrote: > Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them > as default. > > Signed-off-by: Jagan Teki > --- > drivers/clk/sunxi-ng/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 79dfd296c3d1..1fffd3bf6ff3 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU > > config SUN8I_DE2_CCU > bool "Support for the Allwinner SoCs DE2 CCU" > + default ARM64 && ARCH_SUNXI > + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST There is no reason to depend on DRM_SUN4I. There is no compile dependency. Also, this is needed on SUN8I as well, pretty much anything with DE 2.0. So you shouldn't limit it to ARM64. That pretty much breaks things for people with A83T's or H3's. In fact you should enable it by default for these as well. ChenYu > > config SUN8I_R40_CCU > bool "Support for the Allwinner R40 CCU" > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 12/21] bindings: display: Add compatible for A64 tcon-tv
On Mon, Apr 30, 2018 at 05:10:49PM +0530, Jagan Teki wrote: > tcon-tv on Allwinner A64 has similar behavior like Allwinner A83T. > > Signed-off-by: Jagan Teki> --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index 5d448ef2132f..8b6b4bc43d98 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -150,6 +150,7 @@ Required properties: > * allwinner,sun8i-v3s-tcon > * allwinner,sun9i-a80-tcon-lcd > * allwinner,sun9i-a80-tcon-tv > + * allwinner,sun50i-a64-tcon-tv Fallback? > - reg: base address and size of memory-mapped region > - interrupts: interrupt associated to this IP > - clocks: phandles to the clocks feeding the TCON. > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 11/21] bindings: display: Add compatible for A64 Mixer1
On Mon, Apr 30, 2018 at 05:10:48PM +0530, Jagan Teki wrote: > Mixer1 on Allwinner A64 has similar behavior like Allwinner A83T. > > Signed-off-by: Jagan Teki> --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index 7dcd1d64dfe4..5d448ef2132f 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -313,6 +313,7 @@ Required properties: > * allwinner,sun8i-a83t-de2-mixer-1 > * allwinner,sun8i-h3-de2-mixer-0 > * allwinner,sun8i-v3s-de2-mixer > +* allwinner,sun50i-a64-de2-mixer-1 Need to capture fallbacks here. >- reg: base address and size of the memory-mapped region. >- clocks: phandles to the clocks feeding the mixer > * bus: the mixer interface clock > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 10/21] drm/sun4i: Enable DesignWare HDMI for Allwinner 64-bit SoCs
On Mon, Apr 30, 2018 at 7:40 PM, Jagan Tekiwrote: > Allwinner 64-bit SoC like H5/A64 has DesignWare HDMI so > enable them as default. Should we not also enable it by default for SUN8I (A83T, H3, R40?, etc.) > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/sun4i/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig > index eee6bc0eaf97..60468a779a63 100644 > --- a/drivers/gpu/drm/sun4i/Kconfig > +++ b/drivers/gpu/drm/sun4i/Kconfig > @@ -42,6 +42,7 @@ config DRM_SUN4I_BACKEND > > config DRM_SUN8I_DW_HDMI > tristate "Support for Allwinner version of DesignWare HDMI" > + default ARM64 && ARCH_SUNXI > depends on DRM_SUN4I > select DRM_DW_HDMI > help > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 09/21] arm64: dts: allwinner: a64: Add HDMI support
On Mon, Apr 30, 2018 at 05:10:46PM +0530, Jagan Teki wrote: > HDMI on Allwinner A64 has similar behavior like H3/H5, so > reuse the same dts node details for A64. > > Signed-off-by: Jagan Teki> --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 28 > +++ > include/dt-bindings/clock/sun50i-a64-ccu.h| 2 ++ > 2 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 67b80bbe5bf5..da9128ae836d 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -644,6 +644,34 @@ > #interrupt-cells = <3>; > }; > > + hdmi: hdmi@1ee { > + compatible = "allwinner,sun50i-a64-dw-hdmi", > + "allwinner,sun8i-a83t-dw-hdmi"; > + reg = <0x01ee 0x1>; > + reg-io-width = <1>; > + interrupts = ; > + clocks = < CLK_BUS_HDMI>, < CLK_HDMI_DDC>, > + < CLK_HDMI>; > + clock-names = "iahb", "isfr", "tmds"; > + resets = < RST_BUS_HDMI1>; > + reset-names = "ctrl"; > + phys = <_phy>; > + phy-names = "hdmi-phy"; > + status = "disabled"; > + }; > + > + hdmi_phy: hdmi-phy@1ef { > + compatible = "allwinner,sun50i-a64-hdmi-phy", > + "allwinner,sun8i-h3-hdmi-phy"; > + reg = <0x01ef 0x1>; > + clocks = < CLK_BUS_HDMI>, < CLK_HDMI_DDC>, > + < CLK_PLL_VIDEO1>; > + clock-names = "bus", "mod", "pll-0"; > + resets = < RST_BUS_HDMI0>; > + reset-names = "phy"; > + #phy-cells = <0>; HDMI is disabled by default, but the phy is not? > + }; > + > rtc: rtc@1f0 { > compatible = "allwinner,sun6i-a31-rtc"; > reg = <0x01f0 0x54>; > diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h > b/include/dt-bindings/clock/sun50i-a64-ccu.h > index d66432c6e675..41c09df797ef 100644 > --- a/include/dt-bindings/clock/sun50i-a64-ccu.h > +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h > @@ -45,6 +45,8 @@ > > #define CLK_PLL_PERIPH0 11 > > +#define CLK_PLL_VIDEO1 15 > + This belongs in the clock binding patch. > #define CLK_BUS_MIPI_DSI 28 > #define CLK_BUS_CE 29 > #define CLK_BUS_DMA 30 > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU
On Wed, May 2, 2018 at 12:16 AM, Rob Herringwrote: > On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: >> Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. >> >> Signed-off-by: Jagan Teki >> --- >> Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Rob Herring Hi Rob, Do we need to add this if it's just a soc-specific compatible we add in the device tree to future proof things in case we discover quirks later on? AFAIK we haven't been doing this, and this is likely to create some confusion, because they aren't actually mentioned anywhere in the driver. ChenYu ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 08/21] bindings: display: Add compatible for A64 HDMI PHY
On Mon, Apr 30, 2018 at 05:10:45PM +0530, Jagan Teki wrote: > HDMI PHY on Allwinner A64 has similar like H3/H5. > > Signed-off-by: Jagan Teki> --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index 9ea4353caadd..7dcd1d64dfe4 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -104,6 +104,7 @@ Required properties: >- compatible: value must be one of: > * allwinner,sun8i-a83t-hdmi-phy > * allwinner,sun8i-h3-hdmi-phy > +* allwinner,sun50i-a64-hdmi-phy This should be one valid combination per line. The dts shows that the h3 string is a fallback which should be captured in the binding doc. >- reg: base address and size of memory-mapped region >- clocks: phandles to the clocks feeding the HDMI PHY > * bus: the HDMI PHY interface clock > -- > 2.14.3 > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/21] bindings: display: Add compatible for A64 DE2 pipeline
On Mon, Apr 30, 2018 at 05:10:41PM +0530, Jagan Teki wrote: > Allwinner A64 has DE2 pipeline similar to other Allwinner > SOC's like A83T, H3/H5. 'dt-bindings: ' for the subject prefix. > > Signed-off-by: Jagan Teki> --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > 1 file changed, 1 insertion(+) Otherwise, Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU
On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote: > Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. > > Signed-off-by: Jagan Teki> --- > Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106258] AMD Xorg start failes with non-4K page sizes
https://bugs.freedesktop.org/show_bug.cgi?id=106258 --- Comment #9 from Matt Corallo--- Switched the machine over to a 4k-PAGE_SIZE kernel and it works fine, so that does appear to be the issue here. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm
https://bugs.freedesktop.org/show_bug.cgi?id=101651 Gregor Münchchanged: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Gregor Münch --- Looks good now for me. Still an issue for you? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: igt trouble with planes shared between multiple CRTCs (Re: [PATCH v2 0/8] R-Car DU: Support CRC calculation)
Op 01-05-18 om 10:58 schreef Maarten Lankhorst: > Hey, > > Op 30-04-18 om 16:56 schreef Daniel Vetter: >> On Mon, Apr 30, 2018 at 04:55:24PM +0200, Daniel Vetter wrote: >>> On Sat, Apr 28, 2018 at 12:07:04AM +0300, Laurent Pinchart wrote: Hi Daniel, (Removing the linux-media mailing list from CC as it is out of scope) You enquired on IRC whether this patch series passes the igt CRC tests. # ./kms_pipe_crc_basic --run-subtest read-crc-pipe-A IGT-Version: 1.22-gf447f5fc531d (aarch64) (Linux: 4.17.0-rc1-00085-g56e849d93cc9 aarch64) read-crc-pipe-A: Testing connector LVDS-1 using pipe A (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Test assertion failure function igt_pipe_crc_start, file igt_debugfs.c:764: (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Failed assertion: pipe_crc->crc_fd != -1 (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Last errno: 5, Input/output error Stack trace: Subtest read-crc-pipe-A failed. DEBUG (kms_pipe_crc_basic:1638) DEBUG: Test requirement passed: !(pipe >= data->display.n_pipes) (kms_pipe_crc_basic:1638) INFO: read-crc-pipe-A: Testing connector LVDS-1 using pipe A (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: set_pipe(A) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: Selecting pipe A (kms_pipe_crc_basic:1638) DEBUG: Clearing the fb with color (0.00,1.00,0.00) (kms_pipe_crc_basic:1638) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1024, height=768, format=0x34325258, tiling=0x0, size=0) (kms_pipe_crc_basic:1638) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=1, pitch=4096) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: Test requirement passed: plane_idx >= 0 && plane_idx < pipe->n_planes (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: plane_set_fb(140) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: plane_set_size (1024x768) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: fb_set_position(0,0) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: fb_set_size(1024x768) (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: commit { (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: SetCrtc pipe A, fb 140, src (0, 0), mode 1024x768 (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe A, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, plane 2, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, plane 3, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, plane 4, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe B, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, plane 1, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, plane 2, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, plane 3, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, plane 4, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe C, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, plane 1, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, plane 2, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, plane 3, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, plane 4, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe D, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe D, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, plane 2, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, plane 3, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, plane 4, disabling (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: } (kms_pipe_crc_basic:1638) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0' (kms_pipe_crc_basic:1638) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0' (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Test assertion failure function igt_pipe_crc_start, file igt_debugfs.c:764: (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Failed assertion: pipe_crc->crc_fd != -1 (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Last errno: 5, Input/output error (kms_pipe_crc_basic:1638) igt-core-INFO: Stack trace: END Subtest read-crc-pipe-A: FAIL (0.061s) I think the
Re: [PATCH] dt-bindings: panel: lvds: Fix path to display timing bindings
On Wed, Apr 25, 2018 at 09:49:38AM +0200, Geert Uytterhoeven wrote: > Fixes: 14da3ed8dd08c581 ("devicetree/bindings: display: Document common > panel properties") > Signed-off-by: Geert Uytterhoeven> --- > Documentation/devicetree/bindings/display/panel/panel-common.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] drm/ttm: Only allocate huge pages with new flag TTM_PAGE_FLAG_TRANSHUGE
On 2018-05-01 01:15 AM, Dave Airlie wrote: >> >> >> Yes, I fixed the original false positive messages myself with the swiotlb >> maintainer and I was CCed in fixing the recent fallout from Chris changes as >> well. > > So do we have a good summary of where this at now? > > I'm getting reports on 4.16.4 still displaying these, what hammer do I > need to hit things with to get 4.16.x+1 to not do this? > > Is there still outstanding issues upstream. There are, https://patchwork.freedesktop.org/patch/219765/ should hopefully fix the last of it. > [...] I've no idea if the swiotlb things people report are the false > positive, or some new thing. The issues I've seen reported with 4.16 are false positives from TTM's perspective, which uses DMA_ATTR_NO_WARN to suppress these warnings, due to multiple regressions introduced by commit 0176adb004065d6815a8e67946752df4cd947c5b "swiotlb: refactor coherent buffer allocation" in 4.16-rc1. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105018] Kernel panic when waking up after screen goes blank.
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #34 from Michel Dänzer--- While it's good to hear that xf86-video-amdgpu doesn't trigger it, the kernel BUG is still a kernel driver bug. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v3 2/2] drm/panel: Add device_link from panel device to drm device
Add device_link from panel device (supplier) to drm device (consumer) when drm_panel_attach() is called. This patch should protect the master drm driver if an attached panel driver unbinds while it is in use. The device_link should make sure the drm device is unbound before the panel driver becomes unavailable. The device_link is removed when drm_panel_detach() is called. The drm_panel_detach() should be called by the consumer DRM driver, not the panel driver, otherwise both drivers are racing to delete the same link. Signed-off-by: Jyri SarhaReviewed-by: Eric Anholt --- drivers/gpu/drm/drm_panel.c | 10 ++ include/drm/drm_panel.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 29d2c74..7474045 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -24,6 +24,7 @@ #include #include +#include #include #include @@ -101,6 +102,13 @@ int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector) if (panel->connector) return -EBUSY; + panel->link = device_link_add(connector->dev->dev, panel->dev, 0); + if (!panel->link) { + dev_err(panel->dev, "failed to link panel to %s\n", + dev_name(connector->dev->dev)); + return -EINVAL; + } + panel->connector = connector; panel->drm = connector->dev; @@ -123,6 +131,8 @@ EXPORT_SYMBOL(drm_panel_attach); */ int drm_panel_detach(struct drm_panel *panel) { + device_link_del(panel->link); + panel->connector = NULL; panel->drm = NULL; diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 14ac240..26a1b5f 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -89,6 +89,7 @@ struct drm_panel { struct drm_device *drm; struct drm_connector *connector; struct device *dev; + struct device_link *link; const struct drm_panel_funcs *funcs; -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105018] Kernel panic when waking up after screen goes blank.
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #33 from Öyvind Saether--- In my case the problem was not having xorg-x11-drv-amdgpu installed (how embarrassing) which made xorg use xorg-x11-drv-ati. Yes, really. I assumed Fedora 28 beta installed it along with all the other drives and didn't realize until comparing the X logs on a box which didn't have a problem with one that did. I did file the Fedora bug kindly asking xorg-x11-drv-amdgpu to be installed as a default. Simply installing xorg-x11-drv-amdgpu solved this error and amdgpu kernel crash: [12743.692030] kernel BUG at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4708! I realize the immensity of my stupidity not realizing xorg-x11-drv-amdgpu will make you laugh but it's not like the kernel panic message warned me. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 104082] amdgpu 0000:07:00.0: swiotlb buffer is full (sz: 2097152 bytes)
https://bugs.freedesktop.org/show_bug.cgi?id=104082 Michel Dänzerchanged: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #50 from Michel Dänzer --- The remaining issue should be fixed with https://patchwork.freedesktop.org/patch/219765/ . Anyway, the issues in 4.16 were swiotlb regressions, not directly related to the issue originally reported here. If there's ever an issue again with the fix above and Takashi-san's fix referenced in comment 40, please report it to the swiotlb developers instead of here. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] swiotlb: Fix inversed DMA_ATTR_NO_WARN test
From: Michel DänzerThe result was printing the warning only when we were explicitly asked not to. Cc: sta...@vger.kernel.org Fixes: 0176adb004065d6815a8e67946752df4cd947c5b "swiotlb: refactor coherent buffer allocation" Signed-off-by: Michel Dänzer --- lib/swiotlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index c43ec2271469..e9ac21540628 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -750,7 +750,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle, swiotlb_tbl_unmap_single(dev, phys_addr, size, DMA_TO_DEVICE, DMA_ATTR_SKIP_CPU_SYNC); out_warn: - if ((attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) { + if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) { dev_warn(dev, "swiotlb: coherent allocation failed, size=%zu\n", size); -- 2.17.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106258] AMD Xorg start failes with non-4K page sizes
https://bugs.freedesktop.org/show_bug.cgi?id=106258 --- Comment #8 from Andrey Grodzovsky--- I Wonder is there a way to reproduce this on x86 platform, from looking in kflags there is no CONFIG_x86_4/16/64K_PAGES flags. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106258] AMD Xorg start failes with non-4K page sizes
https://bugs.freedesktop.org/show_bug.cgi?id=106258 --- Comment #7 from Michel Dänzer--- (In reply to Timothy Pearson from comment #6) > This looks like something that should be filed at bugzilla.kernel.org > against the amdgpu driver itself. It will get more visibility by the right > people there. No, we prefer this bugzilla for tracking kernel driver issues as well. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] backlight: Remove s6e63m0 driver
On Mon, Apr 30, 2018 at 07:29:44PM +0200, Krzysztof Kozlowski wrote: > The driver for S6E63M0 AMOLED LCD panel is not used. It does not > support DeviceTree and respective possible users (S5Pv210 Aquila and > Goni boards) are DeviceTree-only. > > Suggested-by: Marek Szyprowski> Cc: Marek Szyprowski > Cc: Inki Dae > Signed-off-by: Krzysztof Kozlowski No objections to this on my side, however this patch (unlike the other) doesn't say this driver is *replaced* by an alternative, sounds more like it has merely bit rotted to the point it becomes unreachable. So it has my ack but I'll happliy to withdraw it if an interested party feels they need to devicetreeize it. Acked-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/Kconfig | 8 - > drivers/video/backlight/Makefile| 1 - > drivers/video/backlight/s6e63m0.c | 857 > > drivers/video/backlight/s6e63m0_gamma.h | 266 -- > 4 files changed, 1132 deletions(-) > delete mode 100644 drivers/video/backlight/s6e63m0.c > delete mode 100644 drivers/video/backlight/s6e63m0_gamma.h > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 5d2d0d7e8100..be0c130b6597 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -111,14 +111,6 @@ config LCD_HP700 > If you have an HP Jornada 700 series handheld (710/720/728) > say Y to enable LCD control driver. > > -config LCD_S6E63M0 > - tristate "S6E63M0 AMOLED LCD Driver" > - depends on SPI && BACKLIGHT_CLASS_DEVICE > - default n > - help > - If you have an S6E63M0 LCD Panel, say Y to enable its > - LCD control driver. > - > config LCD_LD9040 > tristate "LD9040 AMOLED LCD Driver" > depends on SPI && BACKLIGHT_CLASS_DEVICE > diff --git a/drivers/video/backlight/Makefile > b/drivers/video/backlight/Makefile > index 19da71d518bf..8773fdd64e99 100644 > --- a/drivers/video/backlight/Makefile > +++ b/drivers/video/backlight/Makefile > @@ -14,7 +14,6 @@ obj-$(CONFIG_LCD_LMS283GF05)+= lms283gf05.o > obj-$(CONFIG_LCD_LMS501KF03) += lms501kf03.o > obj-$(CONFIG_LCD_LTV350QV) += ltv350qv.o > obj-$(CONFIG_LCD_PLATFORM) += platform_lcd.o > -obj-$(CONFIG_LCD_S6E63M0)+= s6e63m0.o > obj-$(CONFIG_LCD_TDO24M) += tdo24m.o > obj-$(CONFIG_LCD_TOSA) += tosa_lcd.o > obj-$(CONFIG_LCD_VGG2432A4) += vgg2432a4.o > diff --git a/drivers/video/backlight/s6e63m0.c > b/drivers/video/backlight/s6e63m0.c > deleted file mode 100644 > index 3c4a22a3063a.. > --- a/drivers/video/backlight/s6e63m0.c > +++ /dev/null > @@ -1,857 +0,0 @@ > -/* > - * S6E63M0 AMOLED LCD panel driver. > - * > - * Author: InKi Dae > - * > - * Derived from drivers/video/omap/lcd-apollon.c > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the > - * Free Software Foundation; either version 2 of the License, or (at your > - * option) any later version. > - */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -#include "s6e63m0_gamma.h" > - > -#define SLEEPMSEC0x1000 > -#define ENDDEF 0x2000 > -#define DEFMASK 0xFF00 > -#define COMMAND_ONLY 0xFE > -#define DATA_ONLY0xFF > - > -#define MIN_BRIGHTNESS 0 > -#define MAX_BRIGHTNESS 10 > - > -struct s6e63m0 { > - struct device *dev; > - struct spi_device *spi; > - unsigned intpower; > - unsigned intcurrent_brightness; > - unsigned intgamma_mode; > - unsigned intgamma_table_count; > - struct lcd_device *ld; > - struct backlight_device *bd; > - struct lcd_platform_data*lcd_pd; > -}; > - > -static const unsigned short seq_panel_condition_set[] = { > - 0xF8, 0x01, > - DATA_ONLY, 0x27, > - DATA_ONLY, 0x27, > - DATA_ONLY, 0x07, > - DATA_ONLY, 0x07, > - DATA_ONLY, 0x54, > - DATA_ONLY, 0x9f, > - DATA_ONLY, 0x63, > - DATA_ONLY, 0x86, > - DATA_ONLY, 0x1a, > - DATA_ONLY, 0x33, > - DATA_ONLY, 0x0d, > - DATA_ONLY, 0x00, > - DATA_ONLY, 0x00, > - > - ENDDEF, 0x > -}; > - > -static const unsigned short seq_display_condition_set[] = { > - 0xf2, 0x02, > - DATA_ONLY, 0x03, > - DATA_ONLY, 0x1c, > - DATA_ONLY, 0x10, > - DATA_ONLY, 0x10, > - > - 0xf7, 0x03, > - DATA_ONLY, 0x00, > - DATA_ONLY, 0x00, > - > - ENDDEF,
Re: [PATCH 2/2] backlight: Remove ld9040 driver
On Mon, Apr 30, 2018 at 07:29:45PM +0200, Krzysztof Kozlowski wrote: > The driver for LD9040 AMOLED LCD panel was superseded with DRM driver > panel-samsung-ld9040.c. It does not support DeviceTree and respective > possible user (Exynos4210 Universal C210) is DeviceTree-only and uses > DRM version of driver.. > > Suggested-by: Marek Szyprowski> Cc: Marek Szyprowski > Cc: Inki Dae > Signed-off-by: Krzysztof Kozlowski Acked-by: Daniel Thompson > --- > drivers/video/backlight/Kconfig| 8 - > drivers/video/backlight/Makefile | 1 - > drivers/video/backlight/ld9040.c | 811 > - > drivers/video/backlight/ld9040_gamma.h | 202 > 4 files changed, 1022 deletions(-) > delete mode 100644 drivers/video/backlight/ld9040.c > delete mode 100644 drivers/video/backlight/ld9040_gamma.h > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index be0c130b6597..2202daf2ab4f 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -111,14 +111,6 @@ config LCD_HP700 > If you have an HP Jornada 700 series handheld (710/720/728) > say Y to enable LCD control driver. > > -config LCD_LD9040 > - tristate "LD9040 AMOLED LCD Driver" > - depends on SPI && BACKLIGHT_CLASS_DEVICE > - default n > - help > - If you have an LD9040 Panel, say Y to enable its > - control driver. > - > config LCD_AMS369FG06 > tristate "AMS369FG06 AMOLED LCD Driver" > depends on SPI && BACKLIGHT_CLASS_DEVICE > diff --git a/drivers/video/backlight/Makefile > b/drivers/video/backlight/Makefile > index 8773fdd64e99..0b327c0cb750 100644 > --- a/drivers/video/backlight/Makefile > +++ b/drivers/video/backlight/Makefile > @@ -9,7 +9,6 @@ obj-$(CONFIG_LCD_HX8357) += hx8357.o > obj-$(CONFIG_LCD_ILI922X)+= ili922x.o > obj-$(CONFIG_LCD_ILI9320)+= ili9320.o > obj-$(CONFIG_LCD_L4F00242T03)+= l4f00242t03.o > -obj-$(CONFIG_LCD_LD9040) += ld9040.o > obj-$(CONFIG_LCD_LMS283GF05) += lms283gf05.o > obj-$(CONFIG_LCD_LMS501KF03) += lms501kf03.o > obj-$(CONFIG_LCD_LTV350QV) += ltv350qv.o > diff --git a/drivers/video/backlight/ld9040.c > b/drivers/video/backlight/ld9040.c > deleted file mode 100644 > index 677f8abba27c.. > --- a/drivers/video/backlight/ld9040.c > +++ /dev/null > @@ -1,811 +0,0 @@ > -/* > - * ld9040 AMOLED LCD panel driver. > - * > - * Copyright (c) 2011 Samsung Electronics > - * Author: Donghwa Lee > - * Derived from drivers/video/backlight/s6e63m0.c > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the > - * Free Software Foundation; either version 2 of the License, or (at your > - * option) any later version. > - */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -#include "ld9040_gamma.h" > - > -#define SLEEPMSEC0x1000 > -#define ENDDEF 0x2000 > -#define DEFMASK 0xFF00 > -#define COMMAND_ONLY 0xFE > -#define DATA_ONLY0xFF > - > -#define MIN_BRIGHTNESS 0 > -#define MAX_BRIGHTNESS 24 > - > -struct ld9040 { > - struct device *dev; > - struct spi_device *spi; > - unsigned intpower; > - unsigned intcurrent_brightness; > - > - struct lcd_device *ld; > - struct backlight_device *bd; > - struct lcd_platform_data*lcd_pd; > - > - struct mutexlock; > - bool enabled; > -}; > - > -static struct regulator_bulk_data supplies[] = { > - { .supply = "vdd3", }, > - { .supply = "vci", }, > -}; > - > -static void ld9040_regulator_enable(struct ld9040 *lcd) > -{ > - int ret = 0; > - struct lcd_platform_data *pd = NULL; > - > - pd = lcd->lcd_pd; > - mutex_lock(>lock); > - if (!lcd->enabled) { > - ret = regulator_bulk_enable(ARRAY_SIZE(supplies), supplies); > - if (ret) > - goto out; > - > - lcd->enabled = true; > - } > - msleep(pd->power_on_delay); > -out: > - mutex_unlock(>lock); > -} > - > -static void ld9040_regulator_disable(struct ld9040 *lcd) > -{ > - int ret = 0; > - > - mutex_lock(>lock); > - if (lcd->enabled) { > - ret = regulator_bulk_disable(ARRAY_SIZE(supplies), supplies); > - if (ret) > - goto out; > - > - lcd->enabled = false; > - } > -out: > - mutex_unlock(>lock); > -} > - >
Re: [PATCH v4 2/2] drivers: remove force dma flag from buses
On Sat, Apr 28, 2018 at 08:21:59AM +0530, Nipun Gupta wrote: > With each bus implementing its own DMA configuration callback, > there is no need for bus to explicitly have force_dma in its > global structure. This patch modifies of_dma_configure API to > accept an input parameter which specifies if implicit DMA > configuration is required even when it is not described by the > firmware. > > Signed-off-by: Nipun Gupta> Acked-by: Bjorn Helgaas # PCI parts > --- > Changes in v2: > - This is a new change suggested by Robin and Christoph > and is added to the series. > > Changes in v3: > - Rebase and changes corresponding to the changes in patch 1/2 > > Changes in v4: > - Rebased on top of 4.17-rc2 > > drivers/amba/bus.c| 1 - > drivers/base/platform.c | 3 +-- > drivers/bcma/main.c | 2 +- > drivers/dma/qcom/hidma_mgmt.c | 2 +- > drivers/gpu/host1x/bus.c | 5 ++--- > drivers/of/device.c | 6 -- > drivers/of/of_reserved_mem.c | 2 +- > drivers/pci/pci-driver.c | 3 +-- > include/linux/device.h| 4 > include/linux/of_device.h | 8 ++-- > 10 files changed, 17 insertions(+), 19 deletions(-) Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106258] AMD Xorg start failes with non-4K page sizes
https://bugs.freedesktop.org/show_bug.cgi?id=106258 --- Comment #6 from Timothy Pearson--- This looks like something that should be filed at bugzilla.kernel.org against the amdgpu driver itself. It will get more visibility by the right people there. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: igt trouble with planes shared between multiple CRTCs (Re: [PATCH v2 0/8] R-Car DU: Support CRC calculation)
Hey, Op 30-04-18 om 16:56 schreef Daniel Vetter: > On Mon, Apr 30, 2018 at 04:55:24PM +0200, Daniel Vetter wrote: >> On Sat, Apr 28, 2018 at 12:07:04AM +0300, Laurent Pinchart wrote: >>> Hi Daniel, >>> >>> (Removing the linux-media mailing list from CC as it is out of scope) >>> >>> You enquired on IRC whether this patch series passes the igt CRC tests. >>> >>> # ./kms_pipe_crc_basic --run-subtest read-crc-pipe-A >>> IGT-Version: 1.22-gf447f5fc531d (aarch64) (Linux: >>> 4.17.0-rc1-00085-g56e849d93cc9 aarch64) >>> read-crc-pipe-A: Testing connector LVDS-1 using pipe A >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Test assertion failure >>> function igt_pipe_crc_start, file igt_debugfs.c:764: >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Failed assertion: >>> pipe_crc->crc_fd != -1 >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Last errno: 5, Input/output >>> error >>> Stack trace: >>> Subtest read-crc-pipe-A failed. >>> DEBUG >>> (kms_pipe_crc_basic:1638) DEBUG: Test requirement passed: !(pipe >= >>> data->display.n_pipes) >>> (kms_pipe_crc_basic:1638) INFO: read-crc-pipe-A: Testing connector LVDS-1 >>> using pipe A >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: set_pipe(A) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: Selecting pipe A >>> (kms_pipe_crc_basic:1638) DEBUG: Clearing the fb with color (0.00,1.00,0.00) >>> (kms_pipe_crc_basic:1638) igt-fb-DEBUG: >>> igt_create_fb_with_bo_size(width=1024, height=768, format=0x34325258, >>> tiling=0x0, size=0) >>> (kms_pipe_crc_basic:1638) igt-fb-DEBUG: >>> igt_create_fb_with_bo_size(handle=1, pitch=4096) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: Test requirement passed: plane_idx >>> >= 0 && plane_idx < pipe->n_planes >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: plane_set_fb(140) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: plane_set_size >>> (1024x768) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: fb_set_position(0,0) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: A.0: fb_set_size(1024x768) >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: commit { >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: LVDS-1: SetCrtc pipe >>> A, fb 140, src (0, 0), mode 1024x768 >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe A, >>> disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, >>> plane 2, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, >>> plane 3, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe A, >>> plane 4, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe B, >>> disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, >>> plane 1, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, >>> plane 2, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, >>> plane 3, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe B, >>> plane 4, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe C, >>> disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, >>> plane 1, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, >>> plane 2, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, >>> plane 3, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe C, >>> plane 4, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe D, >>> disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetCrtc pipe D, >>> disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, >>> plane 2, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, >>> plane 3, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: SetPlane pipe D, >>> plane 4, disabling >>> (kms_pipe_crc_basic:1638) igt-kms-DEBUG: display: } >>> (kms_pipe_crc_basic:1638) igt-debugfs-DEBUG: Opening debugfs directory >>> '/sys/kernel/debug/dri/0' >>> (kms_pipe_crc_basic:1638) igt-debugfs-DEBUG: Opening debugfs directory >>> '/sys/kernel/debug/dri/0' >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Test assertion failure >>> function igt_pipe_crc_start, file igt_debugfs.c:764: >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Failed assertion: >>> pipe_crc->crc_fd != -1 >>> (kms_pipe_crc_basic:1638) igt-debugfs-CRITICAL: Last errno: 5, Input/output >>> error >>> (kms_pipe_crc_basic:1638) igt-core-INFO: Stack trace: >>> END >>> Subtest read-crc-pipe-A: FAIL (0.061s) >>> >>> I think the answer is no, but I don't think it's the fault of this patch >>> series. Opening the CRC data file returns -EIO because the CRTC is not >>> active, >>> and I'm
Re: [PATCH 1/2 v4] drm/pl111: Support the Versatile Express
On Mon, Apr 30, 2018 at 03:55:41PM +0100, Robin Murphy wrote: > On 27/04/18 19:51, Linus Walleij wrote: > > On Fri, Apr 27, 2018 at 5:02 PM, Robin Murphywrote: > > > > > I dug a little bit and it seems pl111_modeset_init() is deferring because > > > it > > > can't find endpoint 0. And given that that's apparently pointing at some > > > non-existent panel rather than the DVI encoder as I would (naively) > > > expect, > > > I can at least form a self-consistent explanation and give up on the > > > grounds > > > that I'm probably missing some important DT changes. > > > > Yeah it does help if I also send the required DT changes :/ > > > > Sorry for my absentmindedness, I'll shoot it off right now so you > > can test it. > > Hooray, thanks for that. > > For these 2 patches with a V2P-CA15_A7 tile and the DT fixed up, > > Tested-by: Robin Murphy > > Framebuffer console and /dev/fb0 access for the motherboard CLCD works, and > it keeps out of the way as expected with CONFIG_DRM_HDLCD=y. I can't > convince an X session to start, but that appears more to do with sii902x > falling apart*, which I can't be bothered to even try debugging. > > Robin. > > > *specifically, lots of this, which I imagine is related to xorg trying to > either read the EDID or change mode: > ... > [ 243.439669] i2c i2c-0: sendbytes: NAK bailout. > [ 243.454247] i2c i2c-0: sendbytes: NAK bailout. > [ 247.743261] i2c i2c-0: sendbytes: NAK bailout. > [ 247.770281] sii902x 0-0039: failed to read status (-6) > [ 247.786609] i2c i2c-0: sendbytes: NAK bailout. > [ 248.118522] i2c i2c-0: sendbytes: NAK bailout. > [ 248.145485] sii902x 0-0039: failed to read status (-6) > [ 248.177800] i2c i2c-0: sendbytes: NAK bailout. > [ 258.256500] i2c i2c-0: sendbytes: NAK bailout. > [ 258.274763] i2c i2c-0: sendbytes: NAK bailout. > [ 268.499637] i2c i2c-0: sendbytes: NAK bailout. > [ 268.517899] i2c i2c-0: sendbytes: NAK bailout. That's a long standing issue that I've never got to the bottom of. The sii902x seems to have been wired in a curious way on the VExpress board and it is struggling to pass-through the I2C connection to the monitor. Best regards, Liviu > ... > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯ ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] video: fbdev: fix spelling mistake: "frambuffer" -> "framebuffer"
From: Colin Ian KingTrivial fix to spelling mistake in error messages Signed-off-by: Colin Ian King --- drivers/video/fbdev/au1100fb.c | 2 +- drivers/video/fbdev/au1200fb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c index 7c9a672e9811..5e0491861439 100644 --- a/drivers/video/fbdev/au1100fb.c +++ b/drivers/video/fbdev/au1100fb.c @@ -464,7 +464,7 @@ static int au1100fb_drv_probe(struct platform_device *dev) PAGE_ALIGN(fbdev->fb_len), >fb_phys, GFP_KERNEL); if (!fbdev->fb_mem) { - print_err("fail to allocate frambuffer (size: %dK))", + print_err("fail to allocate framebuffer (size: %dK))", fbdev->fb_len / 1024); return -ENOMEM; } diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c index 87d5a62bf6ca..3872ccef4cb2 100644 --- a/drivers/video/fbdev/au1200fb.c +++ b/drivers/video/fbdev/au1200fb.c @@ -1696,7 +1696,7 @@ static int au1200fb_drv_probe(struct platform_device *dev) >fb_phys, GFP_KERNEL, DMA_ATTR_NON_CONSISTENT); if (!fbdev->fb_mem) { - print_err("fail to allocate frambuffer (size: %dK))", + print_err("fail to allocate framebuffer (size: %dK))", fbdev->fb_len / 1024); ret = -ENOMEM; goto failed; -- 2.17.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFC 06/11] arm64: dts: mediatek: Add Elm Rev. 3 device tree
Hi, Le mercredi 18 octobre 2017 à 16:49 +0800, Yingjoe Chen a écrit : > Hi, > > > On Fri, 2017-09-29 at 15:09 +0200, Ulrich Hecht wrote: > > Signed-off-by: Ulrich Hecht> > --- > > arch/arm64/boot/dts/mediatek/Makefile|1 + > > arch/arm64/boot/dts/mediatek/mt8173-elm-rev3.dts | 21 + > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 210 + > > arch/arm64/boot/dts/mediatek/mt8173-oak.dtsi | 1014 > > ++ > > 4 files changed, 1246 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-rev3.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-oak.dtsi > > > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile > > b/arch/arm64/boot/dts/mediatek/Makefile > > index 151723b..0521e29 100644 > > --- a/arch/arm64/boot/dts/mediatek/Makefile > > +++ b/arch/arm64/boot/dts/mediatek/Makefile > > @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6795-evb.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-rev3.dtb > > > > always := $(dtb-y) > > subdir-y := $(dts-dirs) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-rev3.dts > > b/arch/arm64/boot/dts/mediatek/mt8173-elm-rev3.dts > > new file mode 100644 > > index 000..68d4095 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-rev3.dts > > @@ -0,0 +1,21 @@ > > +/* > > + * Copyright 2016 MediaTek Inc. > > + * Author: Eddie Huang > > + * > > + * This program is free software; you can redistribute it and/or > > modify > > + * it under the terms of the GNU General Public License version 2 > > as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +/dts-v1/; > > +#include "mt8173-elm.dtsi" > > + > > +/ { > > + model = "Mediatek Elm rev3 board"; > > + compatible = "google,elm-rev3", "google,elm", > > "mediatek,mt8173"; > > +}; When mainlining ARM Chromium OS devices, it seems that per-revision dts files are often dropped and merged into a single-revision dts for the whole device. This is perhaps because the early revisions of the devices are for internal development and never make it to the market. Also, I would suggest using an explicit model name instead of copying the compatible. Here, that would be "Chromebook R13 CB5-312T". > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > new file mode 100644 > > index 000..850037f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > @@ -0,0 +1,210 @@ > > +/* > > + * Copyright 2016 MediaTek Inc. > > + * Author: Eddie Huang > > + * > > + * This program is free software; you can redistribute it and/or > > modify > > + * it under the terms of the GNU General Public License version 2 > > as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include "mt8173-oak.dtsi" > > + > > +/ { > > + hdmicon: connector { > > + compatible = "hdmi-connector"; > > + label = "hdmi"; > > + type = "a"; > > + > > + port { > > + hdmi_connector_in: endpoint { > > + remote-endpoint = > > <_mux_out_hdmi>; > > + }; > > + }; > > + }; > > + > > + hdmi_mux: hdmi_mux { > > + compatible = "gpio-display-mux"; > > Where is the binding for this? > > > + status = "okay"; > > + detect-gpios = < 36 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <_mux_pins>; > > > If you use gpio_request or related api, it will set pinmux > automatically. > Do we really need this pinctrl? > > > + ddc-i2c-bus = <>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { /* input */ > > + reg = <0>; > > + > > + hdmi_mux_in: endpoint { > > + remote-endpoint = > > <_out>; > > + }; > > + }; > > + > > + port@1 { /* output */ > > +
[Bug 103234] KWin crashed when Alt+Tab-ing through open windows
https://bugs.freedesktop.org/show_bug.cgi?id=103234 Michel Dänzerchanged: What|Removed |Added CC||viktor.kecsk...@gmail.com --- Comment #21 from Michel Dänzer --- *** Bug 106327 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 106309] MST Multi-Stream Transport Kills All Displays Using Radeon Driver On Radeon HD 7570
https://bugs.freedesktop.org/show_bug.cgi?id=106309 Michel Dänzerchanged: What|Removed |Added Product|xorg|DRI Component|Driver/Radeon |DRM/Radeon QA Contact|xorg-t...@lists.x.org | Assignee|xorg-driver-...@lists.x.org |dri-devel@lists.freedesktop ||.org --- Comment #3 from Michel Dänzer --- (In reply to pl43c from comment #2) > Should I have reported this to bugzilla.kernel.org instead? No, we prefer this bugzilla for kernel driver issues as well. Reassigning. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 07/21] bindings: display: Add compatible for A64 HDMI
HDMI on Allwinner A64 has similar like H3/H5. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index f0fd9274a25d..9ea4353caadd 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -78,6 +78,7 @@ Required properties: - compatible: value must be one of: * "allwinner,sun8i-a83t-dw-hdmi" +* "allwinner,sun50i-a64-dw-hdmi" - reg: base address and size of memory-mapped region - reg-io-width: See dw_hdmi.txt. Shall be 1. - interrupts: HDMI interrupt number -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU
Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/sun8i-de2.txt b/Documentation/devicetree/bindings/clock/sun8i-de2.txt index f2fa87c4765c..7f425bc0e820 100644 --- a/Documentation/devicetree/bindings/clock/sun8i-de2.txt +++ b/Documentation/devicetree/bindings/clock/sun8i-de2.txt @@ -7,6 +7,7 @@ Required properties : - "allwinner,sun8i-h3-de2-clk" - "allwinner,sun8i-v3s-de2-clk" - "allwinner,sun50i-h5-de2-clk" + - "allwinner,sun50i-a64-de2-clk" - reg: Must contain the registers base address and length - clocks: phandle to the clocks feeding the display engine subsystem. -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 21/21] arm64: dts: allwinner: a64: sopine: Enable HDMI output
Enable HDMI output on sopine board. Signed-off-by: Jagan Teki--- .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts index abe179de35d7..72f29b78117c 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts @@ -61,6 +61,17 @@ stdout-path = "serial0:115200n8"; }; + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; + reg_vcc1v8: vcc1v8 { compatible = "regulator-fixed"; regulator-name = "vcc1v8"; @@ -69,6 +80,10 @@ }; }; + { + status = "okay"; +}; + { status = "okay"; }; @@ -86,6 +101,17 @@ status = "okay"; }; + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + { ext_rgmii_phy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 16/21] arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output
Enable HDMI output on Bananpi-m64 board. Signed-off-by: Jagan Teki--- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts index 2250dec9974c..69063c1fbddf 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts @@ -60,6 +60,17 @@ stdout-path = "serial0:115200n8"; }; + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; + leds { compatible = "gpio-leds"; @@ -86,6 +97,10 @@ }; }; + { + status = "okay"; +}; + { status = "okay"; }; @@ -99,6 +114,17 @@ status = "okay"; }; + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + { pinctrl-names = "default"; pinctrl-0 = <_pins>; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[REGRESSION] drm/amd/dc: Add dc display driver (v2)
Hi Harry, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found the following commit introduced the bug: commit 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c Author: Harry WentlandDate: Tue Sep 12 15:58:20 2017 -0400 drm/amd/dc: Add dc display driver (v2) The regression was introduced as of v4.15-rc1 and still exists in current mainline. The commit does not need to be reverted to resolve the bug. Disabling the CONFIG_DRM_AMD_DC_PRE_VEGA option makes the bug go away. I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue? Thanks, Joe [0] http://pad.lv/1761751 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support
On Fri, Apr 27, 2018 at 01:21:42PM +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset removes unused MERAM support (last user was removed > 3 years ago) from shmobile fbdev & drm drivers and then removes > MERAM driver itself. > > If it is okay to merge this patches I would like patch #1 to go > through fbdev tree and patch #2 to go through drm tree. Once they > are both upstream (v4.18) I will apply patch #3 to fbdev tree. Nice to see this cleanup, thanks. Reviewed-by: Simon Horman___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 13/21] drm/sun4i: Enable DE2 Mixer for Allwinner 64-bit SoCs
Allwinner 64-bit SoC like H5/A64 has DE2 Mixer so enable them as default. Signed-off-by: Jagan Teki--- drivers/gpu/drm/sun4i/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 60468a779a63..95ae04964756 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -52,7 +52,7 @@ config DRM_SUN8I_DW_HDMI config DRM_SUN8I_MIXER tristate "Support for Allwinner Display Engine 2.0 Mixer" - default MACH_SUN8I + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) help Choose this option if you have an Allwinner SoC with the Allwinner Display Engine 2.0, which has a mixer to do some -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs
Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them as default. Signed-off-by: Jagan Teki--- drivers/clk/sunxi-ng/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig index 79dfd296c3d1..1fffd3bf6ff3 100644 --- a/drivers/clk/sunxi-ng/Kconfig +++ b/drivers/clk/sunxi-ng/Kconfig @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU config SUN8I_DE2_CCU bool "Support for the Allwinner SoCs DE2 CCU" + default ARM64 && ARCH_SUNXI + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST config SUN8I_R40_CCU bool "Support for the Allwinner R40 CCU" -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 08/21] bindings: display: Add compatible for A64 HDMI PHY
HDMI PHY on Allwinner A64 has similar like H3/H5. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index 9ea4353caadd..7dcd1d64dfe4 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -104,6 +104,7 @@ Required properties: - compatible: value must be one of: * allwinner,sun8i-a83t-hdmi-phy * allwinner,sun8i-h3-hdmi-phy +* allwinner,sun50i-a64-hdmi-phy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the HDMI PHY * bus: the HDMI PHY interface clock -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 19/21] arm64: dts: allwinner: a64: a64-olinuxino: Enable HDMI output
Enable HDMI output on a64-olinuxino board. Signed-off-by: Jagan Teki--- .../boot/dts/allwinner/sun50i-a64-olinuxino.dts| 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts index 3b3081b10ecb..83329c8fec4f 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts @@ -58,12 +58,38 @@ stdout-path = "serial0:115200n8"; }; + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ }; }; + { + status = "okay"; +}; + + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + { pinctrl-names = "default"; pinctrl-0 = <_pins>; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 24/24] drm/bridge: establish a link between the bridge supplier and consumer
On 2018-04-30 17:32, Daniel Vetter wrote: > On Fri, Apr 27, 2018 at 12:31:39AM +0200, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (the drm_device) to some >> non-existent bridge supplier. >> >> Signed-off-by: Peter Rosin> > Minus the ->owner bikeshed I brought up in the previous patch I agree with > this approach as the best way to move forward for now. > > Acked-by: Daniel Vetter Thanks, let's see if Laurent is also on-board... > One small suggestion below, for merging I'd say pls get Jyri's > review/tested-by too, since you're both working on the same problem it > seems. Yes, I too would be very happy to see a tested-by from someone. > Aside: Do you want commit rights to drm-misc to be able to push work like > this? If that makes life easier, sure. Cheers, Peter ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 1/3] drm/prime: Iterate SG DMA addresses separately
On 4/30/2018 9:54 AM, Robin Murphy wrote: > For dma_map_sg(), DMA API implementations are free to merge consecutive > segments into a single DMA mapping if conditions are suitable, thus the > resulting DMA addresses which drm_prime_sg_to_page_addr_arrays() > iterates over may be packed into fewer entries than sgt->nents implies. > > The current implementation does not account for this, meaning that its > callers either have to reject the 0 < count < nents case or risk getting > bogus DMA addresses beyond the first segment. Fortunately this is quite > easy to handle without having to rejig structures to also store the > mapped count, since the total DMA length should still be equal to the > total buffer length. All we need is a second scatterlist cursor to > iterate through the DMA addresses independently of the page addresses. > > Reviewed-by: Christian König> Signed-off-by: Robin Murphy > --- Much better Tested-by: Sinan Kaya for the first two patches. (1/3 and 2/3) -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 20/21] arm64: dts: allwinner: a64: pine64: Enable HDMI output
Enable HDMI output on pine64 board. Signed-off-by: Jagan Teki--- .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts index a75825798a71..a4ec0900a885 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts @@ -62,6 +62,21 @@ chosen { stdout-path = "serial0:115200n8"; }; + + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; +}; + + { + status = "okay"; }; { @@ -82,6 +97,17 @@ }; + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + { pinctrl-names = "default"; pinctrl-0 = <_pins>; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI
On Sat, Apr 28, 2018 at 12:34:26AM +0300, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 27 April 2018 19:57:21 EEST Kieran Bingham wrote: > > The DU1 external dot clock is provided by the fixed frequency clock > > generator X21, while the DU0 and DU3 clocks are provided by the > > programmable Versaclock5 clock generator. > > > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board > > and hook it up to the HDMI connector. > > > > Based on patches from Takeshi Kihara> > > > Signed-off-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart Thanks, applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 09/21] arm64: dts: allwinner: a64: Add HDMI support
HDMI on Allwinner A64 has similar behavior like H3/H5, so reuse the same dts node details for A64. Signed-off-by: Jagan Teki--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 28 +++ include/dt-bindings/clock/sun50i-a64-ccu.h| 2 ++ 2 files changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 67b80bbe5bf5..da9128ae836d 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -644,6 +644,34 @@ #interrupt-cells = <3>; }; + hdmi: hdmi@1ee { + compatible = "allwinner,sun50i-a64-dw-hdmi", +"allwinner,sun8i-a83t-dw-hdmi"; + reg = <0x01ee 0x1>; + reg-io-width = <1>; + interrupts = ; + clocks = < CLK_BUS_HDMI>, < CLK_HDMI_DDC>, +< CLK_HDMI>; + clock-names = "iahb", "isfr", "tmds"; + resets = < RST_BUS_HDMI1>; + reset-names = "ctrl"; + phys = <_phy>; + phy-names = "hdmi-phy"; + status = "disabled"; + }; + + hdmi_phy: hdmi-phy@1ef { + compatible = "allwinner,sun50i-a64-hdmi-phy", +"allwinner,sun8i-h3-hdmi-phy"; + reg = <0x01ef 0x1>; + clocks = < CLK_BUS_HDMI>, < CLK_HDMI_DDC>, +< CLK_PLL_VIDEO1>; + clock-names = "bus", "mod", "pll-0"; + resets = < RST_BUS_HDMI0>; + reset-names = "phy"; + #phy-cells = <0>; + }; + rtc: rtc@1f0 { compatible = "allwinner,sun6i-a31-rtc"; reg = <0x01f0 0x54>; diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h index d66432c6e675..41c09df797ef 100644 --- a/include/dt-bindings/clock/sun50i-a64-ccu.h +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h @@ -45,6 +45,8 @@ #define CLK_PLL_PERIPH011 +#define CLK_PLL_VIDEO1 15 + #define CLK_BUS_MIPI_DSI 28 #define CLK_BUS_CE 29 #define CLK_BUS_DMA30 -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 23/24] drm/bridge: require the .owner to be filled in on drm_bridge_attach
On 2018-04-30 17:24, Daniel Vetter wrote: > On Fri, Apr 27, 2018 at 12:31:38AM +0200, Peter Rosin wrote: >> The .owner will be handy to have around. >> >> Signed-off-by: Peter Rosin>> --- >> drivers/gpu/drm/drm_bridge.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c >> index 9f023bd84d56..a038da696802 100644 >> --- a/drivers/gpu/drm/drm_bridge.c >> +++ b/drivers/gpu/drm/drm_bridge.c >> @@ -115,6 +115,9 @@ int drm_bridge_attach(struct drm_encoder *encoder, >> struct drm_bridge *bridge, >> if (!encoder || !bridge) >> return -EINVAL; >> >> +if (WARN_ON(!bridge->owner)) >> +return -EINVAL; > > I think conceptually this is checked at the wrong place, and I think also > misnamed > a bit. The ->owner is essentially the struct device (and its associated > driver) that provides the drm_bridge. As such it should be filled out > already at drm_bridge_add() time, and I think the check should be in > there. For driver-internal bridges it might make sense to also check this > here, not sure. Or just require all bridges get added. The reason for the position is that while I originally had the WARN in drm_bridge_add, I found that quite a few bridges never call drm_bridge_add. So I moved it. Other options are to start requiring all bridge suppliers to call drm_bridge_add or to have the WARN in both function. Too me, it would make sense to require all bridge suppliers to call drm_bridge_add, as that enables other init stuff later, when needed. But that is a hairy patch to get right, and is probably best left as a separate series. > Wrt the name, I think we should call this pdev or something. ->owner > usually means the module owner. I think in other subsystems ->dev is used, > but in drm we use ->dev for the drm_device pointer, so totally different > thing. pdev = physical device is the best I came up with. Better > suggestions very much welcome. pdev is about as problematic as owner. To me it reads "platform device". And dev for a drm_device is also somewhat problematic, and I think that drm would have been better, but dev for drm_device is probably quite common. But one way to go is to rename the current dev to drm, so that dev is freed up for the owner/supplier device. But that is a tedious patch to write (I don't do the cocci thing). Other suggestions I can think of: odev for owner device, sdev for supplier device or just plain supplier. Cheers, Peter > -Daniel > >> + >> if (previous && (!previous->dev || previous->encoder != encoder)) >> return -EINVAL; >> >> -- >> 2.11.0 >> >> ___ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 02/21] arm64: dts: allwinner: a64: Add DE2 CCU
DE2 in A64 has clock control unit and behavior is same like H3/H5, so reuse the same in A64. Signed-off-by: Jagan Teki--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 1b2ef28c42bd..67b80bbe5bf5 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -43,9 +43,11 @@ */ #include +#include #include #include #include +#include / { interrupt-parent = <>; @@ -168,6 +170,19 @@ #size-cells = <1>; ranges; + display_clocks: clock@100 { + compatible = "allwinner,sun50i-a64-de2-clk", +"allwinner,sun50i-h5-de2-clk"; + reg = <0x0100 0x10>; + clocks = < CLK_DE>, +< CLK_BUS_DE>; + clock-names = "mod", + "bus"; + resets = < RST_BUS_DE>; + #clock-cells = <1>; + #reset-cells = <1>; + }; + syscon: syscon@1c0 { compatible = "allwinner,sun50i-a64-system-controller", "syscon"; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 14/21] arm64: dts: allwinner: a64: Add HDMI pipeline
HDMI pipeline on A64 has similar behavior like A83T where tcon1 is connected to HDMI. So reuse similar dts nodes for A64. Signed-off-by: Jagan Teki--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 83 +++ 1 file changed, 83 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index da9128ae836d..f017baa4f5db 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -107,6 +107,12 @@ }; }; + de: display-engine { + compatible = "allwinner,sun50i-a64-display-engine"; + allwinner,pipelines = <>; + status = "disabled"; + }; + osc24M: osc24M_clk { #clock-cells = <0>; compatible = "fixed-clock"; @@ -183,6 +189,31 @@ #reset-cells = <1>; }; + mixer1: mixer@120 { + compatible = "allwinner,sun50i-a64-de2-mixer-1", +"allwinner,sun8i-a83t-de2-mixer-1"; + reg = <0x0120 0x10>; + clocks = <_clocks CLK_BUS_MIXER1>, +<_clocks CLK_MIXER1>; + clock-names = "bus", + "mod"; + resets = <_clocks RST_WB>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + mixer1_out: port@1 { + reg = <1>; + + mixer1_out_tcon1: endpoint { + remote-endpoint = <_in_mixer1>; + }; + }; + }; + }; + + syscon: syscon@1c0 { compatible = "allwinner,sun50i-a64-system-controller", "syscon"; @@ -200,6 +231,41 @@ #dma-cells = <1>; }; + tcon1: lcd-controller@1c0d000 { + compatible = "allwinner,sun50i-a64-tcon-tv", +"allwinner,sun8i-a83t-tcon-tv"; + reg = <0x01c0d000 0x1000>; + interrupts = ; + clocks = < CLK_BUS_TCON1>, < CLK_TCON1>; + clock-names = "ahb", "tcon-ch1"; + resets = < RST_BUS_TCON1>; + reset-names = "lcd"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + tcon1_in: port@0 { + reg = <0>; + + tcon1_in_mixer1: endpoint { + remote-endpoint = <_out_tcon1>; + }; + }; + + tcon1_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + tcon1_out_hdmi: endpoint@1 { + reg = <1>; + remote-endpoint = <_in_tcon1>; + }; + }; + }; + }; + mmc0: mmc@1c0f000 { compatible = "allwinner,sun50i-a64-mmc"; reg = <0x01c0f000 0x1000>; @@ -658,6 +724,23 @@ phys = <_phy>; phy-names = "hdmi-phy"; status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + hdmi_in: port@0 { + reg = <0>; + + hdmi_in_tcon1: endpoint { + remote-endpoint = <_out_hdmi>; + }; + }; + + hdmi_out: port@1 { + reg = <1>; + }; + }; }; hdmi_phy: hdmi-phy@1ef { -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 17/21] arm64: dts: allwinner: a64: nanopi-a64: Enable HDMI output
Enable HDMI output on nanopi-a64 board. Signed-off-by: Jagan Teki--- .../boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts index e2dce48fa29a..19fe7eed45e9 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts @@ -57,6 +57,21 @@ chosen { stdout-path = "serial0:115200n8"; }; + + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; +}; + + { + status = "okay"; }; { @@ -67,6 +82,17 @@ status = "okay"; }; + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + /* i2c1 connected with gpio headers like pine64, bananapi */ { pinctrl-names = "default"; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 10/21] drm/sun4i: Enable DesignWare HDMI for Allwinner 64-bit SoCs
Allwinner 64-bit SoC like H5/A64 has DesignWare HDMI so enable them as default. Signed-off-by: Jagan Teki--- drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index eee6bc0eaf97..60468a779a63 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -42,6 +42,7 @@ config DRM_SUN4I_BACKEND config DRM_SUN8I_DW_HDMI tristate "Support for Allwinner version of DesignWare HDMI" + default ARM64 && ARCH_SUNXI depends on DRM_SUN4I select DRM_DW_HDMI help -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] video: fbdev: omap2: remove rfbi
Hi, On Mon, Apr 30, 2018 at 10:06:11AM +0300, Tomi Valkeinen wrote: > On 27/04/18 21:12, Aaro Koskinen wrote: > >> You should be targeting omapdrm driver instead, fbdev subsystem is closed > >> for the new hardware support. > > > > AFAIK, based on N950 display support discussion, it's impossible to get > > anything new into omapdrm for a long time. And based on Tomi's comments, > > restoring RFBI support with omapfb should be a minor thing. > > I was perhaps a bit vague, but I didn't say it should be a minor thing. > I meant that there should be no architectural obstacles in omapfb, and I > think all the generic plumbing to enable N800 display is there in omapfb. > > That said, it still needs a real amount of work with the rfbi driver, > the encoder driver and the panel driver on N800 (the encoder and the > panel driver are not in mainline anymore). Let's see first if I get anything working. After that we can evaluate the impact properly once we see the actual patches needed. A. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 00/21] arm64: allwinner: Add A64 DE2 HDMI support
Allwinner A64 has display engine pipeline like other Allwinner SOC's A83T/H3/H5. A64 DE2 behaviour similar to Allwinner A83T where mixer0, connected to tcon0 with RGB, LVDS MIPI-DSI and mixer1, connected to tcon1 with HDMI as per Display System Block DiagramAllwinner_A64_User_Manual_V1.1.pdf This is the first series on Allwinner A64 DE2 HDMI support which followed with previous RFC series [1] (thanks to Maxime, Jernej for comments on RFC series) and rest will add in future patches. patch 1: dt-bindings for a64 de2 ccu patch 2: add node support for a64 de2 ccu patch 3: enable DE2_CCU for Allwinner 64-bit SoCs patch 4: dt-bindings for a64 de2 pipeline patch 5: add support for a64 de2 patch 6: defconfig: enable CONFIG_DRM_SUN4I patch 7 -8: dt-bindings for a64 HDMI and HDMI PHY patch 9: add support for a64 HDMI patch 10: enable DesignWare HDMI for Allwinner 64-bit SoCs patch 11 - 12: dt-bindings for a64 mixer1 and tcon1 patch 13: enable de2 mixer for Allwinner 64-bit SoCs patch 14: add support for a64 HDMI pipeline patch 15: add support for HVCC regulator patch 16: enable HDMI out for bananapi-m64 patch 17: enable HDMI out for nanopi-a64 patch 18: enable HDMI out for orangepi-win patch 19: enable HDMI out for a64-olinuxino patch 20: enable HDMI out for pine64 patch 21: enable HDMI out for sopine Since this series added HDMI through mixer1 through tcon1, I have used CLK_PLL_VIDEO1 as pll-0 we need to update the driver to support both CLK_PLL_VIDEO0 and 1 once we have add hdmi through mixer0. Note: with pine64 and sopine, I'm unable to see any display on screen but loadded fine, request to verify anyone. Log: --- # modprobe -a sun4i-drm sun8i-mixer sun4i_tv sun4i-drm-hdmi sun8i-drm-hdmi [ 13.390465] sun4i-drm display-engine: bound 120.mixer (ops sun8i_mixer_ops [sun8i_mixer]) [ 13.399247] sun4i-drm display-engine: No panel or bridge found... RGB output disabled [ 13.407113] sun4i-drm display-engine: bound 1c0d000.lcd-controller (ops sun4i_tcon_ops [sun4i_tcon]) [ 13.417386] sun8i-dw-hdmi 1ee.hdmi: Detected HDMI TX controller v1.32a with HDCP (sun8i_dw_hdmi_ph y) [ 13.427436] sun8i-dw-hdmi 1ee.hdmi: registered DesignWare HDMI I2C bus driver [ 13.435987] sun4i-drm display-engine: bound 1ee.hdmi (ops sun8i_dw_hdmi_ops [sun8i_drm_hdmi]) [ 13.444868] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 13.451498] [drm] No driver support for vblank timestamp query. [ 13.96] Console: switching to colour frame buffer device 320x90 [ 14.008789] sun4i-drm display-engine: fb0: frame buffer device [ 14.028297] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0 [1] https://lkml.org/lkml/2018/4/24/547 Icenowy Zheng (1): drm: sun4i: add support for HVCC regulator for DWC HDMI glue Jagan Teki (20): dt-bindings: clock: Add compatible for A64 DE2 CCU arm64: dts: allwinner: a64: Add DE2 CCU clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs bindings: display: Add compatible for A64 DE2 pipeline drm/sun4i: Add support for A64 display engine arm64: defconfig: Enable CONFIG_DRM_SUN4I bindings: display: Add compatible for A64 HDMI bindings: display: Add compatible for A64 HDMI PHY arm64: dts: allwinner: a64: Add HDMI support drm/sun4i: Enable DesignWare HDMI for Allwinner 64-bit SoCs bindings: display: Add compatible for A64 Mixer1 bindings: display: Add compatible for A64 tcon-tv drm/sun4i: Enable DE2 Mixer for Allwinner 64-bit SoCs arm64: dts: allwinner: a64: Add HDMI pipeline arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output arm64: dts: allwinner: a64: nanopi-a64: Enable HDMI output arm64: dts: allwinner: a64: orangepi-win: Enable HDMI output arm64: dts: allwinner: a64: a64-olinuxino: Enable HDMI output arm64: dts: allwinner: a64: pine64: Enable HDMI output arm64: dts: allwinner: a64: sopine: Enable HDMI output .../devicetree/bindings/clock/sun8i-de2.txt| 1 + .../bindings/display/sunxi/sun4i-drm.txt | 5 + .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 26 + .../boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 26 + .../boot/dts/allwinner/sun50i-a64-olinuxino.dts| 26 + .../boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 26 + .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 26 + .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 26 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 126 + arch/arm64/configs/defconfig | 1 + drivers/clk/sunxi-ng/Kconfig | 2 + drivers/gpu/drm/sun4i/Kconfig | 3 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 14 +++
Re: [PATCH v2 08/11] arm64: dts: r8a77965: Populate the DU instance placeholder
On Fri, Apr 27, 2018 at 05:57:19PM +0100, Kieran Bingham wrote: > The DU entity node has been previously added but only as a placeholder. > Populate the node with the properties to use the device. > > Signed-off-by: Kieran Bingham> Reviewed-by: Laurent Pinchart Thanks, applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 06/11] arm64: dts: r8a77965: Add FCPF and FCPV instances
On Fri, Apr 27, 2018 at 05:57:17PM +0100, Kieran Bingham wrote: > The FCPs handle the interface between various IP cores and memory. Add > the instances related to the FDPs and VSP2s. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart. > > Signed-off-by: Takeshi Kihara > [Kieran: Rebase to top of tree] > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent Pinchart Thanks, applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 07/11] arm64: dts: r8a77965: Add VSP instances
On Fri, Apr 27, 2018 at 05:57:18PM +0100, Kieran Bingham wrote: > The r8a77965 has 4 VSP instances. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart. > > Signed-off-by: Takeshi Kihara > [Kieran: Rebased to top of tree, fixed sort orders] > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent Pinchart Thanks, applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 04/21] bindings: display: Add compatible for A64 DE2 pipeline
Allwinner A64 has DE2 pipeline similar to other Allwinner SOC's like A83T, H3/H5. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index 3346c1e2a7a0..f0fd9274a25d 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -343,6 +343,7 @@ Required properties: * allwinner,sun8i-h3-display-engine * allwinner,sun8i-v3s-display-engine * allwinner,sun9i-a80-display-engine +* allwinner,sun50i-a64-display-engine - allwinner,pipelines: list of phandle to the display engine frontends (DE 1.0) or mixers (DE 2.0) available. -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 09/11] arm64: dts: r8a77965: Add HDMI encoder instance
On Fri, Apr 27, 2018 at 05:57:20PM +0100, Kieran Bingham wrote: > Add the HDMI encoder to the R8A77965 DT in disabled state. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart. > > Signed-off-by: Takeshi Kihara > [Kieran: Rebase to top of tree] > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent Pinchart Thanks, applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] video: fbdev: omap2: remove rfbi
Hi, On Mon, Apr 30, 2018 at 05:34:59PM +0200, Bartlomiej Zolnierkiewicz wrote: > BROKEN is not an user selectable config option so without modifying > drivers/video/fbdev/omap2/omapfb/dss/Kconfig the RFBI driver is not > even included in the kernel build.. Yes, I know. It's still incorrect to state that the code "doesn't even compile". A. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 05/21] drm/sun4i: Add support for A64 display engine
A64 display engine has two mixers which are connected to LVDS/RGB/MIPI-DSI and HDMI output through tcon0 and tcon1. Signed-off-by: Jagan Teki--- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 50d19605c38f..c84102a750f8 100644 --- a/drivers/gpu/drm/sun4i/sun4i_drv.c +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c @@ -368,6 +368,7 @@ static const struct of_device_id sun4i_drv_of_table[] = { { .compatible = "allwinner,sun8i-h3-display-engine" }, { .compatible = "allwinner,sun8i-v3s-display-engine" }, { .compatible = "allwinner,sun9i-a80-display-engine" }, + { .compatible = "allwinner,sun50i-a64-display-engine" }, { } }; MODULE_DEVICE_TABLE(of, sun4i_drv_of_table); -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 12/21] bindings: display: Add compatible for A64 tcon-tv
tcon-tv on Allwinner A64 has similar behavior like Allwinner A83T. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index 5d448ef2132f..8b6b4bc43d98 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -150,6 +150,7 @@ Required properties: * allwinner,sun8i-v3s-tcon * allwinner,sun9i-a80-tcon-lcd * allwinner,sun9i-a80-tcon-tv + * allwinner,sun50i-a64-tcon-tv - reg: base address and size of memory-mapped region - interrupts: interrupt associated to this IP - clocks: phandles to the clocks feeding the TCON. -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 22/24] drm/bridge: remove the .of_node member
On 2018-04-28 10:09, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on v4.17-rc2] > [also build test ERROR on next-20180426] > [cannot apply to drm/drm-next robclark/msm-next > drm-exynos/exynos-drm/for-next] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Peter-Rosin/device-link-bridge-supplier-drm-device/20180428-135229 > config: arm-allmodconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > >drivers/gpu//drm/rockchip/rockchip_lvds.c: In function > 'rockchip_lvds_bind': >>> drivers/gpu//drm/rockchip/rockchip_lvds.c:381:24: error: 'struct >>> drm_bridge' has no member named 'of_node' > remote = lvds->bridge->of_node; >^~ > > vim +381 drivers/gpu//drm/rockchip/rockchip_lvds.c Ugh. So, patch 1/24 needs to be amended with this diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index e67f4ea28c0e..3f33034b3f58 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -377,8 +377,10 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, } if (lvds->panel) remote = lvds->panel->dev->of_node; - else + else if (lvds->bridge->of_node) remote = lvds->bridge->of_node; + else + remote = lvds->bridge->owner->of_node; if (of_property_read_string(dev->of_node, "rockchip,output", )) /* default set it as output rgb */ lvds->output = DISPLAY_OUTPUT_RGB; and patch 22/24 with this diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index 3f33034b3f58..8c82fa647536 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -377,8 +377,6 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, } if (lvds->panel) remote = lvds->panel->dev->of_node; - else if (lvds->bridge->of_node) - remote = lvds->bridge->of_node; else remote = lvds->bridge->owner->of_node; if (of_property_read_string(dev->of_node, "rockchip,output", )) But that is of course just a stop-gap. The real fix is to adapt to the "drm: bridge: Add support for static image formats" series from Jacopo. But that's orthogonal. Cheers, Peter ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 06/21] arm64: defconfig: Enable CONFIG_DRM_SUN4I
Enable DRM Support for Allwinner Display Engine, built as a module. Signed-off-by: Jagan Teki--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 8ac1feafe563..723e6a5121fa 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -410,6 +410,7 @@ CONFIG_DRM_EXYNOS_DSI=y CONFIG_DRM_EXYNOS_HDMI=y CONFIG_DRM_EXYNOS_MIC=y CONFIG_DRM_ROCKCHIP=m +CONFIG_DRM_SUN4I=m CONFIG_ROCKCHIP_ANALOGIX_DP=y CONFIG_ROCKCHIP_CDN_DP=y CONFIG_ROCKCHIP_DW_HDMI=y -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 15/21] drm: sun4i: add support for HVCC regulator for DWC HDMI glue
From: Icenowy ZhengAllwinner SoCs with DWC HDMI controller have a "HVCC" power pin for the HDMI part, and on some boards it's connected to a dedicated regulator rather than the main 3.3v. Add support for optional HVCC regulator. For boards that doesn't use a dedicated regulator to power it, the default dummy regulator is used. Signed-off-by: Icenowy Zheng Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 14 ++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 9f40a44b456b..7c33faff7ad4 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -73,6 +73,12 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, if (encoder->possible_crtcs == 0) return -EPROBE_DEFER; + hdmi->vcc_hdmi = devm_regulator_get(dev, "hvcc"); + if (IS_ERR(hdmi->vcc_hdmi)) { + dev_err(dev, "Could not get HDMI power supply\n"); + return PTR_ERR(hdmi->vcc_hdmi); + } + hdmi->rst_ctrl = devm_reset_control_get(dev, "ctrl"); if (IS_ERR(hdmi->rst_ctrl)) { dev_err(dev, "Could not get ctrl reset control\n"); @@ -91,6 +97,12 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, return ret; } + ret = regulator_enable(hdmi->vcc_hdmi); + if (ret) { + dev_err(dev, "Cannot enable HDMI power supply\n"); + goto err_disable_vcc; + } + ret = clk_prepare_enable(hdmi->clk_tmds); if (ret) { dev_err(dev, "Could not enable tmds clock\n"); @@ -143,6 +155,8 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, clk_disable_unprepare(hdmi->clk_tmds); err_assert_ctrl_reset: reset_control_assert(hdmi->rst_ctrl); +err_disable_vcc: + regulator_disable(hdmi->vcc_hdmi); return ret; } diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h index 79154f0f674a..c25d75ef9303 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #define SUN8I_HDMI_PHY_DBG_CTRL_REG0x @@ -173,6 +174,7 @@ struct sun8i_dw_hdmi { struct drm_encoder encoder; struct sun8i_hdmi_phy *phy; struct dw_hdmi_plat_dataplat_data; + struct regulator*vcc_hdmi; struct reset_control*rst_ctrl; }; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 18/21] arm64: dts: allwinner: a64: orangepi-win: Enable HDMI output
Enable HDMI output on Orangepi-win board. Signed-off-by: Jagan Teki--- .../boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts index bf42690a3361..b6fdd052d473 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts @@ -57,12 +57,38 @@ chosen { stdout-path = "serial0:115200n8"; }; + + connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <_out_con>; + }; + }; + }; +}; + + { + status = "okay"; }; { status = "okay"; }; + { + hvcc-supply = <_dldo1>; + status = "okay"; +}; + +_out { + hdmi_out_con: endpoint { + remote-endpoint = <_con_in>; + }; +}; + { pinctrl-names = "default"; pinctrl-0 = <_pins>; -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 11/21] bindings: display: Add compatible for A64 Mixer1
Mixer1 on Allwinner A64 has similar behavior like Allwinner A83T. Signed-off-by: Jagan Teki--- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index 7dcd1d64dfe4..5d448ef2132f 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -313,6 +313,7 @@ Required properties: * allwinner,sun8i-a83t-de2-mixer-1 * allwinner,sun8i-h3-de2-mixer-0 * allwinner,sun8i-v3s-de2-mixer +* allwinner,sun50i-a64-de2-mixer-1 - reg: base address and size of the memory-mapped region. - clocks: phandles to the clocks feeding the mixer * bus: the mixer interface clock -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 105832] radeonsi NIR missing bindless textures support
https://bugs.freedesktop.org/show_bug.cgi?id=105832 Timothy Arcerichanged: What|Removed |Added Component|Mesa core |Drivers/Gallium/radeonsi QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop |org |.org Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop |org |.org -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel