Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on
On Tuesday, 9 April 2024 11:26:25 CEST Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, 27 Mar 2024, Maxime Ripard wrote: > > Jani recently pointed out that the Kconfig symbols are a bit difficult > > to work with at the moment when they depend on each other, and that > > using depends on would be a better idea, but no one really did the work > > so far. > > > > So here it goes :) > > > > It's been tested by comparing the riscv defconfig, arm > > multi_v7_defconfig, arm64 defconfig, drm-misc-arm, drm-misc-arm64 and > > drm-misc-x86 before and after this series and making sure they are > > identical. > > That is not true: comparing drm-misc/for-linux-next to v6.9-rc2, > arm/multi_v7_defconfig, arm64/defconfig, and riscv/defconfig lost > several of: >- CONFIG_DRM_DW_HDMI, >- CONFIG_DRM_DW_HDMI_AHB_AUDIO, >- CONFIG_DRM_DW_HDMI_CEC, >- CONFIG_DRM_DW_HDMI_I2S_AUDIO, >- CONFIG_DRM_IMX_HDMI. >- CONFIG_DRM_MESON_DW_HDMI, >- CONFIG_DRM_RCAR_DW_HDMI, >- CONFIG_DRM_SUN8I_DW_HDMI, >- CONFIG_ROCKCHIP_DW_HDMI, >- CONFIG_SND_MESON_G12A_TOHDMITX, > > > Let me know what you think, > > IMHO this series looks like a big usuability issue for anyone > configuring the kernel, and you try to work around this by sprinkling > "default y" around. > > The user should not need to know which helpers are needed for the driver > he is interested in. When a symbol selects another symbol, it should > just make sure the dependencies of the target symbol are met. > > Thanks for reverting ;-) I *think* that I ran into this issue (but it may also be KEBKAC). I tried to build a Debian arm64 kernel from 6.9-rc3 with a number of drm-misc- next patches, including this patch set. debian/config/arm64/config: CONFIG_DRM_SUN8I_DW_HDMI=m In my 6.7.9 kernel the sun8i-drm-hdmi module got build. (as well as meson_dw_hdmi, although it does not have an explicit configuration for it, but there appears a similarity with it in the `drm: Make drivers depends on DRM_DW_HDMI` commit) But in my newly build kernel both are NOT build. While I can't complain about meson_dw_hdmi, I would have expected the sun8i- drm-hdmi module to be build. Cheers, Diederik PS: The Kconfig says that the module will be called `sun8i_dw_hdmi`, but that seems to be incorrect signature.asc Description: This is a digitally signed message part.
Re: [PATCH v4 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2
On Saturday, 27 January 2024 10:48:45 CET Manuel Traut wrote: > This includes support for both the v0.1 units that were sent to developers > and the v2.0 units from production. > > v1.0 is not included as no units are known to exist. > > Working/Tested: > - SDMMC > - UART > - Buttons > - Charging/Battery/PMIC > - Audio > - USB > - Display > - SPI NOR Flash > > Signed-off-by: Alexander Warnecke > Signed-off-by: Manuel Traut Everything seems to (still) work, so: Tested-By: Diederik de Haas Thanks for submitting this upstream :-) Cheers, Diederik signature.asc Description: This is a digitally signed message part.
Re: [PATCH v2 0/4] arm64: rockchip: Pine64 pinetab2 support
On Saturday, 23 December 2023 16:20:14 CET Manuel Traut wrote: > This adds support for the BOE TH101MB31IG002 LCD Panel used in Pinetab2 [1] > and Pinetab-V [2] as well as the devictrees for the Pinetab2 v0.1 and v2.0. I have a PineTab2 4GB/64GB model and I run a Debian Trixie system *from an SDcard* (danctnix system is on eMMC). On it, I have a 6.6 kernel with my own patch set and a 6.7-rc7 kernel with this patch set. Everything seems to work properly. I've now also tested the HDMI output connector and that worked too :) So based on that, you can add my Tested-By: Diederik de Haas I do see an error in dmesg wrt mmc. I had one with my own patch set too, but a different one and it seems the mainline patch set fixes that, but then runs into another issue: [5.570059] dwmmc_rockchip fe2c.mmc: could not set regulator OCR (-22) [5.570835] dwmmc_rockchip fe2c.mmc: failed to enable vmmc regulator [5.616373] dwmmc_rockchip fe2c.mmc: could not set regulator OCR (-22) [5.621903] dwmmc_rockchip fe2c.mmc: failed to enable vmmc regulator Both also have an error wrt `goodix_911_cfg.bin` firmware, but the error could be because Debian kernel 'upgraded' a warning to an error. I've searched online for that filename, but haven't found anything. The touchscreen works, so I guess that one can be ignored. kernel 6.7-rc7 + mainline patch set: === # uname -a Linux pinetab2 6.7-rc7+unreleased-arm64 #1 SMP Debian 6.7~rc7-1~pine64 (2023-12-24) aarch64 GNU/Linux # dmesg --level emerg,alert,crit # dmesg --level emerg,alert,crit,err [5.570059] dwmmc_rockchip fe2c.mmc: could not set regulator OCR (-22) [5.570835] dwmmc_rockchip fe2c.mmc: failed to enable vmmc regulator [5.616373] dwmmc_rockchip fe2c.mmc: could not set regulator OCR (-22) [5.621903] dwmmc_rockchip fe2c.mmc: failed to enable vmmc regulator [ 19.569452] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2) [ 19.575504] firmware_class: See https://wiki.debian.org/Firmware for information about missing firmware [ 19.613497] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2) # dmesg | grep mmc [3.782844] dwmmc_rockchip fe2c.mmc: IDMAC supports 32-bit address mode. [3.783027] dwmmc_rockchip fe2c.mmc: Using internal DMA controller. [3.783132] dwmmc_rockchip fe2c.mmc: Version ID is 270a [3.783314] dwmmc_rockchip fe2c.mmc: DW MMC controller at irq 24,32 bit host data width,256 deep fifo [3.853034] dwmmc_rockchip fe2b.mmc: IDMAC supports 32-bit address mode. [3.853859] dwmmc_rockchip fe2b.mmc: Using internal DMA controller. [3.854492] dwmmc_rockchip fe2b.mmc: Version ID is 270a [3.856863] dwmmc_rockchip fe2b.mmc: DW MMC controller at irq 31,32 bit host data width,256 deep fifo [3.861731] dwmmc_rockchip fe2c.mmc: IDMAC supports 32-bit address mode. [3.862459] dwmmc_rockchip fe2c.mmc: Using internal DMA controller. [3.863088] dwmmc_rockchip fe2c.mmc: Version ID is 270a [3.863656] dwmmc_rockchip fe2c.mmc: DW MMC controller at irq 24,32 bit host data width,256 deep fifo [3.870506] dwmmc_rockchip fe2c.mmc: Failed getting OCR mask: -22 [4.015316] dwmmc_rockchip fe2b.mmc: IDMAC supports 32-bit address mode. [4.016042] dwmmc_rockchip fe2b.mmc: Using internal DMA controller. [4.016660] dwmmc_rockchip fe2b.mmc: Version ID is 270a [4.017223] dwmmc_rockchip fe2b.mmc: DW MMC controller at irq 31,32 bit host data width,256 deep fifo [4.034954] dwmmc_rockchip fe2c.mmc: IDMAC supports 32-bit address mode. [4.035772] dwmmc_rockchip fe2c.mmc: Using internal DMA controller. [4.037119] dwmmc_rockchip fe2c.mmc: Version ID is 270a [4.039868] dwmmc_rockchip fe2c.mmc: DW MMC controller at irq 24,32 bit host data width,256 deep fifo [4.041248] dwmmc_rockchip fe2c.mmc: Failed getting OCR mask: -22 [5.172937] dwmmc_rockchip fe2b.mmc: IDMAC supports 32-bit address mode. [5.175108] dwmmc_rockchip fe2b.mmc: Using internal DMA controller. [5.175750] dwmmc_rockchip fe2b.mmc: Version ID is 270a [5.176311] dwmmc_rockchip fe2b.mmc: DW MMC controller at irq 31,32 bit host data width,256 deep fifo [5.179484] dwmmc_rockchip fe2b.mmc: Got CD GPIO [5.193439] mmc_host mmc0: Bus speed (slot 0) = 375000Hz (slot req 40Hz, actual 375000HZ div = 0) [5.259322] mmc_host mmc0: Bus speed (slot 0) = 15000Hz (slot req 15000Hz, actual 15000HZ div = 0) [5.332873] dwmmc_rockchip fe2b.mmc: Successfully tuned phase to 254 [5.332922] mmc0: new ultra high speed SDR104 SDHC card at address 59b4 [5.335025] mmcblk0: mmc0:59b4 0 14.9 GiB [5.345735] mmcblk0: p1 p2 [5.563710] dwmmc_rockchip fe2c.mmc: IDMAC supports 32-bit address mode. [5.564608] dwmmc_rockchip fe2c.mmc: Using intern
Re: [PATCH 4/6] arm64: dts: rockchip: Add devicetree for Pine64 Pinetab2
Hi Manuel,
On Saturday, 23 December 2023 14:59:34 CET Manuel Traut wrote:
> On Fri, Dec 22, 2023 at 06:01:54PM +0100, Diederik de Haas wrote:
> > On Friday, 22 December 2023 12:05:44 CET Manuel Traut wrote:
> > > +
> > > + {
> > > + assigned-clocks = < PLL_GPLL>, < PLL_PPLL>, <
> > > PLL_VPLL>; + assigned-clock-rates = <12>, <2>,
> > > <5>; +};
> >
> > Attachment seem to work and for this I also have the attached patch in my
> > patch set.
> > IIRC without it you get an error in dmesg immediately at boot up which is
> > visible on the PT2 *if* you have immediate visual output (which is not
> > (yet?) the case in my image/kernel).
>
> you can see the message also by calling "dmesg --level err".
> I could verify that your patch removes the error message.
As I have been using that patch for a while, I couldn't verify it myself
anymore ;-)
If you use the (default) danctnix image, then you see it immediately at boot
up (at least the last time I tried it). With my (WIP) image, I only get visual
output after 5-7 seconds, so you'll likely miss that visual error if the image
you use also has a delay before outputting things on the screen.
But indeed, it would still show up in dmesg (without the patch).
> I will pick the change for v2.
Great :-)
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH 4/6] arm64: dts: rockchip: Add devicetree for Pine64 Pinetab2
On Friday, 22 December 2023 12:05:44 CET Manuel Traut wrote:
> +
> + {
> + assigned-clocks = < PLL_GPLL>, < PLL_PPLL>, <
> PLL_VPLL>; + assigned-clock-rates = <12>, <2>,
> <5>; +};
Attachment seem to work and for this I also have the attached patch in my
patch set.
IIRC without it you get an error in dmesg immediately at boot up which is
visible on the PT2 *if* you have immediate visual output (which is not (yet?)
the case in my image/kernel).
Cheers,
Diederik>From d782a64f3b51ffb2f33d3ba3e11e2ebc416542e3 Mon Sep 17 00:00:00 2001
From: Jonas Karlman
Date: Thu, 17 Aug 2023 17:52:47 +0200
Subject: [PATCH 6/8] arm64: dts: rk3566-pinetab2: Fix cru assigned clocks
Jonas Karlman provided/linked to the patch on IRC.
Seems related to upstream commit 64b69474edf3b885c19a89bb165f978ba1b4be00.
Signed-off-by: Diederik de Haas
Link: https://github.com/Kwiboo/u-boot-rockchip/blob/rk3568-2023.10/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi#L11-L15
Link: https://lore.kernel.org/all/20230110225547.1563119-2-jo...@kwiboo.se/
---
arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index bbd7ed53602a..4a5bee5a28a7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -288,8 +288,9 @@ {
};
{
- assigned-clocks = < PLL_GPLL>, < PLL_PPLL>, < PLL_VPLL>;
- assigned-clock-rates = <12>, <2>, <5>;
+ assigned-clocks = < CLK_RTC_32K>, < PLL_GPLL>, < PLL_PPLL>, < PLL_VPLL>;
+ assigned-clock-rates = <32768>, <12>, <2>, <5>;
+ assigned-clock-parents = < CLK_RTC32K_FRAC>;
};
_dphy {
--
2.42.0
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH 4/6] arm64: dts: rockchip: Add devicetree for Pine64 Pinetab2
On Friday, 22 December 2023 12:05:44 CET Manuel Traut wrote:
> + rk817-sound {
> + compatible = "simple-audio-card";
> + pinctrl-names = "default";
> + pinctrl-0 = <_det_l>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,name = "PineTab2";
> + simple-audio-card,mclk-fs = <256>;
> +
> + simple-audio-card,widgets =
> + "Microphone", "Mic Jack",
> + "Headphone", "Headphones",
> + "Microphone", "Microphone",
> + "Speaker", "Speakers";
> +
> + simple-audio-card,routing =
> + "MICL", "Microphone",
> + "MICR", "Mic Jack",
> + "Headphones", "HPOL",
> + "Headphones", "HPOR",
> + "Speaker Amplifier INL", "HPOL",
> + "Speaker Amplifier INR", "HPOR",
> + "Speakers", "Speaker Amplifier OUTL",
> + "Speakers", "Speaker Amplifier OUTR";
> +
> + simple-audio-card,hp-det-gpio = < RK_PC6
> GPIO_ACTIVE_HIGH>; + simple-audio-card,aux-devs =
> <_amp>;
> + simple-audio-card,pin-switches = "Speakers", "Microphone";
> +
> + simple-audio-card,cpu {
> + sound-dai = <_8ch>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <>;
> + };
> + };
Not sure if it's right (or allowed) to post a different patch as attachment,
but I have been using a different audio configuration (see attachment).
I haven't yet tried if/how it works via HDMI yet, but the speakers and
headphones work fine.
This patch is based on the following commit:
https://github.com/TuxThePenguin0/linux/commit/
872b829a3511cfa853bd3af3bd4f30be1cb3d1ab
I've added 'Danct12' to the To list as they are the maintainer of the primary
PT2 image and we worked together to get to this audio config.
I don't if they still use it.
(I've been using my own kernel/image for a while now).
Cheers,
Diederik>From 17efeb0ae766886345ff0574c534079742539b56 Mon Sep 17 00:00:00 2001
From: Scott Santucci
Date: Mon, 17 Jul 2023 13:06:20 +0200
Subject: [PATCH 3/8] arm64: dts: rk3566-pinetab2: Fix audio configuration
The audio configuration of the PineTab2 matches the `rk817_ext` alsa
ucm2 profile, so switch the configuration to that. Use `rk817_ext` and
not `rk817_int` as the PineTab2 uses an external amplifier.
Also the headphones plugged/unplugged detection is backwards, so apply
the fix provided by Danct12 .
Signed-off-by: Diederik de Haas
Link: https://github.com/dreemurrs-embedded/Pine64-Arch/pull/555
---
arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index a766f21bd6f8..59e4bf2f77c7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -116,14 +116,14 @@ rk817-sound {
pinctrl-names = "default";
pinctrl-0 = <_det_l>;
simple-audio-card,format = "i2s";
- simple-audio-card,name = "PineTab2";
+ simple-audio-card,name = "rk817_ext";
simple-audio-card,mclk-fs = <256>;
simple-audio-card,widgets =
"Microphone", "Mic Jack",
"Headphone", "Headphones",
"Microphone", "Microphone",
- "Speaker", "Speakers";
+ "Speaker", "Internal Speakers";
simple-audio-card,routing =
"MICL", "Microphone",
@@ -132,12 +132,12 @@ rk817-sound {
"Headphones", "HPOR",
"Speaker Amplifier INL", "HPOL",
"Speaker Amplifier INR", "HPOR",
- "Speakers", "Speaker Amplifier OUTL",
- "Speakers", "Speaker Amplifier OUTR";
+ "Internal Speakers", "Speaker Amplifier OUTL",
+ "Internal Speakers", "Speaker Amplifier OUTR";
- simple-audio-card,hp-det-gpio = < RK_PC6 GPIO_ACTIVE_HIGH>;
+ simple-audio-card,hp-det-gpio = < RK_PC6 GPIO_ACTIVE_LOW>;
simple-audio-card,aux-devs = <_amp>;
- simple-audio-card,pin-switches = "Speakers", "Microphone";
+ simple-audio-card,pin-switches = "Internal Speakers", "Microphone";
simple-audio-card,cpu {
sound-dai = <_8ch>;
--
2.42.0
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH 0/6] arm64: rockchip: Pine64 pinetab2 support
On Friday, 22 December 2023 12:05:40 CET Manuel Traut wrote: > [3] > https://salsa.debian.org/Mobian-team/devices/kernels/rockchip-linux/-/blob/ > mobian-6.6/debian/patches/display/0018-drm-panel-add-BOE-TH101MB31IG002-28A- > driver.patch?ref_type=heads > [4] > https://salsa.debian.org/Mobian-team/devices/kernels/rockchip-linux/-/blob/ > mobian-6.6/debian/patches/device-tree/0134-arch-arm64-add-Pine64-PineTab2-de > vice-trees.patch?ref_type=heads FWIW I believe the actual sources are from https://github.com/TuxThePenguin0/linux/commits/device/pine64-pinetab2_stable signature.asc Description: This is a digitally signed message part.
Re: [PATCH 1/6] dt-bindings: display: panel: Add BOE TH101MB31IG002-28A panel
On Friday, 22 December 2023 12:05:41 CET Manuel Traut wrote: > +title: BOE TH101MB31IG002-28A Pine64 Pinetab2 DSI Display Panel s/Pine64 Pinetab2 // ? It is used by the PT2 but I assume it's a 'standalone' panel? signature.asc Description: This is a digitally signed message part.
Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full
On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote: > Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 > and RK3399 result in wrong colors being displayed. > > The issue can be observed using modetest: > > modetest -s @:1920x1080-60@RG24 > modetest -s @:1920x1080-60@BG24 On my Rock64 (rk3328) I was able to see the problem without this patch and see it displaying correctly with it, so Tested-by: Diederik de Haas signature.asc Description: This is a digitally signed message part.
Re: Bug#1042753: nouveau bug in linux/6.1.38-2
On Friday, 4 August 2023 15:11:46 CEST Olaf Skibbe wrote: > (On the occasion a maybe silly question: am I right assuming that the > kernel has to be build on the machine we want to reproduce the bug on? > Otherwise it could use much faster hardware (running also bookworm).) If that is also an amd64 machine running Debian kernel 6.1.38-2, it should be fine to build the kernel on the faster machine. signature.asc Description: This is a digitally signed message part.
Re: [PATCH] agp/amd64: Fix full name of the GPL
On Sunday, 22 January 2023 20:49:22 CET Christophe JAILLET wrote: > Le 22/01/2023 à 19:16, Diederik de Haas a écrit : > > Signed-off-by: Diederik de Haas > > --- > > > > drivers/char/agp/amd64-agp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c > > index ce8651436609..3020fd92fd00 100644 > > --- a/drivers/char/agp/amd64-agp.c > > +++ b/drivers/char/agp/amd64-agp.c > > @@ -1,7 +1,7 @@ > > > > // SPDX-License-Identifier: GPL-2.0-only > > /* > > > >* Copyright 2001-2003 SuSE Labs. > > > > - * Distributed under the GNU public license, v2. > > + * Distributed under the GNU General Public License, v2. > > > >* > >* This is a GART driver for the AMD Opteron/Athlon64 on-CPU > >northbridge. > >* It also includes support for the AMD 8151 AGP bridge, > > maybe the line can just be removed. > There is already a SPDX-License-Identifier above. Hi, That does sound reasonable, but I'm now seeing it as a legal issue [1] and no longer as a spelling one. Strictly speaking it seems there is a discrepancy between the SPDX identifier and the 'full' license statement. While it may be reasonable to *assume* the "GNU General Public License, v2" was meant, when it comes to license/legal stuff, I think that does not suffice. So I'd like to retract my patch submission and want to leave it up to people who are in a position to resolve this issue, if that needs to be done. Apologies for the noise. Diederik [1] https://lore.kernel.org/lkml/ad99d227-ce82-319b-6323-b70ac009d...@roeck-us.net/ signature.asc Description: This is a digitally signed message part.
[PATCH] agp/amd64: Fix full name of the GPL
Signed-off-by: Diederik de Haas --- drivers/char/agp/amd64-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c index ce8651436609..3020fd92fd00 100644 --- a/drivers/char/agp/amd64-agp.c +++ b/drivers/char/agp/amd64-agp.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /* * Copyright 2001-2003 SuSE Labs. - * Distributed under the GNU public license, v2. + * Distributed under the GNU General Public License, v2. * * This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge. * It also includes support for the AMD 8151 AGP bridge, -- 2.39.0
Re: Bug#1005005: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?
On maandag 21 maart 2022 19:49:56 CET Dominique Dumont wrote: > On Monday, 21 March 2022 09:57:59 CET Thorsten Leemhuis wrote: > > Dominique/Salvatore/Eric, what's the status of this regression? > > According to the debian bug tracker the problem is solved with 5.16 and > > 5.17, but was 5.15 ever fixed? > > I don't think so. > > On kernel side, the commit fixing this issue is > e55a3aea418269266d84f426b3bd70794d3389c8 . > > According to the logs of [1] , this commit landed in v5.17-rc3 It was included in 5.15.22, but the newest 5.15 kernel uploaded to Debian was 5.15.15, so their is no fixed 5.15 in Debian. It was also included in 5.16.8 and the earlier version in Debian which had that commit was 5.16.10 (uploaded 2022-02-18 to Unstable). Current version in Unstable is 5.16.14. Testing/Bookworm now had 5.16.12. In Experimental, on 2022-02-12, 5.17-rc3 was uploaded. HTH, Diederik signature.asc Description: This is a digitally signed message part.
