RE: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

[Keller, Jacob E]

> -Original Message-
> From: Julien Panis 
> Sent: Friday, April 12, 2024 7:02 AM
> To: Keller, Jacob E ; David S. Miller
> ; Eric Dumazet ; Jakub Kicinski
> ; Paolo Abeni ; Russell King
> ; Alexei Starovoitov ; Daniel Borkmann
> ; Jesper Dangaard Brouer ; John
> Fastabend ; Sumit Semwal
> ; Christian König ; Simon
> Horman ; Andrew Lunn ; Ratheesh
> Kannoth ; Naveen Mamindlapalli
> 
> Cc: danishan...@ti.com; yuehaib...@huawei.com; rog...@kernel.org;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org; b...@vger.kernel.org; 
> linux-
> me...@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm-
> s...@lists.linaro.org
> Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW
> Ethernet driver
> 
> On 4/10/24 01:51, Jacob Keller wrote:
> >
> > On 4/8/2024 2:38 AM, Julien Panis wrote:
> >> This patch adds XDP support to TI AM65 CPSW Ethernet driver.
> >>
> >> The following features are implemented: NETDEV_XDP_ACT_BASIC,
> >> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT.
> >>
> >> Zero-copy and non-linear XDP buffer supports are NOT implemented.
> >>
> >> Besides, the page pool memory model is used to get better performance.
> >>
> >> Signed-off-by: Julien Panis 
> >> ---
> > Reviewed-by: Jacob Keller 
> 
> Thank you for your review Jacob.
> I'll add your 'Reviewed-by' tag for PATCH 1/3 in next version. Unfortunately,
> I will not for PATCH 2/3 and 3/3 because there will be too many changes,
> following Jakub's comments.

Sounds good. Feel free to CC me on the next version too and I can review the 
new changes 

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

[Keller, Jacob E]

On Fri, 2014-07-18 at 09:28 -0700, James Bottomley wrote:
> On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
> 
> What kernel coding style?  checkpatch isn't the arbiter of style, if
> that's the only problem.
> 
> The DEFINE_PCI macro was a well reasoned addition when it was added in
> 2008.  The problem was most people were getting the definition wrong.
> When we converted away from CONFIG_HOTPLUG, having this DEFINE_ meant
> that only one place needed changing instead of hundreds for PCI tables.
> 
> The reason people were getting the PCI table wrong was mostly the init
> section specifiers which are now gone, but it has enough underlying
> utility (mostly constification) that I don't think we'd want to churn
> the kernel hugely to make a change to struct pci_table and then have to
> start detecting and fixing misuses.
> 
> James
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I would rather fix the misuses of the macro, than remove it. Could we
possibly make checkpatch smart enough to tell when the macro is misused?

Thanks,
Jake