Re: [PATCH 3/5] drm/bridge: tc358762: Instruct DSI host to generate HSE packets
Hey Marek,
On 15.06.2023 22:19:00, Marek Vasut wrote:
> This bridge seems to need the HSE packet, otherwise the image is
> shifted up and corrupted at the bottom. This makes the bridge
> work with Samsung DSIM on i.MX8MM and i.MX8MP.
I'm using v6.6 (which includes this series) on an i.MX8MP with the 7inch
Rspi Panel ("powertip,ph800480t013-idf02"), but I cannot get a stable
image.
With an unmodified imx8mp clock tree the lower 1/4 of the image sheers
to the left.
With 24.75 MHz on the media_disp1_pix and media_mipi_phy1_ref and 792
MHz on video_pll1_out, the image is not static, but wobbly and it's
wrapped around half of the image.
video_pll1_ref_sel1102400
0 0 5 Y
video_pll1 110 79200
0 0 5 Y
video_pll1_bypass 110 79200
0 0 5 Y
video_pll1_out 220 79200
0 0 5 Y
media_mipi_phy1_ref 1102475
0 0 5 Y
media_mipi_phy1_ref_root 000
2475 0 0 5 Y
media_disp2_pix 000 79200
0 0 5 N
media_disp2_pix_root_clk 000
79200 0 0 5 N
media_disp1_pix 1102475
0 0 5 Y
media_disp1_pix_root_clk 110
2475 0 0 5 Y
Do you have a working device tree for such a setup? regards, Marc
Relevant DT snipped for my setup:
&{/} {
panel {
compatible = "powertip,ph800480t013-idf02";
power-supply = <>;
backlight = <>;
port {
panel_in: endpoint {
remote-endpoint = <_out>;
};
};
};
};
_dsi {
samsung,esc-clock-frequency = <5400>;
assigned-clock-parents = < IMX8MP_SYS_PLL1_800M>,
< IMX8MP_VIDEO_PLL1_OUT>;
assigned-clock-rates = <2>, <2475>;
status = "okay";
bridge@0 {
compatible = "toshiba,tc358762";
reg = <0>;
vddc-supply = <>;
reset-gpio = < 0 0>;
ports {
#address-cells = <1>;
#size-cells = <0>;
port@0 {
reg = <0>;
bridge_in: endpoint {
remote-endpoint = <_out>;
};
};
port@1 {
reg = <1>;
bridge_out: endpoint {
remote-endpoint = <_in>;
};
};
};
};
ports {
#address-cells = <1>;
#size-cells = <0>;
port@1 {
reg = <1>;
dsi_out: endpoint {
data-lanes = <1 2>;
remote-endpoint = <_in>;
};
};
};
};
_blk_ctrl {
assigned-clock-rates = <5>, <2>,
<0>, <0>, <79200>;
};
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
signature.asc
Description: PGP signature
Re: [PATCH] phy: Explicitly include correct DT includes
On 14.07.2023 11:48:35, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > drivers/phy/phy-can-transceiver.c | 1 + Acked-by: Marc Kleine-Budde # for drivers/phy/phy-can-transceiver.c regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | signature.asc Description: PGP signature
Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples
On 28.02.2023 15:54:33, Rob Herring wrote:
> SPI and I2C bus node names are expected to be "spi" or "i2c",
> respectively, with nothing else, a unit-address, or a '-N' index. A
> pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these
> cases. Mostly scripted with the following commands:
>
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/i2c[0-9] {/i2c {/'
> git grep -l '\sspi[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/spi[0-9] {/spi {/'
>
> With this, a few errors in examples were exposed and fixed.
>
> Signed-off-by: Rob Herring
> ---
> Cc: Miguel Ojeda
> Cc: Krzysztof Kozlowski
> Cc: Benson Leung
> Cc: Guenter Roeck
> Cc: Stephen Boyd
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Robert Foss
> Cc: Thierry Reding
> Cc: Sam Ravnborg
> Cc: MyungJoo Ham
> Cc: Chanwoo Choi
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Pavel Machek
> Cc: Lee Jones
> Cc: Mauro Carvalho Chehab
> Cc: "David S. Miller"
> Cc: Eric Dumazet
> Cc: Jakub Kicinski
> Cc: Paolo Abeni
> Cc: Wolfgang Grandegger
> Cc: Kalle Valo
> Cc: Sebastian Reichel
> Cc: Mark Brown
> Cc: Greg Kroah-Hartman
> Cc: linux-...@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-g...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-l...@vger.kernel.org
> Cc: linux-me...@vger.kernel.org
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-wirel...@vger.kernel.org
> Cc: linux...@vger.kernel.org
> Cc: alsa-de...@alsa-project.org
> Cc: linux-...@vger.kernel.org
> ---
> .../bindings/net/can/microchip,mcp251xfd.yaml | 2 +-
Acked-by: Marc Kleine-Budde # for the
microchip,mcp251xfd.yaml
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
signature.asc
Description: PGP signature
Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()
On 27.09.2022 13:12:35, Stefan Wahren wrote: > > > > yes the issue is only triggered without HDMI connected. I was able to > > > > reproduce with an older vc4 firmware from 2020 (don't want to upgrade > > > > yet). > > > > Kernel was also an arm64 build with defconfig. > > > > > > > > Here some rough starting point for bisection: > > > > > > > > 5.18.0 good > > > > 5.19.0 bad > > > > 5.19.6 bad > > > Sorry it took a bit of time, it looks like I found another bug while > > > trying to test this yesterday. > > > > > > Your datapoints are interesting though. I have a custom configuration > > > and it does boot 5.19 without an HDMI connected. > > > > > > So I guess it leaves us with either the firmware version being different > > > (I'm using a newer version, from March 2022), or the configuration. I'll > > > test with defconfig. > > So it turns out compiling vc4 as a module is the culprit. > > Do you mean regardless of the kernel version in your case? On Debian vc4 is a module, too, both on 5.18.x (good) and 5.19.6 (bad). > In my test cases i build vc4 always as module. > > > It's not clear to me why at this point, but the first register write in > > vc4_hdmi_reset stalls. > > Sounds like timing issue or a missing dependency (clock or power domain) Here it fails 100%, regardless if the module is automatically loaded by udev or later on an idle system via insmod. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()
On 26.09.2022 14:08:04, Stefan Wahren wrote: > Hi Marc, > > Am 26.09.22 um 12:21 schrieb Marc Kleine-Budde: > > On 22.09.2022 17:06:00, Maxime Ripard wrote: > > > > I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, > > > > using Debian's v5.19 kernel (Debian's v5.18 was working flawless). > > > > > > > > | [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] > > > > | [0.00] Linux version 5.19.0-1-arm64 > > > > (debian-ker...@lists.debian.org) (gcc-11 (Debian 11.3.0-5) 11.3.0, GNU > > > > ld (GNU Binutils for Debian) 2.38.90.20220713) #1 SMP Debian 5.19.6-1 > > > > (2022-0 > > > > 9-01) > > > > | [0.00] Machine model: Raspberry Pi 3 Model B+ > > > > | [3.747500] raspberrypi-firmware soc:firmware: Attached to > > > > firmware from 2022-03-24T13:21:11 > > > > > > > > As soon a the vc4 module is loaded the following warnings hits 4 > > > > times, then the machine stops. > > [...] > > > > > The warning itself is fixed, both upstream and in stable (5.19.7). > > Ok. Debian is using 5.19.6 > > > > > It shouldn't have any relation to the hang though. Can you share your > > > setup? > > - config.txt: > > > > >8>8>8>8 > > gpu_mem=16 > > disable_splash=1 > > > > arm_64bit=1 > > enable_uart=1 > > uart_2ndstage=1 > > > > os_prefix=/u-boot/ > > > > [pi3] > > force_turbo=1 > > >8>8>8>8 > > > > - Raspberry Pi 3 Model B+ > > - no HDMI connected > > Does it mean, the issue only occurs without HDMI connected? > If you didn't test with HDMI yet, could you please do? The error occurs with HDMI not connected, as vc4 is the gfx driver I thought this might be of interest. :) I don't have a HDMI monitor here, but I'll come back to you as soon as I get access to one (might take some time). Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()
On 22.09.2022 17:06:00, Maxime Ripard wrote: > > I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, > > using Debian's v5.19 kernel (Debian's v5.18 was working flawless). > > > > | [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] > > > > > > | [0.00] Linux version 5.19.0-1-arm64 > > (debian-ker...@lists.debian.org) (gcc-11 (Debian 11.3.0-5) 11.3.0, GNU ld > > (GNU Binutils for Debian) 2.38.90.20220713) #1 SMP Debian 5.19.6-1 (2022-0 > > 9-01) > > > > > > | [0.00] Machine model: Raspberry Pi 3 Model B+ > > | [3.747500] raspberrypi-firmware soc:firmware: Attached to firmware > > from 2022-03-24T13:21:11 > > > > As soon a the vc4 module is loaded the following warnings hits 4 > > times, then the machine stops. [...] > The warning itself is fixed, both upstream and in stable (5.19.7). Ok. Debian is using 5.19.6 > It shouldn't have any relation to the hang though. Can you share your > setup? - config.txt: >8>8>8>8 gpu_mem=16 disable_splash=1 arm_64bit=1 enable_uart=1 uart_2ndstage=1 os_prefix=/u-boot/ [pi3] force_turbo=1 >8>8>8>8 - Raspberry Pi 3 Model B+ - no HDMI connected - firmware 2022-03-24T13:21:11 which boot u-boot: - u-boot 2022.04+dfsg-2+b1 (Debian testing) I'm using the "/usr/lib/u-boot/rpi_3/u-boot.bin" u-boot start: - Linux version 5.19.0-1-arm64 (debian-ker...@lists.debian.org) kernel and dtb are unmodified Debian's linux-image-5.19.0-1-arm64 $ ls -l /boot/dtbs/5.19.0-1-arm64/broadcom/bcm2837-rpi-3-b-plus.dtb -rwxr-xr-x 1 root root 15351 Sep 22 09:52 /boot/dtbs/5.19.0-1-arm64/broadcom/bcm2837-rpi-3-b-plus.dtb* $ md5sum /boot/dtbs/5.19.0-1-arm64/broadcom/bcm2837-rpi-3-b-plus.dtb 4a9c76c3c4dcafac7d69872ee88ac5fc /boot/dtbs/5.19.0-1-arm64/broadcom/bcm2837-rpi-3-b-plus.dtb - currently, I've blacklisted vc4, but systems hangs after modprobe vc4 (4x backtrace, then hang) regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()
] invoke_syscall+0x50/0x120 | [ 67.204766] el0_svc_common.constprop.0+0x4c/0x100 | [ 67.209626] do_el0_svc+0x3c/0xd0 | [ 67.212987] el0_svc+0x3c/0x100 | [ 67.216174] el0t_64_sync_handler+0xbc/0x140 | [ 67.220502] el0t_64_sync+0x18c/0x190 | [ 67.224216] ---[ end trace ]--- | [ 67.228942] [ cut here ] Is this a known problem? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Re: [PATCH] dt-bindings: Drop redundant 'maxItems/minItems' in if/then schemas
On 03.05.2022 11:27:38, Rob Herring wrote: > Another round of removing redundant minItems/maxItems when 'items' list is > specified. This time it is in if/then schemas as the meta-schema was > failing to check this case. > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > .../bindings/net/can/bosch,c_can.yaml | 3 --- For net/can: Acked-by: Marc Kleine-Budde regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Re: [PATCH v2 59/63] can: flexcan: Use struct_group() to zero struct flexcan_regs regions
On 17.08.2021 23:05:29, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add struct_group() to mark both regions of struct flexcan_regs that get > initialized to zero. Avoid the future warnings: > > In function 'fortify_memset_chk', > inlined from 'memset_io' at ./include/asm-generic/io.h:1169:2, > inlined from 'flexcan_ram_init' at drivers/net/can/flexcan.c:1403:2: > ./include/linux/fortify-string.h:199:4: warning: call to > '__write_overflow_field' declared with attribute warning: detected write > beyond size of field (1st parameter); maybe use struct_group()? > [-Wattribute-warning] > 199 |__write_overflow_field(p_size_field, size); > |^~ > In function 'fortify_memset_chk', > inlined from 'memset_io' at ./include/asm-generic/io.h:1169:2, > inlined from 'flexcan_ram_init' at drivers/net/can/flexcan.c:1408:3: > ./include/linux/fortify-string.h:199:4: warning: call to > '__write_overflow_field' declared with attribute warning: detected write > beyond size of field (1st parameter); maybe use struct_group()? > [-Wattribute-warning] > 199 |__write_overflow_field(p_size_field, size); > |^~~~~~~~~~ > > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-...@vger.kernel.org > Cc: net...@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Marc Kleine-Budde > - memset_io(>mb[0][0], 0, > - offsetof(struct flexcan_regs, rx_smb1[3]) - > - offsetof(struct flexcan_regs, mb[0][0]) + 0x4); > + memset_io(>init, 0, sizeof(regs->init)); This even makes the code more readable! \o/ > if (priv->can.ctrlmode & CAN_CTRLMODE_FD) > - memset_io(>tx_smb_fd[0], 0, > - offsetof(struct flexcan_regs, rx_smb1_fd[17]) - > - offsetof(struct flexcan_regs, tx_smb_fd[0]) + 0x4); > + memset_io(>init_fd, 0, sizeof(regs->init_fd)); > > reg_ctrl2 &= ~FLEXCAN_CTRL2_WRMFRZ; > priv->write(reg_ctrl2, >ctrl2); regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On 15.06.2021 13:15:43, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. [...] > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 -- Acked-by: Marc Kleine-Budde regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature
[PATCH] drm/etnaviv: dump: fix sparse warnings
This patch fixes the following sparse warnings, by adding the missing endianess
conversion functions.
| etnaviv/etnaviv_dump.c:78:26: warning: restricted __le32 degrades to integer
| etnaviv/etnaviv_dump.c:88:26: warning: incorrect type in assignment
(different base types)
| etnaviv/etnaviv_dump.c:88:26:expected restricted __le32 [usertype] reg
| etnaviv/etnaviv_dump.c:88:26:got unsigned short const
| etnaviv/etnaviv_dump.c:89:28: warning: incorrect type in assignment
(different base types)
| etnaviv/etnaviv_dump.c:89:28:expected restricted __le32 [usertype] value
| etnaviv/etnaviv_dump.c:89:28:got unsigned int
| etnaviv/etnaviv_dump.c:210:43: warning: incorrect type in assignment
(different base types)
| etnaviv/etnaviv_dump.c:210:43:expected restricted __le32
| etnaviv/etnaviv_dump.c:210:43:got long
Signed-off-by: Marc Kleine-Budde
---
drivers/gpu/drm/etnaviv/etnaviv_dump.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
index 706af0304ca4..f418e0b75772 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
@@ -75,7 +75,7 @@ static void etnaviv_core_dump_header(struct
core_dump_iterator *iter,
hdr->file_size = cpu_to_le32(data_end - iter->data);
iter->hdr++;
- iter->data += hdr->file_size;
+ iter->data += le32_to_cpu(hdr->file_size);
}
static void etnaviv_core_dump_registers(struct core_dump_iterator *iter,
@@ -85,8 +85,8 @@ static void etnaviv_core_dump_registers(struct
core_dump_iterator *iter,
unsigned int i;
for (i = 0; i < ARRAY_SIZE(etnaviv_dump_registers); i++, reg++) {
- reg->reg = etnaviv_dump_registers[i];
- reg->value = gpu_read(gpu, etnaviv_dump_registers[i]);
+ reg->reg = cpu_to_le32(etnaviv_dump_registers[i]);
+ reg->value = cpu_to_le32(gpu_read(gpu,
etnaviv_dump_registers[i]));
}
etnaviv_core_dump_header(iter, ETDUMP_BUF_REG, reg);
@@ -207,7 +207,7 @@ void etnaviv_core_dump(struct etnaviv_gem_submit *submit)
if (!IS_ERR(pages)) {
int j;
- iter.hdr->data[0] = bomap - bomap_start;
+ iter.hdr->data[0] = cpu_to_le32((bomap - bomap_start));
for (j = 0; j < obj->base.size >> PAGE_SHIFT; j++)
*bomap++ = cpu_to_le64(page_to_phys(*pages++));
--
2.29.2
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 11/12] MAINTAINERS: add Lucas Stach as maintainer for the etnaviv DRM driver
On 12/04/2015 06:07 PM, Russell King - ARM Linux wrote: > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote: >> Signed-off-by: Lucas Stach > > Acked-by: Russell King <rmk+kernel at arm.linux.org.uk> > > Although, I would like to be copied on patches, I don't think we > have a way to encode that information in MAINTAINERS. I think you can just add another "M: Russell King " next to Lucas. We have this for the CAN drivers and it seems to work. > >> --- >> MAINTAINERS | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e9caa4b28828..1c69563c61ed 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -3741,6 +3741,13 @@ S:Maintained >> F: drivers/gpu/drm/sti >> F: Documentation/devicetree/bindings/display/st,stih4xx.txt >> >> +DRM DRIVERS FOR VIVANTE GPU IP >> +M: Lucas Stach >> +L: dri-devel at lists.freedesktop.org >> +S: Maintained >> +F: drivers/gpu/drm/etnaviv >> +F: Documentation/devicetree/bindings/display/etnaviv >> + >> DSBR100 USB FM RADIO DRIVER >> M: Alexey Klimov >> L: linux-media at vger.kernel.org >> -- >> 2.6.2 >> > Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 455 bytes Desc: OpenPGP digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20151204/6e853db6/attachment-0001.sig>
[PATCH] imx-drm: imx-drm-core: add suspend/resume support
On 07/24/2014 11:47 AM, Lucas Stach wrote: > Am Donnerstag, den 24.07.2014, 17:17 +0800 schrieb Shawn Guo: >> HDMI currently stops working after a system suspend/resume cycle. It >> turns out that the cause is the imx-hdmi encoder .dpms hook doesn't get >> called from anywhere across suspend/resume cycle. >> >> The patch follows what exynos drm driver does to walk the list of >> connectors and call their .dpms function from suspend/resume hook. And >> the connectors' .dpms function will in turn filter down to the .dpms >> hooks of encoders and CRTCs. >> >> With this change, HDMI can continue working after a suspend/resume >> cycle. >> >> Signed-off-by: Shawn Guo >> --- >> Tested with HDMI and LVDS. It'd be great if someone can help test TVE >> to ensure the patch doesn't break anything. >> >> drivers/staging/imx-drm/imx-drm-core.c | 39 >> ++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/drivers/staging/imx-drm/imx-drm-core.c >> b/drivers/staging/imx-drm/imx-drm-core.c >> index def8280d7ee6..b0ea1f0ed32f 100644 >> --- a/drivers/staging/imx-drm/imx-drm-core.c >> +++ b/drivers/staging/imx-drm/imx-drm-core.c >> @@ -696,6 +696,44 @@ static int imx_drm_platform_remove(struct >> platform_device *pdev) >> return 0; >> } >> >> +#if CONFIG_PM_SLEEP > > use #ifdef ...or remove #if/#ifdef and mark as __maybe_unused Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 242 bytes Desc: OpenPGP digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140724/453066e7/attachment-0001.sig>
