Re: [PATCH 4.9.y 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally

2017-11-07 Thread Nhan Ngoc. Nguyen 

On 11/6/2017 2:57 PM, Greg KH wrote:

On Fri, Nov 03, 2017 at 10:10:26AM +0700, Nhan Nguyen wrote:

From: John Stultz 

commit 651e4769ba2a9f20c4b8a823ae2727bf7fa9c9f0 upstream.

In chasing down issues with EDID probing, I found some
duplicated but incomplete logic used to power the chip on and
off.

This patch refactors the adv7511_power_on/off functions, so
they can be used for internal needs.

Cc: David Airlie 
Cc: Archit Taneja 
Cc: Wolfram Sang 
Cc: Lars-Peter Clausen 
Cc: Laurent Pinchart 
Cc: dri-devel@lists.freedesktop.org
Cc: sta...@vger.kernel.org
Signed-off-by: John Stultz 
Signed-off-by: Archit Taneja 
Signed-off-by: Thong Ho 
Signed-off-by: Nhan Nguyen 
Link: 
http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-5-git-send-email-john.stu...@linaro.org
---
  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 15 +++
  1 file changed, 11 insertions(+), 4 deletions(-)

Why are you asking for these 3 patches to be backported to the 4.9
stable tree?  What bugs are they fixing?  How do they meet the stable
kernel rules?

totally confused,

greg k-h


This patch is re-writes the i2c address to ADV7511_REG_EDID_I2C_ADDR register 
to ensure its properly set before reading the EDID data.
In the past, the backporting is for Kernel v4.4 and you asked to port for 4.9 
also.




___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4.4.y] drm: adv7511: Re-write the i2c address before EDID probing

2017-09-09 Thread Nhan Ngoc. Nguyen 

This patch is ported from linux stable 4.9, commit 
3587c856675c45809010c2cee5b21096f6e8e938.
So I think I don't need to port on version 4.9.

On 9/8/2017 2:21 PM, Greg KH wrote:

On Fri, Sep 08, 2017 at 09:46:02AM +0700, Nhan Nguyen wrote:

commit 3587c856675c45809010c2cee5b21096f6e8e938 upstream.

I've found that by just turning the chip on and off via the
POWER_DOWN register, I end up getting i2c_transfer errors on
HiKey.

Investigating further, it turns out that some of the register
state in hardware is getting lost, as the device registers are
reset when the chip is powered down.

Thus this patch simply re-writes the i2c address to the
ADV7511_REG_EDID_I2C_ADDR register to ensure its properly set
before we try to read the EDID data.

Cc: David Airlie 
Cc: Archit Taneja 
Cc: Wolfram Sang 
Cc: Lars-Peter Clausen 
Cc: Laurent Pinchart 
Cc: dri-devel@lists.freedesktop.org
Cc: sta...@vger.kernel.org
Reviewed-by: Laurent Pinchart 
Tested-by: Laurent Pinchart 
Signed-off-by: John Stultz 
Signed-off-by: Archit Taneja 
Signed-off-by: Thong Ho 
Signed-off-by: Nhan Nguyen 
Link: 
http://patchwork.freedesktop.org/patch/msgid/1484614372-15342-7-git-send-email-john.stu...@linaro.org
---
  drivers/gpu/drm/i2c/adv7511.c | 11 +++
  1 file changed, 7 insertions(+), 4 deletions(-)

Can you provide a working backport for the 4.9-stable kernel as well?

Also, please do not send backports for patches that do not also work in
newer stable kernels, like 4.9, I backported some of this series there,
but I shouldn't have to check for you.

thanks,

greg k-h


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel