[PATCH] drm/radeon/kms: fix i2c map for rv250/280

[Thierry Vignaud]

On 23 July 2011 20:02,   wrote:
> From: Alex Deucher 
>
> Those chips have crt2_ddc bus.

Maybe adding a comment in the code'll make sure nobody will ever "clean up" or
"optimize" the tests by replacing them back by "else if (rdev->family
>= CHIP_R200)"...

> - ? ? ? } else if (rdev->family >= CHIP_R200) {
> + ? ? ? } else if ((rdev->family == CHIP_R200) ||
> + ? ? ? ? ? ? ? ? ?(rdev->family >= CHIP_R300)) {
> ? ? ? ? ? ? ? ?/* 0x68 */
> ? ? ? ? ? ? ? ?i2c = combios_setup_i2c_bus(rdev, DDC_MONID, 0, 0);
> ? ? ? ? ? ? ? ?rdev->i2c_bus[3] = radeon_i2c_create(dev, , "MONID");

My 2 cents

Re: [PATCH] drm/radeon/kms: fix i2c map for rv250/280

[Thierry Vignaud]

On 23 July 2011 20:02,  alexdeuc...@gmail.com wrote:
 From: Alex Deucher alexander.deuc...@amd.com

 Those chips have crt2_ddc bus.

Maybe adding a comment in the code'll make sure nobody will ever clean up or
optimize the tests by replacing them back by else if (rdev-family
= CHIP_R200)...

 -       } else if (rdev-family = CHIP_R200) {
 +       } else if ((rdev-family == CHIP_R200) ||
 +                  (rdev-family = CHIP_R300)) {
                /* 0x68 */
                i2c = combios_setup_i2c_bus(rdev, DDC_MONID, 0, 0);
                rdev-i2c_bus[3] = radeon_i2c_create(dev, i2c, MONID);

My 2 cents
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] fix mesa build from tarball

[Thierry Vignaud]

Hi

The following patch fixes building mesa from tarball (generated from git):
- one Makefile disappeared (Makefile.template)
- two other were missing (src/mesa/drivers/dri/Makefile.{defines,targets}

Please apply
Thx
-- next part --
A non-text attachment was scrubbed...
Name: fix-build-from-tarball.diff
Type: application/octet-stream
Size: 543 bytes
Desc: not available
URL: 

[PATCH] fix mesa build from tarball

[Thierry Vignaud]

Hi

The following patch fixes building mesa from tarball (generated from git):
- one Makefile disappeared (Makefile.template)
- two other were missing (src/mesa/drivers/dri/Makefile.{defines,targets}

Please apply
Thx


fix-build-from-tarball.diff
Description: Binary data
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

BUG: unable to handle kernel paging request at 6b6b6b6b in radeon_read_ring_rptr()

[Thierry Vignaud]

On 25 May 2011 17:43, Alex Deucher  wrote:
>> Xorg from FC14 plus linux kernel 2.6.37, 2.6.38 and 2.6.39 on x86 crashes
>> immediately upon start.
>
> Any reason you are not using kms?

Any reason you are not respecting the netiquette ?
Quoting nearly 1000 lines unrelated to your one line answer is quite rude :-(

Re: BUG: unable to handle kernel paging request at 6b6b6b6b in radeon_read_ring_rptr()

[Thierry Vignaud]

On 25 May 2011 17:43, Alex Deucher alexdeuc...@gmail.com wrote:
 Xorg from FC14 plus linux kernel 2.6.37, 2.6.38 and 2.6.39 on x86 crashes
 immediately upon start.

 Any reason you are not using kms?

Any reason you are not respecting the netiquette ?
Quoting nearly 1000 lines unrelated to your one line answer is quite rude :-(
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] fix mesa tarball creation again

[Thierry Vignaud]

On 19 April 2011 16:35, Brian  wrote:
>>> Pushed, thanks.
>>
>> Can you know commit this one that fixes missing files in the generated
>> tarball
>> so that one can build mesa out of the tarball?
>> Thx
>
> I'll commit it soon. ?Thanks.

Hi
The following patch fix tarball creation again (removed files and one
missing Makefile)
-- next part --
A non-text attachment was scrubbed...
Name: fix-tarball-again.diff
Type: text/x-patch
Size: 808 bytes
Desc: not available
URL: 

Re: [PATCH] fix mesa tarball creation again

[Thierry Vignaud]

On 19 April 2011 16:35, Brian bri...@vmware.com wrote:
 Pushed, thanks.

 Can you know commit this one that fixes missing files in the generated
 tarball
 so that one can build mesa out of the tarball?
 Thx

 I'll commit it soon.  Thanks.

Hi
The following patch fix tarball creation again (removed files and one
missing Makefile)
diff --git a/Makefile b/Makefile
index 41d1654..fd23b30 100644
--- a/Makefile
+++ b/Makefile
@@ -272,7 +272,6 @@ MAIN_FILES = \
 	$(DIRECTORY)/src/mesa/tnl_dd/*.[ch]\
 	$(DIRECTORY)/src/mesa/tnl_dd/imm/*.[ch]\
 	$(DIRECTORY)/src/mesa/tnl_dd/imm/NOTES.imm			\
-	$(DIRECTORY)/src/mesa/vf/*.[ch]	\
 	$(DIRECTORY)/src/mesa/drivers/Makefile\
 	$(DIRECTORY)/src/mesa/drivers/beos/*.cpp			\
 	$(DIRECTORY)/src/mesa/drivers/beos/Makefile			\
@@ -323,6 +322,7 @@ MAPI_FILES = \
 	$(DIRECTORY)/src/mapi/mapi/sources.mak\
 	$(DIRECTORY)/src/mapi/mapi/*.[ch]\
 	$(DIRECTORY)/src/mapi/shared-glapi/SConscript			\
+	$(DIRECTORY)/src/mapi/shared-glapi/Makefile			\
 	$(DIRECTORY)/src/mapi/vgapi/Makefile\
 	$(DIRECTORY)/src/mapi/vgapi/SConscript\
 	$(DIRECTORY)/src/mapi/vgapi/vgapi.csv\
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] fix mesa tarball creation again

[Thierry Vignaud]

On 18 April 2011 01:27, Marek Ol??k  wrote:
> Pushed, thanks.

Can you know commit this one that fixes missing files in the generated tarball
so that one can build mesa out of the tarball?
Thx
-- next part --
A non-text attachment was scrubbed...
Name: fix-missing-files-in-tarball.diff
Type: text/x-patch
Size: 755 bytes
Desc: not available
URL: 

Re: [PATCH] fix mesa tarball creation again

[Thierry Vignaud]

On 18 April 2011 01:27, Marek Olšák mar...@gmail.com wrote:
 Pushed, thanks.

Can you know commit this one that fixes missing files in the generated tarball
so that one can build mesa out of the tarball?
Thx
diff --git a/Makefile b/Makefile
index 646e152..e4796cf 100644
--- a/Makefile
+++ b/Makefile
@@ -231,6 +231,8 @@ MAIN_FILES = \
 	$(DIRECTORY)/src/glsl/Makefile.template\
 	$(DIRECTORY)/src/glsl/SConscript\
 	$(DIRECTORY)/src/glsl/*.[ch]	\
+	$(DIRECTORY)/src/glsl/*.ll	\
+	$(DIRECTORY)/src/glsl/*.yy	\
 	$(DIRECTORY)/src/glsl/*.[cly]pp	\
 	$(DIRECTORY)/src/glsl/README	\
 	$(DIRECTORY)/src/glsl/glcpp/*.[chly]\
@@ -245,6 +247,7 @@ MAIN_FILES = \
 	$(DIRECTORY)/src/mesa/depend	\
 	$(MAIN_ES_FILES)		\
 	$(DIRECTORY)/src/mesa/main/*.[chS]\
+	$(DIRECTORY)/src/mesa/main/*.cpp\
 	$(DIRECTORY)/src/mesa/main/descrip.mms\
 	$(DIRECTORY)/src/mesa/math/*.[ch]\
 	$(DIRECTORY)/src/mesa/math/descrip.mms\
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] fix mesa tarball creation again

[Thierry Vignaud]

Hi

The following patch fixes mesa tarball creation again
-- next part --
A non-text attachment was scrubbed...
Name: fix-tarball-creation.diff
Type: text/x-patch
Size: 446 bytes
Desc: not available
URL: 

[PATCH] fix mesa tarball creation again

[Thierry Vignaud]

Hi

The following patch fixes mesa tarball creation again
diff --git a/Makefile b/Makefile
index be95679..646e152 100644
--- a/Makefile
+++ b/Makefile
@@ -250,7 +250,6 @@ MAIN_FILES = \
 	$(DIRECTORY)/src/mesa/math/descrip.mms\
 	$(DIRECTORY)/src/mesa/program/*.[chly]\
 	$(DIRECTORY)/src/mesa/program/*.cpp\
-	$(DIRECTORY)/src/mesa/program/Makefile\
 	$(DIRECTORY)/src/mesa/program/descrip.mms			\
 	$(DIRECTORY)/src/mesa/swrast/*.[ch]\
 	$(DIRECTORY)/src/mesa/swrast/descrip.mms			\
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 25709] [DRI1 & DRI2] sauerbraten: broken water rendering

[Thierry Vignaud]

On 10 March 2011 19:57,   wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=25709
>
> Marek Ol??k  changed:
>
> ? ? ? ? ? What ? ?|Removed ? ? ? ? ? ? ? ? ? ? |Added
> 
> ? ? ? ? ? ? Status|NEW ? ? ? ? ? ? ? ? ? ? ? ? |RESOLVED
> ? ? ? ? Resolution| ? ? ? ? ? ? ? ? ? ? ? ? ? ?|WONTFIX
>
> --- Comment #2 from Marek Ol??k  2011-03-10 10:57:28 PST 
> ---
> Closing because r300c is no longer supported.

BTW, then r300c should be patched to warn about this in Xorg.*.log...
My 2 cents

[PATCH] drm/i915: fix corruptions on i8xx due to relaxed fencing

[Thierry Vignaud]

On 22 February 2011 18:25, Daniel Vetter  wrote:
> It looks like gen2 has a peculiar interleaved 2-row inter-tile
> layout. Probably inherited from i81x which had 2kb tiles (which
> naturally fit an even-number-of-tile-rows scheme to fit onto 4kb
> pages). There is no other mention of this in any docs (also not
> in the Intel internal documention according to Chris Wilson).

Giving that lack of documentation, could you put some more comments in the code?
so that nobody cleans out that "strange workaround" in 6 monthes...

> @@ -215,6 +215,20 @@ i915_tiling_ok(struct drm_device *dev, int stride, int 
> size, int tiling_mode)
> ? ? ? ? ? ? ? ?}
> ? ? ? ?}
>
> + ? ? ? if (IS_GEN2(dev) ||
> + ? ? ? ? ? (tiling_mode == I915_TILING_Y && HAS_128_BYTE_Y_TILING(dev)))
> + ? ? ? ? ? ? ? tile_height = 32;
> + ? ? ? else
> + ? ? ? ? ? ? ? tile_height = 8;
> + ? ? ? /* i8xx is strange: It has 2 interleaved rows of tiles, so needs an 
> even
> + ? ? ? ?* number of tile rows. */
> + ? ? ? if (IS_GEN2(dev))
> + ? ? ? ? ? ? ? tile_height *= 2;
> +
> + ? ? ? /* Size needs to be aligned to a full tile row */
> + ? ? ? if (size & (tile_height * stride - 1))
> + ? ? ? ? ? ? ? return false;
> +
> ? ? ? ?/* 965+ just needs multiples of tile width */
> ? ? ? ?if (INTEL_INFO(dev)->gen >= 4) {
> ? ? ? ? ? ? ? ?if (stride & (tile_width - 1))