Re: [PATCH RESEND v2 0/2] panel-simple: Add InnoLux G070ACE-L01 support

2023-04-11 Thread Richard Leitner
On Mon, Mar 13, 2023 at 08:50:15AM +0100, richard.leit...@linux.dev wrote:
> This series adds support for the InnoLux G070ACE-L01 7" 800x480 TFT LCD
> panel with WLED backlight.

Friendly reminder for this small series 😉

> 
> Signed-off-by: Richard Leitner 
> ---
> Richard Leitner (2):
>   dt-bindings: display: simple: add support for InnoLux G070ACE-L01
>   drm/panel: simple: Add InnoLux G070ACE-L01
> 
>  .../bindings/display/panel/panel-simple.yaml   |  2 ++
>  drivers/gpu/drm/panel/panel-simple.c   | 35 
> ++
>  2 files changed, 37 insertions(+)
> ---
> base-commit: c0b67534c95c537f7a506a06b98e5e85d72e2b7d
> change-id: 20230201-innolux-g070ace-fda21c89efe2
> 
> Best regards,
> -- 
> Richard Leitner 
> 


[PATCH RESEND v2 0/2] panel-simple: Add InnoLux G070ACE-L01 support

2023-03-13 Thread richard . leitner
This series adds support for the InnoLux G070ACE-L01 7" 800x480 TFT LCD
panel with WLED backlight.

Signed-off-by: Richard Leitner 
---
Richard Leitner (2):
  dt-bindings: display: simple: add support for InnoLux G070ACE-L01
  drm/panel: simple: Add InnoLux G070ACE-L01

 .../bindings/display/panel/panel-simple.yaml   |  2 ++
 drivers/gpu/drm/panel/panel-simple.c   | 35 ++
 2 files changed, 37 insertions(+)
---
base-commit: c0b67534c95c537f7a506a06b98e5e85d72e2b7d
change-id: 20230201-innolux-g070ace-fda21c89efe2

Best regards,
-- 
Richard Leitner 



[PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-03-13 Thread richard . leitner
From: Richard Leitner 

Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible
string.

Acked-by: Krzysztof Kozlowski 
Signed-off-by: Richard Leitner 
---
 Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 18241f4051d2..fd3e5ad769dc 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -174,6 +174,8 @@ properties:
   - innolux,at043tn24
 # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
   - innolux,at070tn92
+# Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel
+  - innolux,g070ace-l01
 # Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD panel
   - innolux,g070y2-l01
 # Innolux G070Y2-T02 7" WVGA (800x480) TFT LCD TTL panel

-- 
2.39.2



[PATCH RESEND v2 2/2] drm/panel: simple: Add InnoLux G070ACE-L01

2023-03-13 Thread richard . leitner
From: Richard Leitner 

Add InnoLux G070ACE-L01 7" 800x480 TFT LCD with WLED backlight panel
support. Timing data was extracted from datasheet and vendor provided
EDID file.

Signed-off-by: Richard Leitner 
---
 drivers/gpu/drm/panel/panel-simple.c | 35 +++
 1 file changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 8a3b685c2fcc..d90f86ad3789 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2142,6 +2142,38 @@ static const struct panel_desc innolux_at070tn92 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing innolux_g070ace_l01_timing = {
+   .pixelclock = { 2520, 3500, 3570 },
+   .hactive = { 800, 800, 800 },
+   .hfront_porch = { 30, 32, 87 },
+   .hback_porch = { 30, 32, 87 },
+   .hsync_len = { 1, 1, 1 },
+   .vactive = { 480, 480, 480 },
+   .vfront_porch = { 3, 3, 3 },
+   .vback_porch = { 13, 13, 13 },
+   .vsync_len = { 1, 1, 4 },
+   .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc innolux_g070ace_l01 = {
+   .timings = &innolux_g070ace_l01_timing,
+   .num_timings = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 91,
+   },
+   .delay = {
+   .prepare = 10,
+   .enable = 50,
+   .disable = 50,
+   .unprepare = 500,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+   .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct display_timing innolux_g070y2_l01_timing = {
.pixelclock = { 2800, 2950, 3200 },
.hactive = { 800, 800, 800 },
@@ -4098,6 +4130,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,at070tn92",
.data = &innolux_at070tn92,
+   }, {
+   .compatible = "innolux,g070ace-l01",
+   .data = &innolux_g070ace_l01,
}, {
.compatible = "innolux,g070y2-l01",
.data = &innolux_g070y2_l01,

-- 
2.39.2



Re: [PATCH v2 4/4] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-03-07 Thread Richard Leitner
Hi Lucas,

hope I got the latest version of this series. If not, please feel free
to point me to the correct one.

On Fri, Dec 16, 2022 at 10:07:42PM +0100, Lucas Stach wrote:
> This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a
> full timing generator and can switch between different video sources. On
> the i.MX8MP however the only supported source is the LCDIF. The block
> just needs to be powered up and told about the polarity of the video
> sync signals to act in bypass mode.
> 
> Signed-off-by: Lucas Stach 
> Tested-by: Marek Vasut 

I've successfully tested this patch on our custom i.MX8MP board. The
test case was basically "cat /dev/urandom > /dev/fb1" with a 800x480
HDMI display.

Therefore please feel free to add:

Tested-by: Richard Leitner 

> ---
>  drivers/gpu/drm/bridge/imx/Kconfig   |   7 +
>  drivers/gpu/drm/bridge/imx/Makefile  |   1 +
>  drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 202 +++
>  3 files changed, 210 insertions(+)
>  create mode 100644 drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> 


Re: [PATCH v2 2/4] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI

2023-03-07 Thread Richard Leitner
Hi Lucas,

On Fri, Dec 16, 2022 at 10:07:40PM +0100, Lucas Stach wrote:
> Add a simple wrapper driver for the DWC HDMI bridge driver that
> implements the few bits that are necessary to abstract the i.MX8MP
> SoC integration.
> 
> Signed-off-by: Lucas Stach 
> Reviewed-by: Laurent Pinchart 
> Tested-by: Marek Vasut 

I've successfully tested this patch on our custom i.MX8MP board. The
test case was basically "cat /dev/urandom > /dev/fb1" with a 800x480
HDMI display.

Therefore please feel free to add:

Tested-by: Richard Leitner 

> ---
>  drivers/gpu/drm/bridge/imx/Kconfig   |   9 ++
>  drivers/gpu/drm/bridge/imx/Makefile  |   2 +
>  drivers/gpu/drm/bridge/imx/imx8mp-hdmi.c | 140 +++
>  3 files changed, 151 insertions(+)
>  create mode 100644 drivers/gpu/drm/bridge/imx/imx8mp-hdmi.c


[PATCH v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-02-01 Thread richard . leitner
From: Richard Leitner 

Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible
string.

Acked-by: Krzysztof Kozlowski 
Signed-off-by: Richard Leitner 
---
 Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 18241f4051d2..fd3e5ad769dc 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -174,6 +174,8 @@ properties:
   - innolux,at043tn24
 # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
   - innolux,at070tn92
+# Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel
+  - innolux,g070ace-l01
 # Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD panel
   - innolux,g070y2-l01
 # Innolux G070Y2-T02 7" WVGA (800x480) TFT LCD TTL panel

-- 
2.39.1



[PATCH v2 2/2] drm/panel: simple: Add InnoLux G070ACE-L01

2023-02-01 Thread richard . leitner
From: Richard Leitner 

Add InnoLux G070ACE-L01 7" 800x480 TFT LCD with WLED backlight panel
support. Timing data was extracted from datasheet and vendor provided
EDID file.

Signed-off-by: Richard Leitner 
---
 drivers/gpu/drm/panel/panel-simple.c | 35 +++
 1 file changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 8a3b685c2fcc..d90f86ad3789 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2142,6 +2142,38 @@ static const struct panel_desc innolux_at070tn92 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing innolux_g070ace_l01_timing = {
+   .pixelclock = { 2520, 3500, 3570 },
+   .hactive = { 800, 800, 800 },
+   .hfront_porch = { 30, 32, 87 },
+   .hback_porch = { 30, 32, 87 },
+   .hsync_len = { 1, 1, 1 },
+   .vactive = { 480, 480, 480 },
+   .vfront_porch = { 3, 3, 3 },
+   .vback_porch = { 13, 13, 13 },
+   .vsync_len = { 1, 1, 4 },
+   .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc innolux_g070ace_l01 = {
+   .timings = &innolux_g070ace_l01_timing,
+   .num_timings = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 91,
+   },
+   .delay = {
+   .prepare = 10,
+   .enable = 50,
+   .disable = 50,
+   .unprepare = 500,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+   .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct display_timing innolux_g070y2_l01_timing = {
.pixelclock = { 2800, 2950, 3200 },
.hactive = { 800, 800, 800 },
@@ -4098,6 +4130,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,at070tn92",
.data = &innolux_at070tn92,
+   }, {
+   .compatible = "innolux,g070ace-l01",
+   .data = &innolux_g070ace_l01,
}, {
.compatible = "innolux,g070y2-l01",
.data = &innolux_g070y2_l01,

-- 
2.39.1



[PATCH v2 0/2] panel-simple: Add InnoLux G070ACE-L01 support

2023-02-01 Thread richard . leitner
This series adds support for the InnoLux G070ACE-L01 7" 800x480 TFT LCD
panel with WLED backlight.

Signed-off-by: Richard Leitner 
---
Richard Leitner (2):
  dt-bindings: display: simple: add support for InnoLux G070ACE-L01
  drm/panel: simple: Add InnoLux G070ACE-L01

 .../bindings/display/panel/panel-simple.yaml   |  2 ++
 drivers/gpu/drm/panel/panel-simple.c   | 35 ++
 2 files changed, 37 insertions(+)
---
base-commit: c0b67534c95c537f7a506a06b98e5e85d72e2b7d
change-id: 20230201-innolux-g070ace-fda21c89efe2

Best regards,
-- 
Richard Leitner 



[PATCH 2/2] drm/panel: simple: Add InnoLux G070ACE-L01

2022-11-18 Thread richard . leitner
From: Richard Leitner 

Add InnoLux G070ACE-L01 7" 800x480 TFT LCD with WLED backlight panel
support. Timing data was extracted from datasheet and vendor provided
EDID file.

Signed-off-by: Richard Leitner 
---

Cc: Thierry Reding 
Cc: Sam Ravnborg 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: dri-devel@lists.freedesktop.org

---
 drivers/gpu/drm/panel/panel-simple.c | 35 
 1 file changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 2944228a8e2c..b2b5ec5839de 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2142,6 +2142,38 @@ static const struct panel_desc innolux_at070tn92 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing innolux_g070ace_l01_timing = {
+   .pixelclock = { 2520, 3500, 3570 },
+   .hactive = { 800, 800, 800 },
+   .hfront_porch = { 30, 32, 87 },
+   .hback_porch = { 30, 32, 87 },
+   .hsync_len = { 1, 1, 1 },
+   .vactive = { 480, 480, 480 },
+   .vfront_porch = { 3, 3, 3 },
+   .vback_porch = { 13, 13, 13 },
+   .vsync_len = { 1, 1, 4 },
+   .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc innolux_g070ace_l01 = {
+   .timings = &innolux_g070ace_l01_timing,
+   .num_timings = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 91,
+   },
+   .delay = {
+   .prepare = 10,
+   .enable = 50,
+   .disable = 50,
+   .unprepare = 500,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+   .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct display_timing innolux_g070y2_l01_timing = {
.pixelclock = { 2800, 2950, 3200 },
.hactive = { 800, 800, 800 },
@@ -4096,6 +4128,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,at070tn92",
.data = &innolux_at070tn92,
+   }, {
+   .compatible = "innolux,g070ace-l01",
+   .data = &innolux_g070ace_l01,
}, {
.compatible = "innolux,g070y2-l01",
.data = &innolux_g070y2_l01,
-- 
2.38.1



[PATCH 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2022-11-18 Thread richard . leitner
From: Richard Leitner 

Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible
string.

Signed-off-by: Richard Leitner 
---

Cc: Thierry Reding 
Cc: Sam Ravnborg 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Rob Herring 
Cc: Krzysztof Kozlowski 
Cc: dri-devel@lists.freedesktop.org
Cc: devicet...@vger.kernel.org

---
 .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 18241f4051d2..fd3e5ad769dc 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -174,6 +174,8 @@ properties:
   - innolux,at043tn24
 # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
   - innolux,at070tn92
+# Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel
+  - innolux,g070ace-l01
 # Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD panel
   - innolux,g070y2-l01
 # Innolux G070Y2-T02 7" WVGA (800x480) TFT LCD TTL panel
-- 
2.38.1