Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Thu, 22 Feb 2024, Rob Herring wrote: > On Tue, Feb 20, 2024 at 08:30:38AM +, dharm...@microchip.com wrote: > > Hi Lee, > > > > On 20/02/24 1:50 pm, Lee Jones wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > > > > > >> Hi Krzysztof, > > >> > > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know > > >>> the content is safe > > >>> > > >>> On 08/02/2024 11:43, Lee Jones wrote: > > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > > Convert the atmel,hlcdc binding to DT schema format. > > > > > > Align clocks and clock-names properties to clearly indicate that the > > > LCD > > > controller expects lvds_pll_clk when interfaced with the lvds > > > display. This > > > alignment with the specific hardware requirements ensures accurate > > > device tree > > > configuration for systems utilizing the HLCDC IP. > > > > > > [...] > > > > Applied, thanks! > > > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > commit: cb946db1335b599ece363d33966bf653ed0fa58a > > > > >>> > > >>> Next is still failing. > > >>> > > >>> Dharma, > > >>> You must explain and clearly mark dependencies between patches. > > >> > > >> I sincerely apologize for any confusion caused by the oversight. I have > > >> organized the patches according to their dependencies in the patch > > >> series, but unfortunately, I neglected to explicitly mention these > > >> dependencies. I understand the importance of clear communication in our > > >> collaborative efforts. Please feel free to provide guidance on how I can > > >> assist you further in resolving this matter. > > > > > > If this continues to be an issue, I can just remove the commit. > > > > There won't be any issue if both pwm and display binding goes before the > > mfd binding. > > > > Could you please pick the display binding as well? > > As this is still not resolved, I've applied the display binding. Not > ideal, but should fix next. Works for me. -- Lee Jones [李琼斯]
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > Hi Lee, > > On 20/02/24 1:50 pm, Lee Jones wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > > > >> Hi Krzysztof, > >> > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know > >>> the content is safe > >>> > >>> On 08/02/2024 11:43, Lee Jones wrote: > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > Convert the atmel,hlcdc binding to DT schema format. > > > > Align clocks and clock-names properties to clearly indicate that the LCD > > controller expects lvds_pll_clk when interfaced with the lvds display. > > This > > alignment with the specific hardware requirements ensures accurate > > device tree > > configuration for systems utilizing the HLCDC IP. > > > > [...] > > Applied, thanks! > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > commit: cb946db1335b599ece363d33966bf653ed0fa58a > > >>> > >>> Next is still failing. > >>> > >>> Dharma, > >>> You must explain and clearly mark dependencies between patches. > >> > >> I sincerely apologize for any confusion caused by the oversight. I have > >> organized the patches according to their dependencies in the patch > >> series, but unfortunately, I neglected to explicitly mention these > >> dependencies. I understand the importance of clear communication in our > >> collaborative efforts. Please feel free to provide guidance on how I can > >> assist you further in resolving this matter. > > > > If this continues to be an issue, I can just remove the commit. > > There won't be any issue if both pwm and display binding goes before the > mfd binding. > > Could you please pick the display binding as well? Only with an ACK from the relevant Maintainers. -- Lee Jones [李琼斯]
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Tue, Feb 20, 2024 at 08:30:38AM +, dharm...@microchip.com wrote: > Hi Lee, > > On 20/02/24 1:50 pm, Lee Jones wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > > > >> Hi Krzysztof, > >> > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know > >>> the content is safe > >>> > >>> On 08/02/2024 11:43, Lee Jones wrote: > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > Convert the atmel,hlcdc binding to DT schema format. > > > > Align clocks and clock-names properties to clearly indicate that the LCD > > controller expects lvds_pll_clk when interfaced with the lvds display. > > This > > alignment with the specific hardware requirements ensures accurate > > device tree > > configuration for systems utilizing the HLCDC IP. > > > > [...] > > Applied, thanks! > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > commit: cb946db1335b599ece363d33966bf653ed0fa58a > > >>> > >>> Next is still failing. > >>> > >>> Dharma, > >>> You must explain and clearly mark dependencies between patches. > >> > >> I sincerely apologize for any confusion caused by the oversight. I have > >> organized the patches according to their dependencies in the patch > >> series, but unfortunately, I neglected to explicitly mention these > >> dependencies. I understand the importance of clear communication in our > >> collaborative efforts. Please feel free to provide guidance on how I can > >> assist you further in resolving this matter. > > > > If this continues to be an issue, I can just remove the commit. > > There won't be any issue if both pwm and display binding goes before the > mfd binding. > > Could you please pick the display binding as well? As this is still not resolved, I've applied the display binding. Not ideal, but should fix next. Rob
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On 20/02/2024 04:34, dharm...@microchip.com wrote: > Hi Krzysztof, > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 08/02/2024 11:43, Lee Jones wrote: >>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: Convert the atmel,hlcdc binding to DT schema format. Align clocks and clock-names properties to clearly indicate that the LCD controller expects lvds_pll_clk when interfaced with the lvds display. This alignment with the specific hardware requirements ensures accurate device tree configuration for systems utilizing the HLCDC IP. [...] >>> >>> Applied, thanks! >>> >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>>commit: cb946db1335b599ece363d33966bf653ed0fa58a >>> >> >> Next is still failing. >> >> Dharma, >> You must explain and clearly mark dependencies between patches. > > I sincerely apologize for any confusion caused by the oversight. I have > organized the patches according to their dependencies in the patch Does it mean that all your other patchsets which contain multiple patches have dependencies? That would be the meaning of above approach. Unfortunately that's not good... I'll comment in other places for individual issues. Best regards, Krzysztof
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
Hello, On Tue, Feb 20, 2024 at 08:20:26AM +, Lee Jones wrote: > On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > > On 08/02/2024 11:43, Lee Jones wrote: > > >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > > >>> Convert the atmel,hlcdc binding to DT schema format. > > >>> > > >>> Align clocks and clock-names properties to clearly indicate that the LCD > > >>> controller expects lvds_pll_clk when interfaced with the lvds display. > > >>> This > > >>> alignment with the specific hardware requirements ensures accurate > > >>> device tree > > >>> configuration for systems utilizing the HLCDC IP. > > >>> > > >>> [...] > > >> > > >> Applied, thanks! > > >> > > >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > >>commit: cb946db1335b599ece363d33966bf653ed0fa58a > > >> > > > > > > Next is still failing. > > If this continues to be an issue, I can just remove the commit. The missing part in next is that patch 1 isn't included. So the options are: a) Someone (dri or dt folks?) merges patch 1 This fixes the state in next, though some commits stay around that fail dt_binding_check b) Someone (mfd or dt?) merges all 3 patches in one go and the two patches already applied are dropped. This makes dt_binding_check happy for all revs. For me a) is good enough, but I guess the dri people are not aware there is something to do for them?! Would be nice if Sam or Boris commented. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ | signature.asc Description: PGP signature
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
Hi Lee, On 20/02/24 1:50 pm, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > >> Hi Krzysztof, >> >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >>> content is safe >>> >>> On 08/02/2024 11:43, Lee Jones wrote: On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. > This > alignment with the specific hardware requirements ensures accurate device > tree > configuration for systems utilizing the HLCDC IP. > > [...] Applied, thanks! [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format commit: cb946db1335b599ece363d33966bf653ed0fa58a >>> >>> Next is still failing. >>> >>> Dharma, >>> You must explain and clearly mark dependencies between patches. >> >> I sincerely apologize for any confusion caused by the oversight. I have >> organized the patches according to their dependencies in the patch >> series, but unfortunately, I neglected to explicitly mention these >> dependencies. I understand the importance of clear communication in our >> collaborative efforts. Please feel free to provide guidance on how I can >> assist you further in resolving this matter. > > If this continues to be an issue, I can just remove the commit. There won't be any issue if both pwm and display binding goes before the mfd binding. Could you please pick the display binding as well? > > -- > Lee Jones [李琼斯] -- With Best Regards, Dharma B.
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Tue, 20 Feb 2024, dharm...@microchip.com wrote: > Hi Krzysztof, > > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On 08/02/2024 11:43, Lee Jones wrote: > >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >>> Convert the atmel,hlcdc binding to DT schema format. > >>> > >>> Align clocks and clock-names properties to clearly indicate that the LCD > >>> controller expects lvds_pll_clk when interfaced with the lvds display. > >>> This > >>> alignment with the specific hardware requirements ensures accurate device > >>> tree > >>> configuration for systems utilizing the HLCDC IP. > >>> > >>> [...] > >> > >> Applied, thanks! > >> > >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >>commit: cb946db1335b599ece363d33966bf653ed0fa58a > >> > > > > Next is still failing. > > > > Dharma, > > You must explain and clearly mark dependencies between patches. > > I sincerely apologize for any confusion caused by the oversight. I have > organized the patches according to their dependencies in the patch > series, but unfortunately, I neglected to explicitly mention these > dependencies. I understand the importance of clear communication in our > collaborative efforts. Please feel free to provide guidance on how I can > assist you further in resolving this matter. If this continues to be an issue, I can just remove the commit. -- Lee Jones [李琼斯]
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
Hi Krzysztof, On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 08/02/2024 11:43, Lee Jones wrote: >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>> Convert the atmel,hlcdc binding to DT schema format. >>> >>> Align clocks and clock-names properties to clearly indicate that the LCD >>> controller expects lvds_pll_clk when interfaced with the lvds display. This >>> alignment with the specific hardware requirements ensures accurate device >>> tree >>> configuration for systems utilizing the HLCDC IP. >>> >>> [...] >> >> Applied, thanks! >> >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>commit: cb946db1335b599ece363d33966bf653ed0fa58a >> > > Next is still failing. > > Dharma, > You must explain and clearly mark dependencies between patches. I sincerely apologize for any confusion caused by the oversight. I have organized the patches according to their dependencies in the patch series, but unfortunately, I neglected to explicitly mention these dependencies. I understand the importance of clear communication in our collaborative efforts. Please feel free to provide guidance on how I can assist you further in resolving this matter. > > Lee, > Can you pick up two previous patches as well? > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On 16/02/2024 09:43, Uwe Kleine-König wrote: >>> I applied the pwm patch now. If Lee wants to pick up this one via his >>> tree that would be fine for me, too. If that's the case please tell me, >>> then I'll drop it from my for-next branch again. Feel free to add >>> my Acked-by: Uwe Kleine-König for patch >>> #2 then. >> >> At least next is happy. > > The pwm binding is in next now (as > 0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still > tells me (among others): > > Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml: > Error in referenced schema matching $id: > http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml > > This is what you meant, right? This goes away as soon as the first patch Yeah, apparently there was more than one dependency. > (dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied, > too. So next isn't completely happy yet. Sigh... Best regards, Krzysztof
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
Hello Krzysztof, On Thu, Feb 15, 2024 at 07:44:53PM +0100, Krzysztof Kozlowski wrote: > On 15/02/2024 11:02, Uwe Kleine-König wrote: > > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: > >> On 08/02/2024 11:43, Lee Jones wrote: > >>> Applied, thanks! > >>> > >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > >>> commit: cb946db1335b599ece363d33966bf653ed0fa58a > >>> > >> > >> Next is still failing. > > > > Failing in the sense of dtbs_check, right? > > No, bindings were failing. dt_binding_check. This must not fail, so kind > of bummer... > > >> Dharma, > >> You must explain and clearly mark dependencies between patches. > >> > >> Lee, > >> Can you pick up two previous patches as well? > > > > I applied the pwm patch now. If Lee wants to pick up this one via his > > tree that would be fine for me, too. If that's the case please tell me, > > then I'll drop it from my for-next branch again. Feel free to add > > my Acked-by: Uwe Kleine-König for patch > > #2 then. > > At least next is happy. The pwm binding is in next now (as 0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still tells me (among others): Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml This is what you meant, right? This goes away as soon as the first patch (dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied, too. So next isn't completely happy yet. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ | signature.asc Description: PGP signature
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On 15/02/2024 11:02, Uwe Kleine-König wrote: > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: >> On 08/02/2024 11:43, Lee Jones wrote: >>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: Convert the atmel,hlcdc binding to DT schema format. Align clocks and clock-names properties to clearly indicate that the LCD controller expects lvds_pll_clk when interfaced with the lvds display. This alignment with the specific hardware requirements ensures accurate device tree configuration for systems utilizing the HLCDC IP. [...] >>> >>> Applied, thanks! >>> >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format >>> commit: cb946db1335b599ece363d33966bf653ed0fa58a >>> >> >> Next is still failing. > > Failing in the sense of dtbs_check, right? No, bindings were failing. dt_binding_check. This must not fail, so kind of bummer... > >> Dharma, >> You must explain and clearly mark dependencies between patches. >> >> Lee, >> Can you pick up two previous patches as well? > > I applied the pwm patch now. If Lee wants to pick up this one via his > tree that would be fine for me, too. If that's the case please tell me, > then I'll drop it from my for-next branch again. Feel free to add > my Acked-by: Uwe Kleine-König for patch > #2 then. At least next is happy. > Best regards, Krzysztof
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: > On 08/02/2024 11:43, Lee Jones wrote: > > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > >> Convert the atmel,hlcdc binding to DT schema format. > >> > >> Align clocks and clock-names properties to clearly indicate that the LCD > >> controller expects lvds_pll_clk when interfaced with the lvds display. This > >> alignment with the specific hardware requirements ensures accurate device > >> tree > >> configuration for systems utilizing the HLCDC IP. > >> > >> [...] > > > > Applied, thanks! > > > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > commit: cb946db1335b599ece363d33966bf653ed0fa58a > > > > Next is still failing. Failing in the sense of dtbs_check, right? > Dharma, > You must explain and clearly mark dependencies between patches. > > Lee, > Can you pick up two previous patches as well? I applied the pwm patch now. If Lee wants to pick up this one via his tree that would be fine for me, too. If that's the case please tell me, then I'll drop it from my for-next branch again. Feel free to add my Acked-by: Uwe Kleine-König for patch #2 then. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ | signature.asc Description: PGP signature
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On 08/02/2024 11:43, Lee Jones wrote: > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >> Convert the atmel,hlcdc binding to DT schema format. >> >> Align clocks and clock-names properties to clearly indicate that the LCD >> controller expects lvds_pll_clk when interfaced with the lvds display. This >> alignment with the specific hardware requirements ensures accurate device >> tree >> configuration for systems utilizing the HLCDC IP. >> >> [...] > > Applied, thanks! > > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > commit: cb946db1335b599ece363d33966bf653ed0fa58a > Next is still failing. Dharma, You must explain and clearly mark dependencies between patches. Lee, Can you pick up two previous patches as well? Best regards, Krzysztof
Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with the specific hardware requirements ensures accurate device tree > configuration for systems utilizing the HLCDC IP. > > [...] Applied, thanks! [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format commit: cb946db1335b599ece363d33966bf653ed0fa58a -- Lee Jones [李琼斯]
