[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

GitLab Migration User  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEEDINFO|RESOLVED

--- Comment #5 from GitLab Migration User  ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/667.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

--- Comment #4 from Mark Janes  ---
I was able to reproduce this bug using the old versions of piglit and mesa

  piglit:  1f39e07d44f7d78557d69c505168afb8eab913c6
  mesa:c2a0600

After updating piglit to the latest revision, the test passes.  This
seems to be the correct behavior, based on Ian's comment.

Based on this information, I think it is safe to conclude that this
bug does not indicate a regression in mesa.  Instead, it is caused by
using a fixed version of mesa, but failing to pull in the
corresponding piglit fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

--- Comment #3 from Chad Versace  ---
Brian Wilson said:
> It fails in the following Mesa commit:
>   c2a0600 i965: Don't set NirOptions for stages that will use the vec4 
> backend [May 2015-ish]

Incorrect. The actual Mesa tree that Brian's team is validating is commit
c1a0600 plus many patches. I've the pushed the full tree, patches included, to 

  git://github.com/chadversary/mesa refs/tags/chadv/cros-gerrit-262788-patched

Also, the Piglit being tested is the following commit plus a few incosequential
patches.

  commit 4069bec62a8a99c44573395ea1597694760f
  Author: Marek Olšák 
  AuthorDate: Thu Apr 30 14:11:26 2015 +0200
  Commit: Marek Olšák 
  CommitDate: Thu Apr 30 22:41:02 2015 +0200
  Subject: framework: use the correct executable for GLES parser tests

Building that Piglit against recent Mesa, however, produces an error at
linktime. The fix requires backporting Piglit commit
845ba0e4dfb9372307f5d3032abdd0860e76731b.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

--- Comment #2 from Brian Wilson  ---
This is the version of Piglit that is being used:
http://cgit.freedesktop.org/piglit/commit/?id=1f39e07d44f7d78557d69c505168afb8eab913c6

Here is the failing test output:
06/13 08:50:32.209 DEBUG|base_utils:0239| [stdout] + Running test
[shaders/glsl-floating-constant-120] of expected runtime 0.0 sec:
[bin/shader_runner tests/shaders/glsl-floating-constant-120.shader_test -auto]
06/13 08:50:32.310 DEBUG|base_utils:0239| [stderr] Failed to compile
FS: 0:5(14): error: syntax error, unexpected NEW_IDENTIFIER, expecting ',' or
';'
06/13 08:50:32.312 DEBUG|base_utils:0239| [stderr] 
06/13 08:50:32.314 DEBUG|base_utils:0239| [stdout] PIGLIT: {"result":
"fail" }
06/13 08:50:32.315 DEBUG|base_utils:0239| [stdout] + fail ::
shaders/glsl-floating-constant-120

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

Ian Romanick  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Ian Romanick  ---
Does your piglit have the following commit?  Mesa was updated to follow the
spec, and the test was previously incorrect.

commit 63aef6af996d5ca37e9dee78e0392106848e2735
Author: Neil Roberts 
Date:   Wed Nov 26 18:35:32 2014 +

Don't test floats with the form ‘1f’

There is nothing in the GLSL spec which says you can have a float
literal without an exponent or a decimal point even if you add the ‘f’
suffix. This patch replaces that literal with some other variations
that should be accepted according to the spec.

Reviewed-by: Matt Turner 

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91016

Kenneth Graunke  changed:

   What|Removed |Added

  Component|Mesa core   |Drivers/Gallium/i915g
   Assignee|mesa-dev at lists.freedesktop. |dri-devel at 
lists.freedesktop
   |org |.org
 QA Contact|mesa-dev at lists.freedesktop. |dri-devel at 
lists.freedesktop
   |org |.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: