Re: [Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check
On 5/24/2023 6:40 PM, Dmitry Baryshkov wrote: On Thu, 25 May 2023 at 02:04, Abhinav Kumar wrote: On 5/24/2023 3:46 PM, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: In preparation to virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In case of virtual planes the plane's pipe will not be known up to the point of atomic_check() callback. Signed-off-by: Dmitry Baryshkov --- Will legacy paths be broken with this? So lets say there is no atomic_check we will not have a valid sspp anymore. I think it should still work, even if goes through the modeset crtc, it should still call drm_atomic_commit() internally which should have the call to atomic_check, once you confirm this , i can ack this particular change. Can you please describe the scenario you have in mind? If I got you correctly, you were asking about the non-commit IOCTLs. Because of the atomic helpers being used (e.g. drm_atomic_helper_set_config()), they will also result in a call to drm_atomic_commit(), which invokes drm_atomic_check_only(). Yes, that was pretty much the scenario I was referring to, thanks for confirming.
Re: [Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check
On Thu, 25 May 2023 at 02:04, Abhinav Kumar wrote: > > > > On 5/24/2023 3:46 PM, Abhinav Kumar wrote: > > > > > > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: > >> In preparation to virtualized planes support, move pstate->pipe > >> initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In > >> case of virtual planes the plane's pipe will not be known up to the > >> point of atomic_check() callback. > >> > >> Signed-off-by: Dmitry Baryshkov > >> --- > > > > Will legacy paths be broken with this? So lets say there is no > > atomic_check we will not have a valid sspp anymore. > > I think it should still work, even if goes through the modeset crtc, it > should still call drm_atomic_commit() internally which should have the > call to atomic_check, once you confirm this , i can ack this particular > change. Can you please describe the scenario you have in mind? If I got you correctly, you were asking about the non-commit IOCTLs. Because of the atomic helpers being used (e.g. drm_atomic_helper_set_config()), they will also result in a call to drm_atomic_commit(), which invokes drm_atomic_check_only(). -- With best wishes Dmitry
Re: [Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check
On 5/24/2023 3:46 PM, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: In preparation to virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In case of virtual planes the plane's pipe will not be known up to the point of atomic_check() callback. Signed-off-by: Dmitry Baryshkov --- Will legacy paths be broken with this? So lets say there is no atomic_check we will not have a valid sspp anymore. I think it should still work, even if goes through the modeset crtc, it should still call drm_atomic_commit() internally which should have the call to atomic_check, once you confirm this , i can ack this particular change.
