[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-24 Thread John Hunter 
ok, let's keep it the the original way.

On Fri, Apr 24, 2015 at 12:09 AM, Daniel Vetter  wrote:

> On Wed, Apr 22, 2015 at 10:50:55AM +0800, John Hunter wrote:
> > Sure, but I need Daniel to admit that, because maybe include the two
> header
> > file make it easier to understand.
> > And after checked other files in drm/i915, I found that a lot other file
> do
> > the
> > same thing(include both header file). So I will just wait Daniel to wait
> up
> > and
> > give me the order :-)
>
> drm/i915 headers are a bit a chaos anyway, so I'm not sure how useful that
> would be really. And generally the trend in linux (and drm) is to have
> split-up headers, so moving everyone to just include intel_drv.h would be
> the "wrong" direction.
>
> tbh I just don't have an opinion really ;-)
> -Daniel
>
> >
> > On Wed, Apr 22, 2015 at 10:35 AM, yongjun_wei at trendmicro.com.cn <
> > yongjun_wei at trendmicro.com.cn> wrote:
> >
> > >  Hi John,
> > >
> > >
> > >
> > > Feel free to submit a new patch.
> > >
> > >
> > >
> > > Regards,
> > >
> > > Yongjun Wei
> > >
> > >
> > >
> > > *From:* John Hunter [mailto:zhjwpku at gmail.com]
> > > *Sent:* 2015年4月22日 10:30
> > > *To:* weiyj_lk at 163.com; Daniel Vetter; Jani Nikula; David Airlie;
> Yongjun
> > > Wei (RD-CN); intel-gfx at lists.freedesktop.org;
> > > dri-devel at lists.freedesktop.org; open list
> > > *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove
> > > duplicated include from intel_audio.c
> > >
> > >
> > >
> > > Hi,
> > >
> > >
> > >
> > > I think maybe we should remove both of the two lines:
> > >
> > > #include "intel_drv.h"
> > >
> > > #include "i915_drv.h"
> > >
> > > Because we have* two* "intel_drv.h" and *one* "i915_drv.h", and
> > >
> > > "i915_drv.h" has already been included in the "intel_drv.h".
> > >
> > >
> > >
> > > I not sure whether i am right. If you need me to do the patch,
> > >
> > > let me know.
> > >
> > >
> > >
> > >
> > >
> > > On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter 
> wrote:
> > >
> > > On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote:
> > > > From: Wei Yongjun 
> > > >
> > > > Remove duplicated include.
> > > >
> > > > Signed-off-by: Wei Yongjun 
> > >
> > > Queued for -next, thanks for the patch.
> > > -Daniel
> > >
> > > > ---
> > > >  drivers/gpu/drm/i915/intel_audio.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > > b/drivers/gpu/drm/i915/intel_audio.c
> > > > index 2396cc7..d00d488 100644
> > > > --- a/drivers/gpu/drm/i915/intel_audio.c
> > > > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > > > @@ -28,7 +28,6 @@
> > > >
> > > >  #include 
> > > >  #include 
> > > > -#include "intel_drv.h"
> > > >  #include "i915_drv.h"
> > > >
> > > >  /**
> > > >
> > > > ___
> > > > Intel-gfx mailing list
> > > > Intel-gfx at lists.freedesktop.org
> > > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation
> > > http://blog.ffwll.ch
> > >
> > > ___
> > > dri-devel mailing list
> > > dri-devel at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >
> > >
> > >
> > >
> > >
> > > --
> > >
> > > Best regards
> > >
> > > Junwang Zhao
> > >
> > > Microprocessor Research and Develop Center
> > >
> > > Department of Computer Science 
> > >
> > > Peking University
> > >
> > > Beijing, 100871, PRC
> > >
> > > ===
> > >
> > > This message has been analyzed by Deep Discovery Email Inspector.
> > >
> > >
> > >
> > > TREND MICRO EMAIL NOTICE
> > > The information contained in this email and any attachments is
> confidential
> > > and may be subject to copyright or other intellectual property
> protection.
> > > If you are not the intended recipient, you are not authorized to use or
> > > disclose this information, and we request that you notify us by reply
> mail or
> > > telephone and delete the original message from your mail system.
> > >
> > >
> >
> >
> > --
> > Best regards
> > Junwang Zhao
> > Microprocessor Research and Develop Center
> > Department of Computer Science 
> > Peking University
> > Beijing, 100871, PRC
>
> > ___
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>



-- 
Best regards
Junwang Zhao
Microprocessor Research and Develop Center
Department of Computer Science 
Peking University
Beijing, 100871, PRC
-- next part --
An HTML attachment was scrubbed...
URL: 
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150424/4fbb8764/attachment.html>

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-23 Thread Daniel Vetter 
On Wed, Apr 22, 2015 at 10:50:55AM +0800, John Hunter wrote:
> Sure, but I need Daniel to admit that, because maybe include the two header
> file make it easier to understand.
> And after checked other files in drm/i915, I found that a lot other file do
> the
> same thing(include both header file). So I will just wait Daniel to wait up
> and
> give me the order :-)

drm/i915 headers are a bit a chaos anyway, so I'm not sure how useful that
would be really. And generally the trend in linux (and drm) is to have
split-up headers, so moving everyone to just include intel_drv.h would be
the "wrong" direction.

tbh I just don't have an opinion really ;-)
-Daniel

> 
> On Wed, Apr 22, 2015 at 10:35 AM, yongjun_wei at trendmicro.com.cn <
> yongjun_wei at trendmicro.com.cn> wrote:
> 
> >  Hi John,
> >
> >
> >
> > Feel free to submit a new patch.
> >
> >
> >
> > Regards,
> >
> > Yongjun Wei
> >
> >
> >
> > *From:* John Hunter [mailto:zhjwpku at gmail.com]
> > *Sent:* 2015年4月22日 10:30
> > *To:* weiyj_lk at 163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun
> > Wei (RD-CN); intel-gfx at lists.freedesktop.org;
> > dri-devel at lists.freedesktop.org; open list
> > *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove
> > duplicated include from intel_audio.c
> >
> >
> >
> > Hi,
> >
> >
> >
> > I think maybe we should remove both of the two lines:
> >
> > #include "intel_drv.h"
> >
> > #include "i915_drv.h"
> >
> > Because we have* two* "intel_drv.h" and *one* "i915_drv.h", and
> >
> > "i915_drv.h" has already been included in the "intel_drv.h".
> >
> >
> >
> > I not sure whether i am right. If you need me to do the patch,
> >
> > let me know.
> >
> >
> >
> >
> >
> > On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter  wrote:
> >
> > On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote:
> > > From: Wei Yongjun 
> > >
> > > Remove duplicated include.
> > >
> > > Signed-off-by: Wei Yongjun 
> >
> > Queued for -next, thanks for the patch.
> > -Daniel
> >
> > > ---
> > >  drivers/gpu/drm/i915/intel_audio.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > b/drivers/gpu/drm/i915/intel_audio.c
> > > index 2396cc7..d00d488 100644
> > > --- a/drivers/gpu/drm/i915/intel_audio.c
> > > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > > @@ -28,7 +28,6 @@
> > >
> > >  #include 
> > >  #include 
> > > -#include "intel_drv.h"
> > >  #include "i915_drv.h"
> > >
> > >  /**
> > >
> > > ___
> > > Intel-gfx mailing list
> > > Intel-gfx at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> >
> > ___
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
> >
> >
> > --
> >
> > Best regards
> >
> > Junwang Zhao
> >
> > Microprocessor Research and Develop Center
> >
> > Department of Computer Science 
> >
> > Peking University
> >
> > Beijing, 100871, PRC
> >
> > ===
> >
> > This message has been analyzed by Deep Discovery Email Inspector.
> >
> >
> >
> > TREND MICRO EMAIL NOTICE
> > The information contained in this email and any attachments is confidential
> > and may be subject to copyright or other intellectual property protection.
> > If you are not the intended recipient, you are not authorized to use or
> > disclose this information, and we request that you notify us by reply mail 
> > or
> > telephone and delete the original message from your mail system.
> >
> >
> 
> 
> -- 
> Best regards
> Junwang Zhao
> Microprocessor Research and Develop Center
> Department of Computer Science 
> Peking University
> Beijing, 100871, PRC

> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread John Hunter 
Sure, but I need Daniel to admit that, because maybe include the two header
file make it easier to understand.
And after checked other files in drm/i915, I found that a lot other file do
the
same thing(include both header file). So I will just wait Daniel to wait up
and
give me the order :-)

On Wed, Apr 22, 2015 at 10:35 AM, yongjun_wei at trendmicro.com.cn <
yongjun_wei at trendmicro.com.cn> wrote:

>  Hi John,
>
>
>
> Feel free to submit a new patch.
>
>
>
> Regards,
>
> Yongjun Wei
>
>
>
> *From:* John Hunter [mailto:zhjwpku at gmail.com]
> *Sent:* 2015年4月22日 10:30
> *To:* weiyj_lk at 163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun
> Wei (RD-CN); intel-gfx at lists.freedesktop.org;
> dri-devel at lists.freedesktop.org; open list
> *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove
> duplicated include from intel_audio.c
>
>
>
> Hi,
>
>
>
> I think maybe we should remove both of the two lines:
>
> #include "intel_drv.h"
>
> #include "i915_drv.h"
>
> Because we have* two* "intel_drv.h" and *one* "i915_drv.h", and
>
> "i915_drv.h" has already been included in the "intel_drv.h".
>
>
>
> I not sure whether i am right. If you need me to do the patch,
>
> let me know.
>
>
>
>
>
> On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter  wrote:
>
> On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote:
> > From: Wei Yongjun 
> >
> > Remove duplicated include.
> >
> > Signed-off-by: Wei Yongjun 
>
> Queued for -next, thanks for the patch.
> -Daniel
>
> > ---
> >  drivers/gpu/drm/i915/intel_audio.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c
> b/drivers/gpu/drm/i915/intel_audio.c
> > index 2396cc7..d00d488 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -28,7 +28,6 @@
> >
> >  #include 
> >  #include 
> > -#include "intel_drv.h"
> >  #include "i915_drv.h"
> >
> >  /**
> >
> > ___
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
>
>
> --
>
> Best regards
>
> Junwang Zhao
>
> Microprocessor Research and Develop Center
>
> Department of Computer Science 
>
> Peking University
>
> Beijing, 100871, PRC
>
> ===
>
> This message has been analyzed by Deep Discovery Email Inspector.
>
>
>
> TREND MICRO EMAIL NOTICE
> The information contained in this email and any attachments is confidential
> and may be subject to copyright or other intellectual property protection.
> If you are not the intended recipient, you are not authorized to use or
> disclose this information, and we request that you notify us by reply mail or
> telephone and delete the original message from your mail system.
>
>


-- 
Best regards
Junwang Zhao
Microprocessor Research and Develop Center
Department of Computer Science 
Peking University
Beijing, 100871, PRC
-- next part --
An HTML attachment was scrubbed...
URL: 
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150422/8fd9604a/attachment.html>

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread John Hunter 
Hi,

I think maybe we should remove both of the two lines:
#include "intel_drv.h"
#include "i915_drv.h"
Because we have* two* "intel_drv.h" and *one* "i915_drv.h", and
"i915_drv.h" has already been included in the "intel_drv.h".

I not sure whether i am right. If you need me to do the patch,
let me know.


On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter  wrote:

> On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote:
> > From: Wei Yongjun 
> >
> > Remove duplicated include.
> >
> > Signed-off-by: Wei Yongjun 
>
> Queued for -next, thanks for the patch.
> -Daniel
>
> > ---
> >  drivers/gpu/drm/i915/intel_audio.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c
> b/drivers/gpu/drm/i915/intel_audio.c
> > index 2396cc7..d00d488 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -28,7 +28,6 @@
> >
> >  #include 
> >  #include 
> > -#include "intel_drv.h"
> >  #include "i915_drv.h"
> >
> >  /**
> >
> > ___
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>



-- 
Best regards
Junwang Zhao
Microprocessor Research and Develop Center
Department of Computer Science 
Peking University
Beijing, 100871, PRC
-- next part --
An HTML attachment was scrubbed...
URL:

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread yongjun_...@trendmicro.com.cn 
Hi John,

Feel free to submit a new patch.

Regards,
Yongjun Wei

From: John Hunter [mailto:zhjw...@gmail.com]
Sent: 2015年4月22日 10:30
To: weiyj_lk at 163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun Wei 
(RD-CN); intel-gfx at lists.freedesktop.org; dri-devel at 
lists.freedesktop.org; open list
Subject: Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated 
include from intel_audio.c

Hi,

I think maybe we should remove both of the two lines:
#include "intel_drv.h"
#include "i915_drv.h"
Because we have two "intel_drv.h" and one "i915_drv.h", and
"i915_drv.h" has already been included in the "intel_drv.h".

I not sure whether i am right. If you need me to do the patch,
let me know.


On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter mailto:daniel at ffwll.ch>> wrote:
On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com<mailto:weiyj_lk 
at 163.com> wrote:
> From: Wei Yongjun mailto:yongjun_wei at 
> trendmicro.com.cn>>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun  trendmicro.com.cn<mailto:yongjun_wei at trendmicro.com.cn>>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c 
> b/drivers/gpu/drm/i915/intel_audio.c
> index 2396cc7..d00d488 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -28,7 +28,6 @@
>
>  #include 
>  #include 
> -#include "intel_drv.h"
>  #include "i915_drv.h"
>
>  /**
>
> ___
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org<mailto:Intel-gfx at lists.freedesktop.org>
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel at lists.freedesktop.org<mailto:dri-devel at lists.freedesktop.org>
http://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Best regards
Junwang Zhao
Microprocessor Research and Develop Center
Department of Computer Science 
Peking University
Beijing, 100871, PRC

===

This message has been analyzed by Deep Discovery Email Inspector.




TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.

-- next part --
An HTML attachment was scrubbed...
URL: 
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150422/9c630c28/attachment-0001.html>

[Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-16 Thread Daniel Vetter 
On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk at 163.com wrote:
> From: Wei Yongjun 
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun 

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_audio.c 
> b/drivers/gpu/drm/i915/intel_audio.c
> index 2396cc7..d00d488 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -28,7 +28,6 @@
>  
>  #include 
>  #include 
> -#include "intel_drv.h"
>  #include "i915_drv.h"
>  
>  /**
> 
> ___
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch