Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On Thu, Jun 24, 2021 at 12:05:16AM -0700, Matthew Brost wrote:
> From: Daniele Ceraolo Spurio
>
> Unblock GuC submission on Gen11+ platforms.
>
> Signed-off-by: Michal Wajdeczko
> Signed-off-by: Daniele Ceraolo Spurio
> Signed-off-by: Matthew Brost
Updating debug message per feedback, with that:
Reviewed-by: Matthew Brost
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.h| 1 +
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14 +-
> 4 files changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index fae01dc8e1b9..77981788204f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -54,6 +54,7 @@ struct intel_guc {
> struct ida guc_ids;
> struct list_head guc_id_list;
>
> + bool submission_supported;
> bool submission_selected;
>
> struct i915_vma *ads_vma;
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index a427336ce916..405339202280 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -2042,6 +2042,13 @@ void intel_guc_submission_disable(struct intel_guc
> *guc)
> /* Note: By the time we're here, GuC may have already been reset */
> }
>
> +static bool __guc_submission_supported(struct intel_guc *guc)
> +{
> + /* GuC submission is unavailable for pre-Gen11 */
> + return intel_guc_is_supported(guc) &&
> +INTEL_GEN(guc_to_gt(guc)->i915) >= 11;
> +}
> +
> static bool __guc_submission_selected(struct intel_guc *guc)
> {
> struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
> @@ -2054,6 +2061,7 @@ static bool __guc_submission_selected(struct intel_guc
> *guc)
>
> void intel_guc_submission_init_early(struct intel_guc *guc)
> {
> + guc->submission_supported = __guc_submission_supported(guc);
> guc->submission_selected = __guc_submission_selected(guc);
> }
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
> index a2a3fad72be1..be767eb6ff71 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h
> @@ -37,8 +37,7 @@ int intel_guc_wait_for_pending_msg(struct intel_guc *guc,
>
> static inline bool intel_guc_submission_is_supported(struct intel_guc *guc)
> {
> - /* XXX: GuC submission is unavailable for now */
> - return false;
> + return guc->submission_supported;
> }
>
> static inline bool intel_guc_submission_is_wanted(struct intel_guc *guc)
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index 7a69c3c027e9..61be0aa81492 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -34,8 +34,15 @@ static void uc_expand_default_options(struct intel_uc *uc)
> return;
> }
>
> - /* Default: enable HuC authentication only */
> - i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
> + /* Intermediate platforms are HuC authentication only */
> + if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
> + drm_dbg(>drm, "Disabling GuC only due to old platform\n");
> + i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
> + return;
> + }
> +
> + /* Default: enable HuC authentication and GuC submission */
> + i915->params.enable_guc = ENABLE_GUC_LOAD_HUC | ENABLE_GUC_SUBMISSION;
> }
>
> /* Reset GuC providing us with fresh state for both GuC and HuC.
> @@ -313,9 +320,6 @@ static int __uc_init(struct intel_uc *uc)
> if (i915_inject_probe_failure(uc_to_gt(uc)->i915))
> return -ENOMEM;
>
> - /* XXX: GuC submission is unavailable for now */
> - GEM_BUG_ON(intel_uc_uses_guc_submission(uc));
> -
> ret = intel_guc_init(guc);
> if (ret)
> return ret;
> --
> 2.28.0
>
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On 07.07.2021 02:57, John Harrison wrote:
> On 7/3/2021 01:21, Martin Peres wrote:
>> On 02/07/2021 18:07, Michal Wajdeczko wrote:
>>> On 02.07.2021 10:09, Martin Peres wrote:
On 02/07/2021 10:29, Pekka Paalanen wrote:
> On Thu, 1 Jul 2021 21:28:06 +0200
> Daniel Vetter wrote:
>
>> On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
>> wrote:
>>>
>>> On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
> On 6/30/2021 01:22, Martin Peres wrote:
>> On 24/06/2021 10:05, Matthew Brost wrote:
>>> From: Daniele Ceraolo Spurio
>>>
>>> Unblock GuC submission on Gen11+ platforms.
>>>
>>> Signed-off-by: Michal Wajdeczko
>>> Signed-off-by: Daniele Ceraolo Spurio
>>>
>>> Signed-off-by: Matthew Brost
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 +
>>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
>>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
>>> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
>>> +-
>>> 4 files changed, 19 insertions(+), 7 deletions(-)
...
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>>> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>>> index 7a69c3c027e9..61be0aa81492 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>>> @@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
>>> intel_uc *uc)
>>> return;
>>> }
>>> - /* Default: enable HuC authentication only */
>>> - i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
>>> + /* Intermediate platforms are HuC authentication only */
>>> + if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
>>> + drm_dbg(>drm, "Disabling GuC only due to old
>>> platform\n");
>>
>> This comment does not seem accurate, given that DG1 is barely
>> out, and
>> ADL is not out yet. How about:
>>
>> "Disabling GuC on untested platforms"?
> Just because something is not in the shops yet does not mean it is
> new.
> Technology is always obsolete by the time it goes on sale.
That is a very good reason to not use terminology like "new",
"old",
"current", "modern" etc. at all.
End users like me definitely do not share your interpretation of
"old".
>>>
>>> Yep, old and new is relative. In the end, what matters is the
>>> validation
>>> effort, which is why I was proposing "untested platforms".
>>>
>>> Also, remember that you are not writing these messages for Intel
>>> engineers, but instead are writing for Linux *users*.
>>
>> It's drm_dbg. Users don't read this stuff, at least not users with no
>> clue what the driver does and stuff like that.
>
> If I had a problem, I would read it, and I have no clue what anything
> of that is.
Exactly.
> I don't see how replacing 'old' for 'untested' helps anybody to
> understand anything. Untested just implies we can't be bothered to test
> stuff before publishing it. And as previously stated, this is purely a
> political decision not a technical one. Sure, change the message to be
> 'Disabling GuC submission but enabling HuC loading via GuC on platform
> XXX' if that makes it clearer what is going on. Or just drop the message
> completely. It's simply explaining what the default option is for the
> current platform which you can also get by reading the code. However, I
> disagree that 'untested' is the correct message. Quite a lot of testing
> has been happening on TGL+ with GuC submission enabled.
>
This level of defense for what is clearly a bad *debug* message (at the
very least, the grammar) makes no sense at all!
I don't want to hear arguments like "Not my patch" from a developer
literally sending the patch to the ML and who added his SoB to the
patch, playing with words, or minimizing the problem of having such a
message.
>>>
>>> Agree that 'not my patch' is never a good excuse, but equally we can't
>>> blame original patch author as patch was updated few times since then.
>>
>> I never wanted to blame the author here, I was only speaking about the
>> handling of feedback on the patch.
>>
>>>
>>> Maybe to avoid confusions and simplify reviews, we could split this
>>> patch into two smaller: first one that really unblocks GuC submission on
>>> all Gen11+ (see __guc_submission_supported) and second one that updates
>>> defaults for Gen12+ (see uc_expand_default_options), as original patch
>>> (from ~2019) evolved more than what title/commit message says.
>>
>> Both work for me, as long
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On Tue, 6 Jul 2021 17:57:35 -0700
John Harrison wrote:
> On 7/3/2021 01:21, Martin Peres wrote:
> > On 02/07/2021 18:07, Michal Wajdeczko wrote:
> >> On 02.07.2021 10:09, Martin Peres wrote:
> >>> On 02/07/2021 10:29, Pekka Paalanen wrote:
> On Thu, 1 Jul 2021 21:28:06 +0200
> Daniel Vetter wrote:
>
> > On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
> > wrote:
> >>
> >> On 01/07/2021 11:14, Pekka Paalanen wrote:
> >>> On Wed, 30 Jun 2021 11:58:25 -0700
> >>> John Harrison wrote:
> On 6/30/2021 01:22, Martin Peres wrote:
> > On 24/06/2021 10:05, Matthew Brost wrote:
> >> From: Daniele Ceraolo Spurio
> >>
> >> Unblock GuC submission on Gen11+ platforms.
> >>
> >> Signed-off-by: Michal Wajdeczko
> >> Signed-off-by: Daniele Ceraolo Spurio
> >>
> >> Signed-off-by: Matthew Brost
> >> ---
> >> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 +
> >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
> >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
> >> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
> >> +-
> >> 4 files changed, 19 insertions(+), 7 deletions(-)
> >>>
> >>> ...
> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> >> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> >> index 7a69c3c027e9..61be0aa81492 100644
> >> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> >> @@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
> >> intel_uc *uc)
> >> return;
> >> }
> >> - /* Default: enable HuC authentication only */
> >> - i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
> >> + /* Intermediate platforms are HuC authentication only */
> >> + if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
> >> + drm_dbg(>drm, "Disabling GuC only due to old
> >> platform\n");
> >
> > This comment does not seem accurate, given that DG1 is barely
> > out, and
> > ADL is not out yet. How about:
> >
> > "Disabling GuC on untested platforms"?
> Just because something is not in the shops yet does not mean it is
> new.
> Technology is always obsolete by the time it goes on sale.
> >>>
> >>> That is a very good reason to not use terminology like "new",
> >>> "old",
> >>> "current", "modern" etc. at all.
> >>>
> >>> End users like me definitely do not share your interpretation of
> >>> "old".
> >>
> >> Yep, old and new is relative. In the end, what matters is the
> >> validation
> >> effort, which is why I was proposing "untested platforms".
> >>
> >> Also, remember that you are not writing these messages for Intel
> >> engineers, but instead are writing for Linux *users*.
> >
> > It's drm_dbg. Users don't read this stuff, at least not users with no
> > clue what the driver does and stuff like that.
>
> If I had a problem, I would read it, and I have no clue what anything
> of that is.
> >>>
> >>> Exactly.
> I don't see how replacing 'old' for 'untested' helps anybody to
> understand anything. Untested just implies we can't be bothered to test
> stuff before publishing it. And as previously stated, this is purely a
> political decision not a technical one. Sure, change the message to be
> 'Disabling GuC submission but enabling HuC loading via GuC on platform
> XXX' if that makes it clearer what is going on. Or just drop the message
> completely. It's simply explaining what the default option is for the
> current platform which you can also get by reading the code. However, I
> disagree that 'untested' is the correct message. Quite a lot of testing
> has been happening on TGL+ with GuC submission enabled.
Hi,
it seems to me that "untested" was just a wrong guess, nothing more. It
was presented with "how about?", not as an exact demand.
You don't have to attack that word, just use another phrasing that is
both correct and not misleading to the majority of tech savvy people.
Thanks,
pq
pgpEpnsZ3NSb3.pgp
Description: OpenPGP digital signature
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On 7/3/2021 01:21, Martin Peres wrote:
On 02/07/2021 18:07, Michal Wajdeczko wrote:
On 02.07.2021 10:09, Martin Peres wrote:
On 02/07/2021 10:29, Pekka Paalanen wrote:
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
On 6/30/2021 01:22, Martin Peres wrote:
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
+-
4 files changed, 19 insertions(+), 7 deletions(-)
...
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 7a69c3c027e9..61be0aa81492 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
intel_uc *uc)
return;
}
- /* Default: enable HuC authentication only */
- i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+ /* Intermediate platforms are HuC authentication only */
+ if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
+ drm_dbg(>drm, "Disabling GuC only due to old
platform\n");
This comment does not seem accurate, given that DG1 is barely
out, and
ADL is not out yet. How about:
"Disabling GuC on untested platforms"?
Just because something is not in the shops yet does not mean it is
new.
Technology is always obsolete by the time it goes on sale.
That is a very good reason to not use terminology like "new",
"old",
"current", "modern" etc. at all.
End users like me definitely do not share your interpretation of
"old".
Yep, old and new is relative. In the end, what matters is the
validation
effort, which is why I was proposing "untested platforms".
Also, remember that you are not writing these messages for Intel
engineers, but instead are writing for Linux *users*.
It's drm_dbg. Users don't read this stuff, at least not users with no
clue what the driver does and stuff like that.
If I had a problem, I would read it, and I have no clue what anything
of that is.
Exactly.
I don't see how replacing 'old' for 'untested' helps anybody to
understand anything. Untested just implies we can't be bothered to test
stuff before publishing it. And as previously stated, this is purely a
political decision not a technical one. Sure, change the message to be
'Disabling GuC submission but enabling HuC loading via GuC on platform
XXX' if that makes it clearer what is going on. Or just drop the message
completely. It's simply explaining what the default option is for the
current platform which you can also get by reading the code. However, I
disagree that 'untested' is the correct message. Quite a lot of testing
has been happening on TGL+ with GuC submission enabled.
This level of defense for what is clearly a bad *debug* message (at the
very least, the grammar) makes no sense at all!
I don't want to hear arguments like "Not my patch" from a developer
literally sending the patch to the ML and who added his SoB to the
patch, playing with words, or minimizing the problem of having such a
message.
Agree that 'not my patch' is never a good excuse, but equally we can't
blame original patch author as patch was updated few times since then.
I never wanted to blame the author here, I was only speaking about the
handling of feedback on the patch.
Maybe to avoid confusions and simplify reviews, we could split this
patch into two smaller: first one that really unblocks GuC submission on
all Gen11+ (see __guc_submission_supported) and second one that updates
defaults for Gen12+ (see uc_expand_default_options), as original patch
(from ~2019) evolved more than what title/commit message says.
Both work for me, as long as it is a collaborative effort.
I'm not seeing how splitting the patch up fixes the complaints about the
debug message.
And to be clear, no-one is actually arguing for a code change as such?
The issue is just about the text of the debug message? Or did I miss
something somewhere?
John.
Cheers,
Martin
Then we can fix all messaging and make sure it's clear and understood.
Thanks,
Michal
All of the above are just clear signals for the community to get off
your playground, which is frankly unacceptable. Your email address does
not matter.
In the spirit of collaboration, your response should have been "Good
catch, how about or ?". This would not have wasted everyone's
time in an attempt to just have it your way.
My level of confidence in this GuC transition was already low, but you
guys are working hard to
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On 02/07/2021 18:07, Michal Wajdeczko wrote:
On 02.07.2021 10:09, Martin Peres wrote:
On 02/07/2021 10:29, Pekka Paalanen wrote:
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
On 6/30/2021 01:22, Martin Peres wrote:
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
+-
4 files changed, 19 insertions(+), 7 deletions(-)
...
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 7a69c3c027e9..61be0aa81492 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
intel_uc *uc)
return;
}
- /* Default: enable HuC authentication only */
- i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+ /* Intermediate platforms are HuC authentication only */
+ if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
+ drm_dbg(>drm, "Disabling GuC only due to old
platform\n");
This comment does not seem accurate, given that DG1 is barely
out, and
ADL is not out yet. How about:
"Disabling GuC on untested platforms"?
Just because something is not in the shops yet does not mean it is
new.
Technology is always obsolete by the time it goes on sale.
That is a very good reason to not use terminology like "new", "old",
"current", "modern" etc. at all.
End users like me definitely do not share your interpretation of
"old".
Yep, old and new is relative. In the end, what matters is the
validation
effort, which is why I was proposing "untested platforms".
Also, remember that you are not writing these messages for Intel
engineers, but instead are writing for Linux *users*.
It's drm_dbg. Users don't read this stuff, at least not users with no
clue what the driver does and stuff like that.
If I had a problem, I would read it, and I have no clue what anything
of that is.
Exactly.
This level of defense for what is clearly a bad *debug* message (at the
very least, the grammar) makes no sense at all!
I don't want to hear arguments like "Not my patch" from a developer
literally sending the patch to the ML and who added his SoB to the
patch, playing with words, or minimizing the problem of having such a
message.
Agree that 'not my patch' is never a good excuse, but equally we can't
blame original patch author as patch was updated few times since then.
I never wanted to blame the author here, I was only speaking about the
handling of feedback on the patch.
Maybe to avoid confusions and simplify reviews, we could split this
patch into two smaller: first one that really unblocks GuC submission on
all Gen11+ (see __guc_submission_supported) and second one that updates
defaults for Gen12+ (see uc_expand_default_options), as original patch
(from ~2019) evolved more than what title/commit message says.
Both work for me, as long as it is a collaborative effort.
Cheers,
Martin
Then we can fix all messaging and make sure it's clear and understood.
Thanks,
Michal
All of the above are just clear signals for the community to get off
your playground, which is frankly unacceptable. Your email address does
not matter.
In the spirit of collaboration, your response should have been "Good
catch, how about or ?". This would not have wasted everyone's
time in an attempt to just have it your way.
My level of confidence in this GuC transition was already low, but you
guys are working hard to shoot yourself in the foot. Trust should be
earned!
Martin
Thanks,
pq
___
Intel-gfx mailing list
intel-...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On 02.07.2021 10:09, Martin Peres wrote:
> On 02/07/2021 10:29, Pekka Paalanen wrote:
>> On Thu, 1 Jul 2021 21:28:06 +0200
>> Daniel Vetter wrote:
>>
>>> On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
>>> wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
> On Wed, 30 Jun 2021 11:58:25 -0700
> John Harrison wrote:
>
>> On 6/30/2021 01:22, Martin Peres wrote:
>>> On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
+-
4 files changed, 19 insertions(+), 7 deletions(-)
>
> ...
>
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 7a69c3c027e9..61be0aa81492 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
intel_uc *uc)
return;
}
- /* Default: enable HuC authentication only */
- i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+ /* Intermediate platforms are HuC authentication only */
+ if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
+ drm_dbg(>drm, "Disabling GuC only due to old
platform\n");
>>>
>>> This comment does not seem accurate, given that DG1 is barely
>>> out, and
>>> ADL is not out yet. How about:
>>>
>>> "Disabling GuC on untested platforms"?
>>>
>> Just because something is not in the shops yet does not mean it is
>> new.
>> Technology is always obsolete by the time it goes on sale.
>
> That is a very good reason to not use terminology like "new", "old",
> "current", "modern" etc. at all.
>
> End users like me definitely do not share your interpretation of
> "old".
Yep, old and new is relative. In the end, what matters is the
validation
effort, which is why I was proposing "untested platforms".
Also, remember that you are not writing these messages for Intel
engineers, but instead are writing for Linux *users*.
>>>
>>> It's drm_dbg. Users don't read this stuff, at least not users with no
>>> clue what the driver does and stuff like that.
>>
>> If I had a problem, I would read it, and I have no clue what anything
>> of that is.
>
> Exactly.
>
> This level of defense for what is clearly a bad *debug* message (at the
> very least, the grammar) makes no sense at all!
>
> I don't want to hear arguments like "Not my patch" from a developer
> literally sending the patch to the ML and who added his SoB to the
> patch, playing with words, or minimizing the problem of having such a
> message.
Agree that 'not my patch' is never a good excuse, but equally we can't
blame original patch author as patch was updated few times since then.
Maybe to avoid confusions and simplify reviews, we could split this
patch into two smaller: first one that really unblocks GuC submission on
all Gen11+ (see __guc_submission_supported) and second one that updates
defaults for Gen12+ (see uc_expand_default_options), as original patch
(from ~2019) evolved more than what title/commit message says.
Then we can fix all messaging and make sure it's clear and understood.
Thanks,
Michal
>
> All of the above are just clear signals for the community to get off
> your playground, which is frankly unacceptable. Your email address does
> not matter.
>
> In the spirit of collaboration, your response should have been "Good
> catch, how about or ?". This would not have wasted everyone's
> time in an attempt to just have it your way.
>
> My level of confidence in this GuC transition was already low, but you
> guys are working hard to shoot yourself in the foot. Trust should be
> earned!
>
> Martin
>
>>
>>
>> Thanks,
>> pq
>>
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On 02/07/2021 10:29, Pekka Paalanen wrote:
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
On 6/30/2021 01:22, Martin Peres wrote:
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h| 1 +
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14 +-
4 files changed, 19 insertions(+), 7 deletions(-)
...
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 7a69c3c027e9..61be0aa81492 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
intel_uc *uc)
return;
}
-/* Default: enable HuC authentication only */
-i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+/* Intermediate platforms are HuC authentication only */
+if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
+drm_dbg(>drm, "Disabling GuC only due to old
platform\n");
This comment does not seem accurate, given that DG1 is barely out, and
ADL is not out yet. How about:
"Disabling GuC on untested platforms"?
Just because something is not in the shops yet does not mean it is new.
Technology is always obsolete by the time it goes on sale.
That is a very good reason to not use terminology like "new", "old",
"current", "modern" etc. at all.
End users like me definitely do not share your interpretation of "old".
Yep, old and new is relative. In the end, what matters is the validation
effort, which is why I was proposing "untested platforms".
Also, remember that you are not writing these messages for Intel
engineers, but instead are writing for Linux *users*.
It's drm_dbg. Users don't read this stuff, at least not users with no
clue what the driver does and stuff like that.
If I had a problem, I would read it, and I have no clue what anything
of that is.
Exactly.
This level of defense for what is clearly a bad *debug* message (at the
very least, the grammar) makes no sense at all!
I don't want to hear arguments like "Not my patch" from a developer
literally sending the patch to the ML and who added his SoB to the
patch, playing with words, or minimizing the problem of having such a
message.
All of the above are just clear signals for the community to get off
your playground, which is frankly unacceptable. Your email address does
not matter.
In the spirit of collaboration, your response should have been "Good
catch, how about or ?". This would not have wasted everyone's
time in an attempt to just have it your way.
My level of confidence in this GuC transition was already low, but you
guys are working hard to shoot yourself in the foot. Trust should be earned!
Martin
Thanks,
pq
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
> On Thu, Jul 1, 2021 at 8:27 PM Martin Peres wrote:
> >
> > On 01/07/2021 11:14, Pekka Paalanen wrote:
> > > On Wed, 30 Jun 2021 11:58:25 -0700
> > > John Harrison wrote:
> > >
> > >> On 6/30/2021 01:22, Martin Peres wrote:
> > >>> On 24/06/2021 10:05, Matthew Brost wrote:
> > From: Daniele Ceraolo Spurio
> >
> > Unblock GuC submission on Gen11+ platforms.
> >
> > Signed-off-by: Michal Wajdeczko
> > Signed-off-by: Daniele Ceraolo Spurio
> > Signed-off-by: Matthew Brost
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.h| 1 +
> > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
> > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
> > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14
> > +-
> > 4 files changed, 19 insertions(+), 7 deletions(-)
> >
> > >
> > > ...
> > >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > index 7a69c3c027e9..61be0aa81492 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> > @@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
> > intel_uc *uc)
> > return;
> > }
> > -/* Default: enable HuC authentication only */
> > -i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
> > +/* Intermediate platforms are HuC authentication only */
> > +if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
> > +drm_dbg(>drm, "Disabling GuC only due to old
> > platform\n");
> > >>>
> > >>> This comment does not seem accurate, given that DG1 is barely out, and
> > >>> ADL is not out yet. How about:
> > >>>
> > >>> "Disabling GuC on untested platforms"?
> > >>>
> > >> Just because something is not in the shops yet does not mean it is new.
> > >> Technology is always obsolete by the time it goes on sale.
> > >
> > > That is a very good reason to not use terminology like "new", "old",
> > > "current", "modern" etc. at all.
> > >
> > > End users like me definitely do not share your interpretation of "old".
> >
> > Yep, old and new is relative. In the end, what matters is the validation
> > effort, which is why I was proposing "untested platforms".
> >
> > Also, remember that you are not writing these messages for Intel
> > engineers, but instead are writing for Linux *users*.
>
> It's drm_dbg. Users don't read this stuff, at least not users with no
> clue what the driver does and stuff like that.
If I had a problem, I would read it, and I have no clue what anything
of that is.
Thanks,
pq
pgpKLgqlyzoiW.pgp
Description: OpenPGP digital signature
Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres wrote:
>
> On 01/07/2021 11:14, Pekka Paalanen wrote:
> > On Wed, 30 Jun 2021 11:58:25 -0700
> > John Harrison wrote:
> >
> >> On 6/30/2021 01:22, Martin Peres wrote:
> >>> On 24/06/2021 10:05, Matthew Brost wrote:
> From: Daniele Ceraolo Spurio
>
> Unblock GuC submission on Gen11+ platforms.
>
> Signed-off-by: Michal Wajdeczko
> Signed-off-by: Daniele Ceraolo Spurio
> Signed-off-by: Matthew Brost
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.h| 1 +
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h | 3 +--
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14 +-
> 4 files changed, 19 insertions(+), 7 deletions(-)
>
> >
> > ...
> >
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index 7a69c3c027e9..61be0aa81492 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -34,8 +34,15 @@ static void uc_expand_default_options(struct
> intel_uc *uc)
> return;
> }
> -/* Default: enable HuC authentication only */
> -i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
> +/* Intermediate platforms are HuC authentication only */
> +if (IS_DG1(i915) || IS_ALDERLAKE_S(i915)) {
> +drm_dbg(>drm, "Disabling GuC only due to old
> platform\n");
> >>>
> >>> This comment does not seem accurate, given that DG1 is barely out, and
> >>> ADL is not out yet. How about:
> >>>
> >>> "Disabling GuC on untested platforms"?
> >>>
> >> Just because something is not in the shops yet does not mean it is new.
> >> Technology is always obsolete by the time it goes on sale.
> >
> > That is a very good reason to not use terminology like "new", "old",
> > "current", "modern" etc. at all.
> >
> > End users like me definitely do not share your interpretation of "old".
>
> Yep, old and new is relative. In the end, what matters is the validation
> effort, which is why I was proposing "untested platforms".
>
> Also, remember that you are not writing these messages for Intel
> engineers, but instead are writing for Linux *users*.
It's drm_dbg. Users don't read this stuff, at least not users with no
clue what the driver does and stuff like that.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
