Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
> On 05/06/2023 09:53, Tvrtko Ursulin wrote:
>> On 31/05/2023 18:10, fei.y...@intel.com wrote:
>>> From: Fei Yang
>>>
>>> This series introduce a new extension for GEM_CREATE,
>>> 1. end support for set caching ioctl [PATCH 1/2]
>>> 2. add set_pat extension for gem_create [PATCH 2/2]
>>>
>>> v2: drop one patch that was merged separately
>>> commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
>>> v3: rebased on https://patchwork.freedesktop.org/series/117082/
>>> v4: fix missing unlock introduced in v3, and
>>> solve a rebase conflict
>>> v5: replace obj->cache_level with pat_set_by_user,
>>> fix i915_cache_level_str() for legacy platforms.
>>> v6: rebased on https://patchwork.freedesktop.org/series/117480/
>>> v7: rebased on https://patchwork.freedesktop.org/series/117528/
>>> v8: dropped the two dependent patches that has been merged
>>> separately. Add IGT link and Tested-by (MESA).
>>> v9: addressing comments (Andi)
>>> v10: acked-by and tested-by MESA
>>> v11: drop "end support for set caching ioctl" (merged)
>>> remove tools/include/uapi/drm/i915_drm.h
>>> v12: drop Bspec reference in comment. add to commit message instead
>>> v13: sent to test with igt@gem_create@create-ext-set-pat
>>> v14: sent to test with igt@gem_create@create-ext-set-pat
>>> v15: update commit message with documentation note and t-b/a-b from
>>> Media driver folks.
>>>
>>> Fei Yang (1):
>>>drm/i915: Allow user to set cache at BO creation
>>>
>>> drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++
>>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 6
>>> include/uapi/drm/i915_drm.h| 41 ++
>>> 3 files changed, 83 insertions(+)
>>>
>>
>> Try with:
>>
>> Test-with: 20230526172221.1438998-1-fei.y...@intel.com
>>
>> That is how it is supposed to be done, to do a CI run against a test
>> case not yet merged that is.
Yes, the result can be found at https://patchwork.freedesktop.org/series/116870/
, under rev14, expand Fi.CI.IGT, you would see,
New IGT tests (1)
igt@gem_create@create-ext-set-pat:
Statuses : 6 pass(s)
Exec time: [0.0] s
> Or I see that IGT has been since merged so you probably have results
> already?
Seems like the last update ran into some random failure which caused CI to stop.
> Regards,
>
> Tvrtko
Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
On Mon, Jun 05, 2023 at 10:16:22AM +0100, Tvrtko Ursulin wrote:
>
> On 05/06/2023 09:53, Tvrtko Ursulin wrote:
> >
> > On 31/05/2023 18:10, fei.y...@intel.com wrote:
> > > From: Fei Yang
> > >
> > > This series introduce a new extension for GEM_CREATE,
> > > 1. end support for set caching ioctl [PATCH 1/2]
> > > 2. add set_pat extension for gem_create [PATCH 2/2]
> > >
> > > v2: drop one patch that was merged separately
> > > commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
> > > v3: rebased on https://patchwork.freedesktop.org/series/117082/
> > > v4: fix missing unlock introduced in v3, and
> > > solve a rebase conflict
> > > v5: replace obj->cache_level with pat_set_by_user,
> > > fix i915_cache_level_str() for legacy platforms.
> > > v6: rebased on https://patchwork.freedesktop.org/series/117480/
> > > v7: rebased on https://patchwork.freedesktop.org/series/117528/
> > > v8: dropped the two dependent patches that has been merged
> > > separately. Add IGT link and Tested-by (MESA).
> > > v9: addressing comments (Andi)
> > > v10: acked-by and tested-by MESA
> > > v11: drop "end support for set caching ioctl" (merged)
> > > remove tools/include/uapi/drm/i915_drm.h
> > > v12: drop Bspec reference in comment. add to commit message instead
> > > v13: sent to test with igt@gem_create@create-ext-set-pat
> > > v14: sent to test with igt@gem_create@create-ext-set-pat
> > > v15: update commit message with documentation note and t-b/a-b from
> > > Media driver folks.
> > >
> > > Fei Yang (1):
> > > drm/i915: Allow user to set cache at BO creation
> > >
> > > drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++
> > > drivers/gpu/drm/i915/gem/i915_gem_object.c | 6
> > > include/uapi/drm/i915_drm.h | 41 ++
> > > 3 files changed, 83 insertions(+)
> > >
> >
> > Try with:
> >
> > Test-with: 20230526172221.1438998-1-fei.y...@intel.com
> >
> > That is how it is supposed to be done, to do a CI run against a test
> > case not yet merged that is.
>
> Or I see that IGT has been since merged so you probably have results
> already?
CI has stopped somewhere in the BAT tests. Can anyone hit the
"Test revision 1 again" button? Fei, would you?
We had it tested some revisions back, though.
Andi
Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
On 05/06/2023 09:53, Tvrtko Ursulin wrote:
On 31/05/2023 18:10, fei.y...@intel.com wrote:
From: Fei Yang
This series introduce a new extension for GEM_CREATE,
1. end support for set caching ioctl [PATCH 1/2]
2. add set_pat extension for gem_create [PATCH 2/2]
v2: drop one patch that was merged separately
commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
v3: rebased on https://patchwork.freedesktop.org/series/117082/
v4: fix missing unlock introduced in v3, and
solve a rebase conflict
v5: replace obj->cache_level with pat_set_by_user,
fix i915_cache_level_str() for legacy platforms.
v6: rebased on https://patchwork.freedesktop.org/series/117480/
v7: rebased on https://patchwork.freedesktop.org/series/117528/
v8: dropped the two dependent patches that has been merged
separately. Add IGT link and Tested-by (MESA).
v9: addressing comments (Andi)
v10: acked-by and tested-by MESA
v11: drop "end support for set caching ioctl" (merged)
remove tools/include/uapi/drm/i915_drm.h
v12: drop Bspec reference in comment. add to commit message instead
v13: sent to test with igt@gem_create@create-ext-set-pat
v14: sent to test with igt@gem_create@create-ext-set-pat
v15: update commit message with documentation note and t-b/a-b from
Media driver folks.
Fei Yang (1):
drm/i915: Allow user to set cache at BO creation
drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++
drivers/gpu/drm/i915/gem/i915_gem_object.c | 6
include/uapi/drm/i915_drm.h | 41 ++
3 files changed, 83 insertions(+)
Try with:
Test-with: 20230526172221.1438998-1-fei.y...@intel.com
That is how it is supposed to be done, to do a CI run against a test
case not yet merged that is.
Or I see that IGT has been since merged so you probably have results
already?
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
On 31/05/2023 18:10, fei.y...@intel.com wrote:
From: Fei Yang
This series introduce a new extension for GEM_CREATE,
1. end support for set caching ioctl [PATCH 1/2]
2. add set_pat extension for gem_create [PATCH 2/2]
v2: drop one patch that was merged separately
commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
v3: rebased on https://patchwork.freedesktop.org/series/117082/
v4: fix missing unlock introduced in v3, and
solve a rebase conflict
v5: replace obj->cache_level with pat_set_by_user,
fix i915_cache_level_str() for legacy platforms.
v6: rebased on https://patchwork.freedesktop.org/series/117480/
v7: rebased on https://patchwork.freedesktop.org/series/117528/
v8: dropped the two dependent patches that has been merged
separately. Add IGT link and Tested-by (MESA).
v9: addressing comments (Andi)
v10: acked-by and tested-by MESA
v11: drop "end support for set caching ioctl" (merged)
remove tools/include/uapi/drm/i915_drm.h
v12: drop Bspec reference in comment. add to commit message instead
v13: sent to test with igt@gem_create@create-ext-set-pat
v14: sent to test with igt@gem_create@create-ext-set-pat
v15: update commit message with documentation note and t-b/a-b from
Media driver folks.
Fei Yang (1):
drm/i915: Allow user to set cache at BO creation
drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++
drivers/gpu/drm/i915/gem/i915_gem_object.c | 6
include/uapi/drm/i915_drm.h| 41 ++
3 files changed, 83 insertions(+)
Try with:
Test-with: 20230526172221.1438998-1-fei.y...@intel.com
That is how it is supposed to be done, to do a CI run against a test
case not yet merged that is.
Regards,
Tvrtko
