[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
On 16 September 2014 04:51, Ezequiel Garcia wrote: > On 15 Sep 05:59 PM, Dave Airlie wrote: >> On 15 September 2014 17:50, Ezequiel Garcia >> wrote: >> > Dave, >> > >> > On 03 Sep 08:08 AM, Johannes Pointner wrote: >> >> 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia > >> vanguardiasur.com.ar>: >> >> > Dave, >> >> > >> >> > I'm resending this, hoping it can be pushed for v3.18. The patchset was >> >> > ready for v3.17, but it got no maintainer feedback or review. Maybe it >> >> > fell >> >> > through some crack? >> >> > >> >> > Just for reference, here goes the details about this series and why it's >> >> > needed: >> >> > >> >> > This patchset adds the required changes to support an optional backlight >> >> > and GPIO for the tilcdc panel driver. >> >> > >> >> > There was some code to support a backlight, but it was broken and >> >> > undocumented. >> >> > I've followed the nice implementation in panel-simple and added a >> >> > similar >> >> > one here. >> >> > >> >> > The enable GPIO is required to turn on and off devices with such >> >> > capability. >> >> > Also here, I've followed panel-simple which looks correct. >> >> > >> >> > In addition to this there are very minor cosmetic cleanups and a larger >> >> > fix for the error path in tilcdc's DRM driver .load error path. >> >> > >> >> >> >> I tested the series with 3.16.1 (with additonal patches from Guido and >> >> Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for >> >> me without an issue. I tried it with and without the backlight >> >> addition in the dts file. >> >> >> >> For the series: >> >> Tested-by: Johannes Pointner >> >> >> > >> > Any feedback for this series? >> > >> > If at all possible, it'd be great to not miss the merge this time. >> >> Could you stick it in a git tree somewhere? and send a pull request for it? >> > > Hm.. I really don't have a git tree ready :/ > > Do you think you can pick the patches this time? I'll setup a tree as soon > as possible. Okay pushed to drm-next. Dave.
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
On 15 Sep 05:59 PM, Dave Airlie wrote: > On 15 September 2014 17:50, Ezequiel Garcia > wrote: > > Dave, > > > > On 03 Sep 08:08 AM, Johannes Pointner wrote: > >> 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia >> vanguardiasur.com.ar>: > >> > Dave, > >> > > >> > I'm resending this, hoping it can be pushed for v3.18. The patchset was > >> > ready for v3.17, but it got no maintainer feedback or review. Maybe it > >> > fell > >> > through some crack? > >> > > >> > Just for reference, here goes the details about this series and why it's > >> > needed: > >> > > >> > This patchset adds the required changes to support an optional backlight > >> > and GPIO for the tilcdc panel driver. > >> > > >> > There was some code to support a backlight, but it was broken and > >> > undocumented. > >> > I've followed the nice implementation in panel-simple and added a similar > >> > one here. > >> > > >> > The enable GPIO is required to turn on and off devices with such > >> > capability. > >> > Also here, I've followed panel-simple which looks correct. > >> > > >> > In addition to this there are very minor cosmetic cleanups and a larger > >> > fix for the error path in tilcdc's DRM driver .load error path. > >> > > >> > >> I tested the series with 3.16.1 (with additonal patches from Guido and > >> Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for > >> me without an issue. I tried it with and without the backlight > >> addition in the dts file. > >> > >> For the series: > >> Tested-by: Johannes Pointner > >> > > > > Any feedback for this series? > > > > If at all possible, it'd be great to not miss the merge this time. > > Could you stick it in a git tree somewhere? and send a pull request for it? > Hm.. I really don't have a git tree ready :/ Do you think you can pick the patches this time? I'll setup a tree as soon as possible. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
On 15 September 2014 17:50, Ezequiel Garcia wrote: > Dave, > > On 03 Sep 08:08 AM, Johannes Pointner wrote: >> 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia > vanguardiasur.com.ar>: >> > Dave, >> > >> > I'm resending this, hoping it can be pushed for v3.18. The patchset was >> > ready for v3.17, but it got no maintainer feedback or review. Maybe it fell >> > through some crack? >> > >> > Just for reference, here goes the details about this series and why it's >> > needed: >> > >> > This patchset adds the required changes to support an optional backlight >> > and GPIO for the tilcdc panel driver. >> > >> > There was some code to support a backlight, but it was broken and >> > undocumented. >> > I've followed the nice implementation in panel-simple and added a similar >> > one here. >> > >> > The enable GPIO is required to turn on and off devices with such >> > capability. >> > Also here, I've followed panel-simple which looks correct. >> > >> > In addition to this there are very minor cosmetic cleanups and a larger >> > fix for the error path in tilcdc's DRM driver .load error path. >> > >> >> I tested the series with 3.16.1 (with additonal patches from Guido and >> Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for >> me without an issue. I tried it with and without the backlight >> addition in the dts file. >> >> For the series: >> Tested-by: Johannes Pointner >> > > Any feedback for this series? > > If at all possible, it'd be great to not miss the merge this time. Could you stick it in a git tree somewhere? and send a pull request for it? Dave.
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
Dave, On 03 Sep 08:08 AM, Johannes Pointner wrote: > 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia : > > Dave, > > > > I'm resending this, hoping it can be pushed for v3.18. The patchset was > > ready for v3.17, but it got no maintainer feedback or review. Maybe it fell > > through some crack? > > > > Just for reference, here goes the details about this series and why it's > > needed: > > > > This patchset adds the required changes to support an optional backlight > > and GPIO for the tilcdc panel driver. > > > > There was some code to support a backlight, but it was broken and > > undocumented. > > I've followed the nice implementation in panel-simple and added a similar > > one here. > > > > The enable GPIO is required to turn on and off devices with such capability. > > Also here, I've followed panel-simple which looks correct. > > > > In addition to this there are very minor cosmetic cleanups and a larger > > fix for the error path in tilcdc's DRM driver .load error path. > > > > I tested the series with 3.16.1 (with additonal patches from Guido and > Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for > me without an issue. I tried it with and without the backlight > addition in the dts file. > > For the series: > Tested-by: Johannes Pointner > Any feedback for this series? If at all possible, it'd be great to not miss the merge this time. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
2014-09-02 14:51 GMT+02:00 Ezequiel Garcia : > Dave, > > I'm resending this, hoping it can be pushed for v3.18. The patchset was > ready for v3.17, but it got no maintainer feedback or review. Maybe it fell > through some crack? > > Just for reference, here goes the details about this series and why it's > needed: > > This patchset adds the required changes to support an optional backlight > and GPIO for the tilcdc panel driver. > > There was some code to support a backlight, but it was broken and > undocumented. > I've followed the nice implementation in panel-simple and added a similar > one here. > > The enable GPIO is required to turn on and off devices with such capability. > Also here, I've followed panel-simple which looks correct. > > In addition to this there are very minor cosmetic cleanups and a larger > fix for the error path in tilcdc's DRM driver .load error path. > I tested the series with 3.16.1 (with additonal patches from Guido and Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for me without an issue. I tried it with and without the backlight addition in the dts file. For the series: Tested-by: Johannes Pointner > Ezequiel Garcia (8): > drm/tilcdc: Fix the error path in tilcdc_load() > drm/tilcdc: panel: Add missing of_node_put > drm/tilcdc: panel: Remove unused variable > drm/tilcdc: panel: Spurious whitespace removal > drm/tilcdc: panel: Use devm_kzalloc to simplify the error path > drm/tilcdc: panel: Fix backlight devicetree support > drm/tilcdc: panel: Set return value explicitly > drm/tilcdc: panel: Add support for enable GPIO > > .../devicetree/bindings/drm/tilcdc/panel.txt | 7 ++ > drivers/gpu/drm/tilcdc/tilcdc_drv.c| 60 +++--- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 74 > +- > 3 files changed, 114 insertions(+), 27 deletions(-) > > -- > 2.0.1 >
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
On 3 September 2014 03:08, Johannes Pointner wrote: [..] > > I tested the series with 3.16.1 (with additonal patches from Guido and > Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for > me without an issue. I tried it with and without the backlight > addition in the dts file. > > For the series: > Tested-by: Johannes Pointner > Thanks a lot for the test, -- Ezequiel Garc?a, VanguardiaSur www.vanguardiasur.com.ar
[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support
Dave, I'm resending this, hoping it can be pushed for v3.18. The patchset was ready for v3.17, but it got no maintainer feedback or review. Maybe it fell through some crack? Just for reference, here goes the details about this series and why it's needed: This patchset adds the required changes to support an optional backlight and GPIO for the tilcdc panel driver. There was some code to support a backlight, but it was broken and undocumented. I've followed the nice implementation in panel-simple and added a similar one here. The enable GPIO is required to turn on and off devices with such capability. Also here, I've followed panel-simple which looks correct. In addition to this there are very minor cosmetic cleanups and a larger fix for the error path in tilcdc's DRM driver .load error path. Ezequiel Garcia (8): drm/tilcdc: Fix the error path in tilcdc_load() drm/tilcdc: panel: Add missing of_node_put drm/tilcdc: panel: Remove unused variable drm/tilcdc: panel: Spurious whitespace removal drm/tilcdc: panel: Use devm_kzalloc to simplify the error path drm/tilcdc: panel: Fix backlight devicetree support drm/tilcdc: panel: Set return value explicitly drm/tilcdc: panel: Add support for enable GPIO .../devicetree/bindings/drm/tilcdc/panel.txt | 7 ++ drivers/gpu/drm/tilcdc/tilcdc_drv.c| 60 +++--- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 74 +- 3 files changed, 114 insertions(+), 27 deletions(-) -- 2.0.1
