Re: [PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
Hi Laurent,
On Tue, Jan 22, 2019 at 4:07 AM Laurent Pinchart
wrote:
> On Mon, Jan 21, 2019 at 11:18:26AM +0100, Daniel Vetter wrote:
> > On Mon, Jan 21, 2019 at 11:03:44AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, Jan 21, 2019 at 10:35 AM Daniel Vetter wrote:
> > >> On Fri, Jan 18, 2019 at 05:22:58PM +0100, Geert Uytterhoeven wrote:
> > >>> Since its incarnation in v3.7 almost 7 years ago, no users of the SH
> > >>> Mobile DRM driver have appeared.
> > >>>
> > >>> Hence remove the driver. It can be resurrected from git history,
> > >>> if/when needed.
> > >>>
> > >>> Signed-off-by: Geert Uytterhoeven
> > >>
> > >> I'd prefer removing the fbdev variant tbh ...
> > >
> > > I understand ;-)
> > >
> > > But sh_mobile_lcdc_fb is used on 5 legacy SuperH platforms, and 1 ARM
> > > platform. At least the latter is working fine.
> > >
> > >> Not sure why exactly the switch never happened.
> > >
> > > Me neither. I^HGoogle can't even find posted patches of board
> > > integration.
> > >
> > > Note that both drivers lack DT support, which would be very desirable on
> > > ARM, as graphics is the single remaining working driver on the Atmark
> > > Techno Armadillo 800 EVA board not using DT.
> >
> > Ah I wondered why the drm driver isn't just automatically picked up in
> > today's neat world of DT (if you enable it in .config instead of the fbdev
> > one). It's not even using DT yet :-/
>
> I'd prefer dropping the fbdev driver too, but that would require porting
> the SH boards to the DRM driver, and implement DT support for the ARM
> board. I don't think anyone is willing to invest time in this, so I'm
> fine dropping this driver as the boards are pretty much dead. I would,
> however, also drop the fbdev driver in that case.
I agree the SH boards are pretty much dead.
However, derivatives of the Armadillo-800 EVA board are still available[1],
and even received a product update last month[2].
A relative made it to the International Space Station in 2017[3].
[1] https://armadillo.atmark-techno.com/products
[2] https://armadillo.atmark-techno.com/armadillo-840
[3] https://lists.freedesktop.org/archives/gstreamer-devel/2017-July/064696.html
BTW, do you still have the prototype integration patches for the DRM driver,
presumably for SH-Mobile AP4?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
Hello, On Mon, Jan 21, 2019 at 11:18:26AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 11:03:44AM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 21, 2019 at 10:35 AM Daniel Vetter wrote: > >> On Fri, Jan 18, 2019 at 05:22:58PM +0100, Geert Uytterhoeven wrote: > >>> Since its incarnation in v3.7 almost 7 years ago, no users of the SH > >>> Mobile DRM driver have appeared. > >>> > >>> Hence remove the driver. It can be resurrected from git history, > >>> if/when needed. > >>> > >>> Signed-off-by: Geert Uytterhoeven > >> > >> I'd prefer removing the fbdev variant tbh ... > > > > I understand ;-) > > > > But sh_mobile_lcdc_fb is used on 5 legacy SuperH platforms, and 1 ARM > > platform. At least the latter is working fine. > > > >> Not sure why exactly the switch never happened. > > > > Me neither. I^HGoogle can't even find posted patches of board integration. > > > > Note that both drivers lack DT support, which would be very desirable on > > ARM, as graphics is the single remaining working driver on the Atmark > > Techno Armadillo 800 EVA board not using DT. > > Ah I wondered why the drm driver isn't just automatically picked up in > today's neat world of DT (if you enable it in .config instead of the fbdev > one). It's not even using DT yet :-/ I'd prefer dropping the fbdev driver too, but that would require porting the SH boards to the DRM driver, and implement DT support for the ARM board. I don't think anyone is willing to invest time in this, so I'm fine dropping this driver as the boards are pretty much dead. I would, however, also drop the fbdev driver in that case. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
On Mon, Jan 21, 2019 at 11:03:44AM +0100, Geert Uytterhoeven wrote: > Hi Daniel, > > On Mon, Jan 21, 2019 at 10:35 AM Daniel Vetter wrote: > > On Fri, Jan 18, 2019 at 05:22:58PM +0100, Geert Uytterhoeven wrote: > > > Since its incarnation in v3.7 almost 7 years ago, no users of the SH > > > Mobile DRM driver have appeared. > > > > > > Hence remove the driver. It can be resurrected from git history, > > > if/when needed. > > > > > > Signed-off-by: Geert Uytterhoeven > > > > I'd prefer removing the fbdev variant tbh ... > > I understand ;-) > > But sh_mobile_lcdc_fb is used on 5 legacy SuperH platforms, and 1 ARM > platform. At least the latter is working fine. > > > Not sure why exactly the switch never happened. > > Me neither. I^HGoogle can't even find posted patches of board integration. > > Note that both drivers lack DT support, which would be very desirable on > ARM, as graphics is the single remaining working driver on the Atmark > Techno Armadillo 800 EVA board not using DT. Ah I wondered why the drm driver isn't just automatically picked up in today's neat world of DT (if you enable it in .config instead of the fbdev one). It's not even using DT yet :-/ -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
Hi Daniel,
On Mon, Jan 21, 2019 at 10:35 AM Daniel Vetter wrote:
> On Fri, Jan 18, 2019 at 05:22:58PM +0100, Geert Uytterhoeven wrote:
> > Since its incarnation in v3.7 almost 7 years ago, no users of the SH
> > Mobile DRM driver have appeared.
> >
> > Hence remove the driver. It can be resurrected from git history,
> > if/when needed.
> >
> > Signed-off-by: Geert Uytterhoeven
>
> I'd prefer removing the fbdev variant tbh ...
I understand ;-)
But sh_mobile_lcdc_fb is used on 5 legacy SuperH platforms, and 1 ARM
platform. At least the latter is working fine.
> Not sure why exactly the switch never happened.
Me neither. I^HGoogle can't even find posted patches of board integration.
Note that both drivers lack DT support, which would be very desirable on
ARM, as graphics is the single remaining working driver on the Atmark
Techno Armadillo 800 EVA board not using DT.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
On Fri, Jan 18, 2019 at 05:22:58PM +0100, Geert Uytterhoeven wrote: > Since its incarnation in v3.7 almost 7 years ago, no users of the SH > Mobile DRM driver have appeared. > > Hence remove the driver. It can be resurrected from git history, > if/when needed. > > Signed-off-by: Geert Uytterhoeven I'd prefer removing the fbdev variant tbh ... Not sure why exactly the switch never happened. -Daniel > --- > Against drm/drm-next > > MAINTAINERS | 2 - > drivers/gpu/drm/Kconfig | 2 - > drivers/gpu/drm/Makefile | 1 - > drivers/gpu/drm/shmobile/Kconfig | 14 - > drivers/gpu/drm/shmobile/Makefile | 8 - > .../gpu/drm/shmobile/shmob_drm_backlight.c| 86 --- > .../gpu/drm/shmobile/shmob_drm_backlight.h| 19 - > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 689 -- > drivers/gpu/drm/shmobile/shmob_drm_crtc.h | 53 -- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 311 > drivers/gpu/drm/shmobile/shmob_drm_drv.h | 41 -- > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 146 > drivers/gpu/drm/shmobile/shmob_drm_kms.h | 29 - > drivers/gpu/drm/shmobile/shmob_drm_plane.c| 259 --- > drivers/gpu/drm/shmobile/shmob_drm_plane.h| 18 - > drivers/gpu/drm/shmobile/shmob_drm_regs.h | 307 > include/linux/platform_data/shmob_drm.h | 91 --- > 17 files changed, 2076 deletions(-) > delete mode 100644 drivers/gpu/drm/shmobile/Kconfig > delete mode 100644 drivers/gpu/drm/shmobile/Makefile > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h > delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h > delete mode 100644 include/linux/platform_data/shmob_drm.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4c0879650caf3c10..61009a7be8862d68 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5098,8 +5098,6 @@ L: linux-renesas-...@vger.kernel.org > T: git git://linuxtv.org/pinchartl/media drm/du/next > S: Supported > F: drivers/gpu/drm/rcar-du/ > -F: drivers/gpu/drm/shmobile/ > -F: include/linux/platform_data/shmob_drm.h > F: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > F: Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > F: Documentation/devicetree/bindings/display/renesas,du.txt > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index bd943a71756ca81b..3df7b8905ca8b736 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -273,8 +273,6 @@ source "drivers/gpu/drm/atmel-hlcdc/Kconfig" > > source "drivers/gpu/drm/rcar-du/Kconfig" > > -source "drivers/gpu/drm/shmobile/Kconfig" > - > source "drivers/gpu/drm/sun4i/Kconfig" > > source "drivers/gpu/drm/omapdrm/Kconfig" > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index f0c1f8731a2761ed..9b5bee490a899468 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -82,7 +82,6 @@ obj-$(CONFIG_DRM_AST) += ast/ > obj-$(CONFIG_DRM_ARMADA) += armada/ > obj-$(CONFIG_DRM_ATMEL_HLCDC)+= atmel-hlcdc/ > obj-$(CONFIG_DRM_RCAR_DU) += rcar-du/ > -obj-$(CONFIG_DRM_SHMOBILE) +=shmobile/ > obj-y+= omapdrm/ > obj-$(CONFIG_DRM_SUN4I) += sun4i/ > obj-y+= tilcdc/ > diff --git a/drivers/gpu/drm/shmobile/Kconfig > b/drivers/gpu/drm/shmobile/Kconfig > deleted file mode 100644 > index 61bbe8e8bcc51db9.. > --- a/drivers/gpu/drm/shmobile/Kconfig > +++ /dev/null > @@ -1,14 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0 > -config DRM_SHMOBILE > - tristate "DRM Support for SH Mobile" > - depends on DRM && ARM > - depends on ARCH_SHMOBILE || COMPILE_TEST > - select BACKLIGHT_CLASS_DEVICE > - select BACKLIGHT_LCD_SUPPORT > - select DRM_KMS_HELPER > - select DRM_KMS_CMA_HELPER > - select DRM_GEM_CMA_HELPER > - help > - Choose this option if you have an SH Mobile chipset. > - If M is selected the module will be called shmob-drm. > - > diff --git a/drivers/gpu/drm/shmobile/Makefile > b/drivers/gpu/drm/shmobile/Makefile > deleted file mode 100644 > index 861edafed8562c87.. > --- a/drivers/gpu/drm/shmobile/Makefile > +++ /dev/null > @@ -1,8 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0 > -shmob-drm-y :=
[PATCH/RFC] drm: Remove unused Renesas SH Mobile DRM driver
Since its incarnation in v3.7 almost 7 years ago, no users of the SH Mobile DRM driver have appeared. Hence remove the driver. It can be resurrected from git history, if/when needed. Signed-off-by: Geert Uytterhoeven --- Against drm/drm-next MAINTAINERS | 2 - drivers/gpu/drm/Kconfig | 2 - drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/shmobile/Kconfig | 14 - drivers/gpu/drm/shmobile/Makefile | 8 - .../gpu/drm/shmobile/shmob_drm_backlight.c| 86 --- .../gpu/drm/shmobile/shmob_drm_backlight.h| 19 - drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 689 -- drivers/gpu/drm/shmobile/shmob_drm_crtc.h | 53 -- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 311 drivers/gpu/drm/shmobile/shmob_drm_drv.h | 41 -- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 146 drivers/gpu/drm/shmobile/shmob_drm_kms.h | 29 - drivers/gpu/drm/shmobile/shmob_drm_plane.c| 259 --- drivers/gpu/drm/shmobile/shmob_drm_plane.h| 18 - drivers/gpu/drm/shmobile/shmob_drm_regs.h | 307 include/linux/platform_data/shmob_drm.h | 91 --- 17 files changed, 2076 deletions(-) delete mode 100644 drivers/gpu/drm/shmobile/Kconfig delete mode 100644 drivers/gpu/drm/shmobile/Makefile delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h delete mode 100644 include/linux/platform_data/shmob_drm.h diff --git a/MAINTAINERS b/MAINTAINERS index 4c0879650caf3c10..61009a7be8862d68 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5098,8 +5098,6 @@ L:linux-renesas-...@vger.kernel.org T: git git://linuxtv.org/pinchartl/media drm/du/next S: Supported F: drivers/gpu/drm/rcar-du/ -F: drivers/gpu/drm/shmobile/ -F: include/linux/platform_data/shmob_drm.h F: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt F: Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt F: Documentation/devicetree/bindings/display/renesas,du.txt diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index bd943a71756ca81b..3df7b8905ca8b736 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -273,8 +273,6 @@ source "drivers/gpu/drm/atmel-hlcdc/Kconfig" source "drivers/gpu/drm/rcar-du/Kconfig" -source "drivers/gpu/drm/shmobile/Kconfig" - source "drivers/gpu/drm/sun4i/Kconfig" source "drivers/gpu/drm/omapdrm/Kconfig" diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index f0c1f8731a2761ed..9b5bee490a899468 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -82,7 +82,6 @@ obj-$(CONFIG_DRM_AST) += ast/ obj-$(CONFIG_DRM_ARMADA) += armada/ obj-$(CONFIG_DRM_ATMEL_HLCDC) += atmel-hlcdc/ obj-$(CONFIG_DRM_RCAR_DU) += rcar-du/ -obj-$(CONFIG_DRM_SHMOBILE) +=shmobile/ obj-y += omapdrm/ obj-$(CONFIG_DRM_SUN4I) += sun4i/ obj-y += tilcdc/ diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig deleted file mode 100644 index 61bbe8e8bcc51db9.. --- a/drivers/gpu/drm/shmobile/Kconfig +++ /dev/null @@ -1,14 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -config DRM_SHMOBILE - tristate "DRM Support for SH Mobile" - depends on DRM && ARM - depends on ARCH_SHMOBILE || COMPILE_TEST - select BACKLIGHT_CLASS_DEVICE - select BACKLIGHT_LCD_SUPPORT - select DRM_KMS_HELPER - select DRM_KMS_CMA_HELPER - select DRM_GEM_CMA_HELPER - help - Choose this option if you have an SH Mobile chipset. - If M is selected the module will be called shmob-drm. - diff --git a/drivers/gpu/drm/shmobile/Makefile b/drivers/gpu/drm/shmobile/Makefile deleted file mode 100644 index 861edafed8562c87.. --- a/drivers/gpu/drm/shmobile/Makefile +++ /dev/null @@ -1,8 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -shmob-drm-y := shmob_drm_backlight.o \ - shmob_drm_crtc.o \ - shmob_drm_drv.o \ - shmob_drm_kms.o \ - shmob_drm_plane.o - -obj-$(CONFIG_DRM_SHMOBILE) += shmob-drm.o diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c deleted file mode 100644 index f6628a5ee95f3e9a.. ---
