Re: [PATCH] Documentation/gpu: Update amdgpu documentation

2023-08-16 Thread Lazar, Lijo 




On 8/17/2023 2:16 AM, Alex Deucher wrote:

On Wed, Aug 16, 2023 at 12:15 AM Lijo Lazar  wrote:


7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
Update the documentation accordingly.

Signed-off-by: Lijo Lazar 
---
  Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/amdgpu/driver-misc.rst 
b/Documentation/gpu/amdgpu/driver-misc.rst
index be131e963d87..26334e54447b 100644
--- a/Documentation/gpu/amdgpu/driver-misc.rst
+++ b/Documentation/gpu/amdgpu/driver-misc.rst
@@ -11,19 +11,19 @@ via sysfs
  product_name
  

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
 :doc: product_name

  product_number
  --

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
 :doc: product_name


I think this should be product_number

Alex



Thanks, made the change while pushing.

Thanks,
Lijo



  serial_number
  -

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
 :doc: serial_number

  unique_id
--
2.25.1

Re: [PATCH] Documentation/gpu: Update amdgpu documentation

2023-08-16 Thread Alex Deucher 
On Wed, Aug 16, 2023 at 12:15 AM Lijo Lazar  wrote:
>
> 7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
> the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
> Update the documentation accordingly.
>
> Signed-off-by: Lijo Lazar 
> ---
>  Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/gpu/amdgpu/driver-misc.rst 
> b/Documentation/gpu/amdgpu/driver-misc.rst
> index be131e963d87..26334e54447b 100644
> --- a/Documentation/gpu/amdgpu/driver-misc.rst
> +++ b/Documentation/gpu/amdgpu/driver-misc.rst
> @@ -11,19 +11,19 @@ via sysfs
>  product_name
>  
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
> :doc: product_name
>
>  product_number
>  --
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
> :doc: product_name

I think this should be product_number

Alex

>
>  serial_number
>  -
>
> -.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
> :doc: serial_number
>
>  unique_id
> --
> 2.25.1
>

Re: [PATCH] Documentation/gpu: Update amdgpu documentation

2023-08-16 Thread Deucher, Alexander 
[AMD Official Use Only - General]

Reviewed-by: Alex Deucher 

From: Lazar, Lijo 
Sent: Tuesday, August 15, 2023 11:56 PM
To: amd-...@lists.freedesktop.org 
Cc: Zhang, Hawking ; Deucher, Alexander 
; s...@canb.auug.org.au ; 
airl...@redhat.com ; dri-devel@lists.freedesktop.org 

Subject: [PATCH] Documentation/gpu: Update amdgpu documentation

7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
Update the documentation accordingly.

Signed-off-by: Lijo Lazar 
---
 Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/amdgpu/driver-misc.rst 
b/Documentation/gpu/amdgpu/driver-misc.rst
index be131e963d87..26334e54447b 100644
--- a/Documentation/gpu/amdgpu/driver-misc.rst
+++ b/Documentation/gpu/amdgpu/driver-misc.rst
@@ -11,19 +11,19 @@ via sysfs
 product_name
 

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: product_name

 product_number
 --

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: product_name

 serial_number
 -

-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: serial_number

 unique_id
--
2.25.1

[PATCH] Documentation/gpu: Update amdgpu documentation

2023-08-15 Thread Lijo Lazar 
7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
Update the documentation accordingly.

Signed-off-by: Lijo Lazar 
---
 Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/amdgpu/driver-misc.rst 
b/Documentation/gpu/amdgpu/driver-misc.rst
index be131e963d87..26334e54447b 100644
--- a/Documentation/gpu/amdgpu/driver-misc.rst
+++ b/Documentation/gpu/amdgpu/driver-misc.rst
@@ -11,19 +11,19 @@ via sysfs
 product_name
 
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: product_name
 
 product_number
 --
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: product_name
 
 serial_number
 -
 
-.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
:doc: serial_number
 
 unique_id
-- 
2.25.1