[PATCH] amdgpu: fix missing deinit on vamgr_32
Hi Alex, Still reading through/learning about amdgpu, so a couple of (not too silly) questions :-) On 31 August 2015 at 15:36, Alex Deucher wrote: > From: "monk.liu" > > Signed-off-by: monk.liu > Signed-off-by: Alex Deucher > --- > amdgpu/amdgpu_device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c > index 75b12e2..e5a923e 100644 > --- a/amdgpu/amdgpu_device.c > +++ b/amdgpu/amdgpu_device.c > @@ -132,6 +132,8 @@ static void > amdgpu_device_free_internal(amdgpu_device_handle dev) > { Do we want to keep fd_mutex held as/just before we get here ? > amdgpu_vamgr_deinit(dev->vamgr); > free(dev->vamgr); > + amdgpu_vamgr_deinit(dev->vamgr_32); > + free(dev->vamgr_32); Based off amdgpu_device_initialize(), shouldn't one also keep track of the 'start' va and and "free" it ? > util_hash_table_destroy(dev->bo_flink_names); > util_hash_table_destroy(dev->bo_handles); Mildly related suggestion for a follow up patch - amdgpu_device_initialize() seems to be missing the these two. Thanks Emil
[PATCH] amdgpu: fix missing deinit on vamgr_32
It looks like it was missed when I rebased my original patches. Patch is Reviewed-by: Jammy Zhou Regards, Jammy -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Monday, August 31, 2015 10:37 PM To: dri-devel at lists.freedesktop.org Cc: Deucher, Alexander; Liu, Monk Subject: [PATCH] amdgpu: fix missing deinit on vamgr_32 From: "monk.liu" <monk@amd.com> Signed-off-by: monk.liu Signed-off-by: Alex Deucher --- amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 75b12e2..e5a923e 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_device.c @@ -132,6 +132,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev) { amdgpu_vamgr_deinit(dev->vamgr); free(dev->vamgr); + amdgpu_vamgr_deinit(dev->vamgr_32); + free(dev->vamgr_32); util_hash_table_destroy(dev->bo_flink_names); util_hash_table_destroy(dev->bo_handles); pthread_mutex_destroy(>bo_table_mutex); -- 1.8.3.1 ___ dri-devel mailing list dri-devel at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] amdgpu: fix missing deinit on vamgr_32
From: "monk.liu"Signed-off-by: monk.liu Signed-off-by: Alex Deucher --- amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 75b12e2..e5a923e 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_device.c @@ -132,6 +132,8 @@ static void amdgpu_device_free_internal(amdgpu_device_handle dev) { amdgpu_vamgr_deinit(dev->vamgr); free(dev->vamgr); + amdgpu_vamgr_deinit(dev->vamgr_32); + free(dev->vamgr_32); util_hash_table_destroy(dev->bo_flink_names); util_hash_table_destroy(dev->bo_handles); pthread_mutex_destroy(>bo_table_mutex); -- 1.8.3.1