Re: [PATCH] backlight: pwm_bl: Add missing curly branches in else branch

2019-10-04 Thread Daniel Thompson 
On Thu, Oct 03, 2019 at 02:35:02PM -0700, Matthias Kaehlcke wrote:
> Add curly braces to an 'else' branch in pwm_backlight_update_status()
> to match the corresponding 'if' branch.
> 
> Signed-off-by: Matthias Kaehlcke 

Reviewed-by: Daniel Thompson 

> ---
> 
>  drivers/video/backlight/pwm_bl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/pwm_bl.c 
> b/drivers/video/backlight/pwm_bl.c
> index 746eebc411df..130abff2705f 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -125,8 +125,9 @@ static int pwm_backlight_update_status(struct 
> backlight_device *bl)
>   state.duty_cycle = compute_duty_cycle(pb, brightness);
>   pwm_apply_state(pb->pwm, );
>   pwm_backlight_power_on(pb);
> - } else
> + } else {
>   pwm_backlight_power_off(pb);
> + }
>  
>   if (pb->notify_after)
>   pb->notify_after(pb->dev, brightness);
> -- 
> 2.23.0.444.g18eeb5a265-goog
>

[PATCH] backlight: pwm_bl: Add missing curly branches in else branch

2019-10-03 Thread Matthias Kaehlcke 
Add curly braces to an 'else' branch in pwm_backlight_update_status()
to match the corresponding 'if' branch.

Signed-off-by: Matthias Kaehlcke 
---

 drivers/video/backlight/pwm_bl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 746eebc411df..130abff2705f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -125,8 +125,9 @@ static int pwm_backlight_update_status(struct 
backlight_device *bl)
state.duty_cycle = compute_duty_cycle(pb, brightness);
pwm_apply_state(pb->pwm, );
pwm_backlight_power_on(pb);
-   } else
+   } else {
pwm_backlight_power_off(pb);
+   }
 
if (pb->notify_after)
pb->notify_after(pb->dev, brightness);
-- 
2.23.0.444.g18eeb5a265-goog

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel