Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c

[Randy Dunlap]

On 9/1/20 6:37 AM, Christian König wrote:
> Am 01.09.20 um 15:32 schrieb Daniel Vetter:
>> On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
>>> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
 Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
 warning in drivers/dma-buf/dma-fence.c:

 ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 
 'cookie' not described in 'dma_fence_end_signalling'

 Signed-off-by: Randy Dunlap 
 Cc: Sumit Semwal 
 Cc: Gustavo Padovan 
 Cc: Christian König 
 Cc: linux-me...@vger.kernel.org
 Cc: dri-devel@lists.freedesktop.org
>>> Acked-by: Christian König 
>> Will you merge these two to drm-misc-fixes or should someone else?
> 
> I was wondering the same thing and just waiting for Randy to reply with 
> please pick them up or I'm going to push them because I have commit access.

I didn't realize that was needed, but anyway, Christian, please apply these 2
dma-buf kernel-doc patches.

thanks.

> Regards,
> Christian.
> 
>>
>> Always a bit confusing when maintainers reply with acks/r-b but not what
>> they'll do with the patch :-)

Agreed.

>> Cheers, Daniel
>>
 ---
    drivers/dma-buf/dma-fence.c |    1 +
    1 file changed, 1 insertion(+)

 --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
 +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
 @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
    /**
     * dma_fence_end_signalling - end a critical DMA fence signalling 
 section
 + * @cookie: opaque cookie from dma_fence_begin_signalling()
     *
     * Closes a critical section annotation opened by 
 dma_fence_begin_signalling().
     */
>>> ___
>>> dri-devel mailing list
>>> dri-devel@lists.freedesktop.org


-- 
~Randy

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c

[Christian König]

Am 01.09.20 um 15:32 schrieb Daniel Vetter:

On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:

Am 31.08.20 um 06:17 schrieb Randy Dunlap:

Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
warning in drivers/dma-buf/dma-fence.c:

../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 
'cookie' not described in 'dma_fence_end_signalling'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: Gustavo Padovan 
Cc: Christian König 
Cc: linux-me...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org

Acked-by: Christian König 

Will you merge these two to drm-misc-fixes or should someone else?


I was wondering the same thing and just waiting for Randy to reply with 
please pick them up or I'm going to push them because I have commit access.


Regards,
Christian.



Always a bit confusing when maintainers reply with acks/r-b but not what
they'll do with the patch :-)

Cheers, Daniel


---
   drivers/dma-buf/dma-fence.c |1 +
   1 file changed, 1 insertion(+)

--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
+++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
@@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
   /**
* dma_fence_end_signalling - end a critical DMA fence signalling section
+ * @cookie: opaque cookie from dma_fence_begin_signalling()
*
* Closes a critical section annotation opened by 
dma_fence_begin_signalling().
*/

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-develdata=02%7C01%7Cchristian.koenig%40amd.com%7C4d8d43fbbb06475f964308d84e7b6a05%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345639254630346sdata=hxraBxca4oxH%2BsvRJaDT44kFp%2BAXlun2GaLYY6L6LdA%3Dreserved=0


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c

[Daniel Vetter]

On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
> > Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
> > warning in drivers/dma-buf/dma-fence.c:
> > 
> > ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 
> > 'cookie' not described in 'dma_fence_end_signalling'
> > 
> > Signed-off-by: Randy Dunlap 
> > Cc: Sumit Semwal 
> > Cc: Gustavo Padovan 
> > Cc: Christian König 
> > Cc: linux-me...@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> 
> Acked-by: Christian König 

Will you merge these two to drm-misc-fixes or should someone else?

Always a bit confusing when maintainers reply with acks/r-b but not what
they'll do with the patch :-)

Cheers, Daniel

> 
> > ---
> >   drivers/dma-buf/dma-fence.c |1 +
> >   1 file changed, 1 insertion(+)
> > 
> > --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
> > +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
> > @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
> >   /**
> >* dma_fence_end_signalling - end a critical DMA fence signalling section
> > + * @cookie: opaque cookie from dma_fence_begin_signalling()
> >*
> >* Closes a critical section annotation opened by 
> > dma_fence_begin_signalling().
> >*/
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c

[Christian König]

Am 31.08.20 um 06:17 schrieb Randy Dunlap:

Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
warning in drivers/dma-buf/dma-fence.c:

../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 
'cookie' not described in 'dma_fence_end_signalling'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: Gustavo Padovan 
Cc: Christian König 
Cc: linux-me...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org


Acked-by: Christian König 


---
  drivers/dma-buf/dma-fence.c |1 +
  1 file changed, 1 insertion(+)

--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
+++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
@@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
  
  /**

   * dma_fence_end_signalling - end a critical DMA fence signalling section
+ * @cookie: opaque cookie from dma_fence_begin_signalling()
   *
   * Closes a critical section annotation opened by 
dma_fence_begin_signalling().
   */


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf: fix kernel-doc warning in

[Christian König]

Am 31.08.20 um 06:16 schrieb Randy Dunlap:

Fix kernel-doc warning in :

../include/linux/dma-buf.h:330: warning: Function parameter or member 
'name_lock' not described in 'dma_buf'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: Gustavo Padovan 
Cc: Christian König 
Cc: linux-me...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org


Reviewed-by: Christian König 


---
  include/linux/dma-buf.h |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

--- lnx-59-rc3.orig/include/linux/dma-buf.h
+++ lnx-59-rc3/include/linux/dma-buf.h
@@ -283,6 +283,7 @@ struct dma_buf_ops {
   * @exp_name: name of the exporter; useful for debugging.
   * @name: userspace-provided name; useful for accounting and debugging,
   *protected by @resv.
+ * @name_lock: spinlock to protect name access
   * @owner: pointer to exporter module; used for refcounting when exporter is a
   * kernel module.
   * @list_node: node for dma_buf accounting and debugging.
@@ -311,7 +312,7 @@ struct dma_buf {
void *vmap_ptr;
const char *exp_name;
const char *name;
-   spinlock_t name_lock; /* spinlock to protect name access */
+   spinlock_t name_lock;
struct module *owner;
struct list_head list_node;
void *priv;


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] dma-buf: fix kernel-doc warning in

[Randy Dunlap]

Fix kernel-doc warning in :

../include/linux/dma-buf.h:330: warning: Function parameter or member 
'name_lock' not described in 'dma_buf'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: Gustavo Padovan 
Cc: Christian König 
Cc: linux-me...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
 include/linux/dma-buf.h |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- lnx-59-rc3.orig/include/linux/dma-buf.h
+++ lnx-59-rc3/include/linux/dma-buf.h
@@ -283,6 +283,7 @@ struct dma_buf_ops {
  * @exp_name: name of the exporter; useful for debugging.
  * @name: userspace-provided name; useful for accounting and debugging,
  *protected by @resv.
+ * @name_lock: spinlock to protect name access
  * @owner: pointer to exporter module; used for refcounting when exporter is a
  * kernel module.
  * @list_node: node for dma_buf accounting and debugging.
@@ -311,7 +312,7 @@ struct dma_buf {
void *vmap_ptr;
const char *exp_name;
const char *name;
-   spinlock_t name_lock; /* spinlock to protect name access */
+   spinlock_t name_lock;
struct module *owner;
struct list_head list_node;
void *priv;
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] dma-buf: fix kernel-doc warning in dma-fence.c

[Randy Dunlap]

Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
warning in drivers/dma-buf/dma-fence.c:

../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 
'cookie' not described in 'dma_fence_end_signalling'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: Gustavo Padovan 
Cc: Christian König 
Cc: linux-me...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/dma-buf/dma-fence.c |1 +
 1 file changed, 1 insertion(+)

--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
+++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
@@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
 
 /**
  * dma_fence_end_signalling - end a critical DMA fence signalling section
+ * @cookie: opaque cookie from dma_fence_begin_signalling()
  *
  * Closes a critical section annotation opened by dma_fence_begin_signalling().
  */
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] dma-buf: fix kernel-doc warning and typos

[Sumit Semwal]

Hi Randy,

On 17 August 2016 at 05:01, Randy Dunlap  wrote:
> From: Randy Dunlap 
>
> Fix dma-buf kernel-doc warning and 2 minor typos in
> fence_array_create().
>
Thanks for your patch, I will queue it up!
> Fixes this warning:
> ..//drivers/dma-buf/fence-array.c:124: warning: No description found for 
> parameter 'signal_on_any'
>
> Signed-off-by: Randy Dunlap 
> Cc: Sumit Semwal 
> Cc: linux-media at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: linaro-mm-sig at lists.linaro.org
> ---
>  drivers/dma-buf/fence-array.c |6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-48-rc2.orig/drivers/dma-buf/fence-array.c
> +++ lnx-48-rc2/drivers/dma-buf/fence-array.c
> @@ -106,14 +106,14 @@ const struct fence_ops fence_array_ops =
>   * @fences:[in]array containing the fences
>   * @context:   [in]fence context to use
>   * @seqno: [in]sequence number to use
> - * @signal_on_any  [in]signal on any fence in the array
> + * @signal_on_any: [in]signal on any fence in the array
>   *
>   * Allocate a fence_array object and initialize the base fence with 
> fence_init().
>   * In case of error it returns NULL.
>   *
> - * The caller should allocte the fences array with num_fences size
> + * The caller should allocate the fences array with num_fences size
>   * and fill it with the fences it wants to add to the object. Ownership of 
> this
> - * array is take and fence_put() is used on each fence on release.
> + * array is taken and fence_put() is used on each fence on release.
>   *
>   * If @signal_on_any is true the fence array signals if any fence in the 
> array
>   * signals, otherwise it signals when all fences in the array signal.

Best,
Sumit.

[PATCH] dma-buf: fix kernel-doc warning and typos

[Randy Dunlap]

From: Randy Dunlap 

Fix dma-buf kernel-doc warning and 2 minor typos in
fence_array_create().

Fixes this warning:
..//drivers/dma-buf/fence-array.c:124: warning: No description found for 
parameter 'signal_on_any'

Signed-off-by: Randy Dunlap 
Cc: Sumit Semwal 
Cc: linux-media at vger.kernel.org
Cc: dri-devel at lists.freedesktop.org
Cc: linaro-mm-sig at lists.linaro.org
---
 drivers/dma-buf/fence-array.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- lnx-48-rc2.orig/drivers/dma-buf/fence-array.c
+++ lnx-48-rc2/drivers/dma-buf/fence-array.c
@@ -106,14 +106,14 @@ const struct fence_ops fence_array_ops =
  * @fences:[in]array containing the fences
  * @context:   [in]fence context to use
  * @seqno: [in]sequence number to use
- * @signal_on_any  [in]signal on any fence in the array
+ * @signal_on_any: [in]signal on any fence in the array
  *
  * Allocate a fence_array object and initialize the base fence with 
fence_init().
  * In case of error it returns NULL.
  *
- * The caller should allocte the fences array with num_fences size
+ * The caller should allocate the fences array with num_fences size
  * and fill it with the fences it wants to add to the object. Ownership of this
- * array is take and fence_put() is used on each fence on release.
+ * array is taken and fence_put() is used on each fence on release.
  *
  * If @signal_on_any is true the fence array signals if any fence in the array
  * signals, otherwise it signals when all fences in the array signal.

[PATCH] dma-buf: fix kernel-doc warning

[Sumit Semwal]

Hi Randy,

~ typing on a mobile device, kindly excuse any typos
On Aug 17, 2014 2:45 AM, "Randy Dunlap"  wrote:
>
> From: Randy Dunlap 
>
> Fix kernel-doc warning, missing parameter description:
>
> Warning(..//include/linux/seqno-fence.h:99): No description found for
parameter 'cond'
Thanks for your patch; this is already fixed by Thierry Reading's patch and
is queued in for-next. [1]
>
> Signed-off-by: Randy Dunlap 
> Cc: Rob Clark 
> Cc: Maarten Lankhorst 
> ---
>  include/linux/seqno-fence.h |1 +
>  1 file changed, 1 insertion(+)
>
> Index: lnx-317-rc1/include/linux/seqno-fence.h
> ===
> --- lnx-317-rc1.orig/include/linux/seqno-fence.h
> +++ lnx-317-rc1/include/linux/seqno-fence.h
> @@ -62,6 +62,7 @@ to_seqno_fence(struct fence *fence)
>   * @context: the execution context this fence is a part of
>   * @seqno_ofs: the offset within @sync_buf
>   * @seqno: the sequence # to signal on
> + * @cond: the fence condition to check
>   * @ops: the fence_ops for operations on this seqno fence
>   *
>   * This function initializes a struct seqno_fence with passed parameters,

Best regards,
Sumit.

[1]: https://lkml.org/lkml/2014/8/8/191
-- next part --
An HTML attachment was scrubbed...
URL: 

[PATCH] dma-buf: fix kernel-doc warning

[Randy Dunlap]

From: Randy Dunlap 

Fix kernel-doc warning, missing parameter description:

Warning(..//include/linux/seqno-fence.h:99): No description found for parameter 
'cond'

Signed-off-by: Randy Dunlap 
Cc: Rob Clark 
Cc: Maarten Lankhorst 
---
 include/linux/seqno-fence.h |1 +
 1 file changed, 1 insertion(+)

Index: lnx-317-rc1/include/linux/seqno-fence.h
===
--- lnx-317-rc1.orig/include/linux/seqno-fence.h
+++ lnx-317-rc1/include/linux/seqno-fence.h
@@ -62,6 +62,7 @@ to_seqno_fence(struct fence *fence)
  * @context: the execution context this fence is a part of
  * @seqno_ofs: the offset within @sync_buf
  * @seqno: the sequence # to signal on
+ * @cond: the fence condition to check
  * @ops: the fence_ops for operations on this seqno fence
  *
  * This function initializes a struct seqno_fence with passed parameters,