Re: [PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c
Applied. Thanks! Alex On Mon, Apr 27, 2020 at 4:03 AM Christian König wrote: > > Am 27.04.20 um 08:37 schrieb Jason Yan: > > The '==' expression itself is bool, no need to convert it to bool again. > > This fixes the following coccicheck warning: > > > > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c:455:70-75: WARNING: > > conversion to bool not needed here > > > > Signed-off-by: Jason Yan > > Reviewed-by: Christian König > > > --- > > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c > > b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c > > index de9c857ab3e9..9d7432f3fb16 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c > > @@ -452,7 +452,7 @@ void mpc2_set_output_gamma( > > next_mode = LUT_RAM_A; > > > > mpc20_power_on_ogam_lut(mpc, mpcc_id, true); > > - mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A ? > > true:false); > > + mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A); > > > > if (next_mode == LUT_RAM_A) > > mpc2_program_luta(mpc, mpcc_id, params); > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c
Am 27.04.20 um 08:37 schrieb Jason Yan: The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c:455:70-75: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan Reviewed-by: Christian König --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c index de9c857ab3e9..9d7432f3fb16 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c @@ -452,7 +452,7 @@ void mpc2_set_output_gamma( next_mode = LUT_RAM_A; mpc20_power_on_ogam_lut(mpc, mpcc_id, true); - mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A ? true:false); + mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A); if (next_mode == LUT_RAM_A) mpc2_program_luta(mpc, mpcc_id, params); ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c
The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c:455:70-75: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c index de9c857ab3e9..9d7432f3fb16 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c @@ -452,7 +452,7 @@ void mpc2_set_output_gamma( next_mode = LUT_RAM_A; mpc20_power_on_ogam_lut(mpc, mpcc_id, true); - mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A ? true:false); + mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A); if (next_mode == LUT_RAM_A) mpc2_program_luta(mpc, mpcc_id, params); -- 2.21.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c
On Mon, 2020-04-27 at 14:37 +0800, Jason Yan wrote: > The '==' expression itself is bool, no need to convert it to bool again. trivia: These descriptions are not quite correct. The operators return an int, either 0 or 1. - 6.5.8 Relational operators 6 Each of the operators < (less than), > (greater than), <= (less than or equal to), and >= (greater than or equal to) shall yield 1 if the specified relation is true and 0 if it is false. 90) The result has type int 6.5.9 Equality operators 3 The == (equal to) and != (not equal to) operators are analogous to the relational operators except for their lower precedence. 91) Each of the operators yields 1 if the specified relation is true and 0 if it is false. The result has type int. For any pair of operands, exactly one of the relations is true. - ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
