Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

[Neil Armstrong]

Hi,

On Fri, 29 Sep 2023 14:54:19 +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git 
(drm-misc-next)

[1/1] drm/bridge: adv7511: Convert to use maple tree register cache
  
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=86c3331c8089ac1cf231825f406c4bf8afd9f3a2

-- 
Neil

Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

[Mark Brown]

On Sat, Sep 30, 2023 at 12:38:17AM +0300, Laurent Pinchart wrote:

> Out of curiosity, is this part of an effort to drop the rbtree cache ?

Probably, yes - there's probably some drivers where it will make sense.


signature.asc
Description: PGP signature

Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

[Laurent Pinchart]

Hi Mark,

Thank you for the patch.

On Fri, Sep 29, 2023 at 02:54:19PM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

I trust on your this statement.

> Signed-off-by: Mark Brown 

Reviewed-by: Laurent Pinchart 

Out of curiosity, is this part of an effort to drop the rbtree cache ?

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c 
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 2611afd2c1c1..d518de88b5c3 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -121,7 +121,7 @@ static const struct regmap_config adv7511_regmap_config = 
> {
>   .val_bits = 8,
>  
>   .max_register = 0xff,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
>   .reg_defaults_raw = adv7511_register_defaults,
>   .num_reg_defaults_raw = ARRAY_SIZE(adv7511_register_defaults),
>  
> @@ -1068,7 +1068,7 @@ static const struct regmap_config 
> adv7511_cec_regmap_config = {
>   .val_bits = 8,
>  
>   .max_register = 0xff,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
>   .volatile_reg = adv7511_cec_register_volatile,
>  };
>  
> 
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-drm-adv7511-2d592921f8a2

-- 
Regards,

Laurent Pinchart

[PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

[Mark Brown]

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Mark Brown 
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c 
b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 2611afd2c1c1..d518de88b5c3 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -121,7 +121,7 @@ static const struct regmap_config adv7511_regmap_config = {
.val_bits = 8,
 
.max_register = 0xff,
-   .cache_type = REGCACHE_RBTREE,
+   .cache_type = REGCACHE_MAPLE,
.reg_defaults_raw = adv7511_register_defaults,
.num_reg_defaults_raw = ARRAY_SIZE(adv7511_register_defaults),
 
@@ -1068,7 +1068,7 @@ static const struct regmap_config 
adv7511_cec_regmap_config = {
.val_bits = 8,
 
.max_register = 0xff,
-   .cache_type = REGCACHE_RBTREE,
+   .cache_type = REGCACHE_MAPLE,
.volatile_reg = adv7511_cec_register_volatile,
 };
 

---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-drm-adv7511-2d592921f8a2

Best regards,
-- 
Mark Brown