[RESEND][PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

[Torsten Duwe]

of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree"). Remove the suffix from the requests.

Signed-off-by: Torsten Duwe 
Reviewed-by: Mark Brown 
---
Mark has actually reviewed this one. patchwork.freedesktop.org dropped
that along with the comments(?)
https://patchwork.freedesktop.org/patch/343005/
https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html

--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -712,14 +709,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
DRM_DEBUG("No panel found\n");
 
/* 1.2V digital core power regulator  */
-   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
+   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
if (IS_ERR(anx6345->dvdd12)) {
DRM_ERROR("dvdd12-supply not found\n");
return PTR_ERR(anx6345->dvdd12);
}
 
/* 2.5V digital core power regulator  */
-   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
+   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
if (IS_ERR(anx6345->dvdd25)) {
DRM_ERROR("dvdd25-supply not found\n");
return PTR_ERR(anx6345->dvdd25);
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RESEND][PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

[Torsten Duwe]

of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree"). Remove the suffix from the requests.

Signed-off-by: Torsten Duwe 
---
https://patchwork.freedesktop.org/patch/343005/
https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html

--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -712,14 +709,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
DRM_DEBUG("No panel found\n");
 
/* 1.2V digital core power regulator  */
-   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
+   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
if (IS_ERR(anx6345->dvdd12)) {
DRM_ERROR("dvdd12-supply not found\n");
return PTR_ERR(anx6345->dvdd12);
}
 
/* 2.5V digital core power regulator  */
-   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
+   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
if (IS_ERR(anx6345->dvdd25)) {
DRM_ERROR("dvdd25-supply not found\n");
return PTR_ERR(anx6345->dvdd25);
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

[Mark Brown]

On Sat, Nov 30, 2019 at 04:09:58PM +0100, Torsten Duwe wrote:
> of_get_regulator() will unconditionally add "-supply" to form the
> property name. This is documented in commit 69511a452e6dc ("map consumer
> regulator based on device tree").

Sorry, I meant to also say:

Reviewed-by: Mark Brown 


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

[Mark Brown]

On Sat, Nov 30, 2019 at 04:09:58PM +0100, Torsten Duwe wrote:

> IMHO that commit message should have ended up somewhere under Documentation/.

This is documented already in the generic regulator bindings and
has been since they were added, they specify that supplies should
always have the suffix -supply.  The commit you reference was
part of the initial merge of the device tree support for the
regulator API.  Including the -supply suffix in the name used
internally in Linux would create problems for all other firmware
interfaces that map names differently.


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

[Torsten Duwe]

of_get_regulator() will unconditionally add "-supply" to form the
property name. This is documented in commit 69511a452e6dc ("map consumer
regulator based on device tree").

Signed-off-by: Torsten Duwe 
---
IMHO that commit message should have ended up somewhere under Documentation/.

--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -712,14 +709,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
DRM_DEBUG("No panel found\n");
 
/* 1.2V digital core power regulator  */
-   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
+   anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
if (IS_ERR(anx6345->dvdd12)) {
DRM_ERROR("dvdd12-supply not found\n");
return PTR_ERR(anx6345->dvdd12);
}
 
/* 2.5V digital core power regulator  */
-   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
+   anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
if (IS_ERR(anx6345->dvdd25)) {
DRM_ERROR("dvdd25-supply not found\n");
return PTR_ERR(anx6345->dvdd25);
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel