Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

[Andrzej Hajda]

On 14.03.2018 16:25, Fabio Estevam wrote:
> Hi Laurent,
>
> On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart
>  wrote:
>> Hi Fabio,
>>
>> Thank you for the patch.
>>
>> On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote:
>>> From: Fabio Estevam 
>>>
>>> The cable_plugin member never receives an assignment, so it is always
>>> false, which causes hdmi_enable_overflow_interrupts() to never
>>> be called as per the logic below:
>>>
>>>   if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
>>>   hdmi_enable_overflow_interrupts(hdmi);
>>>
>>> This has been the case since the driver was originally introduced
>>> in commit 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support").
>>>
>>> Remove the cable_plugin element and the hdmi_enable_overflow_interrupts()
>>> function that is never called.
>>>
>>> Signed-off-by: Fabio Estevam 
>> Tested-by: Laurent Pinchart  # On R-Car H3
>> Reviewed-by: Laurent Pinchart 
> Are you able to apply this patch or should Archit Taneja handle it?

Queued to drm-misc-next.

Regards
Andrzej

>
> Thanks
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

[Fabio Estevam]

Hi Laurent,

On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart
 wrote:
> Hi Fabio,
>
> Thank you for the patch.
>
> On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote:
>> From: Fabio Estevam 
>>
>> The cable_plugin member never receives an assignment, so it is always
>> false, which causes hdmi_enable_overflow_interrupts() to never
>> be called as per the logic below:
>>
>>   if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
>>   hdmi_enable_overflow_interrupts(hdmi);
>>
>> This has been the case since the driver was originally introduced
>> in commit 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support").
>>
>> Remove the cable_plugin element and the hdmi_enable_overflow_interrupts()
>> function that is never called.
>>
>> Signed-off-by: Fabio Estevam 
>
> Tested-by: Laurent Pinchart  # On R-Car H3
> Reviewed-by: Laurent Pinchart 

Are you able to apply this patch or should Archit Taneja handle it?

Thanks
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

[Laurent Pinchart]

Hi Fabio,

Thank you for the patch.

On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote:
> From: Fabio Estevam 
> 
> The cable_plugin member never receives an assignment, so it is always
> false, which causes hdmi_enable_overflow_interrupts() to never
> be called as per the logic below:
> 
>   if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
>   hdmi_enable_overflow_interrupts(hdmi);
> 
> This has been the case since the driver was originally introduced
> in commit 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support").
> 
> Remove the cable_plugin element and the hdmi_enable_overflow_interrupts()
> function that is never called.
> 
> Signed-off-by: Fabio Estevam 

Tested-by: Laurent Pinchart  # On R-Car H3
Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 -
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index a38db40..b0b9570 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -147,7 +147,6 @@ struct dw_hdmi {
>   int vic;
> 
>   u8 edid[HDMI_EDID_LEN];
> - bool cable_plugin;
> 
>   struct {
>   const struct dw_hdmi_phy_ops *ops;
> @@ -1658,12 +1657,6 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi
> *hdmi) hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF);
>  }
> 
> -static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi)
> -{
> - hdmi_writeb(hdmi, 0, HDMI_FC_MASK2);
> - hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2);
> -}
> -
>  static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi)
>  {
>   hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK,
> @@ -1753,8 +1746,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct
> drm_display_mode *mode) hdmi_tx_hdcp_config(hdmi);
> 
>   dw_hdmi_clear_overflow(hdmi);
> - if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
> - hdmi_enable_overflow_interrupts(hdmi);
> 
>   return 0;
>  }

-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

[Fabio Estevam]

From: Fabio Estevam 

The cable_plugin member never receives an assignment, so it is always
false, which causes hdmi_enable_overflow_interrupts() to never
be called as per the logic below:

if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
hdmi_enable_overflow_interrupts(hdmi);

This has been the case since the driver was originally introduced
in commit 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support").

Remove the cable_plugin element and the hdmi_enable_overflow_interrupts()
function that is never called.

Signed-off-by: Fabio Estevam 
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c 
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index a38db40..b0b9570 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -147,7 +147,6 @@ struct dw_hdmi {
int vic;
 
u8 edid[HDMI_EDID_LEN];
-   bool cable_plugin;
 
struct {
const struct dw_hdmi_phy_ops *ops;
@@ -1658,12 +1657,6 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF);
 }
 
-static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi)
-{
-   hdmi_writeb(hdmi, 0, HDMI_FC_MASK2);
-   hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2);
-}
-
 static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi)
 {
hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK,
@@ -1753,8 +1746,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct 
drm_display_mode *mode)
hdmi_tx_hdcp_config(hdmi);
 
dw_hdmi_clear_overflow(hdmi);
-   if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
-   hdmi_enable_overflow_interrupts(hdmi);
 
return 0;
 }
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel