Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

2023-07-09 Thread suijingfeng 

OK, thanks a lot,

done!

On 2023/7/10 13:20, Michael Kelley (LINUX) wrote:

From: Sui Jingfeng  Sent: Sunday, July 9, 2023 3:05 AM

drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':

drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first 
use

in this function)
 1033 | base = screen_info.lfb_base;
  |^~~
drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier 
is reported
only once for each function it appears in
--
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':

drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared

(first use in this function)
   75 | 
drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
  |  ^~~
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared 
identifier is
reported only once for each function it appears in

Reported-by: kernel test robot 
Closes: 
https://lore.kernel.org/oe-kbuild-all/202307090823.nxnt8kk5-...@intel.com/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include  from EFI 
header")
Signed-off-by: Sui Jingfeng 
---
  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@
  #include 
  #include 
  #include 
+#include 

  #include 
  #include 
--
2.25.1

Reviewed-by: Michael Kelley

RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

2023-07-09 Thread Michael Kelley (LINUX) 
From: Sui Jingfeng  Sent: Sunday, July 9, 2023 3:05 AM
> 
>drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared 
> >> (first use
> in this function)
> 1033 | base = screen_info.lfb_base;
>  |^~~
>drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier 
> is reported
> only once for each function it appears in
> --
>drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' 
> >> undeclared
> (first use in this function)
>   75 | 
> drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>  |  ^~~
>drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared 
> identifier is
> reported only once for each function it appears in
> 
> Reported-by: kernel test robot 
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202307090823.nxnt8kk5-...@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include  from EFI 
> header")
> Signed-off-by: Sui Jingfeng 
> ---
>  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  #include 
>  #include 
> --
> 2.25.1

Reviewed-by: Michael Kelley

Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

2023-07-09 Thread Thomas Zimmermann 

Hi

Am 09.07.23 um 12:05 schrieb Sui Jingfeng:

drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':

drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first 
use in this function)

 1033 | base = screen_info.lfb_base;
  |^~~
drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier 
is reported only once for each function it appears in
--
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':

drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared 
(first use in this function)

   75 | 
drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
  |  ^~~
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared 
identifier is reported only once for each function it appears in

Reported-by: kernel test robot 
Closes: 
https://lore.kernel.org/oe-kbuild-all/202307090823.nxnt8kk5-...@intel.com/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include  from EFI 
header")
Signed-off-by: Sui Jingfeng 


Reviewed-by: Thomas Zimmermann 

Thanks for the patch.

Best regards
Thomas



---
  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c 
b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@
  #include 
  #include 
  #include 
+#include 
  
  #include 

  #include 


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


OpenPGP_signature
Description: OpenPGP digital signature

[PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

2023-07-09 Thread Sui Jingfeng 
   drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared 
>> (first use in this function)
1033 | base = screen_info.lfb_base;
 |^~~
   drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is 
reported only once for each function it appears in
--
   drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' 
>> undeclared (first use in this function)
  75 | 
drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
 |  ^~~
   drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared 
identifier is reported only once for each function it appears in

Reported-by: kernel test robot 
Closes: 
https://lore.kernel.org/oe-kbuild-all/202307090823.nxnt8kk5-...@intel.com/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include  from EFI 
header")
Signed-off-by: Sui Jingfeng 
---
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c 
b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
-- 
2.25.1