Re: [PATCH] drm/komeda: Remove useless variable assignment

2020-11-27 Thread Liviu Dudau 
On Fri, Nov 27, 2020 at 11:00:27AM +, carsten.haitz...@foss.arm.com wrote:
> From: Carsten Haitzler 
> 
> ret is not actually read after this (only written in one case then
> returned), so this assign line is useless. This removes that assignment.
> 
> Signed-off-by: Carsten Haitzler 

Acked-by: Liviu Dudau 

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c 
> b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 1d767473ba8a..eea76f51f662 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct 
> komeda_dev *mdev)
>   ret = of_reserved_mem_device_init(dev);
>   if (ret && ret != -ENODEV)
>   return ret;
> - ret = 0;
>  
>   for_each_available_child_of_node(np, child) {
>   if (of_node_name_eq(child, "pipeline")) {
> -- 
> 2.29.2
> 

-- 

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---
¯\_(ツ)_/¯
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/komeda: Remove useless variable assignment

2020-11-27 Thread Steven Price 

On 27/11/2020 11:00, carsten.haitz...@foss.arm.com wrote:

From: Carsten Haitzler 

ret is not actually read after this (only written in one case then
returned), so this assign line is useless. This removes that assignment.

Signed-off-by: Carsten Haitzler 


Reviewed-by: Steven Price 


---
  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 1d767473ba8a..eea76f51f662 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct 
komeda_dev *mdev)
ret = of_reserved_mem_device_init(dev);
if (ret && ret != -ENODEV)
return ret;
-   ret = 0;
  
  	for_each_available_child_of_node(np, child) {

if (of_node_name_eq(child, "pipeline")) {



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/komeda: Remove useless variable assignment

2020-11-27 Thread carsten . haitzler 
From: Carsten Haitzler 

ret is not actually read after this (only written in one case then
returned), so this assign line is useless. This removes that assignment.

Signed-off-by: Carsten Haitzler 
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 1d767473ba8a..eea76f51f662 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct 
komeda_dev *mdev)
ret = of_reserved_mem_device_init(dev);
if (ret && ret != -ENODEV)
return ret;
-   ret = 0;
 
for_each_available_child_of_node(np, child) {
if (of_node_name_eq(child, "pipeline")) {
-- 
2.29.2

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel