Re: [PATCH] drm/msm/dp: Fix platform_get_irq() check

[Dmitry Baryshkov]

On Wed, 06 Dec 2023 15:02:05 +0300, Dan Carpenter wrote:
> The platform_get_irq() function returns negative error codes.  It never
> returns zero.  Fix the check accordingly.
> 
> 

Applied, thanks!

[1/1] drm/msm/dp: Fix platform_get_irq() check
  https://gitlab.freedesktop.org/lumag/msm/-/commit/c4ac0c6c96f0

Best regards,
-- 
Dmitry Baryshkov 

Re: [PATCH] drm/msm/dp: Fix platform_get_irq() check

[Dmitry Baryshkov]

On 06/12/2023 14:02, Dan Carpenter wrote:

The platform_get_irq() function returns negative error codes.  It never
returns zero.  Fix the check accordingly.

Fixes: 82c2a5751227 ("drm/msm/dp: tie dp_display_irq_handler() with dp driver")
Signed-off-by: Dan Carpenter 
---
  drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Dmitry Baryshkov 

--
With best wishes
Dmitry

[PATCH] drm/msm/dp: Fix platform_get_irq() check

[Dan Carpenter]

The platform_get_irq() function returns negative error codes.  It never
returns zero.  Fix the check accordingly.

Fixes: 82c2a5751227 ("drm/msm/dp: tie dp_display_irq_handler() with dp driver")
Signed-off-by: Dan Carpenter 
---
 drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c 
b/drivers/gpu/drm/msm/dp/dp_display.c
index 61b7103498a7..d80cb3d14c6b 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1166,9 +1166,9 @@ static int dp_display_request_irq(struct 
dp_display_private *dp)
struct platform_device *pdev = dp->dp_display.pdev;
 
dp->irq = platform_get_irq(pdev, 0);
-   if (!dp->irq) {
+   if (dp->irq < 0) {
DRM_ERROR("failed to get irq\n");
-   return -EINVAL;
+   return dp->irq;
}
 
rc = devm_request_irq(>dev, dp->irq, dp_display_irq_handler,
-- 
2.42.0