Re: [PATCH] drm/msm/dpu: Remove unused code

[Abhinav Kumar]

On 5/24/2022 1:14 AM, Jiapeng Chong wrote:

Eliminate the follow clang warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
‘mode’ set but not used [-Wunused-but-set-variable].

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 


Fixes: 3177589c6e93("drm/msm/dpu: encoder: drop unused mode_fixup callback")

Reviewed-by: Abhinav Kumar 


---
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 52516eb20cb8..658171799b9a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
struct dpu_encoder_virt *dpu_enc;
struct msm_drm_private *priv;
struct dpu_kms *dpu_kms;
-   const struct drm_display_mode *mode;
struct drm_display_mode *adj_mode;
struct msm_display_topology topology;
struct dpu_global_state *global_state;
@@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
  
  	priv = drm_enc->dev->dev_private;

dpu_kms = to_dpu_kms(priv->kms);
-   mode = _state->mode;
adj_mode = _state->adjusted_mode;
global_state = dpu_kms_get_global_state(crtc_state->state);
if (IS_ERR(global_state))

[PATCH] drm/msm/dpu: Remove unused code

[Jiapeng Chong]

Eliminate the follow clang warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable
‘mode’ set but not used [-Wunused-but-set-variable].

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 52516eb20cb8..658171799b9a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -541,7 +541,6 @@ static int dpu_encoder_virt_atomic_check(
struct dpu_encoder_virt *dpu_enc;
struct msm_drm_private *priv;
struct dpu_kms *dpu_kms;
-   const struct drm_display_mode *mode;
struct drm_display_mode *adj_mode;
struct msm_display_topology topology;
struct dpu_global_state *global_state;
@@ -559,7 +558,6 @@ static int dpu_encoder_virt_atomic_check(
 
priv = drm_enc->dev->dev_private;
dpu_kms = to_dpu_kms(priv->kms);
-   mode = _state->mode;
adj_mode = _state->adjusted_mode;
global_state = dpu_kms_get_global_state(crtc_state->state);
if (IS_ERR(global_state))
-- 
2.20.1.7.g153144c

Re: [PATCH] drm/msm/dpu: Remove unused code and move the header

[Rob Clark]

On Thu, Feb 15, 2018 at 3:45 PM, Jordan Crouse  wrote:
> Remove unused code from dpu_io_util.c.  The functions are only
> used inside of the msm driver so remove the EXPORT_SYMBOL
> tags and move the header dpu_io_util.h from include/linux.
>
> Signed-off-by: Jordan Crouse 

Thanks,

Reviewed-by: Rob Clark 

> ---
>  drivers/gpu/drm/msm/dp/dp_parser.h |   2 +-
>  drivers/gpu/drm/msm/dpu_io_util.c  | 154 
> ++---
>  .../linux => drivers/gpu/drm/msm}/dpu_io_util.h|  10 --
>  drivers/gpu/drm/msm/dpu_power_handle.c |   1 -
>  drivers/gpu/drm/msm/dpu_power_handle.h |   2 +-
>  drivers/gpu/drm/msm/dpu_rsc_priv.h |   1 -
>  drivers/gpu/drm/msm/msm_drv.h  |   1 -
>  7 files changed, 14 insertions(+), 157 deletions(-)
>  rename {include/linux => drivers/gpu/drm/msm}/dpu_io_util.h (86%)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h 
> b/drivers/gpu/drm/msm/dp/dp_parser.h
> index a9cfd03fa5ed..703acb010c8b 100644
> --- a/drivers/gpu/drm/msm/dp/dp_parser.h
> +++ b/drivers/gpu/drm/msm/dp/dp_parser.h
> @@ -15,7 +15,7 @@
>  #ifndef _DP_PARSER_H_
>  #define _DP_PARSER_H_
>
> -#include 
> +#include "dpu_io_util.h"
>
>  #define DP_LABEL "MDSS DP DISPLAY"
>  #define AUX_CFG_LEN10
> diff --git a/drivers/gpu/drm/msm/dpu_io_util.c 
> b/drivers/gpu/drm/msm/dpu_io_util.c
> index a18bc992c136..f39ae38e4cfa 100644
> --- a/drivers/gpu/drm/msm/dpu_io_util.c
> +++ b/drivers/gpu/drm/msm/dpu_io_util.c
> @@ -16,9 +16,9 @@
>  #include 
>  #include 
>  #include 
> -#include 
>
> -#define MAX_I2C_CMDS  16
> +#include "dpu_io_util.h"
> +
>  void dss_reg_w(struct dss_io_data *io, u32 offset, u32 value, u32 debug)
>  {
> u32 in_val;
> @@ -42,8 +42,7 @@ void dss_reg_w(struct dss_io_data *io, u32 offset, u32 
> value, u32 debug)
> (u32)(unsigned long)(io->base + offset),
> value, in_val);
> }
> -} /* dss_reg_w */
> -EXPORT_SYMBOL(dss_reg_w);
> +}
>
>  u32 dss_reg_r(struct dss_io_data *io, u32 offset, u32 debug)
>  {
> @@ -67,30 +66,7 @@ u32 dss_reg_r(struct dss_io_data *io, u32 offset, u32 
> debug)
> (u32)(unsigned long)(io->base + offset), value);
>
> return value;
> -} /* dss_reg_r */
> -EXPORT_SYMBOL(dss_reg_r);
> -
> -void dss_reg_dump(void __iomem *base, u32 length, const char *prefix,
> -   u32 debug)
> -{
> -   if (debug)
> -   print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 32, 4,
> -   (void *)base, length, false);
> -} /* dss_reg_dump */
> -EXPORT_SYMBOL(dss_reg_dump);
> -
> -static struct resource *msm_dss_get_res_byname(struct platform_device *pdev,
> -   unsigned int type, const char *name)
> -{
> -   struct resource *res = NULL;
> -
> -   res = platform_get_resource_byname(pdev, type, name);
> -   if (!res)
> -   DEV_ERR("%s: '%s' resource not found\n", __func__, name);
> -
> -   return res;
> -} /* msm_dss_get_res_byname */
> -EXPORT_SYMBOL(msm_dss_get_res_byname);
> +}
>
>  int msm_dss_ioremap_byname(struct platform_device *pdev,
> struct dss_io_data *io_data, const char *name)
> @@ -103,7 +79,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev,
> return -EINVAL;
> }
>
> -   res = msm_dss_get_res_byname(pdev, IORESOURCE_MEM, name);
> +   res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
> if (!res) {
> DEV_ERR("%pS->%s: '%s' msm_dss_get_res_byname failed\n",
> __builtin_return_address(0), __func__, name);
> @@ -119,8 +95,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev,
> }
>
> return 0;
> -} /* msm_dss_ioremap_byname */
> -EXPORT_SYMBOL(msm_dss_ioremap_byname);
> +}
>
>  void msm_dss_iounmap(struct dss_io_data *io_data)
>  {
> @@ -135,8 +110,7 @@ void msm_dss_iounmap(struct dss_io_data *io_data)
> io_data->base = NULL;
> }
> io_data->len = 0;
> -} /* msm_dss_iounmap */
> -EXPORT_SYMBOL(msm_dss_iounmap);
> +}
>
>  int msm_dss_config_vreg(struct device *dev, struct dss_vreg *in_vreg,
> int num_vreg, int config)
> @@ -211,8 +185,7 @@ if (type == DSS_REG_LDO)
> goto vreg_unconfig;
> }
> return rc;
> -} /* msm_dss_config_vreg */
> -EXPORT_SYMBOL(msm_dss_config_vreg);
> +}
>
>  int msm_dss_enable_vreg(struct dss_vreg *in_vreg, int num_vreg, int enable)
>  {
> @@ -283,48 +256,7 @@ int msm_dss_enable_vreg(struct dss_vreg *in_vreg, int 
> num_vreg, int enable)
> }
>
> return rc;
> -} /* msm_dss_enable_vreg */
> -EXPORT_SYMBOL(msm_dss_enable_vreg);
> -
> -int msm_dss_enable_gpio(struct dss_gpio *in_gpio, int num_gpio, int enable)
> -{
> -   int i = 0, rc = 0;
> -
> -   if (enable) {
> -   for (i = 0; i < num_gpio; i++) {
> - 

[PATCH] drm/msm/dpu: Remove unused code and move the header

[Jordan Crouse]

Remove unused code from dpu_io_util.c.  The functions are only
used inside of the msm driver so remove the EXPORT_SYMBOL
tags and move the header dpu_io_util.h from include/linux.

Signed-off-by: Jordan Crouse 
---
 drivers/gpu/drm/msm/dp/dp_parser.h |   2 +-
 drivers/gpu/drm/msm/dpu_io_util.c  | 154 ++---
 .../linux => drivers/gpu/drm/msm}/dpu_io_util.h|  10 --
 drivers/gpu/drm/msm/dpu_power_handle.c |   1 -
 drivers/gpu/drm/msm/dpu_power_handle.h |   2 +-
 drivers/gpu/drm/msm/dpu_rsc_priv.h |   1 -
 drivers/gpu/drm/msm/msm_drv.h  |   1 -
 7 files changed, 14 insertions(+), 157 deletions(-)
 rename {include/linux => drivers/gpu/drm/msm}/dpu_io_util.h (86%)

diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h 
b/drivers/gpu/drm/msm/dp/dp_parser.h
index a9cfd03fa5ed..703acb010c8b 100644
--- a/drivers/gpu/drm/msm/dp/dp_parser.h
+++ b/drivers/gpu/drm/msm/dp/dp_parser.h
@@ -15,7 +15,7 @@
 #ifndef _DP_PARSER_H_
 #define _DP_PARSER_H_
 
-#include 
+#include "dpu_io_util.h"
 
 #define DP_LABEL "MDSS DP DISPLAY"
 #define AUX_CFG_LEN10
diff --git a/drivers/gpu/drm/msm/dpu_io_util.c 
b/drivers/gpu/drm/msm/dpu_io_util.c
index a18bc992c136..f39ae38e4cfa 100644
--- a/drivers/gpu/drm/msm/dpu_io_util.c
+++ b/drivers/gpu/drm/msm/dpu_io_util.c
@@ -16,9 +16,9 @@
 #include 
 #include 
 #include 
-#include 
 
-#define MAX_I2C_CMDS  16
+#include "dpu_io_util.h"
+
 void dss_reg_w(struct dss_io_data *io, u32 offset, u32 value, u32 debug)
 {
u32 in_val;
@@ -42,8 +42,7 @@ void dss_reg_w(struct dss_io_data *io, u32 offset, u32 value, 
u32 debug)
(u32)(unsigned long)(io->base + offset),
value, in_val);
}
-} /* dss_reg_w */
-EXPORT_SYMBOL(dss_reg_w);
+}
 
 u32 dss_reg_r(struct dss_io_data *io, u32 offset, u32 debug)
 {
@@ -67,30 +66,7 @@ u32 dss_reg_r(struct dss_io_data *io, u32 offset, u32 debug)
(u32)(unsigned long)(io->base + offset), value);
 
return value;
-} /* dss_reg_r */
-EXPORT_SYMBOL(dss_reg_r);
-
-void dss_reg_dump(void __iomem *base, u32 length, const char *prefix,
-   u32 debug)
-{
-   if (debug)
-   print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 32, 4,
-   (void *)base, length, false);
-} /* dss_reg_dump */
-EXPORT_SYMBOL(dss_reg_dump);
-
-static struct resource *msm_dss_get_res_byname(struct platform_device *pdev,
-   unsigned int type, const char *name)
-{
-   struct resource *res = NULL;
-
-   res = platform_get_resource_byname(pdev, type, name);
-   if (!res)
-   DEV_ERR("%s: '%s' resource not found\n", __func__, name);
-
-   return res;
-} /* msm_dss_get_res_byname */
-EXPORT_SYMBOL(msm_dss_get_res_byname);
+}
 
 int msm_dss_ioremap_byname(struct platform_device *pdev,
struct dss_io_data *io_data, const char *name)
@@ -103,7 +79,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev,
return -EINVAL;
}
 
-   res = msm_dss_get_res_byname(pdev, IORESOURCE_MEM, name);
+   res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
if (!res) {
DEV_ERR("%pS->%s: '%s' msm_dss_get_res_byname failed\n",
__builtin_return_address(0), __func__, name);
@@ -119,8 +95,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev,
}
 
return 0;
-} /* msm_dss_ioremap_byname */
-EXPORT_SYMBOL(msm_dss_ioremap_byname);
+}
 
 void msm_dss_iounmap(struct dss_io_data *io_data)
 {
@@ -135,8 +110,7 @@ void msm_dss_iounmap(struct dss_io_data *io_data)
io_data->base = NULL;
}
io_data->len = 0;
-} /* msm_dss_iounmap */
-EXPORT_SYMBOL(msm_dss_iounmap);
+}
 
 int msm_dss_config_vreg(struct device *dev, struct dss_vreg *in_vreg,
int num_vreg, int config)
@@ -211,8 +185,7 @@ if (type == DSS_REG_LDO)
goto vreg_unconfig;
}
return rc;
-} /* msm_dss_config_vreg */
-EXPORT_SYMBOL(msm_dss_config_vreg);
+}
 
 int msm_dss_enable_vreg(struct dss_vreg *in_vreg, int num_vreg, int enable)
 {
@@ -283,48 +256,7 @@ int msm_dss_enable_vreg(struct dss_vreg *in_vreg, int 
num_vreg, int enable)
}
 
return rc;
-} /* msm_dss_enable_vreg */
-EXPORT_SYMBOL(msm_dss_enable_vreg);
-
-int msm_dss_enable_gpio(struct dss_gpio *in_gpio, int num_gpio, int enable)
-{
-   int i = 0, rc = 0;
-
-   if (enable) {
-   for (i = 0; i < num_gpio; i++) {
-   DEV_DBG("%pS->%s: %s enable\n",
-   __builtin_return_address(0), __func__,
-   in_gpio[i].gpio_name);
-
-   rc = gpio_request(in_gpio[i].gpio,
-   in_gpio[i].gpio_name);
-   if (rc < 0) {
-   DEV_ERR("%pS->%s: %s enable failed\n",
-