The recent changes which removed platform data support from panels &
encoders had a few mistakes, causing probes of DVI connector and DSI
command mode panels to fail every time due to missing '!'. Fix the
if()s.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
Reported-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---

Hi Dave,

Can you apply this to drm-next? I have no other fixes at the moment, and
sending a pull request seems pointless.

 drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 2 +-
 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c 
b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
index 3fd5a0b4d4cf..747f26a55e43 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
@@ -279,7 +279,7 @@ static int dvic_probe(struct platform_device *pdev)

        platform_set_drvdata(pdev, ddata);

-       if (pdev->dev.of_node)
+       if (!pdev->dev.of_node)
                return -ENODEV;

        r = dvic_probe_of(pdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c 
b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index ae7dd625e19f..36485c2137ce 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -1180,7 +1180,7 @@ static int dsicm_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, ddata);
        ddata->pdev = pdev;

-       if (pdev->dev.of_node)
+       if (!pdev->dev.of_node)
                return -ENODEV;

        r = dsicm_probe_of(pdev);
-- 
2.5.0

Reply via email to