Re: [PATCH] drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()

[Icenowy Zheng]

在 2021-09-16星期四的 18:42 +0800，Cai Huoqing写道：
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> And using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing 

Looks good to me, and thanks for pointing out this helper.

Acked-by: Icenowy Zheng 

> ---
>  drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 13 +
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
> b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
> index 2a602aee61c3..cb0bb3076099 100644
> --- a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
> +++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
> @@ -456,16 +456,13 @@ static int k101_im2ba02_dsi_probe(struct
> mipi_dsi_device *dsi)
>  
> ret = devm_regulator_bulk_get(>dev, ARRAY_SIZE(ctx-
> >supplies),
>   ctx->supplies);
> -   if (ret < 0) {
> -   dev_err(>dev, "Couldn't get regulators\n");
> -   return ret;
> -   }
> +   if (ret < 0)
> +   return dev_err_probe(>dev, ret, "Couldn't get
> regulators\n");
>  
> ctx->reset = devm_gpiod_get(>dev, "reset",
> GPIOD_OUT_LOW);
> -   if (IS_ERR(ctx->reset)) {
> -   dev_err(>dev, "Couldn't get our reset GPIO\n");
> -   return PTR_ERR(ctx->reset);
> -   }
> +   if (IS_ERR(ctx->reset))
> +   return dev_err_probe(>dev, PTR_ERR(ctx->reset),
> +    "Couldn't get our reset
> GPIO\n");
>  
> drm_panel_init(>panel, >dev, _im2ba02_funcs,
>    DRM_MODE_CONNECTOR_DSI);

[PATCH] drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()

[Cai Huoqing]

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing 
---
 drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 13 +
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c 
b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
index 2a602aee61c3..cb0bb3076099 100644
--- a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
+++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
@@ -456,16 +456,13 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device 
*dsi)
 
ret = devm_regulator_bulk_get(>dev, ARRAY_SIZE(ctx->supplies),
  ctx->supplies);
-   if (ret < 0) {
-   dev_err(>dev, "Couldn't get regulators\n");
-   return ret;
-   }
+   if (ret < 0)
+   return dev_err_probe(>dev, ret, "Couldn't get 
regulators\n");
 
ctx->reset = devm_gpiod_get(>dev, "reset", GPIOD_OUT_LOW);
-   if (IS_ERR(ctx->reset)) {
-   dev_err(>dev, "Couldn't get our reset GPIO\n");
-   return PTR_ERR(ctx->reset);
-   }
+   if (IS_ERR(ctx->reset))
+   return dev_err_probe(>dev, PTR_ERR(ctx->reset),
+"Couldn't get our reset GPIO\n");
 
drm_panel_init(>panel, >dev, _im2ba02_funcs,
   DRM_MODE_CONNECTOR_DSI);
-- 
2.25.1