[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
2010/9/22 Marius Gr?ger : > Am 22.09.2010 06:40, schrieb Alex Deucher: >> >> 2010/9/21 Marius Gr?ger: >>> >>> On 10.09.2010 17:20 Alex Deucher wrote: The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. >>> >>> Is there public documentation available wrt this matter? >>> www.x.org/docs/AMD/ >>> appears to focus on 3D stuff primarily... >>> >> >> Not at the moment, however, you could implement underscan using the 3D >> engine to do the scaling rather than the display scalers. ?I think you >> could even do it with randr crtc transforms (which use the 3d engine). > > Are you referring to xrandr --transpose? At least for me this seems to be > only partially implemented. For example: > > xrandr --output HDMI-0 --mode 1920x1080 at 50i --transform > 0.5,0,0,0,0.5,0,0,0,1 > > This does in fact render the image scaled down by 50%. However, > > xrandr --verbose > > yields: > > HDMI-0 connected 1920x1080+0+0 (0xfd) normal (normal left inverted right x > axis y axis) 1600mm x 900mm > ... > ? ? ? ?Transform: ?1.00 0.00 0.00 > ? ? ? ? ? ? ? ? ? ?0.00 1.00 0.00 > ? ? ? ? ? ? ? ? ? ?0.00 0.00 1.00 > > Translation doesn't work at all, so it's not a viable workaround. The transform shader code in the exa composite code probably needs adjusting to deal properly with translation. Alex > > Sigh. This is all kind of frustrating... > > Regards, > Marius >
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
Am 22.09.2010 06:40, schrieb Alex Deucher: > 2010/9/21 Marius Gr?ger: >> On 10.09.2010 17:20 Alex Deucher wrote: >>> >>> The scaler doesn't appear to work with interlaced modes as you've >>> noticed; I don't off hand know whether it can be made to or not. >>> Unfortunately, I won't have time to dig into this more for a while. >> >> Is there public documentation available wrt this matter? www.x.org/docs/AMD/ >> appears to focus on 3D stuff primarily... >> > > Not at the moment, however, you could implement underscan using the 3D > engine to do the scaling rather than the display scalers. I think you > could even do it with randr crtc transforms (which use the 3d engine). Are you referring to xrandr --transpose? At least for me this seems to be only partially implemented. For example: xrandr --output HDMI-0 --mode 1920x1080 at 50i --transform 0.5,0,0,0,0.5,0,0,0,1 This does in fact render the image scaled down by 50%. However, xrandr --verbose yields: HDMI-0 connected 1920x1080+0+0 (0xfd) normal (normal left inverted right x axis y axis) 1600mm x 900mm ... Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 Translation doesn't work at all, so it's not a viable workaround. Sigh. This is all kind of frustrating... Regards, Marius
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
2010/9/21 Marius Gr?ger : > On 10.09.2010 17:20 Alex Deucher wrote: >> >> The scaler doesn't appear to work with interlaced modes as you've >> noticed; I don't off hand know whether it can be made to or not. >> Unfortunately, I won't have time to dig into this more for a while. > > Is there public documentation available wrt this matter? www.x.org/docs/AMD/ > appears to focus on 3D stuff primarily... > Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers. I think you could even do it with randr crtc transforms (which use the 3d engine). Alex > Regards, > Marius >
Re: [PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
Am 22.09.2010 06:40, schrieb Alex Deucher: 2010/9/21 Marius Grögermarius.groe...@googlemail.com: On 10.09.2010 17:20 Alex Deucher wrote: The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily... Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers. I think you could even do it with randr crtc transforms (which use the 3d engine). Are you referring to xrandr --transpose? At least for me this seems to be only partially implemented. For example: xrandr --output HDMI-0 --mode 1920x1...@50i --transform 0.5,0,0,0,0.5,0,0,0,1 This does in fact render the image scaled down by 50%. However, xrandr --verbose yields: HDMI-0 connected 1920x1080+0+0 (0xfd) normal (normal left inverted right x axis y axis) 1600mm x 900mm ... Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 Translation doesn't work at all, so it's not a viable workaround. Sigh. This is all kind of frustrating... Regards, Marius ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
On 10.09.2010 17:20 Alex Deucher wrote: > The scaler doesn't appear to work with interlaced modes as you've > noticed; I don't off hand know whether it can be made to or not. > Unfortunately, I won't have time to dig into this more for a while. Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily... Regards, Marius
Re: [PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
On 10.09.2010 17:20 Alex Deucher wrote: The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily... Regards, Marius ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
2010/9/21 Marius Gröger marius.groe...@googlemail.com: On 10.09.2010 17:20 Alex Deucher wrote: The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily... Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers. I think you could even do it with randr crtc transforms (which use the 3d engine). Alex Regards, Marius ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
On 10.09.2010 09:19, wrote Alex Deucher: > They aren't compatible. Hm, ok. Is this supposed to be quick fix or is there any chance to get proper underscan for interlaced modes? Secondly, have you had a chance to look at my register dumps? Any clues as to why the Xserver prunes interlaced modes only with KMS? Thanks Marius
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
2010/9/10 Marius Gr?ger : > On 10.09.2010 09:19, wrote Alex Deucher: >> >> They aren't compatible. > > Hm, ok. Is this supposed to be quick fix or is there any chance to get > proper underscan for interlaced modes? > The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. > Secondly, have you had a chance to look at my register dumps? Any clues as > to why the Xserver prunes interlaced modes only with KMS? If this commit (http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=b90cb61ccb0f4f80e0627141f223354a9371d47d) doesn't help, then presumably the problem is due to some change in the xserver. The only difference in the register dump was that the scaler was enabled for underscan in the kms one. Alex > > Thanks > Marius > >
[PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
They aren't compatible. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 8c987c9..127a395 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1151,6 +1151,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc, /* fix up for overscan on hdmi */ if (ASIC_IS_AVIVO(rdev) && + (!(mode->flags & DRM_MODE_FLAG_INTERLACE)) && ((radeon_encoder->underscan_type == UNDERSCAN_ON) || ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) && drm_detect_hdmi_monitor(radeon_connector->edid) && -- 1.7.1.1
Re: [PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
On 10.09.2010 09:19, wrote Alex Deucher: They aren't compatible. Hm, ok. Is this supposed to be quick fix or is there any chance to get proper underscan for interlaced modes? Secondly, have you had a chance to look at my register dumps? Any clues as to why the Xserver prunes interlaced modes only with KMS? Thanks Marius ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/radeon/kms: don't enable underscan with interlaced modes
2010/9/10 Marius Gröger marius.groe...@googlemail.com: On 10.09.2010 09:19, wrote Alex Deucher: They aren't compatible. Hm, ok. Is this supposed to be quick fix or is there any chance to get proper underscan for interlaced modes? The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while. Secondly, have you had a chance to look at my register dumps? Any clues as to why the Xserver prunes interlaced modes only with KMS? If this commit (http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=b90cb61ccb0f4f80e0627141f223354a9371d47d) doesn't help, then presumably the problem is due to some change in the xserver. The only difference in the register dump was that the scaler was enabled for underscan in the kms one. Alex Thanks Marius ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
