Re: [PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'
On Sat, Jul 29, 2023 at 09:12:05PM +0700, Bagas Sanjaya wrote:
> On Fri, Jul 28, 2023 at 10:35:19PM +0800, 孙冉 wrote:
> > WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> >
> > Signed-off-by: Ran Sun
>
> Your From: address != SoB identity
While the comment below is a completely valid complaint, I think this
comment is being rather pedantic. Google Translate will tell you that
孙冉 is Sun Ran, so while the name does not strictly match, it is
clearly the same...
> > ---
> > drivers/gpu/drm/radeon/radeon_object.h | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_object.h
> > b/drivers/gpu/drm/radeon/radeon_object.h
> > index 39cc87a59a9a..9b55a7103cfd 100644
> > --- a/drivers/gpu/drm/radeon/radeon_object.h
> > +++ b/drivers/gpu/drm/radeon/radeon_object.h
> > @@ -37,7 +37,7 @@
> > *
> > * Returns corresponding domain of the ttm mem_type
> > */
> > -static inline unsigned radeon_mem_type_to_domain(u32 mem_type)
> > +static inline unsigned int radeon_mem_type_to_domain(u32 mem_type)
> > {
> > switch (mem_type) {
> > case TTM_PL_VRAM:
> > @@ -112,12 +112,12 @@ static inline unsigned long radeon_bo_size(struct
> > radeon_bo *bo)
> > return bo->tbo.base.size;
> > }
> >
> > -static inline unsigned radeon_bo_ngpu_pages(struct radeon_bo *bo)
> > +static inline unsigned int radeon_bo_ngpu_pages(struct radeon_bo *bo)
> > {
> > return bo->tbo.base.size / RADEON_GPU_PAGE_SIZE;
> > }
> >
> > -static inline unsigned radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
> > +static inline unsigned int radeon_bo_gpu_page_alignment(struct radeon_bo
> > *bo)
> > {
> > return (bo->tbo.page_alignment << PAGE_SHIFT) / RADEON_GPU_PAGE_SIZE;
> > }
> > @@ -189,7 +189,7 @@ static inline void *radeon_sa_bo_cpu_addr(struct
> > drm_suballoc *sa_bo)
> >
> > extern int radeon_sa_bo_manager_init(struct radeon_device *rdev,
> > struct radeon_sa_manager *sa_manager,
> > - unsigned size, u32 align, u32 domain,
> > + unsigned int size, u32 align, u32 domain,
> > u32 flags);
> > extern void radeon_sa_bo_manager_fini(struct radeon_device *rdev,
> >struct radeon_sa_manager *sa_manager);
>
> The patch is whitespace-corrupted. Use git-send-email(1) to submit patches.
> Also, your patch is also MIME-encoded, hence the corruption.
>
> To Alex: Please don't apply this patch due to reasons above.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
Re: [PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'
On Fri, Jul 28, 2023 at 10:35:19PM +0800, 孙冉 wrote:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Ran Sun
Your From: address != SoB identity
> ---
> drivers/gpu/drm/radeon/radeon_object.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.h
> b/drivers/gpu/drm/radeon/radeon_object.h
> index 39cc87a59a9a..9b55a7103cfd 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.h
> +++ b/drivers/gpu/drm/radeon/radeon_object.h
> @@ -37,7 +37,7 @@
> *
> * Returns corresponding domain of the ttm mem_type
> */
> -static inline unsigned radeon_mem_type_to_domain(u32 mem_type)
> +static inline unsigned int radeon_mem_type_to_domain(u32 mem_type)
> {
> switch (mem_type) {
> case TTM_PL_VRAM:
> @@ -112,12 +112,12 @@ static inline unsigned long radeon_bo_size(struct
> radeon_bo *bo)
> return bo->tbo.base.size;
> }
>
> -static inline unsigned radeon_bo_ngpu_pages(struct radeon_bo *bo)
> +static inline unsigned int radeon_bo_ngpu_pages(struct radeon_bo *bo)
> {
> return bo->tbo.base.size / RADEON_GPU_PAGE_SIZE;
> }
>
> -static inline unsigned radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
> +static inline unsigned int radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
> {
> return (bo->tbo.page_alignment << PAGE_SHIFT) / RADEON_GPU_PAGE_SIZE;
> }
> @@ -189,7 +189,7 @@ static inline void *radeon_sa_bo_cpu_addr(struct
> drm_suballoc *sa_bo)
>
> extern int radeon_sa_bo_manager_init(struct radeon_device *rdev,
> struct radeon_sa_manager *sa_manager,
> - unsigned size, u32 align, u32 domain,
> + unsigned int size, u32 align, u32 domain,
> u32 flags);
> extern void radeon_sa_bo_manager_fini(struct radeon_device *rdev,
>struct radeon_sa_manager *sa_manager);
The patch is whitespace-corrupted. Use git-send-email(1) to submit patches.
Also, your patch is also MIME-encoded, hence the corruption.
To Alex: Please don't apply this patch due to reasons above.
Thanks.
--
An old man doll... just what I always wanted! - Clara
signature.asc
Description: PGP signature
[PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Ran Sun
---
drivers/gpu/drm/radeon/radeon_object.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_object.h
b/drivers/gpu/drm/radeon/radeon_object.h
index 39cc87a59a9a..9b55a7103cfd 100644
--- a/drivers/gpu/drm/radeon/radeon_object.h
+++ b/drivers/gpu/drm/radeon/radeon_object.h
@@ -37,7 +37,7 @@
*
* Returns corresponding domain of the ttm mem_type
*/
-static inline unsigned radeon_mem_type_to_domain(u32 mem_type)
+static inline unsigned int radeon_mem_type_to_domain(u32 mem_type)
{
switch (mem_type) {
case TTM_PL_VRAM:
@@ -112,12 +112,12 @@ static inline unsigned long radeon_bo_size(struct
radeon_bo *bo)
return bo->tbo.base.size;
}
-static inline unsigned radeon_bo_ngpu_pages(struct radeon_bo *bo)
+static inline unsigned int radeon_bo_ngpu_pages(struct radeon_bo *bo)
{
return bo->tbo.base.size / RADEON_GPU_PAGE_SIZE;
}
-static inline unsigned radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
+static inline unsigned int radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
{
return (bo->tbo.page_alignment << PAGE_SHIFT) / RADEON_GPU_PAGE_SIZE;
}
@@ -189,7 +189,7 @@ static inline void *radeon_sa_bo_cpu_addr(struct
drm_suballoc *sa_bo)
extern int radeon_sa_bo_manager_init(struct radeon_device *rdev,
struct radeon_sa_manager *sa_manager,
- unsigned size, u32 align, u32 domain,
+ unsigned int size, u32 align, u32 domain,
u32 flags);
extern void radeon_sa_bo_manager_fini(struct radeon_device *rdev,
struct radeon_sa_manager *sa_manager);
--
2.17.1
[PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Ran Sun
---
drivers/gpu/drm/radeon/radeon_object.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_object.h
b/drivers/gpu/drm/radeon/radeon_object.h
index 39cc87a59a9a..9b55a7103cfd 100644
--- a/drivers/gpu/drm/radeon/radeon_object.h
+++ b/drivers/gpu/drm/radeon/radeon_object.h
@@ -37,7 +37,7 @@
*
* Returns corresponding domain of the ttm mem_type
*/
-static inline unsigned radeon_mem_type_to_domain(u32 mem_type)
+static inline unsigned int radeon_mem_type_to_domain(u32 mem_type)
{
switch (mem_type) {
case TTM_PL_VRAM:
@@ -112,12 +112,12 @@ static inline unsigned long radeon_bo_size(struct
radeon_bo *bo)
return bo->tbo.base.size;
}
-static inline unsigned radeon_bo_ngpu_pages(struct radeon_bo *bo)
+static inline unsigned int radeon_bo_ngpu_pages(struct radeon_bo *bo)
{
return bo->tbo.base.size / RADEON_GPU_PAGE_SIZE;
}
-static inline unsigned radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
+static inline unsigned int radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
{
return (bo->tbo.page_alignment << PAGE_SHIFT) / RADEON_GPU_PAGE_SIZE;
}
@@ -189,7 +189,7 @@ static inline void *radeon_sa_bo_cpu_addr(struct
drm_suballoc *sa_bo)
extern int radeon_sa_bo_manager_init(struct radeon_device *rdev,
struct radeon_sa_manager *sa_manager,
- unsigned size, u32 align, u32 domain,
+ unsigned int size, u32 align, u32 domain,
u32 flags);
extern void radeon_sa_bo_manager_fini(struct radeon_device *rdev,
struct radeon_sa_manager *sa_manager);
--
2.17.1
