Re: [PATCH] drm/scdc-helper: Convert errors into debug messages
On Sat, Mar 24, 2018 at 08:35:43AM +0530, Sharma, Shashank wrote: > Reviewed-by: Shashank Sharma Thanks. Pushed to drm-misc-next. > > Regards > Shashank > On 3/23/2018 11:55 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Since we may attempt to reconfigure SCDC when the sink has already been > > disconnected we probably shouldn't scare the user with errors in dmesg > > that are 100% expected in that case. Just leave it up to the caller > > whether to print an error message or not, and just output debug > > messages from the helper itself. > > > > Cc: Shashank Sharma > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/drm_scdc_helper.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c > > b/drivers/gpu/drm/drm_scdc_helper.c > > index 657ea5ab6c3f..870e25f1f788 100644 > > --- a/drivers/gpu/drm/drm_scdc_helper.c > > +++ b/drivers/gpu/drm/drm_scdc_helper.c > > @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter > > *adapter) > > > > ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); > > if (ret < 0) { > > - DRM_ERROR("Failed to read scrambling status: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); > > return false; > > } > > > > @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter > > *adapter, bool enable) > > > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > > if (ret < 0) { > > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > > return false; > > } > > > > @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter > > *adapter, bool enable) > > > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > > if (ret < 0) { > > - DRM_ERROR("Failed to enable scrambling: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); > > return false; > > } > > > > @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct > > i2c_adapter *adapter, bool set) > > > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > > if (ret < 0) { > > - DRM_ERROR("Failed to read TMDS config: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); > > return false; > > } > > > > @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct > > i2c_adapter *adapter, bool set) > > > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > > if (ret < 0) { > > - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); > > + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); > > return false; > > } > > -- Ville Syrjälä Intel OTC ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/scdc-helper: Convert errors into debug messages
Reviewed-by: Shashank Sharma Regards Shashank On 3/23/2018 11:55 PM, Ville Syrjala wrote: From: Ville Syrjälä Since we may attempt to reconfigure SCDC when the sink has already been disconnected we probably shouldn't scare the user with errors in dmesg that are 100% expected in that case. Just leave it up to the caller whether to print an error message or not, and just output debug messages from the helper itself. Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_scdc_helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 657ea5ab6c3f..870e25f1f788 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); if (ret < 0) { - DRM_ERROR("Failed to read scrambling status: %d\n", ret); + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); return false; } @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to enable scrambling: %d\n", ret); + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); return false; } @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); return false; } ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/scdc-helper: Convert errors into debug messages
From: Ville Syrjälä Since we may attempt to reconfigure SCDC when the sink has already been disconnected we probably shouldn't scare the user with errors in dmesg that are 100% expected in that case. Just leave it up to the caller whether to print an error message or not, and just output debug messages from the helper itself. Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_scdc_helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 657ea5ab6c3f..870e25f1f788 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); if (ret < 0) { - DRM_ERROR("Failed to read scrambling status: %d\n", ret); + DRM_DEBUG_KMS("Failed to read scrambling status: %d\n", ret); return false; } @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to enable scrambling: %d\n", ret); + DRM_DEBUG_KMS("Failed to enable scrambling: %d\n", ret); return false; } @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read TMDS config: %d\n", ret); + DRM_DEBUG_KMS("Failed to read TMDS config: %d\n", ret); return false; } @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); + DRM_DEBUG_KMS("Failed to set TMDS clock ratio: %d\n", ret); return false; } -- 2.16.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel