Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-21 Thread Maxime Ripard 
Hi

On Fri, Feb 21, 2020 at 11:10:47AM +0800, Chen-Yu Tsai wrote:
> On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard  wrote:
> >
> > The A33 TCON supports LVDS, so we can toggle the support switch.
> >
> > Signed-off-by: Maxime Ripard 
>
> Acked-by: Chen-Yu Tsai 
>
> The user manual doesn't list the bits for LVDS signal polarity though.
> I assume this was verified with the BSP or actual testing? (or rather,
> will be in the LVDS signal polarity patches.)

The polarity stuff is a separate series :)

But yeah, both were tested on hardware.

I've applied it, thanks!
Maxime


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-20 Thread Chen-Yu Tsai 
On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard  wrote:
>
> The A33 TCON supports LVDS, so we can toggle the support switch.
>
> Signed-off-by: Maxime Ripard 

Acked-by: Chen-Yu Tsai 

The user manual doesn't list the bits for LVDS signal polarity though.
I assume this was verified with the BSP or actual testing? (or rather,
will be in the LVDS signal polarity patches.)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard 
The A33 TCON supports LVDS, so we can toggle the support switch.

Signed-off-by: Maxime Ripard 
---
 drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c 
b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index fdf143042f83..14026b4fa7c7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -1475,6 +1475,7 @@ static const struct sun4i_tcon_quirks sun8i_a33_quirks = {
.has_channel_0  = true,
.has_lvds_alt   = true,
.dclk_min_div   = 1,
+   .supports_lvds  = true,
 };
 
 static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
-- 
2.24.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard 
The A33 TCON supports LVDS, so we can toggle the support switch.

Signed-off-by: Maxime Ripard 
---
 drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c 
b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index fdf143042f83..14026b4fa7c7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -1475,6 +1475,7 @@ static const struct sun4i_tcon_quirks sun8i_a33_quirks = {
.has_channel_0  = true,
.has_lvds_alt   = true,
.dclk_min_div   = 1,
+   .supports_lvds  = true,
 };
 
 static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
-- 
2.24.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard 
On Fri, Feb 14, 2020 at 01:24:27PM +0100, Maxime Ripard wrote:
> The A33 TCON supports LVDS, so we can toggle the support switch.
>
> Signed-off-by: Maxime Ripard 

Sorry, that one was a spurious send-email run ...

Maxime


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel