Re: [PATCH] drm/tilcdc: Remove obsolete "ti, tilcdc, slave" dts binding support

[Rob Herring]

On Mon, Nov 13, 2017 at 6:42 AM, Jyri Sarha  wrote:
> This patch removes DRM_TILCDC_SLAVE_COMPAT option for supporting the
> obsolete "ti,tilcdc,slave" device tree binding. The new of_graph based
> binding - that is widely used in other drm driver too - has been
> supported since Linux v4.2. Maintaining the the backwards dts
> conversion code in 0the DRM_TILCDC_SLAVE_COMPAT has become a nuisance
> for the device/of development so the we decided to drop it after Linux
> v4.14, the 2017 LTS.
>
> Signed-off-by: Jyri Sarha 
> ---
>  drivers/gpu/drm/tilcdc/Kconfig |  11 -
>  drivers/gpu/drm/tilcdc/Makefile|   3 -
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c   | 269 
> -
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dts |  72 ---
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.h   |  25 ---
>  5 files changed, 380 deletions(-)
>  delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
>  delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dts
>  delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.h

Acked-by: Rob Herring 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/tilcdc: Remove obsolete "ti, tilcdc, slave" dts binding support

[Jyri Sarha]

This patch removes DRM_TILCDC_SLAVE_COMPAT option for supporting the
obsolete "ti,tilcdc,slave" device tree binding. The new of_graph based
binding - that is widely used in other drm driver too - has been
supported since Linux v4.2. Maintaining the the backwards dts
conversion code in 0the DRM_TILCDC_SLAVE_COMPAT has become a nuisance
for the device/of development so the we decided to drop it after Linux
v4.14, the 2017 LTS.

Signed-off-by: Jyri Sarha 
---
 drivers/gpu/drm/tilcdc/Kconfig |  11 -
 drivers/gpu/drm/tilcdc/Makefile|   3 -
 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c   | 269 -
 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dts |  72 ---
 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.h   |  25 ---
 5 files changed, 380 deletions(-)
 delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
 delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dts
 delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_slave_compat.h

diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 28fed7e..81ac824 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -12,14 +12,3 @@ config DRM_TILCDC
  controller, for example AM33xx in beagle-bone, DA8xx, or
  OMAP-L1xx.  This driver replaces the FB_DA8XX fbdev driver.
 
-config DRM_TILCDC_SLAVE_COMPAT
-   bool "Support device tree blobs using TI LCDC Slave binding"
-   depends on DRM_TILCDC
-   default y
-   select OF_RESOLVE
-   select OF_OVERLAY
-   help
- Choose this option if you need a kernel that is compatible
- with device tree blobs using the obsolete "ti,tilcdc,slave"
- binding. If you find "ti,tilcdc,slave"-string from your DTB,
- you probably need this. Otherwise you do not.
diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile
index 55ebd51..efc2c4f 100644
--- a/drivers/gpu/drm/tilcdc/Makefile
+++ b/drivers/gpu/drm/tilcdc/Makefile
@@ -2,9 +2,6 @@ ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
ccflags-y += -Werror
 endif
 
-obj-$(CONFIG_DRM_TILCDC_SLAVE_COMPAT) += tilcdc_slave_compat.o \
-tilcdc_slave_compat.dtb.o
-
 tilcdc-y := \
tilcdc_plane.o \
tilcdc_crtc.o \
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c 
b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
deleted file mode 100644
index 482299a..000
--- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
+++ /dev/null
@@ -1,269 +0,0 @@
-/*
- * Copyright (C) 2015 Texas Instruments
- * Author: Jyri Sarha 
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
- */
-
-/*
- * To support the old "ti,tilcdc,slave" binding the binding has to be
- * transformed to the new external encoder binding.
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include "tilcdc_slave_compat.h"
-
-struct kfree_table {
-   int total;
-   int num;
-   void **table;
-};
-
-static int __init kfree_table_init(struct kfree_table *kft)
-{
-   kft->total = 32;
-   kft->num = 0;
-   kft->table = kmalloc(kft->total * sizeof(*kft->table),
-GFP_KERNEL);
-   if (!kft->table)
-   return -ENOMEM;
-
-   return 0;
-}
-
-static int __init kfree_table_add(struct kfree_table *kft, void *p)
-{
-   if (kft->num == kft->total) {
-   void **old = kft->table;
-
-   kft->total *= 2;
-   kft->table = krealloc(old, kft->total * sizeof(*kft->table),
- GFP_KERNEL);
-   if (!kft->table) {
-   kft->table = old;
-   kfree(p);
-   return -ENOMEM;
-   }
-   }
-   kft->table[kft->num++] = p;
-   return 0;
-}
-
-static void __init kfree_table_free(struct kfree_table *kft)
-{
-   int i;
-
-   for (i = 0; i < kft->num; i++)
-   kfree(kft->table[i]);
-
-   kfree(kft->table);
-}
-
-static
-struct property * __init tilcdc_prop_dup(const struct property *prop,
-struct kfree_table *kft)
-{
-   struct property *nprop;
-
-   nprop = kzalloc(sizeof(*nprop), GFP_KERNEL);
-   if (!nprop || kfree_table_add(kft, nprop))
-   return NULL;
-
-   nprop->name = kstrdup(prop->name, GFP_KERNEL);
-   if (!nprop->name || kfree_table_add(kft, nprop->name))
-   return NULL;
-
-   nprop->value = kmemdup(prop->value, prop->length, GFP_KERNEL);
-   if (!nprop->value || kfree_table_add(kft, nprop->value))
-   return NULL;
-
-   nprop->length = prop->length;
-
-   return nprop;
-}
-
-static void __init tilcdc_copy_props(struct device_node *from,
-