Re: [PATCH] drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs

2023-03-17 Thread Christian König 

Am 17.03.23 um 06:44 schrieb Dave Airlie:

On Thu, 16 Mar 2023 at 19:27, Matthew Auld
 wrote:

On Thu, 16 Mar 2023 at 07:26, Christian König
 wrote:

That was accidentially left over when we switched to the delayed delete
worker.

Suggested-by: Matthew Auld 
Signed-off-by: Christian König 
Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
Reported-by: Steven Rostedt (Google) 
Tested-by: Steven Rostedt (Google) 

Reviewed-by: Matthew Auld 

I'm taking this directly into drm-fixes, please don't apply it to
drm-misc-fixes at all.


Ack and sorry for the noise.

Christian.



Dave.

Re: [PATCH] drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs

2023-03-16 Thread Dave Airlie 
On Thu, 16 Mar 2023 at 19:27, Matthew Auld
 wrote:
>
> On Thu, 16 Mar 2023 at 07:26, Christian König
>  wrote:
> >
> > That was accidentially left over when we switched to the delayed delete
> > worker.
> >
> > Suggested-by: Matthew Auld 
> > Signed-off-by: Christian König 
> > Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
> > Reported-by: Steven Rostedt (Google) 
> > Tested-by: Steven Rostedt (Google) 
> Reviewed-by: Matthew Auld 

I'm taking this directly into drm-fixes, please don't apply it to
drm-misc-fixes at all.

Dave.

Re: [PATCH] drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs

2023-03-16 Thread Matthew Auld 
On Thu, 16 Mar 2023 at 07:26, Christian König
 wrote:
>
> That was accidentially left over when we switched to the delayed delete
> worker.
>
> Suggested-by: Matthew Auld 
> Signed-off-by: Christian König 
> Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
> Reported-by: Steven Rostedt (Google) 
> Tested-by: Steven Rostedt (Google) 
Reviewed-by: Matthew Auld

[PATCH] drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs

2023-03-16 Thread Christian König 
That was accidentially left over when we switched to the delayed delete
worker.

Suggested-by: Matthew Auld 
Signed-off-by: Christian König 
Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
Reported-by: Steven Rostedt (Google) 
Tested-by: Steven Rostedt (Google) 
---
 drivers/gpu/drm/ttm/ttm_bo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 459f1b4440da..6314653e91f7 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -294,8 +294,6 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo,
if (unlock_resv)
dma_resv_unlock(bo->base.resv);
 
-   ttm_bo_put(bo);
-
return 0;
 }
 
-- 
2.34.1