Re: [PATCH] drm/vgem: Remove unecessary dma_fence_ops

2018-08-17 Thread Daniel Vetter 
On Thu, Aug 09, 2018 at 01:48:42PM +0100, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-08-09 13:45:44)
> > dma_fence_default_wait is the default now, same for the trivial
> > enable_signaling implementation.
> > 
> > Also remove the ->signaled callback, vgem can't peek ahead with a
> > fastpath, returning false is the default implementation.
> > 
> > v2: Protect the meaningful space! (Chris)
> > 
> > Signed-off-by: Daniel Vetter 
> > Cc: Kees Cook 
> > Cc: Cihangir Akturk 
> > Cc: Chris Wilson 
> > Cc: Sean Paul 
> > Cc: Daniel Vetter 
> 
> 1-4,
> Reviewed-by: Chris Wilson 

Thanks for your reviews, all four pushed to drm-misc-next now.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vgem: Remove unecessary dma_fence_ops

2018-08-09 Thread Chris Wilson 
Quoting Daniel Vetter (2018-08-09 13:45:44)
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
> 
> Also remove the ->signaled callback, vgem can't peek ahead with a
> fastpath, returning false is the default implementation.
> 
> v2: Protect the meaningful space! (Chris)
> 
> Signed-off-by: Daniel Vetter 
> Cc: Kees Cook 
> Cc: Cihangir Akturk 
> Cc: Chris Wilson 
> Cc: Sean Paul 
> Cc: Daniel Vetter 

1-4,
Reviewed-by: Chris Wilson 
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/vgem: Remove unecessary dma_fence_ops

2018-08-09 Thread Daniel Vetter 
dma_fence_default_wait is the default now, same for the trivial
enable_signaling implementation.

Also remove the ->signaled callback, vgem can't peek ahead with a
fastpath, returning false is the default implementation.

v2: Protect the meaningful space! (Chris)

Signed-off-by: Daniel Vetter 
Cc: Kees Cook 
Cc: Cihangir Akturk 
Cc: Chris Wilson 
Cc: Sean Paul 
Cc: Daniel Vetter 
---
 drivers/gpu/drm/vgem/vgem_fence.c | 13 -
 1 file changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/vgem/vgem_fence.c 
b/drivers/gpu/drm/vgem/vgem_fence.c
index b28876c222b4..e6ee71323a66 100644
--- a/drivers/gpu/drm/vgem/vgem_fence.c
+++ b/drivers/gpu/drm/vgem/vgem_fence.c
@@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct 
dma_fence *fence)
return "unbound";
 }
 
-static bool vgem_fence_signaled(struct dma_fence *fence)
-{
-   return false;
-}
-
-static bool vgem_fence_enable_signaling(struct dma_fence *fence)
-{
-   return true;
-}
-
 static void vgem_fence_release(struct dma_fence *base)
 {
struct vgem_fence *fence = container_of(base, typeof(*fence), base);
@@ -76,9 +66,6 @@ static void vgem_fence_timeline_value_str(struct dma_fence 
*fence, char *str,
 static const struct dma_fence_ops vgem_fence_ops = {
.get_driver_name = vgem_fence_get_driver_name,
.get_timeline_name = vgem_fence_get_timeline_name,
-   .enable_signaling = vgem_fence_enable_signaling,
-   .signaled = vgem_fence_signaled,
-   .wait = dma_fence_default_wait,
.release = vgem_fence_release,
 
.fence_value_str = vgem_fence_value_str,
-- 
2.18.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel