Re: [PATCH] drm/vkms: Fix plane duplicate_state

2018-11-29 Thread Daniel Vetter 
On Wed, Nov 28, 2018 at 01:48:53PM -0800, Eric Anholt wrote:
> Daniel Vetter  writes:
> 
> > We need to handle allocation failures and bail out. While at it, tune
> > the allocation failures down to debug level.
> >
> > syzbot injected an allocation failure and then hit this WARN_ON.
> 
> r-b.
> 
> I also often don't add kmalloc failure messages, since it's rare and
> spits a warning anyway.

Yeah, just figured I keep it since it's there. Thanks for the review,
pushed.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vkms: Fix plane duplicate_state

2018-11-28 Thread Eric Anholt 
Daniel Vetter  writes:

> We need to handle allocation failures and bail out. While at it, tune
> the allocation failures down to debug level.
>
> syzbot injected an allocation failure and then hit this WARN_ON.

r-b.

I also often don't add kmalloc failure messages, since it's rare and
spits a warning anyway.


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/vkms: Fix plane duplicate_state

2018-11-28 Thread Daniel Vetter 
We need to handle allocation failures and bail out. While at it, tune
the allocation failures down to debug level.

syzbot injected an allocation failure and then hit this WARN_ON.

Reported-by: syzbot+eb6e5365f23c02517...@syzkaller.appspotmail.com
Signed-off-by: Daniel Vetter 
Cc: Haneen Mohammed 
Cc: Sean Paul 
Cc: Daniel Vetter 
Cc: Rodrigo Siqueira 
Cc: Gustavo Padovan 
---
 drivers/gpu/drm/vkms/vkms_plane.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_plane.c 
b/drivers/gpu/drm/vkms/vkms_plane.c
index 7041007396ae..e3bcea4b4891 100644
--- a/drivers/gpu/drm/vkms/vkms_plane.c
+++ b/drivers/gpu/drm/vkms/vkms_plane.c
@@ -23,8 +23,11 @@ vkms_plane_duplicate_state(struct drm_plane *plane)
return NULL;
 
crc_data = kzalloc(sizeof(*crc_data), GFP_KERNEL);
-   if (WARN_ON(!crc_data))
-   DRM_INFO("Couldn't allocate crc_data");
+   if (!crc_data) {
+   DRM_DEBUG_KMS("Couldn't allocate crc_data\n");
+   kfree(vkms_state);
+   return NULL;
+   }
 
vkms_state->crc_data = crc_data;
 
-- 
2.19.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel