[PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
On 8 March 2016 at 09:15, Sebastian Herbszt wrote: > Thierry Reding wrote: >> From: Thierry Reding >> >> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private >> save/restore hooks") which removed these lines by mistake. >> Thanks I've pulled this into drm-fixes. Dave.
[PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
Thierry Reding wrote: > From: Thierry Reding > > This partially reverts commit d56f57ac969c ("drm/gma500: Move to private > save/restore hooks") which removed these lines by mistake. > > Reported-by: Sebastian Herbszt > Acked-by: Daniel Vetter > Signed-off-by: Thierry Reding > --- > Hi Dave, > > Daniel and I introduced this in v4.5-rc1, so it'd be good to have this > go into v4.5 final once Sebastian and Thomas have confirmed that it is > fixed. > > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > index db082bea8daf..c5a1a08b0449 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct > drm_connector *connector) > > static const struct drm_connector_funcs vmw_sou_connector_funcs = { > .dpms = vmw_du_connector_dpms, > + .detect = vmw_du_connector_detect, > + .fill_modes = vmw_du_connector_fill_modes, > .set_property = vmw_du_connector_set_property, > .destroy = vmw_sou_connector_destroy, > }; Tested-by: Sebastian Herbszt
[PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
Tested-by: Thomas Hellstrom On 03/07/2016 06:06 PM, Thierry Reding wrote: > From: Thierry Reding > > This partially reverts commit d56f57ac969c ("drm/gma500: Move to private > save/restore hooks") which removed these lines by mistake. > > Reported-by: Sebastian Herbszt > Acked-by: Daniel Vetter > Signed-off-by: Thierry Reding > --- > Hi Dave, > > Daniel and I introduced this in v4.5-rc1, so it'd be good to have this > go into v4.5 final once Sebastian and Thomas have confirmed that it is > fixed. > > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > index db082bea8daf..c5a1a08b0449 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct > drm_connector *connector) > > static const struct drm_connector_funcs vmw_sou_connector_funcs = { > .dpms = vmw_du_connector_dpms, > + .detect = vmw_du_connector_detect, > + .fill_modes = vmw_du_connector_fill_modes, > .set_property = vmw_du_connector_set_property, > .destroy = vmw_sou_connector_destroy, > };
[PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
On Mon, Mar 7, 2016 at 6:06 PM, Thierry Reding wrote: > From: Thierry Reding > > This partially reverts commit d56f57ac969c ("drm/gma500: Move to private > save/restore hooks") which removed these lines by mistake. > > Reported-by: Sebastian Herbszt > Acked-by: Daniel Vetter > Signed-off-by: Thierry Reding > --- > Hi Dave, > > Daniel and I introduced this in v4.5-rc1, so it'd be good to have this > go into v4.5 final once Sebastian and Thomas have confirmed that it is > fixed. Yeah, sorry for the silly mistake - no idea any more how that crept in, there's no pending patch series at all even touching these hooks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
[PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
From: Thierry RedingThis partially reverts commit d56f57ac969c ("drm/gma500: Move to private save/restore hooks") which removed these lines by mistake. Reported-by: Sebastian Herbszt Acked-by: Daniel Vetter Signed-off-by: Thierry Reding --- Hi Dave, Daniel and I introduced this in v4.5-rc1, so it'd be good to have this go into v4.5 final once Sebastian and Thomas have confirmed that it is fixed. drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index db082bea8daf..c5a1a08b0449 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct drm_connector *connector) static const struct drm_connector_funcs vmw_sou_connector_funcs = { .dpms = vmw_du_connector_dpms, + .detect = vmw_du_connector_detect, + .fill_modes = vmw_du_connector_fill_modes, .set_property = vmw_du_connector_set_property, .destroy = vmw_sou_connector_destroy, }; -- 2.7.1