Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
On Thu, Apr 26, 2018 at 10:38:08AM +0200, Neil Armstrong wrote:
> Hi Greg,
>
> On 19/04/2018 10:27, Greg KH wrote:
> > On Thu, Apr 19, 2018 at 10:18:35AM +0200, Neil Armstrong wrote:
> >> Hi Greg,
> >>
> >> On 23/02/2018 12:44, Neil Armstrong wrote:
> >>> The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
> >>> identified needing this workaround.
> >>> This patch adds the corresponding version to enable a single iteration for
> >>> this specific version.
> >>>
> >>> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround
> >>> based on device version")
> >>> Signed-off-by: Neil Armstrong
> >>
> >> This patch is now present in linux master as commit
> >> 9c305eb442f3b371fc722ade827bbf673514123e
> >> Could it be selected for 4.14 ?
> >> The patch has been reworked to apply for 4.17 as indicated in the commit
> >> log, but the original patch will apply over 4.14.
> >
> > I don't have any "original" patch here, I just tried applying it to
> > 4.16.y and 4.14.y and it did not work. Can you please provide a working
> > backport?
>
> I sent a backported version last week, any news of it ?
>
> Message-Id: <1524128048-11086-1-git-send-email-narmstr...@baylibre.com>
Ick, for some reason I missed that in my inbox, sorry, I'll queue it up
for the next round of releases. Thanks for reminding me.
greg k-h
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
Hi Greg,
On 19/04/2018 10:27, Greg KH wrote:
> On Thu, Apr 19, 2018 at 10:18:35AM +0200, Neil Armstrong wrote:
>> Hi Greg,
>>
>> On 23/02/2018 12:44, Neil Armstrong wrote:
>>> The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
>>> identified needing this workaround.
>>> This patch adds the corresponding version to enable a single iteration for
>>> this specific version.
>>>
>>> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround
>>> based on device version")
>>> Signed-off-by: Neil Armstrong
>>
>> This patch is now present in linux master as commit
>> 9c305eb442f3b371fc722ade827bbf673514123e
>> Could it be selected for 4.14 ?
>> The patch has been reworked to apply for 4.17 as indicated in the commit
>> log, but the original patch will apply over 4.14.
>
> I don't have any "original" patch here, I just tried applying it to
> 4.16.y and 4.14.y and it did not work. Can you please provide a working
> backport?
I sent a backported version last week, any news of it ?
Message-Id: <1524128048-11086-1-git-send-email-narmstr...@baylibre.com>
Thanks,
Neil
>
> thanks,
>
> greg k-h
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
On Thu, Apr 19, 2018 at 10:18:35AM +0200, Neil Armstrong wrote:
> Hi Greg,
>
> On 23/02/2018 12:44, Neil Armstrong wrote:
> > The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
> > identified needing this workaround.
> > This patch adds the corresponding version to enable a single iteration for
> > this specific version.
> >
> > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround
> > based on device version")
> > Signed-off-by: Neil Armstrong
>
> This patch is now present in linux master as commit
> 9c305eb442f3b371fc722ade827bbf673514123e
> Could it be selected for 4.14 ?
> The patch has been reworked to apply for 4.17 as indicated in the commit log,
> but the original patch will apply over 4.14.
I don't have any "original" patch here, I just tried applying it to
4.16.y and 4.14.y and it did not work. Can you please provide a working
backport?
thanks,
greg k-h
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
Hi Greg,
On 23/02/2018 12:44, Neil Armstrong wrote:
> The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
> identified needing this workaround.
> This patch adds the corresponding version to enable a single iteration for
> this specific version.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based
> on device version")
> Signed-off-by: Neil Armstrong
This patch is now present in linux master as commit
9c305eb442f3b371fc722ade827bbf673514123e
Could it be selected for 4.14 ?
The patch has been reworked to apply for 4.17 as indicated in the commit log,
but the original patch will apply over 4.14.
Thanks,
Neil
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index a38db40..f5018f9 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
>* (and possibly on the platform). So far only i.MX6Q (v1.30a) and
>* i.MX6DL (v1.31a) have been identified as needing the workaround, with
>* 4 and 1 iterations respectively.
> + * The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing
> + * the workaround with a single iteration.
>*/
>
> switch (hdmi->version) {
> @@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> count = 4;
> break;
> case 0x131a:
> + case 0x201a:
> count = 1;
> break;
> default:
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
Hi,
On Tuesday 06 March 2018 03:23 PM, Neil Armstrong wrote:
Hi Architt,
On 23/02/2018 12:44, Neil Armstrong wrote:
The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
identified needing this workaround.
This patch adds the corresponding version to enable a single iteration for
this specific version.
Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on
device version")
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index a38db40..f5018f9 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
* (and possibly on the platform). So far only i.MX6Q (v1.30a) and
* i.MX6DL (v1.31a) have been identified as needing the workaround, with
* 4 and 1 iterations respectively.
+* The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing
+* the workaround with a single iteration.
s/identifies/identified
*/
switch (hdmi->version) {
@@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
count = 4;
break;
case 0x131a:
+ case 0x201a:
count = 1;
break;
default:
This fixes a long time issue on Amlogic SoCs, is it ok for you ?
Looks good to me. Feel free to queue it to drm-misc-next.
Thanks,
Archit
Thanks,
Neil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
Hi Architt,
On 23/02/2018 12:44, Neil Armstrong wrote:
> The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
> identified needing this workaround.
> This patch adds the corresponding version to enable a single iteration for
> this specific version.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based
> on device version")
> Signed-off-by: Neil Armstrong
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index a38db40..f5018f9 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
>* (and possibly on the platform). So far only i.MX6Q (v1.30a) and
>* i.MX6DL (v1.31a) have been identified as needing the workaround, with
>* 4 and 1 iterations respectively.
> + * The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing
> + * the workaround with a single iteration.
>*/
>
> switch (hdmi->version) {
> @@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> count = 4;
> break;
> case 0x131a:
> + case 0x201a:
> count = 1;
> break;
> default:
>
This fixes a long time issue on Amlogic SoCs, is it ok for you ?
Thanks,
Neil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also
identified needing this workaround.
This patch adds the corresponding version to enable a single iteration for
this specific version.
Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on
device version")
Signed-off-by: Neil Armstrong
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index a38db40..f5018f9 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
* (and possibly on the platform). So far only i.MX6Q (v1.30a) and
* i.MX6DL (v1.31a) have been identified as needing the workaround, with
* 4 and 1 iterations respectively.
+* The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing
+* the workaround with a single iteration.
*/
switch (hdmi->version) {
@@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
count = 4;
break;
case 0x131a:
+ case 0x201a:
count = 1;
break;
default:
--
2.7.4
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
