[PATCH] drm: remove unused function 'drm_property_unreference_blob_locked'

[Jani Nikula]

On Wed, 20 May 2015, Arnd Bergmann  wrote:
> This function was added recently but never used, and causes
> a compile warning:
>
> drivers/gpu/drm/drm_crtc.c:4324:13: warning: 
> 'drm_property_unreference_blob_locked' defined but not used 
> [-Wunused-function]
>
> Removing that function avoids the warning. It can simply be put
> back in case it is needed in the future.

http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg at 
mail.gmail.com

>
> Signed-off-by: Arnd Bergmann 
> Fixes: 6bcacf51d05 ("drm: Add reference counting to blob properties")
> ---
> The broken patch is currently in
> git://anongit.freedesktop.org/drm-intel#topic/drm-misc
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 4059f065c854..6e60f71bbf46 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct 
> drm_property_blob *blob)
>  EXPORT_SYMBOL(drm_property_unreference_blob);
>  
>  /**
> - * drm_property_unreference_blob_locked - Unreference a blob property with 
> blob_lock held
> - *
> - * Drop a reference on a blob property. May free the object. This must be
> - * called with blob_lock held.
> - *
> - * @param dev  Device the blob was created on
> - * @param blob Pointer to blob property
> - */
> -static void drm_property_unreference_blob_locked(struct drm_property_blob 
> *blob)
> -{
> - if (!blob)
> - return;
> -
> - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, 
> atomic_read(>refcount.refcount));
> -
> - kref_put(>refcount, drm_property_free_blob);
> -}
> -
> -/**
>   * drm_property_reference_blob - Take a reference on an existing property
>   *
>   * Take a new reference on an existing blob property.
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center

[PATCH] drm: remove unused function 'drm_property_unreference_blob_locked'

[Arnd Bergmann]

This function was added recently but never used, and causes
a compile warning:

drivers/gpu/drm/drm_crtc.c:4324:13: warning: 
'drm_property_unreference_blob_locked' defined but not used [-Wunused-function]

Removing that function avoids the warning. It can simply be put
back in case it is needed in the future.

Signed-off-by: Arnd Bergmann 
Fixes: 6bcacf51d05 ("drm: Add reference counting to blob properties")
---
The broken patch is currently in
git://anongit.freedesktop.org/drm-intel#topic/drm-misc

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 4059f065c854..6e60f71bbf46 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct 
drm_property_blob *blob)
 EXPORT_SYMBOL(drm_property_unreference_blob);

 /**
- * drm_property_unreference_blob_locked - Unreference a blob property with 
blob_lock held
- *
- * Drop a reference on a blob property. May free the object. This must be
- * called with blob_lock held.
- *
- * @param dev  Device the blob was created on
- * @param blob Pointer to blob property
- */
-static void drm_property_unreference_blob_locked(struct drm_property_blob 
*blob)
-{
-   if (!blob)
-   return;
-
-   DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, 
atomic_read(>refcount.refcount));
-
-   kref_put(>refcount, drm_property_free_blob);
-}
-
-/**
  * drm_property_reference_blob - Take a reference on an existing property
  *
  * Take a new reference on an existing blob property.

[PATCH] drm: remove unused function

[Sudip Mukherjee]

this function was not used anywhere and was giving a build warning.

Signed-off-by: Sudip Mukherjee 
---
 drivers/gpu/drm/drm_crtc.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 4059f06..6e60f71 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct 
drm_property_blob *blob)
 EXPORT_SYMBOL(drm_property_unreference_blob);

 /**
- * drm_property_unreference_blob_locked - Unreference a blob property with 
blob_lock held
- *
- * Drop a reference on a blob property. May free the object. This must be
- * called with blob_lock held.
- *
- * @param dev  Device the blob was created on
- * @param blob Pointer to blob property
- */
-static void drm_property_unreference_blob_locked(struct drm_property_blob 
*blob)
-{
-   if (!blob)
-   return;
-
-   DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, 
atomic_read(>refcount.refcount));
-
-   kref_put(>refcount, drm_property_free_blob);
-}
-
-/**
  * drm_property_reference_blob - Take a reference on an existing property
  *
  * Take a new reference on an existing blob property.
-- 
1.8.1.2

[PATCH] drm: remove unused function

[Daniel Stone]

Hi Sudip,

On 14 May 2015 at 12:14, Sudip Mukherjee  wrote:
> this function was not used anywhere and was giving a build warning.

Thanks for the patch, but this function is used in following patches
that are in the process of being merged. This shouldn't have snuck in
in the earlier patch; apologies.

Cheers,
Daniel