Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
On 12/03/2018 03:53 PM, Timur Tabi wrote: > On 12/3/18 12:43 AM, Wen Yang wrote: >> The null check on >cmap is redundant since cmap is a struct >> inside fb_info and can never be null, so the check is always true. >> we may remove it. >> >> Signed-off-by: Wen Yang > > Acked-by: Timur Tabi Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
On 12/3/18 12:43 AM, Wen Yang wrote: The null check on >cmap is redundant since cmap is a struct inside fb_info and can never be null, so the check is always true. we may remove it. Signed-off-by: Wen Yang Acked-by: Timur Tabi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] fbdev: fsl-diu: remove redundant null check on cmap
The null check on >cmap is redundant since cmap is a struct inside fb_info and can never be null, so the check is always true. we may remove it. Signed-off-by: Wen Yang CC: Timur Tabi CC: Bartlomiej Zolnierkiewicz CC: linux-fb...@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: linux-ker...@vger.kernel.org --- drivers/video/fbdev/fsl-diu-fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index 332a56b6811f..9a5451ba4d44 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1575,8 +1575,7 @@ static void uninstall_fb(struct fb_info *info) unregister_framebuffer(info); unmap_video_memory(info); - if (>cmap) - fb_dealloc_cmap(>cmap); + fb_dealloc_cmap(>cmap); mfbi->registered = 0; } -- 2.19.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
