Re: [PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-05-14 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 05:07:41 PM Heiko Stuebner wrote:
> Am Freitag, 27. April 2018, 13:04:24 CEST schrieb Bartlomiej Zolnierkiewicz:
> > auo_k1900fb and auo_k1901fb drivers have been introduced six
> > years ago by following commits:
> > 
> > commit 2c8304d3125b ("video: auo_k190x: add code shared by controller 
> > drivers")
> > commit 96b1d500e028 ("video: auo_k190x: add driver for AUO-K1900 variant")
> > commit 53027cdf2a67 ("video: auo_k190x: add driver for AUO-K1901 variant")
> > 
> > They never had any in-kernel user so just remove them (since
> > they are platform drivers they need corresponding platform
> > devices to be registered by kernel and it has never happened).
> > 
> > Cc: Heiko Stübner 
> > Signed-off-by: Bartlomiej Zolnierkiewicz 
> 
> While I still hold the ereaders using these controllers in high regard
> as my first kernel hacking project, reality is that I don't think I'll
> ever continue on trying to mainline these and if later someone wants
> to resurrect these (very old now) devices, they'll probably need a drm-
> driver anyway. So for the removal
> 
> Reviewed-by: Heiko Stuebner 

Thanks, I've queued the patch for v4.18.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Heiko Stuebner
Am Freitag, 27. April 2018, 13:04:24 CEST schrieb Bartlomiej Zolnierkiewicz:
> auo_k1900fb and auo_k1901fb drivers have been introduced six
> years ago by following commits:
> 
> commit 2c8304d3125b ("video: auo_k190x: add code shared by controller 
> drivers")
> commit 96b1d500e028 ("video: auo_k190x: add driver for AUO-K1900 variant")
> commit 53027cdf2a67 ("video: auo_k190x: add driver for AUO-K1901 variant")
> 
> They never had any in-kernel user so just remove them (since
> they are platform drivers they need corresponding platform
> devices to be registered by kernel and it has never happened).
> 
> Cc: Heiko Stübner 
> Signed-off-by: Bartlomiej Zolnierkiewicz 

While I still hold the ereaders using these controllers in high regard
as my first kernel hacking project, reality is that I don't think I'll
ever continue on trying to mainline these and if later someone wants
to resurrect these (very old now) devices, they'll probably need a drm-
driver anyway. So for the removal

Reviewed-by: Heiko Stuebner 


Heiko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Bartlomiej Zolnierkiewicz
auo_k1900fb and auo_k1901fb drivers have been introduced six
years ago by following commits:

commit 2c8304d3125b ("video: auo_k190x: add code shared by controller drivers")
commit 96b1d500e028 ("video: auo_k190x: add driver for AUO-K1900 variant")
commit 53027cdf2a67 ("video: auo_k190x: add driver for AUO-K1901 variant")

They never had any in-kernel user so just remove them (since
they are platform drivers they need corresponding platform
devices to be registered by kernel and it has never happened).

Cc: Heiko Stübner 
Signed-off-by: Bartlomiej Zolnierkiewicz 
---
 drivers/video/fbdev/Kconfig   |   33 -
 drivers/video/fbdev/Makefile  |3 
 drivers/video/fbdev/auo_k1900fb.c |  204 --
 drivers/video/fbdev/auo_k1901fb.c |  257 
 drivers/video/fbdev/auo_k190x.c   | 1190 --
 drivers/video/fbdev/auo_k190x.h   |  129 
 include/video/auo_k190xfb.h   |  107 ---
 7 files changed, 1923 deletions(-)

Index: b/drivers/video/fbdev/Kconfig
===
--- a/drivers/video/fbdev/Kconfig   2018-04-26 14:54:03.656207576 +0200
+++ b/drivers/video/fbdev/Kconfig   2018-04-26 15:23:47.772252506 +0200
@@ -2253,39 +2253,6 @@ config FB_BROADSHEET
  and could also have been called by other names when coupled with
  a bridge adapter.
 
-config FB_AUO_K190X
-   tristate "AUO-K190X EPD controller support"
-   depends on FB
-   select FB_SYS_FILLRECT
-   select FB_SYS_COPYAREA
-   select FB_SYS_IMAGEBLIT
-   select FB_SYS_FOPS
-   select FB_DEFERRED_IO
-   help
- Provides support for epaper controllers from the K190X series
- of AUO. These controllers can be used to drive epaper displays
- from Sipix.
-
- This option enables the common support, shared by the individual
- controller drivers. You will also have to enable the driver
- for the controller type used in your device.
-
-config FB_AUO_K1900
-   tristate "AUO-K1900 EPD controller support"
-   depends on FB && FB_AUO_K190X
-   help
- This driver implements support for the AUO K1900 epd-controller.
- This controller can drive Sipix epaper displays but can only do
- serial updates, reducing the number of possible frames per second.
-
-config FB_AUO_K1901
-   tristate "AUO-K1901 EPD controller support"
-   depends on FB && FB_AUO_K190X
-   help
- This driver implements support for the AUO K1901 epd-controller.
- This controller can drive Sipix epaper displays and supports
- concurrent updates, making higher frames per second possible.
-
 config FB_JZ4740
tristate "JZ4740 LCD framebuffer support"
depends on FB && MACH_JZ4740
Index: b/drivers/video/fbdev/Makefile
===
--- a/drivers/video/fbdev/Makefile  2018-04-24 16:53:10.043083317 +0200
+++ b/drivers/video/fbdev/Makefile  2018-04-26 15:25:42.128255386 +0200
@@ -100,9 +100,6 @@ obj-$(CONFIG_FB_PMAGB_B)  += pmagb-b-fb
 obj-$(CONFIG_FB_MAXINE)  += maxinefb.o
 obj-$(CONFIG_FB_METRONOME)+= metronomefb.o
 obj-$(CONFIG_FB_BROADSHEET)   += broadsheetfb.o
-obj-$(CONFIG_FB_AUO_K190X)   += auo_k190x.o
-obj-$(CONFIG_FB_AUO_K1900)   += auo_k1900fb.o
-obj-$(CONFIG_FB_AUO_K1901)   += auo_k1901fb.o
 obj-$(CONFIG_FB_S1D13XXX)+= s1d13xxxfb.o
 obj-$(CONFIG_FB_SH7760)  += sh7760fb.o
 obj-$(CONFIG_FB_IMX)  += imxfb.o
Index: b/drivers/video/fbdev/auo_k1900fb.c
===
--- a/drivers/video/fbdev/auo_k1900fb.c 2017-10-18 14:35:21.947448311 +0200
+++ /dev/null   1970-01-01 00:00:00.0 +
@@ -1,204 +0,0 @@
-/*
- * auok190xfb.c -- FB driver for AUO-K1900 controllers
- *
- * Copyright (C) 2011, 2012 Heiko Stuebner 
- *
- * based on broadsheetfb.c
- *
- * Copyright (C) 2008, Jaya Kumar
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Layout is based on skeletonfb.c by James Simmons and Geert Uytterhoeven.
- *
- * This driver is written to be used with the AUO-K1900 display controller.
- *
- * It is intended to be architecture independent. A board specific driver
- * must be used to perform all the physical IO interactions.
- *
- * The controller supports different update modes:
- * mode0+1 16 step gray (4bit)
- * mode2 4 step gray (2bit) - FIXME: add strange refresh
- * mode3 2 step gray (1bit) - FIXME: add strange refresh
- * mode4 handwriting mode (strange behaviour)
- * mode5 automatic selection of update mode
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include