Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings

[Jani Nikula]

On Mon, 25 Sep 2023, Robert Foss  wrote:
> NAK

Feels a bit harsh.

> Personally I value maintaining a simple to follow `git blame` history
> over correcting indentation.
>
> Ideally bad indentation should never be committed in the first place.

Agreed, but when that inevitably happens, do you really want it to be
cast in stone? To me leaving bad indent (or style, or whatever) in place
indicates we don't care, while the opposite is true.

Maybe look into tooling that lets you easily git blame the parent commit
of a line in git blame? (For example, in emacs vc-annotate, it's just a
matter of hitting 'a'.)


BR,
Jani.


>
> On Wed, Sep 20, 2023 at 2:44 AM Yang Li  wrote:
>>
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() 
>> warn: inconsistent indenting
>>
>> Signed-off-by: Yang Li 
>> ---
>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c 
>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> index 673661160e54..fe2ff4984fc5 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct 
>> device *dev)
>> struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>>
>> /* store interrupt status/mask registers */
>> -cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> -cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
>> -cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>> +   cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> +   cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
>> +   cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>>
>> return 0;
>>  }
>> --
>> 2.20.1.7.g153144c
>>

-- 
Jani Nikula, Intel

Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings

[Robert Foss]

NAK

Personally I value maintaining a simple to follow `git blame` history
over correcting indentation.

Ideally bad indentation should never be committed in the first place.

On Wed, Sep 20, 2023 at 2:44 AM Yang Li  wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: 
> inconsistent indenting
>
> Signed-off-by: Yang Li 
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c 
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 673661160e54..fe2ff4984fc5 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct 
> device *dev)
> struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
> /* store interrupt status/mask registers */
> -cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> -cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> -cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> +   cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> +   cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> +   cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
> return 0;
>  }
> --
> 2.20.1.7.g153144c
>

[PATCH -next] drm/bridge: clean up some inconsistent indentings

[Yang Li]

drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: 
inconsistent indenting

Signed-off-by: Yang Li 
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c 
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index 673661160e54..fe2ff4984fc5 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device 
*dev)
struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
 
/* store interrupt status/mask registers */
-cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
-cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
-cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+   cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+   cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+   cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
 
return 0;
 }
-- 
2.20.1.7.g153144c