Re: [PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro

2020-10-16 Thread Sam Ravnborg
Hi Qinglang Miao

On Wed, Sep 16, 2020 at 02:21:23PM +0800, Qinglang Miao wrote:
> Use for_each_child_of_node() macro instead of open coding it.
> 
> Signed-off-by: Qinglang Miao 

Applied to drm-misc-next.

Sam

> ---
>  drivers/video/fbdev/nvidia/nv_of.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/nvidia/nv_of.c 
> b/drivers/video/fbdev/nvidia/nv_of.c
> index 5f3e5179c..d20b8779b 100644
> --- a/drivers/video/fbdev/nvidia/nv_of.c
> +++ b/drivers/video/fbdev/nvidia/nv_of.c
> @@ -42,8 +42,7 @@ int nvidia_probe_of_connector(struct fb_info *info, int 
> conn, u8 **out_edid)
>   const char *pname;
>   int len;
>  
> - for (dp = NULL;
> -  (dp = of_get_next_child(parent, dp)) != NULL;) {
> + for_each_child_of_node(parent, dp) {
>   pname = of_get_property(dp, "name", NULL);
>   if (!pname)
>   continue;
> -- 
> 2.23.0
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro

2020-09-16 Thread Qinglang Miao
Use for_each_child_of_node() macro instead of open coding it.

Signed-off-by: Qinglang Miao 
---
 drivers/video/fbdev/nvidia/nv_of.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_of.c 
b/drivers/video/fbdev/nvidia/nv_of.c
index 5f3e5179c..d20b8779b 100644
--- a/drivers/video/fbdev/nvidia/nv_of.c
+++ b/drivers/video/fbdev/nvidia/nv_of.c
@@ -42,8 +42,7 @@ int nvidia_probe_of_connector(struct fb_info *info, int conn, 
u8 **out_edid)
const char *pname;
int len;
 
-   for (dp = NULL;
-(dp = of_get_next_child(parent, dp)) != NULL;) {
+   for_each_child_of_node(parent, dp) {
pname = of_get_property(dp, "name", NULL);
if (!pname)
continue;
-- 
2.23.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel