Re: [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call

[Helge Deller]

On 9/23/22 12:20, Shang XiaoJing wrote:

devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing 


applied.

Thanks,
Helge


---
  drivers/video/fbdev/imxfb.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 94f3bc637fc8..51fde1b2a793 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -972,7 +972,6 @@ static int imxfb_probe(struct platform_device *pdev)

fbi->regs = devm_ioremap_resource(>dev, res);
if (IS_ERR(fbi->regs)) {
-   dev_err(>dev, "Cannot map frame buffer registers\n");
ret = PTR_ERR(fbi->regs);
goto failed_ioremap;
}

[PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call

[Shang XiaoJing]

devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing 
---
 drivers/video/fbdev/imxfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 94f3bc637fc8..51fde1b2a793 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -972,7 +972,6 @@ static int imxfb_probe(struct platform_device *pdev)
 
fbi->regs = devm_ioremap_resource(>dev, res);
if (IS_ERR(fbi->regs)) {
-   dev_err(>dev, "Cannot map frame buffer registers\n");
ret = PTR_ERR(fbi->regs);
goto failed_ioremap;
}
-- 
2.17.1