Re: [PATCH 0/4] DRM helpers for Display Stream Compression PPS infoframes
On Mon, May 14, 2018 at 06:50:28PM +0200, Daniel Vetter wrote: > On Wed, May 09, 2018 at 02:58:23PM -0700, Manasi Navare wrote: > > VESA Display Stream Compression is a specification for visually losless > > video compression over display links. The DSC standard also defines > > a picture parameter set (PPS) which encoder must communicate to decoders. > > This is done by encapsulating PPS header and payload bytes in an infoframe > > that can be sent to the display sink using secondary data packets > > as defined in DP 1.4 spec. > > > > This patch series creates a new files drm_dsc.h and drm_dsc.c > > which define all the DSC related structures and helpers that > > can be called by drivers to form DSC PPS infoframes before > > enabling Display Stream compression on eDP/DP/MIPI > > Just an aside: At least here the threading for this patch series seems > off. And patchwork also didn't pick up your cover letter: > > https://patchwork.freedesktop.org/series/42969/ > Yes the cover letter didnt get sent to the dri-devel, only to the intel-gfx M-L: https://patchwork.freedesktop.org/series/42968/ > > > > These files can be used to add more DSC spec related helpers > > common to all drivers. > > > > Gaurav K Singh (1): > > drm/dsc: Define VESA Display Stream Compression Capabilities > > > > Manasi Navare (3): > > drm/dp: Define payload size for DP SDP PPS packet > > drm/dsc: Define Display Stream Compression PPS infoframe > > drm/dsc: Add helpers for DSC picture parameter set infoframes > > > > drivers/gpu/drm/Makefile| 2 +- > > drivers/gpu/drm/drm_dsc.c | 222 ++ > > include/drm/drm_dp_helper.h | 1 + > > include/drm/drm_dsc.h | 539 > > > > Please include these new files into the overall kernel-doc structure (and > make sure stuff is sufficiently documented). I have added the necessary headers and documentation in the files itself but will update the kernel-doc structure as wellf or these. Manasi > > Thanks, Daniel > > > 4 files changed, 763 insertions(+), 1 deletion(-) > > create mode 100644 drivers/gpu/drm/drm_dsc.c > > create mode 100644 include/drm/drm_dsc.h > > > > -- > > 2.7.4 > > > > ___ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 0/4] DRM helpers for Display Stream Compression PPS infoframes
On Wed, May 09, 2018 at 02:58:23PM -0700, Manasi Navare wrote: > VESA Display Stream Compression is a specification for visually losless > video compression over display links. The DSC standard also defines > a picture parameter set (PPS) which encoder must communicate to decoders. > This is done by encapsulating PPS header and payload bytes in an infoframe > that can be sent to the display sink using secondary data packets > as defined in DP 1.4 spec. > > This patch series creates a new files drm_dsc.h and drm_dsc.c > which define all the DSC related structures and helpers that > can be called by drivers to form DSC PPS infoframes before > enabling Display Stream compression on eDP/DP/MIPI Just an aside: At least here the threading for this patch series seems off. And patchwork also didn't pick up your cover letter: https://patchwork.freedesktop.org/series/42969/ > > These files can be used to add more DSC spec related helpers > common to all drivers. > > Gaurav K Singh (1): > drm/dsc: Define VESA Display Stream Compression Capabilities > > Manasi Navare (3): > drm/dp: Define payload size for DP SDP PPS packet > drm/dsc: Define Display Stream Compression PPS infoframe > drm/dsc: Add helpers for DSC picture parameter set infoframes > > drivers/gpu/drm/Makefile| 2 +- > drivers/gpu/drm/drm_dsc.c | 222 ++ > include/drm/drm_dp_helper.h | 1 + > include/drm/drm_dsc.h | 539 > Please include these new files into the overall kernel-doc structure (and make sure stuff is sufficiently documented). Thanks, Daniel > 4 files changed, 763 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/drm_dsc.c > create mode 100644 include/drm/drm_dsc.h > > -- > 2.7.4 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 0/4] DRM helpers for Display Stream Compression PPS infoframes
VESA Display Stream Compression is a specification for visually losless video compression over display links. The DSC standard also defines a picture parameter set (PPS) which encoder must communicate to decoders. This is done by encapsulating PPS header and payload bytes in an infoframe that can be sent to the display sink using secondary data packets as defined in DP 1.4 spec. This patch series creates a new files drm_dsc.h and drm_dsc.c which define all the DSC related structures and helpers that can be called by drivers to form DSC PPS infoframes before enabling Display Stream compression on eDP/DP/MIPI These files can be used to add more DSC spec related helpers common to all drivers. Gaurav K Singh (1): drm/dsc: Define VESA Display Stream Compression Capabilities Manasi Navare (3): drm/dp: Define payload size for DP SDP PPS packet drm/dsc: Define Display Stream Compression PPS infoframe drm/dsc: Add helpers for DSC picture parameter set infoframes drivers/gpu/drm/Makefile| 2 +- drivers/gpu/drm/drm_dsc.c | 222 ++ include/drm/drm_dp_helper.h | 1 + include/drm/drm_dsc.h | 539 4 files changed, 763 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/drm_dsc.c create mode 100644 include/drm/drm_dsc.h -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
