Re: [PATCH 0/5] Some drm scheduler internal renames
On 2023-11-06 07:41, Tvrtko Ursulin wrote: > > On 05/11/2023 01:51, Luben Tuikov wrote: >> On 2023-11-02 06:55, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> I found some of the naming a bit incosistent and unclear so just a small >>> attempt to clarify and tidy some of them. See what people think if my first >>> stab improves things or not. >>> >>> Cc: Luben Tuikov >>> Cc: Matthew Brost >>> >>> Tvrtko Ursulin (5): >>>drm/sched: Rename drm_sched_get_cleanup_job to be more descriptive >>>drm/sched: Move free worker re-queuing out of the if block >>>drm/sched: Rename drm_sched_free_job_queue to be more descriptive >>>drm/sched: Rename drm_sched_run_job_queue_if_ready and clarify >>> kerneldoc >>>drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue >>> >>> drivers/gpu/drm/scheduler/sched_entity.c | 4 +- >>> drivers/gpu/drm/scheduler/sched_main.c | 53 >>> include/drm/gpu_scheduler.h | 2 +- >>> 3 files changed, 29 insertions(+), 30 deletions(-) >>> >> >> Series is, >> >> Reviewed-by: Luben Tuikov >> >> and pushed to drm-misc-next. > > Oh thanks, I definitely did not expect that to happen so quickly, > especially since it conflicts with your fix for RR and there are some > other opens. But it is fine, all that can be worked on top. Yeah, it does conflict, and it does make some changes obsolete, but your series was fine and an improvement, so might as well push it. I'll rebase my patch on top of yours. -- Regards, Luben OpenPGP_0x4C15479431A334AF.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [PATCH 0/5] Some drm scheduler internal renames
On 05/11/2023 01:51, Luben Tuikov wrote: On 2023-11-02 06:55, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I found some of the naming a bit incosistent and unclear so just a small attempt to clarify and tidy some of them. See what people think if my first stab improves things or not. Cc: Luben Tuikov Cc: Matthew Brost Tvrtko Ursulin (5): drm/sched: Rename drm_sched_get_cleanup_job to be more descriptive drm/sched: Move free worker re-queuing out of the if block drm/sched: Rename drm_sched_free_job_queue to be more descriptive drm/sched: Rename drm_sched_run_job_queue_if_ready and clarify kerneldoc drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue drivers/gpu/drm/scheduler/sched_entity.c | 4 +- drivers/gpu/drm/scheduler/sched_main.c | 53 include/drm/gpu_scheduler.h | 2 +- 3 files changed, 29 insertions(+), 30 deletions(-) Series is, Reviewed-by: Luben Tuikov and pushed to drm-misc-next. Oh thanks, I definitely did not expect that to happen so quickly, especially since it conflicts with your fix for RR and there are some other opens. But it is fine, all that can be worked on top. Regards, Tvrtko
Re: [PATCH 0/5] Some drm scheduler internal renames
On 2023-11-02 06:55, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I found some of the naming a bit incosistent and unclear so just a small > attempt to clarify and tidy some of them. See what people think if my first > stab improves things or not. > > Cc: Luben Tuikov > Cc: Matthew Brost > > Tvrtko Ursulin (5): > drm/sched: Rename drm_sched_get_cleanup_job to be more descriptive > drm/sched: Move free worker re-queuing out of the if block > drm/sched: Rename drm_sched_free_job_queue to be more descriptive > drm/sched: Rename drm_sched_run_job_queue_if_ready and clarify > kerneldoc > drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue > > drivers/gpu/drm/scheduler/sched_entity.c | 4 +- > drivers/gpu/drm/scheduler/sched_main.c | 53 > include/drm/gpu_scheduler.h | 2 +- > 3 files changed, 29 insertions(+), 30 deletions(-) > Series is, Reviewed-by: Luben Tuikov and pushed to drm-misc-next. Thanks! -- Regards, Luben OpenPGP_0x4C15479431A334AF.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [PATCH 0/5] Some drm scheduler internal renames
Hi Tvrtko, I only now saw this patch and I had to look for it... Do you get a bounce from luben.tui...@amd.com? No? You should have. Please don't use luben.tui...@amd.com. Please use ltuiko...@gmail.com, this email. Regards, Luben On 2023-11-02 06:55, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I found some of the naming a bit incosistent and unclear so just a small > attempt to clarify and tidy some of them. See what people think if my first > stab improves things or not. > > Cc: Luben Tuikov > Cc: Matthew Brost > > Tvrtko Ursulin (5): > drm/sched: Rename drm_sched_get_cleanup_job to be more descriptive > drm/sched: Move free worker re-queuing out of the if block > drm/sched: Rename drm_sched_free_job_queue to be more descriptive > drm/sched: Rename drm_sched_run_job_queue_if_ready and clarify > kerneldoc > drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue > > drivers/gpu/drm/scheduler/sched_entity.c | 4 +- > drivers/gpu/drm/scheduler/sched_main.c | 53 > include/drm/gpu_scheduler.h | 2 +- > 3 files changed, 29 insertions(+), 30 deletions(-) > OpenPGP_0x4C15479431A334AF.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature
[PATCH 0/5] Some drm scheduler internal renames
From: Tvrtko Ursulin I found some of the naming a bit incosistent and unclear so just a small attempt to clarify and tidy some of them. See what people think if my first stab improves things or not. Cc: Luben Tuikov Cc: Matthew Brost Tvrtko Ursulin (5): drm/sched: Rename drm_sched_get_cleanup_job to be more descriptive drm/sched: Move free worker re-queuing out of the if block drm/sched: Rename drm_sched_free_job_queue to be more descriptive drm/sched: Rename drm_sched_run_job_queue_if_ready and clarify kerneldoc drm/sched: Drop suffix from drm_sched_wakeup_if_can_queue drivers/gpu/drm/scheduler/sched_entity.c | 4 +- drivers/gpu/drm/scheduler/sched_main.c | 53 include/drm/gpu_scheduler.h | 2 +- 3 files changed, 29 insertions(+), 30 deletions(-) -- 2.39.2
