Re: [PATCH 0/6 v4] adv7511 EDID probing improvements

2017-01-18 Thread John Stultz
On Wed, Jan 18, 2017 at 9:22 PM, Archit Taneja  wrote:
>
>
> On 01/19/2017 04:34 AM, Laurent Pinchart wrote:
>>
>> Hi John,
>>
>> Thank you for the patches.
>>
>> On Monday 16 Jan 2017 16:52:46 John Stultz wrote:
>>>
>>> Wanted to re-send out v4  of this patch set, integrating some
>>> changes suggested by Laurent, for consideration for merging for
>>> v4.11
>>>
>>> The first three patches are fixups that are hopefully straight
>>> forward, integrating feedback I got from Laurant, with minimal
>>> change from the previous versions.
>>>
>>> The last three patches try to clean up and rework the EDID
>>> probing code, to avoid issues seen on HiKey. I've reworked these
>>> more significantly since v3 to address feedback from Laurent.
>>>
>>> Thoughts and feedback would be appreciated!
>>
>>
>> For the whole series,
>>
>> Tested-by: Laurent Pinchart 
>
>
> Queued to drm-misc-next. Updated the commit messages for patches 5
> and 6 as suggested by Laurent.

Ah! Many thanks Archit! I was going to respin the patches tomorrow but
you beat me to it. :)

The help is much appreciated!
-john
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 0/6 v4] adv7511 EDID probing improvements

2017-01-18 Thread Archit Taneja



On 01/19/2017 04:34 AM, Laurent Pinchart wrote:

Hi John,

Thank you for the patches.

On Monday 16 Jan 2017 16:52:46 John Stultz wrote:

Wanted to re-send out v4  of this patch set, integrating some
changes suggested by Laurent, for consideration for merging for
v4.11

The first three patches are fixups that are hopefully straight
forward, integrating feedback I got from Laurant, with minimal
change from the previous versions.

The last three patches try to clean up and rework the EDID
probing code, to avoid issues seen on HiKey. I've reworked these
more significantly since v3 to address feedback from Laurent.

Thoughts and feedback would be appreciated!


For the whole series,

Tested-by: Laurent Pinchart 


Queued to drm-misc-next. Updated the commit messages for patches 5
and 6 as suggested by Laurent.

Thanks,
Archit




New in v4:
* Tweaked connector.status assignment to avoid race, as
  suggested by Laurent
* Reworked the __adv7511_power_on helpers to avoid calling
  regcache_sync in the EDID probe path
* Added new patch to set EDID_I2C_ADDR register before doing
  EDID read.

Cc: David Airlie 
Cc: Archit Taneja 
Cc: Wolfram Sang 
Cc: Lars-Peter Clausen 
Cc: Laurent Pinchart 
Cc: dri-devel@lists.freedesktop.org

Archit Taneja (1):
  drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
improve monitor detection

John Stultz (5):
  drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
of irq context
  drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
  drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
reused internally
  drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
  drm/bridge: adv7511: Re-write the i2c address before EDID probing

 drivers/gpu/drm/bridge/adv7511/adv7511.h |  2 +
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67
 2 files changed, 51 insertions(+), 18
deletions(-)




--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 0/6 v4] adv7511 EDID probing improvements

2017-01-18 Thread Laurent Pinchart
Hi John,

Thank you for the patches.

On Monday 16 Jan 2017 16:52:46 John Stultz wrote:
> Wanted to re-send out v4  of this patch set, integrating some
> changes suggested by Laurent, for consideration for merging for
> v4.11
> 
> The first three patches are fixups that are hopefully straight
> forward, integrating feedback I got from Laurant, with minimal
> change from the previous versions.
> 
> The last three patches try to clean up and rework the EDID
> probing code, to avoid issues seen on HiKey. I've reworked these
> more significantly since v3 to address feedback from Laurent.
> 
> Thoughts and feedback would be appreciated!

For the whole series,

Tested-by: Laurent Pinchart 

> New in v4:
> * Tweaked connector.status assignment to avoid race, as
>   suggested by Laurent
> * Reworked the __adv7511_power_on helpers to avoid calling
>   regcache_sync in the EDID probe path
> * Added new patch to set EDID_I2C_ADDR register before doing
>   EDID read.
> 
> Cc: David Airlie 
> Cc: Archit Taneja 
> Cc: Wolfram Sang 
> Cc: Lars-Peter Clausen 
> Cc: Laurent Pinchart 
> Cc: dri-devel@lists.freedesktop.org
> 
> Archit Taneja (1):
>   drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
> improve monitor detection
> 
> John Stultz (5):
>   drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
> of irq context
>   drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
>   drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
> reused internally
>   drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
>   drm/bridge: adv7511: Re-write the i2c address before EDID probing
> 
>  drivers/gpu/drm/bridge/adv7511/adv7511.h |  2 +
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67
>  2 files changed, 51 insertions(+), 18
> deletions(-)

-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 0/6 v4] adv7511 EDID probing improvements

2017-01-16 Thread John Stultz
Wanted to re-send out v4  of this patch set, integrating some
changes suggested by Laurent, for consideration for merging for
v4.11

The first three patches are fixups that are hopefully straight
forward, integrating feedback I got from Laurant, with minimal
change from the previous versions.

The last three patches try to clean up and rework the EDID
probing code, to avoid issues seen on HiKey. I've reworked these
more significantly since v3 to address feedback from Laurent.

Thoughts and feedback would be appreciated!

thanks
-john

New in v4:
* Tweaked connector.status assignment to avoid race, as
  suggested by Laurent
* Reworked the __adv7511_power_on helpers to avoid calling
  regcache_sync in the EDID probe path
* Added new patch to set EDID_I2C_ADDR register before doing
  EDID read.

Cc: David Airlie 
Cc: Archit Taneja 
Cc: Wolfram Sang 
Cc: Lars-Peter Clausen 
Cc: Laurent Pinchart 
Cc: dri-devel@lists.freedesktop.org

Archit Taneja (1):
  drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
improve monitor detection

John Stultz (5):
  drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
of irq context
  drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
  drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
reused internally
  drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
  drm/bridge: adv7511: Re-write the i2c address before EDID probing

 drivers/gpu/drm/bridge/adv7511/adv7511.h |  2 +
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67 
 2 files changed, 51 insertions(+), 18 deletions(-)

-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel