[PATCH 0/7] drm/exynos: clean ups

2015-03-13 Thread Inki Dae 
On 2015년 03월 13일 03:45, Gustavo Padovan wrote:
> 2015-03-12 Inki Dae :
> 
>> On 2015년 02월 19일 22:22, Gustavo Padovan wrote:
>>> From: Gustavo Padovan 
>>>
>>> Hi,
>>>
>>> Here goes some clean ups to the exynos drivers. The main clean ups is
>>> the presetting and zpos making the property immutable and the removal
>>> of *_win_data structures.
>>
>> With your cleanup patch set, the plane test doesn't work. Have you ever
>> tested plane feature with modetest application?
>>
>> I typed like below and it looks like no problem but I cannot see
>> anything on Panel except for cute four penguins.
>>
>> # modetest -P 29:100x100+0+0
>> trying to open device 'i915'...failed.
>> trying to open device 'radeon'...failed.
>> trying to open device 'nouveau'...failed.
>> trying to open device 'vmwgfx'...failed.
>> trying to open device 'omapdrm'...failed.
>> trying to open device 'exynos'...success.
>> testing 100x100 at XR24 overlay plane 25
>>
>> And for two plane test,
>>
>> # modetest -P 29:100x100+0+0 -P 29:100x100+0+100
>> trying to open device 'i915'...failed.
>> trying to open device 'radeon'...failed.
>> trying to open device 'nouveau'...failed.
>> trying to open device 'vmwgfx'...failed.
>> trying to open device 'omapdrm'...failed.
>> trying to open device 'exynos'...success.
>> testing 100x100 at XR24 overlay plane 25
>> testing 100x100 at XR24 overlay plane 26
>>
>> Still no screen.
> 
> Well, I did some more testing and even without my patches I can't see a plane
> on the screen. Running only on exynos-drm-next also doesn't work so it is not
> something that my patches introduced, it is already a bug upstream.
> I'm using a snow for testing.

It's strange. I can see a semicircular small box on the screen without
your patch set, and that works well on not only exynos-drm-next but also
exynos-drm-fixes. I'm using a trarts2 board based on Exynos4412 SoC.

Could anyone check the plane test with modetest for double-check?

Thanks,
Inki Dae

> 
>   Gustavo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" 
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[PATCH 0/7] drm/exynos: clean ups

2015-03-13 Thread Inki Dae 
On 2015년 02월 19일 22:22, Gustavo Padovan wrote:
> From: Gustavo Padovan 
> 
> Hi,
> 
> Here goes some clean ups to the exynos drivers. The main clean ups is
> the presetting and zpos making the property immutable and the removal
> of *_win_data structures.

With your cleanup patch set, the plane test doesn't work. Have you ever
tested plane feature with modetest application?

I typed like below and it looks like no problem but I cannot see
anything on Panel except for cute four penguins.

# modetest -P 29:100x100+0+0
trying to open device 'i915'...failed.
trying to open device 'radeon'...failed.
trying to open device 'nouveau'...failed.
trying to open device 'vmwgfx'...failed.
trying to open device 'omapdrm'...failed.
trying to open device 'exynos'...success.
testing 100x100 at XR24 overlay plane 25

And for two plane test,

# modetest -P 29:100x100+0+0 -P 29:100x100+0+100
trying to open device 'i915'...failed.
trying to open device 'radeon'...failed.
trying to open device 'nouveau'...failed.
trying to open device 'vmwgfx'...failed.
trying to open device 'omapdrm'...failed.
trying to open device 'exynos'...success.
testing 100x100 at XR24 overlay plane 25
testing 100x100 at XR24 overlay plane 26

Still no screen.

Thanks,
Inki Dae

> 
> 
> Gustavo Padovan (6):
>   drm/exynos: remove unused exynos_crtc->win_enable() callback
>   drm/exynos: remove struct *_win_data abstraction on planes
>   drm/exynos: preset zpos value for overlay planes
>   drm/exynos: make zpos property immutable
>   drm/exynos: remove exynos_plane_destroy()
>   drm/exynos: remove leftover functions declarations
> 
> Mandeep Singh Baines (1):
>   drm/exynos: track vblank events on a per crtc basis
> 
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c | 176 +--
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c   | 101 ++
>  drivers/gpu/drm/exynos/exynos_drm_crtc.h   |   7 +-
>  drivers/gpu/drm/exynos/exynos_drm_drv.c|  27 
>  drivers/gpu/drm/exynos/exynos_drm_drv.h|  20 +--
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c   | 195 ++
>  drivers/gpu/drm/exynos/exynos_drm_plane.c  |  66 +++--
>  drivers/gpu/drm/exynos/exynos_drm_plane.h  |   7 +-
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c   | 134 +-
>  drivers/gpu/drm/exynos/exynos_mixer.c  | 217 
> ++---
>  10 files changed, 311 insertions(+), 639 deletions(-)
>

[PATCH 0/7] drm/exynos: clean ups

2015-03-12 Thread Gustavo Padovan 
2015-03-12 Inki Dae :

> On 2015년 02월 19일 22:22, Gustavo Padovan wrote:
> > From: Gustavo Padovan 
> >
> > Hi,
> >
> > Here goes some clean ups to the exynos drivers. The main clean ups is
> > the presetting and zpos making the property immutable and the removal
> > of *_win_data structures.
> 
> With your cleanup patch set, the plane test doesn't work. Have you ever
> tested plane feature with modetest application?
> 
> I typed like below and it looks like no problem but I cannot see
> anything on Panel except for cute four penguins.
> 
> # modetest -P 29:100x100+0+0
> trying to open device 'i915'...failed.
> trying to open device 'radeon'...failed.
> trying to open device 'nouveau'...failed.
> trying to open device 'vmwgfx'...failed.
> trying to open device 'omapdrm'...failed.
> trying to open device 'exynos'...success.
> testing 100x100 at XR24 overlay plane 25
> 
> And for two plane test,
> 
> # modetest -P 29:100x100+0+0 -P 29:100x100+0+100
> trying to open device 'i915'...failed.
> trying to open device 'radeon'...failed.
> trying to open device 'nouveau'...failed.
> trying to open device 'vmwgfx'...failed.
> trying to open device 'omapdrm'...failed.
> trying to open device 'exynos'...success.
> testing 100x100 at XR24 overlay plane 25
> testing 100x100 at XR24 overlay plane 26
> 
> Still no screen.

Well, I did some more testing and even without my patches I can't see a plane
on the screen. Running only on exynos-drm-next also doesn't work so it is not
something that my patches introduced, it is already a bug upstream.
I'm using a snow for testing.

Gustavo

[PATCH 0/7] drm/exynos: clean ups

2015-03-12 Thread Gustavo Padovan 
2015-03-12 Inki Dae :

> On 2015년 02월 19일 22:22, Gustavo Padovan wrote:
> > From: Gustavo Padovan 
> >
> > Hi,
> >
> > Here goes some clean ups to the exynos drivers. The main clean ups is
> > the presetting and zpos making the property immutable and the removal
> > of *_win_data structures.
> 
> With your cleanup patch set, the plane test doesn't work. Have you ever
> tested plane feature with modetest application?
> 
> I typed like below and it looks like no problem but I cannot see
> anything on Panel except for cute four penguins.
> 
> # modetest -P 29:100x100+0+0
> trying to open device 'i915'...failed.
> trying to open device 'radeon'...failed.
> trying to open device 'nouveau'...failed.
> trying to open device 'vmwgfx'...failed.
> trying to open device 'omapdrm'...failed.
> trying to open device 'exynos'...success.
> testing 100x100 at XR24 overlay plane 25
> 
> And for two plane test,
> 
> # modetest -P 29:100x100+0+0 -P 29:100x100+0+100
> trying to open device 'i915'...failed.
> trying to open device 'radeon'...failed.
> trying to open device 'nouveau'...failed.
> trying to open device 'vmwgfx'...failed.
> trying to open device 'omapdrm'...failed.
> trying to open device 'exynos'...success.
> testing 100x100 at XR24 overlay plane 25
> testing 100x100 at XR24 overlay plane 26
> 
> Still no screen.

Okay, I'll check on that. I was using a test app we wrote here.
I'll test this again with modetest too.

Gustavo

[PATCH 0/7] drm/exynos: clean ups

2015-02-19 Thread Gustavo Padovan 
From: Gustavo Padovan 

Hi,

Here goes some clean ups to the exynos drivers. The main clean ups is
the presetting and zpos making the property immutable and the removal
of *_win_data structures.


Gustavo Padovan (6):
  drm/exynos: remove unused exynos_crtc->win_enable() callback
  drm/exynos: remove struct *_win_data abstraction on planes
  drm/exynos: preset zpos value for overlay planes
  drm/exynos: make zpos property immutable
  drm/exynos: remove exynos_plane_destroy()
  drm/exynos: remove leftover functions declarations

Mandeep Singh Baines (1):
  drm/exynos: track vblank events on a per crtc basis

 drivers/gpu/drm/exynos/exynos7_drm_decon.c | 176 +--
 drivers/gpu/drm/exynos/exynos_drm_crtc.c   | 101 ++
 drivers/gpu/drm/exynos/exynos_drm_crtc.h   |   7 +-
 drivers/gpu/drm/exynos/exynos_drm_drv.c|  27 
 drivers/gpu/drm/exynos/exynos_drm_drv.h|  20 +--
 drivers/gpu/drm/exynos/exynos_drm_fimd.c   | 195 ++
 drivers/gpu/drm/exynos/exynos_drm_plane.c  |  66 +++--
 drivers/gpu/drm/exynos/exynos_drm_plane.h  |   7 +-
 drivers/gpu/drm/exynos/exynos_drm_vidi.c   | 134 +-
 drivers/gpu/drm/exynos/exynos_mixer.c  | 217 ++---
 10 files changed, 311 insertions(+), 639 deletions(-)

-- 
2.1.0